SuccessChanges

Summary

  1. [libomptarget][nfc] Move cuda threadfence functions behind kmpc_impl (details)
  2. [OpenMP] Fix linkage issue on FreeBSD (details)
  3. [LegalizeTypes] Add missing case for STRICT_FP_ROUND softening (details)
  4. [lldb][test] Handle .categories lookup for inline tests. (details)
  5. Cleanup and speedup NativeRegisterContextLinux_arm64 (details)
  6. [NFC][AIX][XCOFF] fixed compile warning on the strncpy. (details)
  7. [clang-format] update trailing newline treatment in clang-format.py (details)
  8. update string comparison in clang-format.py (details)
  9. [NFC][AIX][XCOFF] if the size of Csect is zero, the Csect do not need (details)
  10. [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls (details)
  11. [MBP] Avoid tail duplication if it can't bring benefit (details)
Commit 0dd62c5c2ec854997ca45f810175c5d1426b474e by jonathanchesterfield
[libomptarget][nfc] Move cuda threadfence functions behind kmpc_impl
Summary:
[libomptarget][nfc] Move cuda threadfence functions behind kmpc_impl
Part of building code under common/ without requiring a cuda compiler
Reviewers: ABataev, jdoerfert, grokos
Reviewed By: ABataev
Subscribers: jvesely, jfb, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D71102
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/data_sharing.cu (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/reduction.cu (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/support.cu (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/loop.cu (diff)
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/sync.cu (diff)
Commit 27535a144910149262f9c2dffb6a24c0b7166f15 by David CARLIER
[OpenMP] Fix linkage issue on FreeBSD
needs kmp_set_thread_affinity_mask_initial implementation.
The file was modifiedopenmp/runtime/src/kmp_affinity.cpp (diff)
Commit 984f1bb3e794b83da5dde9440f9807c645e8e6db by john.brawn
[LegalizeTypes] Add missing case for STRICT_FP_ROUND softening
This fixes a test failure in test/CodeGen/ARM/fp-intrinsics.ll.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp (diff)
Commit 03a242bd41ee49e17f8da96af9787d13e7ea2b93 by rupprecht
[lldb][test] Handle .categories lookup for inline tests.
Summary: When creating a test with `lldbinline.MakeInlineTest()`, the
reported `inspect.getfile(test.__class__)` is `lldbtest.pyc`, meaning
any `.categories` file will be ineffective for those tests. Check for
the test_filename first, which inline tests will set.
Additionally, raise an error with the starting dir if `.categories` is
not found. This makes the problem more obvious when it occurs: when the
test is separated from the test framework tree.
Reviewers: labath, JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71099
The file was modifiedlldb/packages/Python/lldbsuite/test/test_result.py (diff)
Commit b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 by omair.javaid
Cleanup and speedup NativeRegisterContextLinux_arm64
Summary: This patch simplifies register accesses in
NativeRegisterContextLinux_arm64 and also adds some bare minimum caching
to avoid multiple calls to ptrace during a stop.
Linux ptrace returns data in the form of structures containing GPR/FPR
data. This means that one single call is enough to read all GPRs or
FPRs. We do that once per stop and keep reading from or writing to the
buffer that we have in NativeRegisterContextLinux_arm64 class. Before a
resume or detach we write all buffers back.
This is tested on aarch64 thunder x1 with Ubuntu 18.04. Also tested
regressions on x86_64.
Reviewers: labath, clayborg
Reviewed By: labath
Subscribers: kristof.beyls, lldb-commits
Differential Revision: https://reviews.llvm.org/D69371
The file was modifiedlldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h (diff)
The file was modifiedlldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h (diff)
The file was modifiedlldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp (diff)
The file was modifiedlldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp (diff)
Commit c04b63eccd5f9fc19da410caea88d29f11e9886c by diggerlin
[NFC][AIX][XCOFF] fixed compile warning on the strncpy.
SUMMARY: There is warning when compile the file XCOFFObjectWriter.cpp
/srv/llvm-buildbot-srcatch/llvm-build-dir/openmp-gcc-x86_64-linux-debian/llvm.src/llvm/lib/MC/XCOFFObjectWriter.cpp:414:17:
warning: 'char* strncpy(char*, const char*, size_t)' specified bound 8
equals destination size [-Wstringop-truncation]
The patch fixed the warning.
Reviewer: daltenty
Differential Revision: https://reviews.llvm.org/D71119
The file was modifiedllvm/lib/MC/XCOFFObjectWriter.cpp (diff)
Commit b8e03ff50389d83dabf800203f689e227697c996 by paulhoad
[clang-format] update trailing newline treatment in clang-format.py
Summary: The current clang-format.py does not handle trailing newlines
at the end of a file correctly. Trailing empty lines get removed except
one. As far as I understand this is because clang-format gets fed from
stdin and writes to stdout when called from clang-format.py. In a
"normal" file (with no trailing empty lines) the string that gets passed
to clang-format does not contain a trailing '\n' after the '\n'.join
from python. The clang-format binary does not add a trailing newline to
input from stdin, but (if there are multiple trailing '\n', all except
one get removed).
When reading back this means that we see in python from a "normal" file
a string with no trailing '\n'. From a file with (potentially multiple)
empty line(s) at the end, we get a string with one trailing '\n' back in
python. In the former case all is fine, in the latter case split('\n')
makes one empty line at the end of the file out of the clang-format
output. Desired would be instead that the **file** ends with a newline,
but not with an empty line.
For the case that a user specifies a range to format (and wants to keep
trailing empty lines) I did **not** try to fix this by simply removing
all trailing newlines from the clang-format output. Instead, I add a
'\n' to the unformatted file content (i.e. newline-terminate what is
passed to clang-format) and then strip off the last newline from the
output (which itself is now for sure the newline termination of the
clang-format output).
(Should this get approved, I'll need someone to help me land this.)
Reviewers: klimek, MyDeveloperDay
Reviewed By: MyDeveloperDay
Patch By: pseyfert
Subscribers: cfe-commits, llvm-commits
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D70864 update trailing
newline treatment in clang-format.py
The file was modifiedclang/tools/clang-format/clang-format.py (diff)
Commit 79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60 by paulhoad
update string comparison in clang-format.py
Summary: Python 3.8 introduces a SyntaxWarning about string comparisons
with 'is'. This commit updates the string comparison in clang-format.py
that is done with 'is not' to '!='. This should not break compatibility
with older python versions (tested 3.4.9, 2.7.17, 2.7.5, 3.8.0).
Reviewers: MyDeveloperDay, klimek, llvm-commits, cfe-commits
Reviewed By: MyDeveloperDay, klimek
Patch By: pseyfert
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D70664
The file was modifiedclang/tools/clang-format/clang-format.py (diff)
Commit 50d72fa1461b71d898237f3ce19ab367d0508c87 by diggerlin
[NFC][AIX][XCOFF] if the size of Csect is zero, the Csect do not need
write any data into sections
SUMMARY:
if the size of Csect is zero, the Csect do not need write any data into
sections for example, the TOC Csect has zero size, it do not need invoke
a Asm.writeSectionData(W.OS, Csect.MCCsect, Layout);
Reviewers: daltenty Subscribers: rupprecht, seiyai,hiraditya
Differential Revision: https://reviews.llvm.org/D71120
The file was modifiedllvm/lib/MC/XCOFFObjectWriter.cpp (diff)
Commit 164e0fc5c7f782b174db5c87b37725ea0e174853 by Raphael Isemann
[ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls
Summary: When Sema encounters a ObjCMethodDecl definition it declares
the implicit parameters for the ObjCMethodDecl. When importing such a
method with the ASTImporter we need to do the same for the imported
method otherwise we will crash when generating code (where CodeGen
expects that this was called by Sema).
Note I had to implement Objective-C[++] support in Language.cpp as this
is the first test for Objective-C and this would otherwise just hit this
'not implemented' assert when running the unit test.
Reviewers: martong, a.sidorin, shafik
Reviewed By: martong
Subscribers: rnkovacs, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71112
The file was modifiedclang/unittests/AST/Language.cpp (diff)
The file was modifiedclang/unittests/AST/ASTImporterTest.cpp (diff)
The file was modifiedclang/lib/AST/ASTImporter.cpp (diff)
Commit 72942459d070cbfe6f3524e89c3ac37440be7890 by carrot
[MBP] Avoid tail duplication if it can't bring benefit
Current tail duplication integrated in bb layout is designed to increase
the fallthrough from a BB's predecessor to its successor, but we have
observed cases that duplication doesn't increase fallthrough, or it
brings too much size overhead.
To overcome these two issues in function canTailDuplicateUnplacedPreds I
add two checks:
  make sure there is at least one duplication in current work set.
the number of duplication should not exceed the number of successors.
The modification in hasBetterLayoutPredecessor fixes a bug that
potential predecessor must be at the bottom of a chain.
Differential Revision: https://reviews.llvm.org/D64376
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/mve-float-loops.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/speculative-load-hardening.ll (diff)
The file was modifiedllvm/test/CodeGen/PowerPC/block-placement.mir (diff)
The file was modifiedllvm/test/CodeGen/X86/shadow-stack.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/tail-dup-merge-loop-headers.ll (diff)
The file was modifiedllvm/test/CodeGen/RISCV/atomic-rmw.ll (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/uniform-cfg.ll (diff)
The file was modifiedllvm/test/CodeGen/Thumb2/2010-02-11-phi-cycle.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/pr38795.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/mmx-coalescing.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/ragreedy-hoist-spill.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/tail-opts.ll (diff)
The file was modifiedllvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll (diff)
The file was modifiedllvm/test/CodeGen/Thumb2/cbnz.ll (diff)
The file was modifiedllvm/test/CodeGen/RISCV/remat.ll (diff)
The file was addedllvm/test/CodeGen/PowerPC/no-duplicate.ll
The file was modifiedllvm/test/CodeGen/X86/reverse_branches.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/tail-merge-after-mbp.mir (diff)
The file was modifiedllvm/test/CodeGen/AArch64/tbz-tbnz.ll (diff)
The file was modifiedllvm/test/CodeGen/PowerPC/branch-opt.ll (diff)
The file was modifiedllvm/test/CodeGen/AArch64/swifterror.ll (diff)
The file was modifiedllvm/test/CodeGen/PowerPC/expand-contiguous-isel.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/tail-dup-repeat.ll (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/loop_header_nopred.mir (diff)
The file was modifiedllvm/lib/CodeGen/MachineBlockPlacement.cpp (diff)