SuccessChanges

Summary

  1. Revert "Implement nullPointerConstant() using a better API." (details)
  2. [OpenMP][NFC] clang-format the whole openmp project (details)
  3. [LTO] Fix cloning of llvm*.used when splitting module (details)
  4. [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators (details)
  5. [lld/mac] reject -undefined warning and -undefined suppress with -twolevel_namespace (details)
  6. [ConstantRangeTest] Print detailed information on failure (NFC) (details)
Commit 6984e0d4398592a20055cb12842fc72462ce01a5 by steveire
Revert "Implement nullPointerConstant() using a better API."

This reverts commit 9148302a (2019-08-22) which broke the pre-existing
unit test for the matcher.  Also revert commit 518b2266 (Fix the
nullPointerConstant() test to get bots back to green., 2019-08-22) which
incorrectly changed the test to expect the broken behavior.

Differential Revision: https://reviews.llvm.org/D96665
The file was modifiedclang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
The file was modifiedclang/include/clang/ASTMatchers/ASTMatchers.h
Commit 309b00a42e902e816dad03c2c2f1a9e41ba130bc by tianshilei1992
[OpenMP][NFC] clang-format the whole openmp project

Same script as D95318. Test files are excluded.

Reviewed By: AndreyChurbanov

Differential Revision: https://reviews.llvm.org/D97088
The file was modifiedopenmp/runtime/src/kmp_utility.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/common/state-queuei.h
The file was modifiedopenmp/runtime/src/test-touch.c
The file was modifiedopenmp/runtime/src/kmp_threadprivate.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/parallel.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/support.h
The file was modifiedopenmp/runtime/src/kmp_tasking.cpp
The file was modifiedopenmp/runtime/src/ompt-specific.h
The file was modifiedopenmp/runtime/src/kmp_version.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/interface.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/omptarget.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/reduction.cu
The file was modifiedopenmp/runtime/src/kmp_taskdeps.cpp
The file was modifiedopenmp/runtime/src/kmp_lock.cpp
The file was modifiedopenmp/runtime/src/kmp_io.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/common/omptarget.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/legacy/ittnotify.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/task.cu
The file was modifiedopenmp/runtime/src/kmp_settings.cpp
The file was modifiedopenmp/runtime/src/kmp_os.h
The file was modifiedopenmp/runtime/src/kmp_wait_release.h
The file was modifiedopenmp/runtime/src/kmp_error.cpp
The file was modifiedopenmp/runtime/src/kmp_atomic.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
The file was modifiedopenmp/runtime/src/ompt-event-specific.h
The file was modifiedopenmp/runtime/src/kmp_sched.cpp
The file was modifiedopenmp/runtime/src/kmp_dispatch.cpp
The file was modifiedopenmp/runtime/src/kmp_affinity.h
The file was modifiedopenmp/tools/multiplex/ompt-multiplex.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/loop.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/omptargeti.h
The file was modifiedopenmp/runtime/src/kmp_platform.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/ittnotify_types.h
The file was modifiedopenmp/runtime/src/kmp_barrier.cpp
The file was modifiedopenmp/tools/archer/ompt-tsan.cpp
The file was modifiedopenmp/runtime/src/kmp_taskdeps.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/ittnotify.h
The file was modifiedopenmp/runtime/src/kmp_atomic.cpp
The file was modifiedopenmp/runtime/src/kmp_environment.cpp
The file was modifiedopenmp/runtime/src/kmp_itt.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/data_sharing.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/critical.cu
The file was modifiedopenmp/runtime/src/kmp_stats.h
The file was modifiedopenmp/runtime/src/z_Linux_util.cpp
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/ittnotify_static.h
The file was modifiedopenmp/runtime/src/kmp_csupport.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/support.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu
The file was modifiedopenmp/runtime/doc/doxygen/libomp_interface.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/disable_warnings.h
The file was modifiedopenmp/runtime/src/kmp_affinity.cpp
The file was modifiedopenmp/runtime/src/kmp_ftn_entry.h
The file was modifiedopenmp/runtime/src/ompt-general.cpp
The file was modifiedopenmp/runtime/src/kmp_stats.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_locks.hip
The file was modifiedopenmp/runtime/src/kmp_alloc.cpp
The file was modifiedopenmp/runtime/src/kmp_runtime.cpp
The file was modifiedopenmp/runtime/src/kmp_itt.cpp
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/cancel.cu
The file was modifiedopenmp/runtime/src/kmp_gsupport.cpp
The file was modifiedopenmp/runtime/src/kmp_str.cpp
The file was modifiedopenmp/runtime/src/kmp.h
The file was modifiedopenmp/runtime/src/kmp_lock.h
The file was modifiedopenmp/runtime/src/thirdparty/ittnotify/ittnotify_config.h
The file was modifiedopenmp/runtime/src/kmp_i18n.cpp
Commit fde55a9c9bf147241249ae478760ae69dd1925ed by tejohnson
[LTO] Fix cloning of llvm*.used when splitting module

Refines the fix in 3c4c205060c9398da705eb71b63ddd8a04999de9 to only
put globals whose defs were cloned into the split regular LTO module
on the cloned llvm*.used globals. This avoids an issue where one of the
attached values was a local that was promoted in the original module
after the module was cloned. We only need to have the values defined in
the new module on those globals.

Fixes PR49251.

Differential Revision: https://reviews.llvm.org/D97013
The file was addedllvm/test/Transforms/ThinLTOBitcodeWriter/split-used.ll
The file was modifiedllvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
The file was modifiedllvm/lib/Transforms/Utils/ModuleUtils.cpp
Commit 559f3728441d4b8342c71ef554d84a2804575d9d by steveire
[ASTMatchers] Fix hasUnaryOperand matcher for postfix operators

Differential Revision: https://reviews.llvm.org/D97095
The file was modifiedclang/include/clang/ASTMatchers/ASTMatchersInternal.h
The file was modifiedclang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Commit 28d9953af9be537f7602fbd445838e8cceb8d372 by thakis
[lld/mac] reject -undefined warning and -undefined suppress with -twolevel_namespace

See discussion on https://reviews.llvm.org/D93263

-flat_namespace isn't implemented yet, and neither is -undefined dynamic,
so this makes -undefined pretty pointless in lld/MachO for now. But once
we implement -flat_namespace (which we need to do anyways to get check-llvm
to pass with lld as host linker), the code's already there.

Follow-up to https://reviews.llvm.org/D93263#2491865

Differential Revision: https://reviews.llvm.org/D96963
The file was modifiedlld/MachO/Config.h
The file was modifiedlld/MachO/Options.td
The file was modifiedlld/MachO/Driver.cpp
The file was modifiedlld/test/MachO/treat-undef-sym.s
Commit 5ec75c600713d529cee75943f398d12df15574db by nikita.ppv
[ConstantRangeTest] Print detailed information on failure (NFC)

When the optimality check fails, print the inputs, the computed
range and the better range that was found. This makes it much
simpler to identify the cause of the failure.

Make sure that full ranges (which, unlikely all the other cases,
have multiple ways to construct them that all result in the same
range) only print one message by handling them separately.
The file was modifiedllvm/unittests/IR/ConstantRangeTest.cpp