SuccessChanges

Summary

  1. [clangd][remote] Add flag to set idletimeout (details)
  2. [libcxxabi] Fewer assumptions about path from libcxx to libcxxabi (details)
  3. [mlir] Silence some deprecation warnings after dffc487b07d9a50f8c65eccb9241f72af3486c79 (details)
  4. [mlir][linalg] Allow TC ops taking an unused shaped operand. (details)
  5. [Utils] collectBitParts - bail for integers > 128-bits (details)
  6. [mlir][linalg] Add pooling ops to Linalg TC ops. (details)
  7. [libc++] Remove the now unused macos-trunk and macos-backdeployment CI scripts (details)
  8. [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef` (details)
  9. [lldb] Add deref support to libc++ unique_ptr synthetic (details)
  10. [llvm][utils] Support dereferencing llvm::Optional lldb formatter (details)
  11. [llvm][utils] Rename lldb dict variables to internal_dict (details)
  12. [AMDGPU] Better codegen for i64 bitreverse (details)
  13. Fix assert to use getTypeStoreSize instead of getPrimitiveSizeInBits, (details)
  14. [llvm][utils] Fix innocuous off by one in lldb formatters (details)
Commit 1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683 by kadircet
[clangd][remote] Add flag to set idletimeout

By default gRPC has no idletimeout and some firewalls might drop idle
connections after a certain period. This results in idle clients
shouting into void until server resets the connection.

Differential Revision: https://reviews.llvm.org/D97536
The file was modifiedclang-tools-extra/clangd/index/remote/server/Server.cpp
Commit 72b18a86e11ebc970be96a8c2b11aa3a31c14c5d by thakis
[libcxxabi] Fewer assumptions about path from libcxx to libcxxabi

This is useful for projects that pull in libcxx and libcxxabi and build
them using out-of-tree build files, but don't make them sibling
directories (or don't call the sibling directories libcxx and libcxxabi
for some reason).

Fixes PR49313.

Differential Revision: https://reviews.llvm.org/D97379
The file was modifiedllvm/utils/gn/secondary/libcxxabi/src/BUILD.gn
The file was modifiedlibcxxabi/src/CMakeLists.txt
The file was modifiedlibcxxabi/src/stdlib_stdexcept.cpp
Commit 4941fef9c41c42ac11cbe6fcc3e6a43511a5dfed by benny.kra
[mlir] Silence some deprecation warnings after dffc487b07d9a50f8c65eccb9241f72af3486c79
The file was modifiedmlir/tools/mlir-tblgen/OpFormatGen.cpp
The file was modifiedmlir/include/mlir/IR/FunctionSupport.h
The file was modifiedmlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
Commit 855a1196049705344ec90cc1f3fd09b426416311 by hanchung
[mlir][linalg] Allow TC ops taking an unused shaped operand.

If one operand is not used in the formula, it will be considered a
shaped operand. And the result of indexing map of the operand will be the first
reduction dims.

Depends On D97383

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D97384
The file was modifiedmlir/test/mlir-linalg-ods-gen/test-linalg-ods-gen.tc
The file was modifiedmlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp
The file was modifiedmlir/docs/Dialects/Linalg.md
Commit 455d43b951ae31dac133a8650532797f01343a36 by llvm-dev
[Utils] collectBitParts - bail for integers > 128-bits

collectBitParts uses int8_t for the bit indices, leaving a 128-bit limit.

We already test for this before calling collectBitParts, but rGb94c215592bd added truncate handling which meant we could end up processing wider integers.

Thanks to @manojgupta for the repro.
The file was modifiedllvm/test/Transforms/InstCombine/bswap.ll
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
Commit bfd3771c9eecdb5fd8d3f2714e5fc3500bb7d4da by hanchung
[mlir][linalg] Add pooling ops to Linalg TC ops.

- Add EDSC builders for std_cmpf_ogt and std_cmpf_olt.
- Add pooling_nhwc_min/max/sum ops

Depends On D97384

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D97385
The file was modifiedmlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
The file was modifiedmlir/test/Dialect/Linalg/named-ops.mlir
The file was modifiedmlir/test/Dialect/Linalg/generalize-named-ops.mlir
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOpsSpec.tc
Commit cb3de0950309ad0f3546e6e7c5e75eb3bf146662 by Louis Dionne
[libc++] Remove the now unused macos-trunk and macos-backdeployment CI scripts

We use the run-buildbot script everywhere now.
The file was removedlibcxx/utils/ci/macos-backdeployment.sh
The file was removedlibcxx/utils/ci/macos-trunk.sh
Commit 9909237d992000d651b32212d15111453485a6b0 by vlad.vinogradov
[ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`

* `value_type`
* `pointer`
* `const_pointer`
* `reference`
* `const_reference`
* `const_reverse_iterator`
* `size_type`
* `difference_type`

It makes `ArrayRef` and `MutableArrayRef` types fully compliant with STL Container concept.

Reviewed By: lattner, courbet

Differential Revision: https://reviews.llvm.org/D95611
The file was modifiedllvm/include/llvm/ADT/ArrayRef.h
Commit 3a677b29a3b3f6a2539843db4d56ba59689fc0a0 by davelee.com
[lldb] Add deref support to libc++ unique_ptr synthetic

Add frame variable dereference suppport to libc++ `std::unique_ptr`.

This change allows for commands like `v *thing_up` and `v thing_up->m_id`. These commands now work the same way they would with raw pointers, and as they would with expression. This is done by adding an unaccounted for child member named `$$dereference$$`.

Without this change, the command would have to be written as `v *thing_up.__value_` or v thing_up.__value_->m_id` which exposes internal structure and is more clumsy to type.

Additionally, the existing tests were updated. See also https://reviews.llvm.org/D97165 which added deref support for `std::shared_ptr`.

Differential Revision: https://reviews.llvm.org/D97524
The file was modifiedlldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
The file was modifiedlldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/main.cpp
The file was modifiedlldb/source/Plugins/Language/CPlusPlus/LibCxx.h
The file was modifiedlldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py
Commit 408456f53eccd9b2280840aff8fa99f865024544 by davelee.com
[llvm][utils] Support dereferencing llvm::Optional lldb formatter

Add deref support to `llvm::Optional` in `lldbDataFormatters.py`.

This creates a synthetic provider that adds dereference support, but otherwise proxies all access to the underlying value.

With this change, an optional value can be displayed by running `v *someOptional`, and its contents can be accessed with the arrow `operator->`, for example `v someOpt->HasThing`. This matches expressions usable from expression evaluation.

See also D97165 and D97524.

Differential Revision: https://reviews.llvm.org/D97525
The file was modifiedllvm/utils/lldbDataFormatters.py
Commit 8d1b6afcea6c30db7728d966d9281ab373eaa9e1 by davelee.com
[llvm][utils] Rename lldb dict variables to internal_dict

Most lldb scripts use `internal_dict`. Also, `dict` is a builtin constructor,
it's good habit to avoid using it as a variable name.
The file was modifiedllvm/utils/lldbDataFormatters.py
Commit 3ad5216ed88e303cb5d37864bb83b0eec81144af by jay.foad
[AMDGPU] Better codegen for i64 bitreverse

Differential Revision: https://reviews.llvm.org/D97547
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-bitreverse.mir
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/SOPInstructions.td
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/bitreverse.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-bitreverse.mir
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-bitreverse.mir
Commit 740e69b6fdc2b1415065f3d20acc4d10a73edb00 by jyknight
Fix assert to use getTypeStoreSize instead of getPrimitiveSizeInBits,
per comment on D97223.
The file was modifiedllvm/lib/CodeGen/AtomicExpandPass.cpp
Commit a01a406bba8ac624a876f8d5720e1d4949a5b0fa by davelee.com
[llvm][utils] Fix innocuous off by one in lldb formatters

num_children is "last_index" + 1, thus
    num_children + 1 = "last_index" + 2

this worked anyway because the index of `$$dereference$$` would work as long as
it was past the last index.
The file was modifiedllvm/utils/lldbDataFormatters.py