SuccessChanges

Summary

  1. Store (cache) the Argument number (index in the argument list) inside the BlockArgumentImpl (details)
  2. [lld-macho] Properly test subtractor relocations & fix their attributes (details)
  3. [lld-macho] Don't emit rebase opcodes for subtractor minuend relocs (details)
  4. [lld-macho] Add test for a variety of arm64 relocations (details)
  5. [lld-macho] Extract embedded addends for arm64 UNSIGNED relocations (details)
  6. [llvm-readobj] Use ListSeparator (NFC) (details)
  7. [llvm] Fix typos in documentation (NFC) (details)
  8. [IR] Use range-based for loops (NFC) (details)
  9. [mlir] Improve test coverage for print-op-graph (details)
  10. [NFC][AMDGPU] Document the AMDGPU target feature defaults (details)
  11. Change the error message when `-split-input-file` is used with mlir-opt to make it recognizable by IDEs (details)
Commit ee90bb3486948c472a67ec3ca0f0d64927f6643d by joker.eph
Store (cache) the Argument number (index in the argument list) inside the BlockArgumentImpl

This avoids linear search in BlockArgument::getArgNumber().

Differential Revision: https://reviews.llvm.org/D97596
The file was modifiedmlir/include/mlir/IR/Value.h
The file was modifiedmlir/lib/IR/Block.cpp
Commit cc5c03e10957b8dd4ba4efbc5583084c7636a3ba by jezng
[lld-macho] Properly test subtractor relocations & fix their attributes

`llvm-mc` doesn't generate any relocations for subtractions
between local symbols -- they must be global -- so the previous test
wasn't actually testing any relocation logic. I've fixed that and
extended the test to cover r_length=3 relocations as well as both x86_64
and arm64.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D97057
The file was modifiedlld/MachO/Arch/X86_64.cpp
The file was modifiedlld/MachO/Arch/ARM64.cpp
The file was addedlld/test/MachO/reloc-subtractor.s
The file was removedlld/test/MachO/x86-64-reloc-subtract.s
Commit 541390131ef72a8dad93c936d816279c8b76374e by jezng
[lld-macho] Don't emit rebase opcodes for subtractor minuend relocs

Also add a few asserts to verify that we are indeed handling an
UNSIGNED relocation as the minued. I haven't made it an actual
user-facing error since I don't think llvm-mc is capable of generating
SUBTRACTOR relocations without an associated UNSIGNED.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D97103
The file was modifiedlld/MachO/InputSection.cpp
The file was modifiedlld/MachO/Target.h
The file was modifiedlld/MachO/Writer.cpp
The file was modifiedlld/MachO/Arch/ARM64.cpp
The file was modifiedlld/MachO/InputFiles.cpp
The file was modifiedlld/test/MachO/reloc-subtractor.s
Commit 8da88d4b605bd3e596fc26845969ba83a6bf076d by jezng
[lld-macho] Add test for a variety of arm64 relocations

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D97104
The file was modifiedlld/test/MachO/compact-unwind.s
The file was addedlld/test/MachO/arm64-relocs.s
Commit 82b3da6f6f0e91e47074f454907e82b284b8beda by jezng
[lld-macho] Extract embedded addends for arm64 UNSIGNED relocations

On arm64, UNSIGNED relocs are the only ones that use embedded addends
instead of the ADDEND relocation.

Also ensure that the addend works when UNSIGNED is part of a SUBTRACTOR
pair.

Reviewed By: #lld-macho, alexshap

Differential Revision: https://reviews.llvm.org/D97105
The file was modifiedlld/MachO/InputFiles.cpp
The file was modifiedlld/test/MachO/reloc-subtractor.s
The file was modifiedlld/MachO/Arch/ARM64.cpp
The file was modifiedlld/test/MachO/arm64-relocs.s
Commit c81dde9292817e02e55d0096a7ecc322f1a0984b by kazu
[llvm-readobj] Use ListSeparator (NFC)
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
Commit e8fa9014cce41e1057e295b035dda73420612686 by kazu
[llvm] Fix typos in documentation (NFC)
The file was modifiedllvm/docs/LangRef.rst
The file was modifiedllvm/docs/Statepoints.rst
The file was modifiedllvm/docs/MemorySSA.rst
The file was modifiedllvm/docs/CommandLine.rst
The file was modifiedllvm/docs/Lexicon.rst
The file was modifiedllvm/docs/CommandGuide/llvm-install-name-tool.rst
The file was modifiedllvm/docs/CommandGuide/tblgen.rst
The file was modifiedllvm/docs/TableGen/ProgRef.rst
The file was modifiedllvm/docs/MergeFunctions.rst
The file was modifiedllvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
The file was modifiedllvm/docs/AMDGPUModifierSyntax.rst
The file was modifiedllvm/docs/Coroutines.rst
The file was modifiedllvm/docs/ORCv2.rst
The file was modifiedllvm/docs/YamlIO.rst
The file was modifiedllvm/docs/ProgrammersManual.rst
The file was modifiedllvm/docs/BitCodeFormat.rst
The file was modifiedllvm/docs/Passes.rst
The file was modifiedllvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl10.rst
The file was modifiedllvm/docs/StackMaps.rst
The file was modifiedllvm/docs/Frontend/PerformanceTips.rst
The file was modifiedllvm/docs/AMDGPUUsage.rst
The file was modifiedllvm/docs/JITLink.rst
The file was modifiedllvm/docs/MIRLangRef.rst
The file was modifiedllvm/docs/XRay.rst
Commit 6a337f85c8faa0040dc2ad0c0d8f0f033f7a162b by kazu
[IR] Use range-based for loops (NFC)
The file was modifiedllvm/lib/IR/Core.cpp
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp
The file was modifiedllvm/lib/IR/Dominators.cpp
The file was modifiedllvm/lib/IR/BasicBlock.cpp
The file was modifiedllvm/lib/IR/AsmWriter.cpp
The file was modifiedllvm/lib/IR/Attributes.cpp
The file was modifiedllvm/lib/IR/DebugInfoMetadata.cpp
The file was modifiedllvm/lib/IR/Instructions.cpp
The file was modifiedllvm/lib/IR/Mangler.cpp
Commit dd2f50a4d051b2ec797f13f71088f10887fe0709 by jpienaar
[mlir] Improve test coverage for print-op-graph
The file was modifiedmlir/test/Transforms/print-op-graph.mlir
Commit 2da13f1246e1f458d0d9eb716913616eb05f698d by Tony.Tye
[NFC][AMDGPU] Document the AMDGPU target feature defaults

Document the default for the XNACK and SRAMECC target features for code object V2-V3 and V4.

Reviewed By: kzhuravl

Differential Revision: https://reviews.llvm.org/D97598
The file was modifiedllvm/docs/AMDGPUUsage.rst
Commit a6d76cf6101d0479af2d9c9266427c0ea51e3889 by joker.eph
Change the error message when `-split-input-file` is used with mlir-opt to make it recognizable by IDEs

By adding the line number of the split point immediately after the file
name (separated by `:`) this is recognized by various tool as a proper
location.

Ideally we would want to point to the line of the error, but that would
require some very invasive changes I suspect.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D93363
The file was modifiedmlir/lib/Support/ToolUtilities.cpp