Started 8 mo 28 days ago
Took 1 hr 18 min on green-dragon-19

Success Build rL:371584 - C:371584 - #543 (Sep 10, 2019 6:11:46 PM)

  • : 371584
  • : 371584
  • : 371584
  • : 364589
  • : 371154
  • : 371324
  • : 371504
  1. clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

    This patch contains the basic functionality for reporting potentially
    incorrect usage of __builtin_expect() by comparing the developer's
    annotation against a collected PGO profile. A more detailed proposal and
    discussion appears on the CFE-dev mailing list
    ( and a
    prototype of the initial frontend changes appear here in D65300

    We revised the work in D65300 by moving the misexpect check into the
    LLVM backend, and adding support for IR and sampling based profiles, in
    addition to frontend instrumentation.

    We add new misexpect metadata tags to those instructions directly
    influenced by the llvm.expect intrinsic (branch, switch, and select)
    when lowering the intrinsics. The misexpect metadata contains
    information about the expected target of the intrinsic so that we can
    check against the correct PGO counter when emitting diagnostics, and the
    compiler's values for the LikelyBranchWeight and UnlikelyBranchWeight.
    We use these branch weight values to determine when to emit the
    diagnostic to the user.

    A future patch should address the comment at the top of
    LowerExpectIntrisic.cpp to hoist the LikelyBranchWeight and
    UnlikelyBranchWeight values into a shared space that can be accessed
    outside of the LowerExpectIntrinsic pass. Once that is done, the
    misexpect metadata can be updated to be smaller.

    In the long term, it is possible to reconstruct portions of the
    misexpect metadata from the existing profile data. However, we have
    avoided this to keep the code simple, and because some kind of metadata
    tag will be required to identify which branch/switch/select instructions
    are influenced by the use of llvm.expect

    Patch By: paulkirth
    Differential Revision: (detail/ViewSVN)
    by phosek
  2. Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

    The first NFC change is to replace a getCXXABI().isMicrosoft() check
    with getTriple().isWindowsMSVCEnvironment(). This code takes effect in
    non-C++ compilations, so it doesn't make sense to check the C++ ABI. In
    the MS ABI, enums are always considered to be "complete" because the
    underlying type of an unfixed enum will always be 'int'. This behavior
    was moved from -fms-compatibility to MS ABI back in r249656.

    The second change is functional, and it downgrades an error to a warning
    when the MS ABI is used rather than only under -fms-compatibility. The
    reasoning is that it's unreasonable for the following code to reject the
    following code for all MS ABI targets with -fno-ms-compatibility:
      enum Foo { Foo_Val = 0xDEADBEEF };
    This is valid code for any other target, but in the MS ABI, Foo_Val just
    happens to be negative. With this change, clang emits a
    -Wmicrosoft-enum-value warning on this code, but compiles it without

    Fixes PR38478

    Reviewers: hans, rsmith, STL_MSFT

    Subscribers: cfe-commits

    Tags: #clang

    Differential Revision: (detail/ViewSVN)
    by rnk
  3. Revert "llvm-reduce: Add pass to reduce parameters"

    Looks to be failing on asan buildbots

    This reverts commit r371567. (detail/ViewSVN)
    by dblaikie
  4. Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds."

    This reverts commit r371566: this doesn't correctly handle the case
    where LLVM_ENABLE_RUNTIMES contains a list of values. (detail/ViewSVN)
    by phosek
  5. [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path

    Differential Revision: (detail/ViewSVN)
    by Jan Korous
  6. [Object][TextAPI] NFC, fix tapi lit tests

    FileCheck command had wrong casing, which works fine on macOS, repairs the linux build bots (detail/ViewSVN)
    by cishida

Started by an SCM change (5 times)

This run spent:

  • 54 min waiting;
  • 1 hr 18 min build duration;
  • 2 hr 13 min total from scheduled to completion.
LLVM/Clang Warnings: 1 warning.
    Test Result (no failures)