Started 8 mo 18 days ago
Took 1 hr 20 min on green-dragon-17

Success Build rL:372286 - C:372281 - #667 (Sep 18, 2019 7:04:05 PM)

  • : 372286
  • : 372281
  • : 372205
  • : 364589
  • : 371835
  • : 372242
  • : 372206
  1. AMDGPU/GlobalISel: Fix RegBankSelect G_SMULH/G_UMULH pre-gfx9

    The scalar versions were only introduced in gfx9. (detail/ViewSVN)
    by arsenm
  2. GlobalISel: Don't materialize immarg arguments to intrinsics

    Encode them directly as an imm argument to G_INTRINSIC*.

    Since now intrinsics can now define what parameters are required to be
    immediates, avoid using registers for them. Intrinsics could
    potentially want a constant that isn't a legal register type. Also,
    since G_CONSTANT is subject to CSE and legalization, transforms could
    potentially obscure the value (and create extra work for the
    selector). The register bank of a G_CONSTANT is also meaningful, so
    this could throw off future folding and legalization logic for AMDGPU.

    This will be much more convenient to work with than needing to call
    getConstantVRegVal and checking if it may have failed for every
    constant intrinsic parameter. AMDGPU has quite a lot of intrinsics wth
    immarg operands, many of which need inspection during lowering. Having
    to find the value in a register is going to add a lot of boilerplate
    and waste compile time.

    SelectionDAG has always provided TargetConstant for constants which
    should not be legalized or materialized in a register. The distinction
    between Constant and TargetConstant was somewhat fuzzy, and there was
    no automatic way to force usage of TargetConstant for certain
    intrinsic parameters. They were both ultimately ConstantSDNode, and it
    was inconsistently used. It was quite easy to mis-select an
    instruction requiring an immediate. For SelectionDAG, start emitting
    TargetConstant for these arguments, and using timm to match them.

    Most of the work here is to cleanup target handling of constants. Some
    targets process intrinsics through intermediate custom nodes, which
    need to preserve TargetConstant usage to match the intrinsic
    expectation. Pattern inputs now need to distinguish whether a constant
    is merely compatible with an operand or whether it is mandatory.

    The GlobalISelEmitter needs to treat timm as a special case of a leaf
    node, simlar to MachineBasicBlock operands. This should also enable
    handling of patterns for some G_* instructions with immediates, like

    This does include a workaround for a crash in GlobalISelEmitter when
    ARM tries to uses "imm" in an output with a "timm" pattern source. (detail/ViewSVN)
    by arsenm
  3. gn build: Merge r372282 (detail/ViewSVN)
    by gnsyncbot
  4. llvm-reduce: Add pass to reduce instructions

    Patch by Diego Treviño!

    Differential Revision: (detail/ViewSVN)
    by dblaikie
  5. Initialize all fields in ABIArgInfo.

    Due to usage of an uninitialized fields, we end up with
    a Conditional jump or move depends on uninitialised value


    Commited on behalf of Martin Liska <> (detail/ViewSVN)
    by serge_sans_paille

Started by an SCM change (5 times)

This run spent:

  • 1 hr 7 min waiting;
  • 1 hr 20 min build duration;
  • 2 hr 27 min total from scheduled to completion.
LLVM/Clang Warnings: 1 warning.
    Test Result (no failures)