SuccessChanges

Summary

  1. [llvm-objdump][NFC] Declare command-line externs in headers with namespace (details)
  2. [AMDGPU] Disable 'Skip Uniform Regions' optimization by default for AMDGPU. (details)
  3. Add more detailed symbol type categorization, based on a swift patch by (details)
  4. [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam (details)
  5. X86ISelLowering: Minor refactor to avoid redundant initialization while ensuring compiler warnings can hopefully still prove initialization (details)
  6. [lldb/Test] Enable TestGdbRemoteThreadsInfoMemory.py on Windows. (details)
  7. Revert "Make llvm_source_root in llvm-lit relative too." (details)
  8. [gdb-remote] Moving prevents copy elision. Found by clang. (details)
  9. Add option to limit Debugify to locations (omitting variables) (details)
  10. [libc++] Add availability markup for the C++20 Synchronization Library on Apple (details)
  11. [libc++] Only support std::to_chars availability test when back-deploying (details)
  12. Allow MachineFunction to obtain non-const Function (to enable MIR-level debugify) (details)
  13. Support bfdname "elf32-hexagon". (details)
  14. [libc++] 2/N: Enable the new libc++ testing format by default (details)
Commit 076308a4b575d488440d7e715965e9d1c0adb9bb by hubert.reinterpretcast
[llvm-objdump][NFC] Declare command-line externs in headers with namespace

Summary:
This patch moves the forward declarations of command-line `cl::*`
externs in `MachODump.cpp` and `llvm-objdump.cpp` into the headers
corresponding to the file that defines the variable. At the same time,
these externs are moved into the `llvm::objdump` namespace. The externs
that are not referenced outside their defining translation unit are made
static.

This does not factor out uses of the Mach-O options from
`llvm-objdump.cpp`.

Reviewers: jhenderson, MaskRay, DiggerLin, jasonliu, daltenty

Reviewed By: jhenderson, MaskRay

Subscribers: rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77388
The file was modifiedllvm/tools/llvm-objdump/ELFDump.cpp
The file was modifiedllvm/tools/llvm-objdump/llvm-objdump.h
The file was modifiedllvm/tools/llvm-objdump/MachODump.cpp
The file was modifiedllvm/tools/llvm-objdump/llvm-objdump.cpp
The file was addedllvm/tools/llvm-objdump/MachODump.h
Commit 72e8754916f5f003a49477adc9694d3465b44414 by konstantin.pyzhov
[AMDGPU] Disable 'Skip Uniform Regions' optimization by default for AMDGPU.

Reviewers: sameerds, dstuttard

Differential Revision: https://reviews.llvm.org/D77228
The file was modifiedllvm/test/CodeGen/AMDGPU/unhandled-loop-condition-assertion.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/control-flow-optnone.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/wqm.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/sgpr-copy.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/salu-to-valu.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/optimize-negated-cond.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/branch-relaxation.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/uniform-loop-inside-nonuniform.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/nested-loop-conditions.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/udiv64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/early-if-convert.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/udiv.i64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/insert_vector_elt.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/localizer.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/srem64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/cross-block-use-is-not-abi-copy.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/uniform-cfg.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/branch-relaxation-debug-info.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/branch-uniformity.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/i1-copy-phi-uniform-branch.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/sdiv64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/sgpr-control-flow.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/urem.i64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/infinite-loop.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/si-annotate-cf.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/valu-i1.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/divergent-control-flow.ll
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/indirect-addressing-si.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/setcc.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/urem64.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/cf-loop-on-constant.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/cgp-bitfield-extract.ll
Commit 836534f9970295ff559ef49d6c49958aac6171f9 by Jason Molenda
Add more detailed symbol type categorization, based on a swift patch by
Greg Clayton a few years ago.

My patch to augment the symbol table in Mach-O files with the
dyld trie exports data structure only categorized symbols as code
or data, but Greg Clayton had a patch to do something similar to
swift a few years ago that had a more extensive categorization of
symbols, as well as extracting some objc class/ivar names from the
entries. This patch is basically just Greg's, updated a bit and
with a test case added to it.

<rdar://problem/50791451>

Differential Revision: https://reviews.llvm.org/D77369
The file was modifiedlldb/test/API/macosx/dyld-trie-symbols/Makefile
The file was modifiedlldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py
The file was modifiedlldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
The file was addedlldb/test/API/macosx/dyld-trie-symbols/main.mm
The file was removedlldb/test/API/macosx/dyld-trie-symbols/main.cpp
Commit 28ecd7f0b0865878a12d814a6d0de92cb7529d22 by jinl
[clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

Summary:
While [the original diff](https://reviews.llvm.org/D42493) makes a lot of sense, and multiple inline block parameter/trailing paramemter after inline block paramemter should be discouraged, the formatting result is different than what xcode does by default
For the exact same example provided in the original diff:
```
[object
  blockArgument:^{
    a = 42;
  }
     anotherArg:42];
```
The code is hard to read and not very visually pleasing

This diff uses `ObjCBreakBeforeNestedBlockParam` to shield from the formatting
When it's set to false, don't allign the inline block paramemters.

Reviewers: jolesiak, benhamilton, jinlin

Reviewed By: jolesiak

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77039
The file was modifiedclang/docs/ClangFormatStyleOptions.rst
The file was modifiedclang/lib/Format/ContinuationIndenter.cpp
The file was modifiedclang/unittests/Format/FormatTestObjC.cpp
Commit 5aead592f09db941d6fc9c075e474c59b7d1d4f9 by dblaikie
X86ISelLowering: Minor refactor to avoid redundant initialization while ensuring compiler warnings can hopefully still prove initialization

Based on post-commit review/discussion in fabe52a7412b
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 1b7560b877217adc828ed5c8d7818e14dccc7378 by Jonas Devlieghere
[lldb/Test] Enable TestGdbRemoteThreadsInfoMemory.py on Windows.

This test is currently XFAILed but is passing on the Windows bot.
The file was modifiedlldb/test/API/tools/lldb-server/threads-info/TestGdbRemoteThreadsInfoMemory.py
Commit 3185881d69022e03b300e189838b0599ed417be5 by hubert.reinterpretcast
Revert "Make llvm_source_root in llvm-lit relative too."

This reverts commit 6c1a9fb174ac3cf66bfdbab5a327957a0a35ad85.

Commit causes failures:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/49206
The file was modifiedllvm/utils/llvm-lit/llvm-lit.in
The file was modifiedllvm/utils/llvm-lit/CMakeLists.txt
Commit 41610d665013d716da245175ada1d9c5a8b79558 by ditaliano
[gdb-remote] Moving prevents copy elision. Found by clang.
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
Commit 15f7bc78572543d75f56d1e7989801a2ac08c430 by daniel_l_sanders
Add option to limit Debugify to locations (omitting variables)

Summary:
It can be helpful to test behaviour w.r.t locations without having DEBUG_VALUE
around. In particular, because DEBUG_VALUE has the potential to change CodeGen
behaviour (e.g. hasOneUse() vs hasOneNonDbgUse()) while locations generally
don't.

Reviewers: aprantl, bogner

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77438
The file was addedllvm/test/Transforms/Util/Debugify/loc-only.ll
The file was modifiedllvm/lib/Transforms/Utils/Debugify.cpp
Commit 46c38761886fb66b8648ab018ec4cfa04c3b8c7a by Louis Dionne
[libc++] Add availability markup for the C++20 Synchronization Library on Apple
The file was addedlibcxx/test/libcxx/thread/latch.availability.fail.cpp
The file was modifiedlibcxx/include/atomic
The file was modifiedlibcxx/include/__config
The file was modifiedlibcxx/include/latch
The file was addedlibcxx/test/libcxx/thread/barrier.availability.fail.cpp
The file was modifiedlibcxx/include/semaphore
The file was modifiedlibcxx/include/barrier
The file was addedlibcxx/test/libcxx/thread/semaphore.availability.fail.cpp
The file was modifiedlibcxx/include/__threading_support
The file was addedlibcxx/test/libcxx/thread/atomic.availability.fail.cpp
Commit bcf14f375e29b94e7abb381920df795eeefb2309 by Louis Dionne
[libc++] Only support std::to_chars availability test when back-deploying
The file was modifiedlibcxx/test/libcxx/utilities/charconv/charconv.to.chars/availability.fail.cpp
Commit 35b7b0851b1957d4f6f14f023eb3b4571cadc3d7 by daniel_l_sanders
Allow MachineFunction to obtain non-const Function (to enable MIR-level debugify)

Summary:
To debugify MIR, we need to be able to create metadata and to do that, we
need a non-const Module. However, MachineFunction only had a const reference
to the Function preventing this.

Reviewers: aprantl, bogner

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77439
The file was modifiedllvm/lib/CodeGen/MachineModuleInfo.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineFunction.h
The file was modifiedllvm/lib/CodeGen/MachineFunction.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineModuleInfo.h
Commit 5002863ab0d6d16e6f948e712554c48593770341 by sidneym
Support bfdname "elf32-hexagon".

Add support and update testcases.

Differential Revision: https://reviews.llvm.org/D77579
The file was modifiedllvm/test/tools/llvm-objcopy/ELF/cross-arch-headers.test
The file was modifiedllvm/tools/llvm-objcopy/CopyConfig.cpp
The file was modifiedllvm/test/tools/llvm-objcopy/ELF/binary-output-target.test
Commit 276d2b78ce4d9753ed9e46576b4c5ab27d0ebf45 by Louis Dionne
[libc++] 2/N: Enable the new libc++ testing format by default

Both test formats are equivalent, so this *should* not be a problem.
We've fixed a couple of failures uncovered by the first time we tried
making the switch, so this new attempt should go even farther.

If failures are noticed, it should be fine to revert this commit, but
please give a heads up afterwards so we know to address the issues!

Also note that it is still possible to use the old format by passing
`--param=use_old_format=True` when running Lit for the time being.
The file was modifiedlibcxx/test/lit.cfg