SuccessChanges

Summary

  1. [lldb][NFC] Return a reference from ClangASTContext::getASTContext and (details)
Commit f9f49d3594bc7584cc5cb96125ca08f2ad97662c by Raphael Isemann
[lldb][NFC] Return a reference from ClangASTContext::getASTContext and
remove dead nullptr checks
ClangASTContext::getASTContext() currently returns a ptr but we have an
assert there since a while that the ASTContext is not a nullptr. This
causes that we still have a lot of code that is doing nullptr checks on
the result of getASTContext() which is all unreachable code.
This patch changes the return value to a reference to make it clear this
can't be a nullptr and deletes all the nullptr checks.
The file was modifiedlldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp
The file was modifiedlldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
The file was modifiedlldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
The file was modifiedlldb/unittests/Symbol/TestClangASTImporter.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
The file was modifiedlldb/unittests/Expression/ClangExpressionDeclMapTest.cpp
The file was modifiedlldb/include/lldb/Symbol/ClangASTContext.h
The file was modifiedlldb/tools/lldb-test/lldb-test.cpp
The file was modifiedlldb/source/Symbol/ClangASTImporter.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
The file was modifiedlldb/source/Plugins/Language/ObjC/NSArray.cpp
The file was modifiedlldb/unittests/Symbol/TestClangASTContext.cpp
The file was modifiedlldb/unittests/TestingSupport/Symbol/ClangTestUtils.h