SuccessChanges

Summary

  1. [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to (details)
  2. Make lazyload_metadata.ll resilient to the addition of new metadata (details)
  3. Allow newlines in AST Matchers in clang-query files (details)
  4. Revert "Allow newlines in AST Matchers in clang-query files" (details)
Commit cdd25a4c7410d9af69df4ebe0e640506b8e977b4 by kbessonova
[DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to
another node
SelectionDAG::transferDbgValues() can 'reattach' SDDbgValue from one to
another node, but doesn't change its source order. If the destination
node has the order greater than the SDDbgValue, there are two possible
issues revealed later:
* If debug info is attached to an instruction that is the first
definition of a register, this ends up with a def-after-use and the
debug info gets 'undef' later.
* If MIR has another definition of a register above the debug info, the
debug info may represent a source variable incorrectly because it
appears (significantly) before an instruction corresponded to this debug
info.
So, the patch changes the order of an SDDbgValue when it is moved to a
node with greater order.
Reviewers: dblaikie, jmorse, aprantl
Reviewed By: aprantl
Subscribers: aprantl, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71175
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was addedllvm/test/DebugInfo/X86/sdag-transfer-dbgvalue.ll
Commit be4704bd41a4dd8bb5c4dd5a614744c69fb3cf8e by david
Make lazyload_metadata.ll resilient to the addition of new metadata
kinds
Summary: The specific number of records loaded depends on the number of
kinds, but the difference between the lazy and not lazy cases does not.
Reviewers: modocache
Subscribers: llvm-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71882
The file was modifiedllvm/test/ThinLTO/X86/lazyload_metadata.ll
Commit 6a3ecf4dc7ec299394e71b3124df2b3a34ed4ac3 by steveire
Allow newlines in AST Matchers in clang-query files
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71842
The file was modifiedclang-tools-extra/clang-query/tool/ClangQuery.cpp
The file was modifiedclang-tools-extra/clang-query/Query.cpp
The file was modifiedclang/lib/ASTMatchers/Dynamic/Parser.cpp
The file was modifiedclang/unittests/ASTMatchers/Dynamic/ParserTest.cpp
The file was modifiedclang-tools-extra/unittests/clang-query/QueryParserTest.cpp
The file was modifiedclang-tools-extra/clang-query/Query.h
The file was modifiedclang-tools-extra/clang-query/QueryParser.cpp
The file was modifiedclang/include/clang/ASTMatchers/Dynamic/Parser.h
Commit 831b636861ea33c3cc1c1c28384fb1800facf792 by steveire
Revert "Allow newlines in AST Matchers in clang-query files"
This reverts commit 6a3ecf4dc7ec299394e71b3124df2b3a34ed4ac3.
The file was modifiedclang/include/clang/ASTMatchers/Dynamic/Parser.h
The file was modifiedclang/lib/ASTMatchers/Dynamic/Parser.cpp
The file was modifiedclang-tools-extra/unittests/clang-query/QueryParserTest.cpp
The file was modifiedclang-tools-extra/clang-query/Query.h
The file was modifiedclang/unittests/ASTMatchers/Dynamic/ParserTest.cpp
The file was modifiedclang-tools-extra/clang-query/Query.cpp
The file was modifiedclang-tools-extra/clang-query/tool/ClangQuery.cpp
The file was modifiedclang-tools-extra/clang-query/QueryParser.cpp