SuccessChanges

Summary

  1. [lldb] Fix crash in AccessDeclContextSanity when copying (details)
  2. [ARM] Update ifcvt test target triples and opcodes. NFC (details)
  3. Make the llvm-ranlib/help-message.test test pass in unusual (details)
  4. Remove unneeded extra variable realArgIdx. NFC. (details)
  5. [mlir][Linalg] NFC - Rename LinalgGeneric -> GenericLinalg (details)
  6. [mlir][Linalg] NFC - Rename ViewTraits -> StructuredOpTraits (details)
  7. [InstCombine] remove uses before deleting instructions (PR43723) (details)
  8. [llvm-ranlib] Relax D-flag.test to allow it to pass on Windows hosts (details)
  9. [OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing. (details)
  10. [mlir][Linalg] NFC - Cleanup Linalg Declarative Transformations (details)
  11. [mlir][Linalg] NFC - Make consistent use of op.emitOpError (details)
Commit 7ead00872929a994ac40fc2c99fce15968e2c5a6 by Raphael Isemann
[lldb] Fix crash in AccessDeclContextSanity when copying
FunctionTemplateDecl inside a record.
Summary: We currently don't set access specifiers for function template
declarations. This seems to be fine as long as the function template is
not declared inside any record in which case Clang asserts with the
following once we try to query it's access:
``` Assertion failed: (Access != AS_none && "Access specifier is AS_none
inside a record decl"), function AccessDeclContextSanity,
```
This patch just marks these function template declarations as public to
make Clang happy.
Reviewers: shafik, teemperor
Reviewed By: teemperor
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71909
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/main.cpp
The file was removedlldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/TestCompletionCrash2.py
The file was modifiedlldb/unittests/Symbol/TestClangASTContext.cpp
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/TestRegressionAccessFunctionTemplateInRecord.py
The file was removedlldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/main.cpp
Commit 6b067c6a91e5a4630c6ff5747c58c27ef4671242 by david.green
[ARM] Update ifcvt test target triples and opcodes. NFC
Some of the instructions in these tests were technically invalid
combinations (using ARM opcodes in Thumb mode, for example). Update the
targets and the instructions used to be more correct.
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_canFallThroughTo.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_triangleSameCvtNext.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_simple_unanalyzable.mir
The file was modifiedllvm/test/CodeGen/ARM/PR32721_ifcvt_triangle_unanalyzable.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_triangleWoCvtToNextEdge.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_diamond_unanalyzable.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_simple_bad_zero_prob_succ.mir
The file was modifiedllvm/test/CodeGen/ARM/ifcvt_forked_diamond_unanalyzable.mir
Commit 0eea9ba730b5c85b0ff9fa959d22fe5a66b5d013 by gribozavr
Make the llvm-ranlib/help-message.test test pass in unusual
configurations
The version string can be customized by CMake options, so the 'LLVM
version' substring is not guaranteed to appear (see
VersionPrinter::print in llvm/lib/Support/CommandLine.cpp).
The file was modifiedllvm/test/tools/llvm-ranlib/help-message.test
Commit 13a7a4ccbf8ba946a02ce5972e0f93a2d38b5d54 by jay.foad
Remove unneeded extra variable realArgIdx. NFC.
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
Commit afc25a43dc6cfd7dbbd875c68266f3d5ad20e9d4 by ntv
[mlir][Linalg] NFC - Rename LinalgGeneric -> GenericLinalg
Summary: This is part of an ongoing cleanup and uniformization work.
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen,
antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72078
The file was modifiedmlir/lib/Dialect/Linalg/EDSC/Builders.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
Commit 324fd5902a813af034e40bdd7519639f7a739ed6 by ntv
[mlir][Linalg] NFC - Rename ViewTraits -> StructuredOpTraits
Summary: This is part of an ongoing cleanup and uniformization work.
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen,
antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72079
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h
Commit 88fc5fdef6f7a7af4153fa9fd9c7a142e9f4342d by spatel
[InstCombine] remove uses before deleting instructions (PR43723)
This is a less ambitious alternative to previous attempts to fix this
bug with: rG56b2aee1875a rGef02831f0a4e rG56b2aee1875a
...because those all failed bot testing with use-after-free or other
problems.
The original crashing/assert problem is still showing up on various
fuzzers, so I've added a new minimal test based on another one of those
failures.
Instead of trying to manage and coordinate the logic in
isAllocSiteRemovable() with the deletion loops, just loosen the existing
code that handles casts and GEP by replacing with undef to allow other
opcodes. That means that no instructions with uses should assert on
deletion, and there are hopefully no non-obvious sanitizer bugs induced.
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was modifiedllvm/test/Transforms/InstCombine/builtin-object-size-ptr.ll
Commit a4f3847f3d5742cfab7acdc614e7ca54643e0c85 by Alexander.Richardson
[llvm-ranlib] Relax D-flag.test to allow it to pass on Windows hosts
It appears that Windows hosts always report rwxrwxrwx even with the
chmod 644 invocation. As this test only cares about the timestamps and
not the permissions, use a regex wildcard instead.
The file was modifiedllvm/test/tools/llvm-ranlib/D-flag.test
Commit 87a004d0f8c2fe5c4577d81b4306c35e77f21f9a by a.bataev
[OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing.
Summary: `getListOfPossibleValues()` formatted incorrectly when there is
only one value, emitting something like `expected 'conditional' or  in
OpenMP clause 'lastprivate'`.
Reviewers: jdoerfert, ABataev
Reviewed By: jdoerfert
Subscribers: guansong, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71884
The file was modifiedclang/test/OpenMP/parallel_sections_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/simd_lastprivate_messages.cpp
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
The file was modifiedclang/test/OpenMP/target_parallel_for_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/target_parallel_for_simd_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/sections_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/parallel_for_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/parallel_for_simd_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/target_simd_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/for_simd_lastprivate_messages.cpp
The file was modifiedclang/test/OpenMP/for_lastprivate_messages.cpp
Commit a9d9aadcdfa28aef8b276af416aaa69686ee9b69 by ntv
[mlir][Linalg] NFC - Cleanup Linalg Declarative Transformations
Summary: This is part of an ongoing cleanup and uniformization work.
This diff performs 3 types of cleanups: 1. Uniformize transformation
names. 2. Replace all pattern operands that need not be captured by `$_`
3. Replace all usage of pattern captured op by the normalized `op` name
(instead of positional parameters such as `$0`)
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen,
antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72081
The file was modifiedmlir/test/lib/DeclarativeTransforms/TestLinalgTransformPatterns.td
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransformPatterns.td
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h
Commit cd17c0698993142120fb6167bac99bfd5b1add31 by ntv
[mlir][Linalg] NFC - Make consistent use of op.emitOpError
Summary: This is part of an ongoing cleanup and uniformization work.
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen,
antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72084
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp