SuccessChanges

Summary

  1. [DWARF][test] Test all the call-site realted attrs (details)
  2. [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left. (details)
  3. [clang][NFC] Remove redundant cast (details)
  4. [X86] Add test showing failure to remove vector rotate of allsignbits (details)
  5. [clangd] Errors in TestTU cause test failures unless suppressed with (details)
  6. [NFC][ARM] Make some params members instead. (details)
  7. [doc][llvm-objcopy] Remove redundant COFF-specific sub-heading (details)
  8. [mlir] Use all_of instead of a manual loop in IntrinsicGen. NFC (details)
  9. [llvm-libc] Add memory function benchmarks (details)
  10. [SelectionDAG] rot(x, y) --> x iff ComputeNumSignBits(x) == BitWidth(x) (details)
  11. [lldb][NFC] Delete unused ClangASTImporter::CompleteDecl (details)
  12. [lldb][NFC] Fix formatting in ASTImporterDelegate::ImportImpl (details)
  13. [AArch64][SVE] Add intrinsics for FFR manipulation (details)
  14. [NFC][ARM] Add test (details)
  15. [lldb] Fix nondeterminism in TestCppBitfields (details)
  16. [lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex (details)
  17. [X86][SSE] Add shufps+shufps test for fold through commutation (details)
  18. [clangd] Show background index status using LSP 3.15 work-done progress (details)
Commit 035c106f378d6d7e54d5e98737d32f0f246316a2 by djordje.todorovic
[DWARF][test] Test all the call-site realted attrs
Adding the test for the call site encoding in DWARF5 vs GNU extensions.
Some of the attributes were not covered by any test.
Differential Revision: https://reviews.llvm.org/D73266
The file was addedllvm/test/DebugInfo/MIR/X86/call-site-gnu-vs-dwarf5-attrs.mir
Commit b3b68c0f802ebd9892f66bec0e7be96b3fb06e86 by sam.mccall
[Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.
Summary: An heuristic targetting `x && x->foo` was targed overly broadly
and caused the last T&& to be treated as a binary operator.
Reviewers: hokein
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73334
The file was modifiedclang/unittests/Format/FormatTest.cpp
The file was modifiedclang/lib/Format/TokenAnnotator.cpp
Commit 326c39b569e385b35cc117a31a3b20919c799352 by Raphael Isemann
[clang][NFC] Remove redundant cast
This cast just casts Decl* to Decl*.
The file was modifiedclang/lib/AST/ASTImporter.cpp
Commit 7e123255861a3d74306ed1b0ceebd9d1725c84f0 by llvm-dev
[X86] Add test showing failure to remove vector rotate of allsignbits
Rotating an 0/-1 value by any amount will always result in the same 0/-1
value
The file was modifiedllvm/test/CodeGen/X86/rotate_vec.ll
Commit d3260bf5b2f7bdd0c37c892b8ddecce12263b213 by sam.mccall
[clangd] Errors in TestTU cause test failures unless suppressed with
error-ok.
Summary: The historic behavior of TestTU is to gather diagnostics and
otherwise ignore them. So if a test has a syntax error, and doesn't
assert diagnostics, it silently misbehaves. This can be annoying when
developing tests, as evidenced by various tests gaining "assert no
diagnostics" where that's not really the point of the test.
This patch aims to make that default behavior. For the first error
(not warning), TestTU will call ADD_FAILURE().
This can be suppressed with a comment containing "error-ok". For now
that will suppress any errors in the TU. We can make this stricter later
-verify style.
(-verify itself is hard to reuse because of DiagnosticConsumer
interfaces...) A magic-comment was chosen over a TestTU option because
of table-driven tests.
In addition to the behavior change, this patch:
- adds //error-ok where we're knowingly testing invalid code
   (e.g. for diagnostics, crash-resilience, or token-level tests)
- fixes a bunch of errors in the checked-in tests, mostly trivial
(missing ;)
- removes a bunch of now-redundant instances of "assert no diagnostics"
Reviewers: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73199
The file was modifiedclang-tools-extra/clangd/unittests/QualityTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SymbolInfoTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestTU.h
The file was modifiedclang-tools-extra/clangd/unittests/SelectionTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/ASTTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/PrintASTTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/FindTargetTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/FileIndexTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestTU.cpp
The file was modifiedclang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/XRefsTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/CollectMacrosTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/ParsedASTTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/HoverTests.cpp
Commit ddbc077895ba52c2c93679f846d37e1c06f90f74 by sam.parker
[NFC][ARM] Make some params members instead.
Add MachineLoopInfo and ReachingDefAnalysis as members of
LowOverheadLoop instead of passing them several times to different
methods.
The file was modifiedllvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
Commit 0298a8751152a209fe26052ca126b6b36ced0612 by james.henderson
[doc][llvm-objcopy] Remove redundant COFF-specific sub-heading
The sub-heading used to contain the --only-keep-debug switch as that
switch wasn't implemented for ELF at one point. Since the switch is now
in the generic options section, and there are no other options in this
sub-heading, it is pointless and can be deleted.
The file was modifiedllvm/docs/CommandGuide/llvm-objcopy.rst
Commit b9013351936d51424badfecbb3cd1e92c1209bb3 by zinenko
[mlir] Use all_of instead of a manual loop in IntrinsicGen. NFC
This was suggested in post-commit review of D72926.
The file was modifiedmlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
Commit aba80d0734d1bc876395ad048462534618d25ca8 by gchatelet
[llvm-libc] Add memory function benchmarks
Summary: This patch adds a benchmarking infrastructure for llvm-libc
memory functions.
In a nutshell, the code can benchmark small and large buffers for the
memcpy, memset and memcmp functions. It also produces graphs of size vs
latency by running targets of the form
`render-libc-{memcpy|memset|memcmp}-benchmark-{small|big}`.
The configurations are provided as JSON files and the benchmark also
produces a JSON file. This file is then parsed and rendered as a PNG
file via the `render.py` script (make sure to run `pip3 install
matplotlib scipy numpy`). The script can take several JSON files as
input and will superimpose the curves if they are from the same host.
TODO:
- The code benchmarks whatever is available on the host but should be
configured to benchmark the -to be added- llvm-libc memory functions.
- Add a README file with instructions and rationale.
- Produce scores to track the performance of the functions over time to
allow for regression detection.
Reviewers: sivachandra, ckennelly
Subscribers: mgorny, MaskRay, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D72516
The file was addedlibc/utils/benchmarks/JSON.h
The file was addedlibc/utils/benchmarks/LibcBenchmarkTest.cpp
The file was addedlibc/utils/benchmarks/render.py3
The file was addedlibc/utils/benchmarks/Memset.cpp
The file was addedlibc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
The file was modifiedlibc/utils/CMakeLists.txt
The file was addedlibc/utils/benchmarks/LibcMemoryBenchmarkMain.h
The file was addedlibc/utils/benchmarks/RATIONALE.md
The file was addedlibc/utils/benchmarks/LibcBenchmark.h
The file was addedlibc/utils/benchmarks/configuration_small.json
The file was modifiedlibc/utils/HdrGen/CMakeLists.txt
The file was addedlibc/utils/benchmarks/README.md
The file was addedlibc/utils/benchmarks/Memcpy.cpp
The file was addedlibc/utils/benchmarks/LibcBenchmark.cpp
The file was addedlibc/utils/benchmarks/LibcMemoryBenchmarkMain.cpp
The file was addedlibc/utils/benchmarks/CMakeLists.txt
The file was addedlibc/utils/benchmarks/JSON.cpp
The file was addedlibc/utils/benchmarks/LibcMemoryBenchmark.cpp
The file was addedlibc/utils/benchmarks/configuration_big.json
The file was addedlibc/utils/benchmarks/JSONTest.cpp
The file was addedlibc/utils/benchmarks/Memcmp.cpp
The file was addedlibc/utils/benchmarks/LibcMemoryBenchmark.h
Commit 0b45c2264a430b9f40e3cfaf0704050c2101b830 by llvm-dev
[SelectionDAG] rot(x, y) --> x iff ComputeNumSignBits(x) == BitWidth(x)
Rotating an 0/-1 value by any amount will always result in the same 0/-1
value
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modifiedllvm/test/CodeGen/X86/rotate_vec.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
The file was modifiedllvm/test/CodeGen/X86/sdiv_fix.ll
Commit 36f12d2638f887c417bd1167a54e0e6f1bf3daca by Raphael Isemann
[lldb][NFC] Delete unused ClangASTImporter::CompleteDecl
The file was modifiedlldb/source/Symbol/ClangASTImporter.cpp
The file was modifiedlldb/include/lldb/Symbol/ClangASTImporter.h
Commit c0738d2480b93b1c3b354a2be16ea5f6e545c5ef by Raphael Isemann
[lldb][NFC] Fix formatting in ASTImporterDelegate::ImportImpl
The file was modifiedlldb/source/Symbol/ClangASTImporter.cpp
Commit 4c4861b577cb757b72a56b06cec0577fd5ab6eab by kerry.mclaughlin
[AArch64][SVE] Add intrinsics for FFR manipulation
Summary: Implements the following intrinsics:
- llvm.aarch64.sve.setffr
- llvm.aarch64.sve.rdffr
- llvm.aarch64.sve.rdffr.z
- llvm.aarch64.sve.wrffr
Reviewers: sdesmalen, efriedma, dancgr, rengolin
Reviewed By: efriedma
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl,
cameron.mcinally, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73097
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td
The file was addedllvm/test/CodeGen/AArch64/sve-intrinsics-ffr-manipulation.ll
Commit 0ae13766ffd854ec0e88f2b9dc7461bdd7b60479 by sam.parker
[NFC][ARM] Add test
The file was addedllvm/test/CodeGen/Thumb2/LowOverheadLoops/multiple-do-loops.mir
Commit 77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20 by pavel
[lldb] Fix nondeterminism in TestCppBitfields
The test was printing a char[3] variable without a terminating nul. The
memory after that variable (an unnamed bitfield) was not initialized. If
the memory happened to be nonzero, the summary provider for the variable
would run off into the next field.
This is probably not the right behavior (it should stop at the end of
the array), but this is not the purpose of this test. I have filed
pr44649 for this bug, and fixed the test to not depend on this behavior.
The file was modifiedlldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py
The file was modifiedlldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp
Commit d4b092b34125d6c571d43a185a1c774244b76957 by pavel
[lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex
This was needed when asking a compile unit for its dwo component
triggered a infinite recursion if the dwo unit has not been already
parsed.
This has since been fixed.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
Commit e37cdbeeabfb17821b9ff5d2f42e9f440882dab8 by llvm-dev
[X86][SSE] Add shufps+shufps test for fold through commutation
As mentioned on D73023, lowerShuffleWithSHUFPS should be able to commute
the shufps inputs to fold the second arg as it will then permute the
shufps result anyway.
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-128-v4.ll
Commit 7d20e80225b3e4f3f5a8c57929061bef55f3d855 by sam.mccall
[clangd] Show background index status using LSP 3.15 work-done progress
notifications
Summary: It simply shows the completed/total items on the background
queue, e.g.
indexing: 233/1000 The denominator is reset to zero every time the queue
goes idle.
The protocol is fairly complicated here (requires creating a remote
"progress" resource before sending updates). We implement the full
protocol, but I've added an extension allowing it to be skipped to
reduce the burden on clients - in particular the lit test takes this
shortcut.
The addition of background index progress to DiagnosticConsumer seems
ridiculous at first glance, but I believe that interface is trending in
the direction of
"ClangdServer callbacks" anyway. It's due for a rename, but otherwise
actually fits.
Reviewers: kadircet, usaxena95
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, jfb,
cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73218
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.h
The file was modifiedclang-tools-extra/clangd/index/Background.h
The file was modifiedclang-tools-extra/clangd/index/BackgroundQueue.cpp
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
The file was modifiedclang-tools-extra/clangd/Protocol.cpp
The file was modifiedllvm/include/llvm/Support/JSON.h
The file was modifiedclang-tools-extra/clangd/index/Background.cpp
The file was modifiedclang-tools-extra/clangd/Protocol.h
The file was modifiedclang-tools-extra/clangd/ClangdServer.h
The file was modifiedclang-tools-extra/clangd/ClangdServer.cpp
The file was modifiedclang-tools-extra/clangd/test/Inputs/background-index/definition.jsonrpc
The file was modifiedclang-tools-extra/clangd/test/background-index.test
The file was modifiedclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp