SuccessChanges

Summary

  1. [llvm-readelf] - Improve dumping of objects without a section header (details)
  2. [Sema] Try 2: Attempt to perform call-size-specific (details)
  3. [llvm-exegesis][NFC] Simplify code. (details)
  4. [Alignment][NFC] Deprecate Align::None() (details)
  5. [X86][SSE] lowerShuffleWithSHUFPS - commute '2*V1+2*V2 elements' mask if (details)
  6. [X86][SSE] Add another shufps+shufps test for fold through commutation (details)
  7. [clangd][Hover] Change arrow in return type back to → (details)
  8. [lldb][NFC] Cleanup some if conditions in ASTImporterDelegate::Imported (details)
Commit 1af6209d64dc503800797b647f9c281cc2c4ec87 by grimar
[llvm-readelf] - Improve dumping of objects without a section header
string table.
We have a test/Object/no-section-header-string-table.test which checks
what happens when an object does not have a section header string table.
It does not check the full output though. Currently our output is
different from GNU readelf, because the latter prints
"<no-strings>" instead of a section name, while we print nothing.
This patch fixes this, adds a proper test case and removes the one from
test/Object, as it is not a right folder for llvm-readelf tests.
Differential revision: https://reviews.llvm.org/D73193
The file was addedllvm/test/tools/llvm-readobj/ELF/sections-no-section-header-string-table.test
The file was removedllvm/test/Object/no-section-header-string-table.test
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
The file was removedllvm/test/Object/Inputs/no-section-header-string-table.elf-x86-64
Commit ba545c814bc19c3b1ec9ce88a7f13575e0e4ce1d by lebedev.ri
[Sema] Try 2: Attempt to perform call-size-specific
`__attribute__((alloc_align(param_idx)))` validation
Summary:
`alloc_align` attribute takes parameter number, not the alignment
itself, so given **just** the attribute/function declaration we can't do
any sanity checking for said alignment.
However, at call site, given the actual `Expr` that is passed into that
parameter, we //might// be able to evaluate said `Expr` as Integer
Constant Expression, and perform the sanity checks. But since there is
no requirement for that argument to be an immediate, we may fail, and
that's okay.
However if we did evaluate, we should enforce the same constraints as
with
`__builtin_assume_aligned()`/`__attribute__((assume_aligned(imm)))`:
said alignment is a power of two, and is not greater than our magic
threshold
This was initially committed in
c2a9061ac5166e48fe85ea2b6dbce9457c964958 but reverted in
00756b182398b92abe16559287467079087aa631 because of suspicious bot
failures.
Reviewers: erichkeane, aaron.ballman, hfinkel, rsmith, jdoerfert
Reviewed By: erichkeane
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72996
The file was modifiedclang/test/SemaCXX/alloc-align-attr.cpp
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/test/Sema/alloc-align-attr.c
Commit 2ee218f3653fcfd135fc5087a698424f90a9a499 by courbet
[llvm-exegesis][NFC] Simplify code.
Summary: What we're redoing already exists in the X86 backend, it's
called
`X86II::getOperandBias`.
Reviewers: gchatelet
Subscribers: tschuett, mstojanovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73340
The file was modifiedllvm/tools/llvm-exegesis/lib/X86/Target.cpp
Commit 805c157e8aeee24adec897bed42662733eb0d710 by gchatelet
[Alignment][NFC] Deprecate Align::None()
Summary: This is a follow up on
https://reviews.llvm.org/D71473#inline-647262. There's a caveat here
that `Align(1)` relies on the compiler understanding of `Log2_64`
implementation to produce good code. One could use `Align()` as a
replacement but I believe it is less clear that the alignment is one in
that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle,
hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits,
llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
The file was modifiedllvm/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modifiedllvm/lib/IR/IRBuilder.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modifiedllvm/lib/CodeGen/MachineBasicBlock.cpp
The file was modifiedllvm/lib/Target/AMDGPU/R600FrameLowering.h
The file was modifiedllvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonBranchRelaxation.cpp
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64CompressJumpTables.cpp
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
The file was modifiedllvm/lib/Target/AVR/AVRFrameLowering.cpp
The file was modifiedllvm/lib/IR/AutoUpgrade.cpp
The file was modifiedllvm/lib/Target/ARM/ARMConstantIslandPass.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonFixupHwLoops.cpp
The file was modifiedllvm/include/llvm/CodeGen/AsmPrinter.h
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedllvm/lib/Analysis/Loads.cpp
The file was modifiedllvm/lib/CodeGen/MachineFrameInfo.cpp
The file was modifiedllvm/lib/Target/ARM/ARMBasicBlockInfo.cpp
The file was modifiedllvm/lib/Transforms/Utils/InlineFunction.cpp
The file was modifiedllvm/lib/Target/AMDGPU/SIFrameLowering.h
The file was modifiedllvm/lib/Target/Hexagon/HexagonFrameLowering.h
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
The file was modifiedllvm/lib/CodeGen/GlobalISel/CallLowering.cpp
The file was modifiedllvm/lib/Transforms/Instrumentation/Instrumentation.cpp
The file was modifiedllvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
The file was modifiedllvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
The file was modifiedpolly/lib/CodeGen/LoopGeneratorsKMP.cpp
The file was modifiedllvm/include/llvm/Support/Alignment.h
The file was modifiedllvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCBranchSelector.cpp
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUFrameLowering.h
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/lib/CodeGen/MIRPrinter.cpp
The file was modifiedllvm/lib/CodeGen/MachineOperand.cpp
The file was modifiedllvm/lib/IR/DataLayout.cpp
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
The file was modifiedllvm/unittests/Support/AlignmentTest.cpp
The file was modifiedclang/lib/CodeGen/CGObjCMac.cpp
The file was modifiedllvm/lib/Target/Mips/MipsConstantIslandPass.cpp
The file was modifiedllvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/Speculation.cpp
The file was modifiedllvm/lib/Target/Mips/MipsCallLowering.cpp
The file was modifiedllvm/lib/Target/ARM/ARMBasicBlockInfo.h
The file was modifiedllvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
Commit 30fcd29fe47968427e3c6b26709282331c1aed77 by llvm-dev
[X86][SSE] lowerShuffleWithSHUFPS - commute '2*V1+2*V2 elements' mask if
it allows a loaded fold
As mentioned on D73023.
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-128-v4.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 5e62e162cd03b55816ebc8be879ab666001440f6 by llvm-dev
[X86][SSE] Add another shufps+shufps test for fold through commutation
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-128-v4.ll
Commit 1b996faa1575bda6b99e778aaabe14834c10d3ff by kadircet
[clangd][Hover] Change arrow in return type back to →
Summary: Currently 🡺 is used in hover response to represent return
types, but it is not widely available. Changing this back to original to
support more clients.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73336
The file was modifiedclang-tools-extra/clangd/test/hover.test
The file was modifiedclang-tools-extra/clangd/Hover.cpp
The file was modifiedclang-tools-extra/clangd/unittests/HoverTests.cpp
Commit 06ae3748db8a23568f2f238a9534ea9052725ea3 by Raphael Isemann
[lldb][NFC] Cleanup some if conditions in ASTImporterDelegate::Imported
The file was modifiedlldb/source/Symbol/ClangASTImporter.cpp