FailedChanges

Summary

  1. Correct documented spelling of ffinite-math to ffinite-math-only (details)
  2. [clang][SourceManager] cache Macro Expansions (details)
  3. [SVE] Code generation for fixed length vector adds. (details)
  4. [NFC] Builtins: list 'R' for restrict (details)
  5. [VPlan] Add & use VPValue for VPWidenGEPRecipe operands (NFC). (details)
  6. More corrections to documented spelling of ffinite-math to ffinite-math-only (details)
  7. Revert "[sve][acle] Add reinterpret intrinsics for brain float." (details)
  8. [InstCombine] Drop debug loc in TryToSinkInstruction (details)
  9. Extend or truncate __ptr32/__ptr64 pointers when dereferenced. (details)
  10. [sve][acle] Recommit https://reviews.llvm.org/D82501 (details)
  11. [NFC] Bump ObjCOrBuiltinIDBits to 15 (details)
  12. [AMDGPU] Define DWARF encoding for condition code registers (details)
  13. GlobalISel: Don't fail translate on weak cmpxchg (details)
  14. [compiler-rt] Fix mismatched #if/#endif comments (details)
  15. [debugify] Demote an error about empty locations to a warning (details)
  16. [MemorySSA] Update comment in PassBuilder (details)
  17. [NewPM][BasicAA] basicaa -> basic-aa in Analysis/BasicAA (details)
  18. [NewPM][BasicAA] basicaa -> basic-aa in Transforms/SLPVectorizer (details)
  19. Revert "[InstCombine] Drop debug loc in TryToSinkInstruction" (details)
  20. AMDGPU/GlobalISel: Fix some legalization of < dword vector stores (details)
  21. LLParser: Accept align(N) as new syntax for parameter attribute (details)
Commit 7cc5307c73caa72f22edd4208b175e3c36eec46e by melanie.blower
Correct documented spelling of ffinite-math to ffinite-math-only

This is to correct bugs.llvm.org/show_bug.cgi?id=46444
ffinite-math-only is a gcc option.  That is the correct spelling.
File modified is clang/docs/UsersManual.rst
The file was modifiedclang/docs/UsersManual.rst
Commit dffc1420451f674731cb36799c8ae084104ff0b5 by ndesaulniers
[clang][SourceManager] cache Macro Expansions

A seemingly innocuous Linux kernel change [0] seemingly blew up our
compile times by over 3x, as reported by @nathanchance in [1].

The code in question uses a doubly nested macro containing GNU C
statement expressions that are then passed to typeof(), which is then
used in a very important macro for atomic variable access throughout
most of the kernel. The inner most macro, is passed a GNU C statement
expression.  In this case, we have macro arguments that are GNU C
statement expressions, which can contain a significant number of tokens.
The upstream kernel patch caused significant build time regressions for
both Clang and GCC. Since then, some of the nesting has been removed via
@melver, which helps gain back most of the lost compilation time. [2]

Profiles collected [3] from compilations of the slowest TU for us in the
kernel show:
* 51.4% time spent in clang::TokenLexer::updateLocForMacroArgTokens
* 48.7% time spent in clang::SourceManager::getFileIDLocal
* 35.5% time spent in clang::SourceManager::isOffsetInFileID
(mostly calls from the former through to the latter).

So it seems we have a pathological case for which properly tracking the
SourceLocation of macro arguments is significantly harming build
performance. This stands out in referenced flame graph.

In fact, this case was identified previously as being problematic in
commit 3339c568c4 ("[Lex] Speed up updateConsecutiveMacroArgTokens (NFC)")

Looking at the above call chain, there's 3 things we can do to speed up
this case.

1. TokenLexer::updateConsecutiveMacroArgTokens() calls
   SourceManager::isWrittenInSameFile() which calls
   SourceManager::getFileID(), which is both very hot and very expensive
   to call. SourceManger has a one entry cache, member LastFileIDLookup.
   If that isn't the FileID for a give source location offset, we fall
   back to a linear probe, and then to a binary search for the FileID.
   These fallbacks update the one entry cache, but noticeably they do
   not for the case of macro expansions!

   For the slowest TU to compile in the Linux kernel, it seems that we
   miss about 78.67% of the 68 million queries we make to getFileIDLocal
   that we could have had cache hits for, had we saved the macro
   expansion source location's FileID in the one entry cache. [4]

   I tried adding a separate cache item for macro expansions, and to
   check that before the linear then binary search fallbacks, but did
   not find it faster than simply allowing macro expansions into the one
   item cache.  This alone nets us back a lot of the performance loss.

   That said, this is a modification of caching logic, which is playing
   with a double edged sword.  While it significantly improves the
   pathological case, its hard to say that there's not an equal but
   opposite pathological case that isn't regressed by this change.
   Though non-pathological cases of builds of the Linux kernel before
   [0] are only slightly improved (<1%) and builds of LLVM itself don't
   change due to this patch.

   Should future travelers find this change to significantly harm their
   build times, I encourage them to feel empowered to revert this
   change.

2. SourceManager::getFileIDLocal has a FIXME hinting that the call to
   SourceManager::isOffsetInFileID could be made much faster since
   isOffsetInFileID is generic in the sense that it tries to handle the
   more generic case of "local" (as opposed to "loaded") files, though
   the caller has already determined the file to be local. This patch
   implements a new method that specialized for use when the caller
   already knows the file is local, then use that in
   TokenLexer::updateLocForMacroArgTokens.  This should be less
   controversial than 1, and is likely an across the board win. It's
   much less significant for the pathological case, but still a
   measurable win once we have fallen to the final case of binary
   search.  D82497

3. A bunch of methods in SourceManager take a default argument.
   SourceManager::getLocalSLocEntry doesn't do anything with this
   argument, yet many callers of getLocalSLocEntry setup, pass, then
   check this argument. This is wasted work.  D82498

With this patch applied, the above profile [5] for the same pathological
input looks like:
* 25.1% time spent in clang::TokenLexer::updateLocForMacroArgTokens
* 17.2% time spent in clang::SourceManager::getFileIDLocal
and clang::SourceManager::isOffsetInFileID is no longer called, and thus
falls out of the profile.

There may be further improvements to the general problem of "what
interval contains one number out of millions" than the current use of a
one item cache, followed by linear probing, followed by binary
searching. We might even be able to do something smarter in
TokenLexer::updateLocForMacroArgTokens.

[0] https://github.com/ClangBuiltLinux/linux/commit/cdd28ad2d8110099e43527e96d059c5639809680
[1] https://github.com/ClangBuiltLinux/linux/issues/1032
[2] https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/kcsan&id=a5dead405f6be1fb80555bdcb77c406bf133fdc8
[3] https://github.com/ClangBuiltLinux/linux/issues/1032#issuecomment-633712667
[4] https://github.com/ClangBuiltLinux/linux/issues/1032#issuecomment-633741923
[5] https://github.com/ClangBuiltLinux/linux/issues/1032#issuecomment-634932736

Reviewed By: kadircet

Differential Revision: https://reviews.llvm.org/D80681
The file was modifiedclang/lib/Basic/SourceManager.cpp
Commit 3a98d5d7e7f5c651f1f22bf8dc552d5161cb999e by paul.walker
[SVE] Code generation for fixed length vector adds.

Summary:
Teach LowerToPredicatedOp to lower fixed length vector operations.

Add AArch64ISD nodes and isel patterns for predicated integer
and floating point adds.

Together this enables SVE code generation for fixed length vector adds.

Reviewers: rengolin, efriedma

Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82483
The file was addedllvm/test/CodeGen/AArch64/sve-fixed-length-fp-arith.ll
The file was addedllvm/test/CodeGen/AArch64/sve-fixed-length-int-arith.ll
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.h
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
Commit 13fdcd37b325f62ff2513c59807de9ad0a9d2a51 by JF Bastien
[NFC] Builtins: list 'R' for restrict

It was added to the list of builtin modifiers in r148573 back in 2012-01-20, but the comment wasn't updated.
The file was modifiedclang/include/clang/Basic/Builtins.def
Commit c0cdba727ab29fb8ed2758a93a61d9658036ffe7 by flo
[VPlan] Add & use VPValue for VPWidenGEPRecipe operands (NFC).

This patch adds VPValue version of the GEP's operands to
VPWidenGEPRecipe and uses them during code-generation.

Reviewers: Ayal, gilr, rengolin

Reviewed By: gilr

Differential Revision: https://reviews.llvm.org/D80220
The file was modifiedllvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
Commit 467ba4c92f5bfafd88e154c1657d6ac11dfb34df by melanie.blower
More corrections to documented spelling of ffinite-math to ffinite-math-only
The file was modifiedclang/docs/UsersManual.rst
Commit ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c by francesco.petrogalli
Revert "[sve][acle] Add reinterpret intrinsics for brain float."

This reverts commit a15722c5ce4759c12960fe434ee6bd8aac70bb16.

The commmit has to be reverted because I accidentally submit
https://reviews.llvm.org/D82501 without the C tests that were added in
an early version of the patch.
The file was modifiedllvm/test/CodeGen/AArch64/sve-bitcast.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedclang/utils/TableGen/SveEmitter.cpp
Commit 903cf140d0118cf0d3f0f6f8967c6a20d9c5be6b by Vedant Kumar
[InstCombine] Drop debug loc in TryToSinkInstruction

Summary:
The advice in HowToUpdateDebugInfo.rst is to "... preserve the debug
location of an instruction if the instruction either remains in its
basic block, or if its basic block is folded into a predecessor that
branches unconditionally".

TryToSinkInstruction doesn't seem to satisfy the criteria as it's
sinking an instruction to some successor block. Preserving the debug loc
can make single-stepping appear to go backwards, or make a breakpoint
hit on that location happen "too late" (since single-stepping from that
breakpoint can cause the function to return unexpectedly).

So, drop the debug location.

Reviewers: aprantl, davide

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82487
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was addedllvm/test/Transforms/InstCombine/sink_to_unreachable_dbg.ll
Commit 8b59c26bf347be5d96487c89849c0c1108bb3c42 by akhuang
Extend or truncate __ptr32/__ptr64 pointers when dereferenced.

Summary:
A while ago I implemented the functionality to lower Microsoft __ptr32
and __ptr64 pointers, which are stored as 32-bit and 64-bit pointer
and are extended/truncated to the appropriate pointer size when
dereferenced.
This patch adds an addrspacecast to cast from the __ptr32/__ptr64
pointer to a default address space when dereferencing.

Bug: https://bugs.llvm.org/show_bug.cgi?id=42359

Reviewers: hans, arsenm, RKSimon

Subscribers: wdng, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81517
The file was modifiedllvm/test/CodeGen/X86/mixed-ptr-sizes.ll
The file was modifiedllvm/test/CodeGen/X86/mixed-ptr-sizes-i686.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit ddbdff3accb667860d4cbd436746ca28ea343b25 by francesco.petrogalli
[sve][acle] Recommit https://reviews.llvm.org/D82501

The original patch was reverted in
https://github.com/llvm/llvm-project/commit/ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c
as it was missing the C tests that got accidentally missing.

This patch is a NFC of https://reviews.llvm.org/D82501, together with
the SVE ACLE tests for the C intrinsics of svreinterpret for brain
float types.
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedclang/utils/TableGen/SveEmitter.cpp
The file was modifiedllvm/test/CodeGen/AArch64/sve-bitcast.ll
The file was addedclang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c
Commit b10bd6dfc62161671892b2dd3be5152754d14995 by JF Bastien
[NFC] Bump ObjCOrBuiltinIDBits to 15

We're now hitting this because we're at the limit for number of builtins:
  clang/lib/Basic/IdentifierTable.cpp:39:1: error: static_assert failed due to requirement '2 * LargestBuiltinID < (2 << (ObjCOrBuiltinIDBits - 1))' "Insufficient ObjCOrBuiltinID Bits"
  static_assert(2 * LargestBuiltinID < (2 << (ObjCOrBuiltinIDBits - 1)),
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Bump it to 15 so whoever adds a builtin next (as I am, or as anyone else might) doesn't merge conflict over each other.
The file was modifiedclang/include/clang/Basic/IdentifierTable.h
Commit 990f8702c911e444c23a5365ac22d359fc96f7b5 by Tony.Tye
[AMDGPU] Define DWARF encoding for condition code registers

Summary:
- Define DWARF register numbers for vector and scalar condition codes.
- Document intended purpose of reserved DWARF register numbers.

Reviewers: yaxunl, kzhuravl, arsenm, rampitec, b-sumner

Subscribers: jvesely, wdng, nhaehnle, aprantl, dstuttard, tpr, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82519
The file was modifiedllvm/docs/AMDGPUUsage.rst
Commit c2e403c19d40524f868d7803b104224ca4978597 by Matthew.Arsenault
GlobalISel: Don't fail translate on weak cmpxchg

The translation of cmpxchg added by
9481399c0fd2c198c81b92636c0dcff7d4c41df2 specifically skipped weak
cmpxchg due to not understanding the meaning. Weak cmpxchg was added
in 420a216817def01816186910a2e35885c9201951. As explained in the
commit message, the weak mode is implicit in how
ATOMIC_CMP_SWAP_WITH_SUCCESS is lowered. If it's expanded to a regular
ATOMIC_CMP_SWAP, it's replaced with a strong cmpxchg.

This handling seems weird to me, but this was already following the
DAG behavior. I would expect the strong IR instruction to not have the
boolean output. Failing that, I might expect the IRTranslator to emit
ATOMIC_CMP_SWAP and a constant for the boolean.
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
The file was modifiedllvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
Commit 898b01602ba5d53f14306962423fb02615030cd1 by Steven Wu
[compiler-rt] Fix mismatched #if/#endif comments

Fix a mismatched #if/#endif comments from my previous commit.
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp
Commit c1cad151b03c2b05983d569ba3bc05fd74d4dfdc by Vedant Kumar
[debugify] Demote an error about empty locations to a warning

In https://reviews.llvm.org/D81198, we outlined a number of scenarios
where dropping debug locations is appropriate. Stop issuing an error
when this happens.
The file was modifiedllvm/test/DebugInfo/debugify-report-missing-locs-only.ll
The file was modifiedllvm/test/DebugInfo/debugify.ll
The file was modifiedllvm/lib/Transforms/Utils/Debugify.cpp
Commit 2b8a09e1ed5c78cf5ae75fdcf55e1b5349a2d47c by Yuanfang Chen
[MemorySSA] Update comment in PassBuilder

Is teaching the LoopFullUnrollPass to preserve MemorySSA very hard or
just impossible?

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D82618
The file was modifiedllvm/lib/Passes/PassBuilder.cpp
Commit feeed16a5f8127dde6ee01b023f1dbb20d203857 by aeubanks
[NewPM][BasicAA] basicaa -> basic-aa in Analysis/BasicAA

Following https://reviews.llvm.org/D82607.

Reviewed By: ychen

Differential Revision: https://reviews.llvm.org/D82683
The file was modifiedllvm/test/Analysis/BasicAA/2003-09-19-LocalArgument.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-06-01-AliasCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/cs-cs.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-08-01-NoAliasAndGEP.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-04-25-GEPCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/aligned-overread.ll
The file was modifiedllvm/test/Analysis/BasicAA/intrinsics.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-08-01-NoAliasAndCalls.ll
The file was modifiedllvm/test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll
The file was modifiedllvm/test/Analysis/BasicAA/q.bad.ll
The file was modifiedllvm/test/Analysis/BasicAA/dereferenceable.ll
The file was modifiedllvm/test/Analysis/BasicAA/global-size.ll
The file was modifiedllvm/test/Analysis/BasicAA/pr31761.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-02-26-AccessSizeTest.ll
The file was modifiedllvm/test/Analysis/BasicAA/2014-03-18-Maxlookup-reached.ll
The file was modifiedllvm/test/Analysis/BasicAA/fallback-mayalias.ll
The file was modifiedllvm/test/Analysis/BasicAA/invariant_group.ll
The file was modifiedllvm/test/Analysis/BasicAA/2008-11-23-NoaliasRet.ll
The file was modifiedllvm/test/Analysis/BasicAA/noalias-wraparound-bug.ll
The file was modifiedllvm/test/Analysis/BasicAA/assume-index-positive.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-05-21-GEP-Problem.ll
The file was modifiedllvm/test/Analysis/BasicAA/2004-07-28-MustAliasbug.ll
The file was modifiedllvm/test/Analysis/BasicAA/2010-09-15-GEP-SignedArithmetic.ll
The file was modifiedllvm/test/Analysis/BasicAA/phi-loop.ll
The file was modifiedllvm/test/Analysis/BasicAA/pure-const-dce.ll
The file was modifiedllvm/test/Analysis/BasicAA/gep-and-alias-64.ll
The file was modifiedllvm/test/Analysis/BasicAA/2008-06-02-GEPTailCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/tail-byval.ll
The file was modifiedllvm/test/Analysis/BasicAA/2009-10-13-AtomicModRef.ll
The file was modifiedllvm/test/Analysis/BasicAA/dag.ll
The file was modifiedllvm/test/Analysis/BasicAA/empty.ll
The file was modifiedllvm/test/Analysis/BasicAA/noalias-bugs.ll
The file was modifiedllvm/test/Analysis/BasicAA/struct-geps.ll
The file was modifiedllvm/test/Analysis/BasicAA/2006-11-03-BasicAAVectorCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-12-08-OutOfBoundsCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/memset_pattern.ll
The file was modifiedllvm/test/Analysis/BasicAA/phi-aa.ll
The file was modifiedllvm/test/Analysis/BasicAA/negoffset.ll
The file was modifiedllvm/test/Analysis/BasicAA/gep-and-alias.ll
The file was modifiedllvm/test/Analysis/BasicAA/vscale.ll
The file was modifiedllvm/test/Analysis/BasicAA/noalias-geps.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-08-05-GetOverloadedModRef.ll
The file was modifiedllvm/test/Analysis/BasicAA/2009-10-13-GEP-BaseNoAlias.ll
The file was modifiedllvm/test/Analysis/BasicAA/2006-03-03-BadArraySubscript.ll
The file was modifiedllvm/test/Analysis/BasicAA/bug.23626.ll
The file was modifiedllvm/test/Analysis/BasicAA/gep-alias.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-04-22-GEPProblem.ll
The file was modifiedllvm/test/Analysis/BasicAA/2009-03-04-GEPNoalias.ll
The file was modifiedllvm/test/Analysis/BasicAA/modref.ll
The file was modifiedllvm/test/Analysis/BasicAA/nocapture.ll
The file was modifiedllvm/test/Analysis/BasicAA/zext.ll
The file was modifiedllvm/test/Analysis/BasicAA/call-attrs.ll
The file was modifiedllvm/test/Analysis/BasicAA/must-and-partial.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-03-04-GEPCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-10-24-ArgumentsGlobals.ll
The file was modifiedllvm/test/Analysis/BasicAA/gcsetest.ll
The file was modifiedllvm/test/Analysis/BasicAA/phi-speculation.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-07-03-BasicAACrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/128-bit-ptr.ll
The file was modifiedllvm/test/Analysis/BasicAA/byval.ll
The file was modifiedllvm/test/Analysis/BasicAA/tailcall-modref.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-11-05-SizeCrash.ll
The file was modifiedllvm/test/Analysis/BasicAA/phi-spec-order.ll
The file was modifiedllvm/test/Analysis/BasicAA/unreachable-block.ll
The file was modifiedllvm/test/Analysis/BasicAA/constant-over-index.ll
The file was modifiedllvm/test/Analysis/BasicAA/2007-01-13-BasePointerBadNoAlias.ll
The file was modifiedllvm/test/Analysis/BasicAA/cs-cs-arm.ll
The file was modifiedllvm/test/Analysis/BasicAA/intrinsics-arm.ll
The file was modifiedllvm/test/Analysis/BasicAA/invariant_load.ll
The file was modifiedllvm/test/Analysis/BasicAA/sequential-gep.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-12-11-ConstExprGEP.ll
The file was modifiedllvm/test/Analysis/BasicAA/featuretest.ll
The file was modifiedllvm/test/Analysis/BasicAA/full-store-partial-alias.ll
The file was modifiedllvm/test/Analysis/BasicAA/store-promote.ll
The file was modifiedllvm/test/Analysis/BasicAA/2003-11-04-SimpleCases.ll
The file was modifiedllvm/test/Analysis/BasicAA/phi-and-select.ll
The file was modifiedllvm/test/Analysis/BasicAA/ptrmask.ll
The file was modifiedllvm/test/Analysis/BasicAA/cas.ll
The file was modifiedllvm/test/Analysis/BasicAA/bug.23540.ll
The file was modifiedllvm/test/Analysis/BasicAA/args-rets-allocas-loads.ll
The file was modifiedllvm/test/Analysis/BasicAA/guards.ll
The file was modifiedllvm/test/Analysis/BasicAA/underlying-value.ll
The file was modifiedllvm/test/Analysis/BasicAA/assume.ll
The file was modifiedllvm/test/Analysis/BasicAA/no-escape-call.ll
The file was modifiedllvm/test/Analysis/BasicAA/noalias-param.ll
The file was modifiedllvm/test/Analysis/BasicAA/returned.ll
Commit 691c086d155554fd3d9ee8d89fa4fc3bd6f8ed4b by aeubanks
[NewPM][BasicAA] basicaa -> basic-aa in Transforms/SLPVectorizer

Following https://reviews.llvm.org/D82607.

Reviewed By: ychen

Differential Revision: https://reviews.llvm.org/D82681
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_dequeue.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cross_block_slp.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_bullet3.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-shl.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/schedule_budget.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/call.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/ARM/memory.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_netbsd_decompress.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cast.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/extract_in_tree_user.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_mandeltext.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fptosi.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/simple-loop.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/loopinvariant.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_binaryop.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AArch64/nontemporal.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/diamond.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-mul-umulo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/saxpy.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-fix.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fcopysign.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-fp.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/bswap.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/sqrt.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-ssat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/multi_block.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-saddo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_lencod.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/hadd.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/phi_overalignedtype.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_vectorizeTree.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/implicitfloat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/barriercall.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/tiny-tree.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AArch64/load-store-q.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AArch64/matmul.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_flop7.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-usat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/pr16628.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-mul.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/addsub.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/alternate-fp.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/rgb_phi.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/reorder_phi.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-mul-smulo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/zext.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/bad_types.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/return.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/long_chains.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/hoist.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fma.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_sim4b1.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-usat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/phi.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cycle_dup.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/in-tree-user.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/odd_store.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/reduction2.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/extractcost.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/phi3.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/align.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/compare-reduce.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cse.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-uaddo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/consecutive-access.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fptoui.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fminnum.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_cmpop.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/reduction.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/continue_vectorizing.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-ssat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/gep.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/metadata.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/NVPTX/v2f16.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-lshr.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/ordering.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fabs.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/sitofp.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/XCore/no-vector-registers.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/multi_user.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/operandorder.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/ctpop.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/pr19657.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/alternate-int.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cmp_sel.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/external_user.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/pr23510.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-usubo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/debug_info.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_smallpt.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/ctlz.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/unreachable.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_bullet.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fround.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/intrinsic.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/sext.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-ashr.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/flag.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/fmaxnum.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/AArch64/sdiv-pow2.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/powof2div.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/bitreverse.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/scheduling.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/simplebb.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/extract.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cttz.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/hsub.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/ARM/sroa.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-ssubo.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/insertvalue.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/alternate-cast.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_gep.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_7zip.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_scheduling.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/uitofp.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/alternate-calls.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/propagate_ir_flags.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/atomics.ll
Commit ee3620643dfc88a178fa4ca116cf83014e4ee547 by Vedant Kumar
Revert "[InstCombine] Drop debug loc in TryToSinkInstruction"

This reverts commit 903cf140d0118cf0d3f0f6f8967c6a20d9c5be6b.

This might be causing verifier failures on the bots, such as: "inlinable
function call in a function with debug info must have a !dbg location"
--

http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/16976/steps/bootstrap%20clang/logs/stdio
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was removedllvm/test/Transforms/InstCombine/sink_to_unreachable_dbg.ll
Commit 443556c18f5310b03891f4685ac3831bdcf6f5c7 by Matthew.Arsenault
AMDGPU/GlobalISel: Fix some legalization of < dword vector stores

This avoids many instances of failing to legalize a vector truncstore
of <4 x s8> to 2 bytes. We don't perfectly handle every truncstore
yet, largely because the given set of legalization actions can't
actually differentiate between changing the result type and changing
the memory type.
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-global.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-local.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-flat.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-constant.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-private.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-store.mir
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
Commit b091c9a3e180f45c35a7e1fdd8e383c0098d9210 by Matthew.Arsenault
LLParser: Accept align(N) as new syntax for parameter attribute

Every other value parameter attribute uses parentheses, so accept this
as the preferred modern syntax. Updating everything to use the new
syntax is left for a future change.
The file was modifiedllvm/docs/LangRef.rst
The file was modifiedllvm/lib/AsmParser/LLParser.cpp
The file was addedllvm/test/Assembler/align-param-attr-format.ll
The file was modifiedllvm/lib/AsmParser/LLParser.h
The file was addedllvm/test/Assembler/align-param-attr-error0.ll
The file was addedllvm/test/Assembler/align-param-attr-error1.ll
The file was addedllvm/test/Assembler/align-param-attr-error2.ll