UnstableChanges

Summary

  1. [lldb] Add test for executing static initializers in expression command (details)
  2. PCH debug info: Avoid appending the source directory to an absolute path (details)
  3. [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2) (details)
  4. IndVarSimplify - silence static analyzer dyn_cast<> null dereference (details)
  5. CrossDSOCFI - silence static analyzer dyn_cast<> null dereference (details)
  6. GuardWidening - silence static analyzer null dereference warning with (details)
  7. GVNHoist - silence static analyzer dyn_cast<> null dereference warning (details)
  8. SystemZISelLowering - supportedAddressingMode - silence static analyzer (details)
  9. Unify timeouts in gdbserver tests and ensure they are larger if ASAN is (details)
Commit 7a79e10a82e0d5f84385566493823959dc1697b3 by Raphael Isemann
[lldb] Add test for executing static initializers in expression command
llvm-svn: 375422
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/static-initializers/TestStaticInitializers.py
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/static-initializers/main.cpp
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/static-initializers/Makefile
Commit 122e7af03df6f4d4f64db016c7183d0045690558 by Adrian Prantl
PCH debug info: Avoid appending the source directory to an absolute path
When building a precompiled header in -fmodule-format=obj (i.e.,
`-gmodules) in an absolute path, the locig in
CGDebugInfo::createCompileUnit would unconditionally append the source
directory to the -main-file-name. This patch avoids that behavior for
absolute paths.
rdar://problem/46045865
Differential Revision: https://reviews.llvm.org/D69213
llvm-svn: 375423
The file was addedclang/test/PCH/debug-info-pch-container-path.c
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
Commit 814548ec8e1bf85748bc2aa3be173f20267deca4 by sander.desmalen
[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2)
Commit message from D66935:
This patch fixes a bug exposed by D65653 where a subsequent invocation
of `determineCalleeSaves` ends up with a different size for the callee
save area, leading to different frame-offsets in debug information.
In the invocation by PEI, `determineCalleeSaves` tries to determine
whether it needs to spill an extra callee-saved register to get an
emergency spill slot. To do this, it calls 'estimateStackSize' and
manually adds the size of the callee-saves to this. PEI then allocates
the spill objects for the callee saves and the remaining frame layout is
calculated accordingly.
A second invocation in LiveDebugValues causes estimateStackSize to
return the size of the stack frame including the callee-saves. Given
that the size of the callee-saves is added to this, these callee-saves
are counted twice, which leads `determineCalleeSaves` to believe the
stack has become big enough to require spilling an extra callee-save as
emergency spillslot. It then updates CalleeSavedStackSize with a larger
value.
Since CalleeSavedStackSize is used in the calculation of the frame
offset in getFrameIndexReference, this leads to incorrect offsets for
variables/locals when this information is recalculated after PEI.
This patch fixes the lldb unit tests in
`functionalities/thread/concurrent_events/*`
Changes after D66935:
Ensures AArch64FunctionInfo::getCalleeSavedStackSize does not return the
uninitialized CalleeSavedStackSize when running `llc` on a specific pass
where the MIR code has already been expected to have gone through PEI.
Instead, getCalleeSavedStackSize (when passed the MachineFrameInfo) will
try to recalculate the CalleeSavedStackSize from the CalleeSavedInfo. In
debug mode, the compiler will assert the recalculated size equals the
cached size as calculated through a call to determineCalleeSaves.
This fixes two tests:
test/DebugInfo/AArch64/asan-stack-vars.mir
test/DebugInfo/AArch64/compiler-gen-bbs-livedebugvalues.mir that
otherwise fail when compiled using msan.
Reviewed By: omjavaid, efriedma
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68783
llvm-svn: 375425
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
The file was addedllvm/test/CodeGen/AArch64/wrong-callee-save-size-after-livedebugvariables.mir
The file was modifiedllvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp
The file was modifiedllvm/lib/CodeGen/RegUsageInfoCollector.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.h
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.cpp
Commit 0c5df8dbe561949050a7796aa6a83de164f95fed by llvm-dev
IndVarSimplify - silence static analyzer dyn_cast<> null dereference
warning. NFCI.
The static analyzer is warning about a potential null dereference, but
we should be able to use cast<> directly and if not assert will fire for
us.
llvm-svn: 375426
The file was modifiedllvm/lib/Transforms/Scalar/IndVarSimplify.cpp
Commit 10d4b752a7fcb70d87dd3ffe7264aa5cfa8a7a76 by llvm-dev
CrossDSOCFI - silence static analyzer dyn_cast<> null dereference
warning. NFCI.
The static analyzer is warning about a potential null dereference, but
we should be able to use cast<> directly and if not assert will fire for
us.
llvm-svn: 375427
The file was modifiedllvm/lib/Transforms/IPO/CrossDSOCFI.cpp
Commit 783d3c4f0aae65483e8fa8281f84774e09b65a49 by llvm-dev
GuardWidening - silence static analyzer null dereference warning with
assertion. NFCI.
llvm-svn: 375428
The file was modifiedllvm/lib/Transforms/Scalar/GuardWidening.cpp
Commit 57e8f0b05545ded4f2da1979ee9b19af55f3c004 by llvm-dev
GVNHoist - silence static analyzer dyn_cast<> null dereference warning
in hasEHOrLoadsOnPath call. NFCI.
The static analyzer is warning about a potential null dereference, but
we should be able to use cast<> directly and if not assert will fire for
us.
llvm-svn: 375429
The file was modifiedllvm/lib/Transforms/Scalar/GVNHoist.cpp
Commit ae9971255990a4f3cf93fa81a5b44dabd2aa747c by llvm-dev
SystemZISelLowering - supportedAddressingMode - silence static analyzer
dyn_cast<> null dereference warning. NFCI.
The static analyzer is warning about a potential null dereference, but
we should be able to use cast<> directly and if not assert will fire for
us.
llvm-svn: 375430
The file was modifiedllvm/lib/Target/SystemZ/SystemZISelLowering.cpp
Commit 5827a82a5870fcb59a9fb34e6891ca0f009d282a by Adrian Prantl
Unify timeouts in gdbserver tests and ensure they are larger if ASAN is
enabled.
llvm-svn: 375431
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteProcessInfo.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/commandline/TestStubReverseConnect.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py