SuccessChanges

Summary

  1. [clangd] DefineOutline won't copy virtual specifiers on methods (details)
  2. Revert "[Driver] Default to -fno-common for all targets" (details)
  3. Revert abb00753 "build: reduce CMake handling for zlib" (PR44780) (details)
  4. [ExpandMemCmp][NFC] Fix typo in comment. (details)
  5. [lldb] Make sure we don't drop asynchronous output when sourcing files (details)
  6. Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"" (details)
  7. [lldb] Treat RangeDataVector as an augmented binary search tree (details)
  8. [LoopVectorizer] Add reduction tests for inloop reductions. NFC (details)
Commit b2666ccca0277371a09e43a0a5a0f78029ba81e5 by n.james93
[clangd] DefineOutline won't copy virtual specifiers on methods

Summary:
The define out of line refactor tool previously would copy the `virtual`, `override` and `final` specifier into the out of line method definition.
This results in malformed code as those specifiers aren't allowed outside the class definition.

Reviewers: hokein, kadircet

Reviewed By: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D75429
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
Commit 4e363563fa149321514389a031fa063e998d7422 by sjoerd.meijer
Revert "[Driver] Default to -fno-common for all targets"

This reverts commit 0a9fc9233e172601e26381810d093e02ef410f65.

Going to look at the asan failures.

I find the failures in the test suite weird, because they look
like compile time test and I don't understand how that can be
failing, but will have a brief look at that too.
The file was modifiedclang/test/CodeGen/tentative-decls.c
The file was modifiedclang/test/CodeGen/address-space.c
The file was modifiedclang/test/CodeGen/asm-label.c
The file was modifiedclang/test/CodeGenObjC/constant-string-class.m
The file was modifiedclang/test/Driver/clang_f_opts.c
The file was modifiedclang/test/CodeGen/bool-convert.c
The file was modifiedclang/test/CodeGen/cfstring-windows.c
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/test/Driver/xcore-opts.c
The file was modifiedclang/test/Driver/apple-kext-mkernel.c
The file was modifiedclang/test/Driver/fuchsia.c
The file was modifiedclang/test/CodeGen/vlt_to_pointer.c
The file was modifiedclang/test/CodeGen/alignment.c
The file was modifiedclang/test/Headers/xmmintrin.c
The file was modifiedclang/test/CodeGenOpenCL/amdgcn-large-globals.cl
The file was modifiedclang/test/CodeGen/pr25786.c
The file was modifiedclang/test/CodeGen/private-extern-redef.c
The file was modifiedclang/test/CodeGenOpenCL/amdgpu-nullptr.cl
The file was modifiedclang/test/CodeGen/pragma-weak.c
The file was modifiedclang/test/CodeGen/volatile-1.c
The file was modifiedclang/test/PCH/chain-external-defs.c
The file was modifiedclang/test/PCH/external-defs.c
The file was modifiedclang/test/CodeGen/pragma-pack-1.c
The file was modifiedclang/test/CodeGenOpenCL/address-spaces.cl
The file was modifiedclang/docs/ClangCommandLineReference.rst
The file was modifiedclang/test/CodeGen/no-common.c
The file was modifiedclang/test/CodeGen/blocks-windows.c
The file was modifiedclang/test/CodeGen/windows-on-arm-dllimport-dllexport.c
The file was modifiedclang/test/PCH/tentative-defs.c
The file was modifiedclang/test/CodeGen/visibility.c
The file was modifiedclang/test/CodeGen/dllexport.c
The file was modifiedclang/test/CodeGen/alias.c
The file was modifiedclang/test/CodeGenCXX/clang-sections-tentative.c
The file was modifiedclang/test/CodeGen/attr-weakref2.c
The file was modifiedclang/test/CodeGen/c11atomics.c
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedclang/test/CodeGen/attributes.c
The file was modifiedclang/test/CodeGen/cfstring-elf-cfbuild-x86_64.c
The file was modifiedclang/test/CodeGen/default-address-space.c
The file was modifiedclang/test/CodeGen/attr-weak-import.c
The file was addedclang/test/CodeGen/weak-global.c
The file was modifiedclang/test/CodeGenObjC/tentative-cfconstantstring.m
The file was modifiedclang/test/Parser/pragma-visibility2.c
The file was modifiedclang/test/CodeGen/tls-model.c
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedclang/test/CodeGen/align-systemz.c
The file was modifiedclang/test/Frontend/ast-codegen.c
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/test/CodeGen/2008-07-21-mixed-var-fn-decl.c
The file was modifiedclang/test/CodeGen/aarch64-sve.c
The file was modifiedclang/test/CodeGen/dllexport-1.c
The file was modifiedclang/test/CodeGen/microsoft-no-common-align.c
The file was modifiedclang/test/CodeGen/2009-10-20-GlobalDebug.c
The file was modifiedclang/test/CodeGen/dllimport.c
The file was removedclang/test/Driver/no-common.c
Commit 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e by hans
Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)

and follow-ups:
a2ca1c2d "build: disable zlib by default on Windows"
2181bf40 "[CMake] Link against ZLIB::ZLIB"
1079c68a "Attempt to fix ZLIB CMake logic on Windows"

This changed the output of llvm-config --system-libs, and more
importantly it broke stand-alone builds. Instead of piling on more fix
attempts, let's revert this to reduce the risk of more breakages.
The file was modifiedllvm/CMakeLists.txt
The file was modifiedllvm/cmake/config-ix.cmake
The file was modifiedllvm/test/lit.site.cfg.py.in
The file was modifiedllvm/lib/Support/Compression.cpp
The file was modifiedllvm/lib/Support/CRC.cpp
The file was modifiedllvm/unittests/Support/CompressionTest.cpp
The file was modifiedlld/test/CMakeLists.txt
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
The file was modifiedllvm/include/llvm/Config/config.h.cmake
The file was modifiedllvm/test/CMakeLists.txt
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
The file was modifiedclang/test/lit.site.cfg.py.in
The file was modifiedclang/test/CMakeLists.txt
The file was modifiedllvm/lib/Support/CMakeLists.txt
The file was modifiedlld/test/lit.site.cfg.py.in
The file was modifiedcompiler-rt/test/lit.common.configured.in
Commit b0ae20d92e48348e7e2c796f990126c8ea1c0ba5 by courbet
[ExpandMemCmp][NFC] Fix typo in comment.
The file was modifiedllvm/lib/CodeGen/ExpandMemCmp.cpp
Commit 4deea65249d5df2965d4df90ec9cf221bcf9a13e by pavel
[lldb] Make sure we don't drop asynchronous output when sourcing files

Summary:
If a command from a sourced file produces asynchronous output, this
output often does not make its way to the user. This happens because the
asynchronous output machinery relies on the iohandler stack to ensure
the output does not interfere with the things the iohandler is doing.

However, if this happens near the end of the command stream then by the
time the asynchronous output is produced we may already have already
started tearing down the sourcing session. Specifically, we may already
pop the relevant iohandler, leaving the stack empty.

This patch makes sure this kind of output gets printed by adding a
fallback to IOHandlerStack::PrintAsync to print the output directly if
the stack is empty. This is safe because if we have no iohandlers then
there is nothing to synchronize.

Reviewers: JDevlieghere, clayborg

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D75454
The file was addedlldb/test/Shell/Commands/command-thread-select.test
The file was modifiedlldb/source/Core/IOHandler.cpp
Commit 93c73d4834a96ac749dabb624e07f9a146186875 by hans
Revert "Reland "[gn build] (manually) merge 68a235d07f9e70""

This reverts commit 94d4ca90040a5f55ee29f48043881437de56681e.

I reverted 68a235d07f9e70 again in
916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e.
The file was modifiedllvm/utils/gn/secondary/clang/test/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/compiler-rt/test/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/lld/test/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/test/BUILD.gn
Commit 6304368818a1e9883b694b9d8c21ef568176168d by pavel
[lldb] Treat RangeDataVector as an augmented binary search tree

Summary:
Since RangeDataVector is assumed to always be sorted we can treat it as
an flattened BST and augment it with additional information about the
ranges belonging to each "subtree". By storing the maximum endpoint in
every subtree we can query for intervals in O(log n) time.

Reviewers: labath, teemperor

Reviewed By: labath

Subscribers: jarin, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74759
The file was modifiedlldb/include/lldb/Utility/RangeMap.h
Commit ec7e4a9a80155887b6f3c9f15f28253fa6c58859 by david.green
[LoopVectorizer] Add reduction tests for inloop reductions. NFC

Also adds a force-reduction-intrinsics option for testing, for forcing
the generation of reduction intrinsics even when the backend is not
requesting them.
The file was modifiedllvm/lib/Transforms/Utils/LoopUtils.cpp
The file was addedllvm/test/Transforms/LoopVectorize/reduction-inloop.ll