FailedChanges

Summary

  1. [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method. (details)
  2. [NFC][InstCombine] Add test with non-CSE'd casts of load (details)
  3. [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections. (details)
  4. [Driver] Default to -fno-common for all targets (details)
  5. Revert "[mlir][ods] Add query for derived attribute" (details)
  6. [AVR] Fix incorrect register state for LDRdPtr (details)
Commit e93f7e6d1ab973be717e00966f66739930361a80 by grimar
[obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method.

ELFDumper<ELFT>::dump() is too large and deserves splitting.

Differential revision: https://reviews.llvm.org/D75172
The file was modifiedllvm/tools/obj2yaml/elf2yaml.cpp
Commit 9e1443e6f6d0aa55a2caaf6fd540f4a3e5ce81d4 by lebedev.ri
[NFC][InstCombine] Add test with non-CSE'd casts of load

in @t0 we can still change type of load and get rid of casts.
The file was addedllvm/test/Transforms/InstCombine/multi-use-load-casts.ll
Commit d58e383f23d3a64b4ed71926217a6d36543e77c5 by grimar
[obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections.

Sometimes we need to dump an object and build it again from a YAML
description produced. The problem is that obj2yaml does not dump some
of sections, like string tables and symbol tables.

Because of that yaml2obj implicitly creates them and sections created
are not placed at their original locations. They are added to the end of a section list.
That makes a preparing test cases task harder than it can be.

This patch teaches obj2yaml to dump parts of allocatable SHT_STRTAB, SHT_SYMTAB
and SHT_DYNSYM sections to print placeholders for them.
This also allows to preserve usefull parameters, like virtual address.

Differential revision: https://reviews.llvm.org/D74955
The file was addedllvm/test/tools/obj2yaml/implicit-sections-order.yaml
The file was modifiedllvm/tools/obj2yaml/elf2yaml.cpp
The file was modifiedllvm/test/tools/obj2yaml/versym-section.yaml
The file was modifiedllvm/test/tools/obj2yaml/duplicate-symbol-and-section-names.test
Commit 0a9fc9233e172601e26381810d093e02ef410f65 by sjoerd.meijer
[Driver] Default to -fno-common for all targets

This makes -fno-common the default for all targets because this has performance
and code-size benefits and is more language conforming for C code.
Additionally, GCC10 also defaults to -fno-common and so we get consistent
behaviour with GCC.

With this change, C code that uses tentative definitions as definitions of a
variable in multiple translation units will trigger multiple-definition linker
errors. Generally, this occurs when the use of the extern keyword is neglected
in the declaration of a variable in a header file. In some cases, no specific
translation unit provides a definition of the variable. The previous behavior
can be restored by specifying -fcommon.

As GCC has switched already, we benefit from applications already being ported
and existing documentation how to do this. For example:
- https://gcc.gnu.org/gcc-10/porting_to.html
- https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

Differential revision: https://reviews.llvm.org/D75056
The file was modifiedclang/test/Driver/clang_f_opts.c
The file was addedclang/test/Driver/no-common.c
The file was modifiedclang/test/CodeGen/windows-on-arm-dllimport-dllexport.c
The file was modifiedclang/test/CodeGen/blocks-windows.c
The file was modifiedclang/test/CodeGen/c11atomics.c
The file was modifiedclang/test/CodeGenOpenCL/amdgcn-large-globals.cl
The file was modifiedclang/test/Frontend/ast-codegen.c
The file was modifiedclang/test/CodeGen/vlt_to_pointer.c
The file was modifiedclang/test/CodeGen/visibility.c
The file was modifiedclang/include/clang/Driver/Options.td
The file was removedclang/test/CodeGen/weak-global.c
The file was modifiedclang/test/CodeGen/cfstring-windows.c
The file was modifiedclang/test/CodeGen/attr-weak-import.c
The file was modifiedclang/test/Driver/apple-kext-mkernel.c
The file was modifiedclang/test/Driver/fuchsia.c
The file was modifiedclang/test/CodeGen/attributes.c
The file was modifiedclang/test/CodeGen/alignment.c
The file was modifiedclang/test/CodeGen/dllimport.c
The file was modifiedclang/test/CodeGen/pragma-weak.c
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/test/CodeGen/tentative-decls.c
The file was modifiedclang/test/CodeGen/bool-convert.c
The file was modifiedclang/test/CodeGen/default-address-space.c
The file was modifiedclang/test/CodeGen/asm-label.c
The file was modifiedclang/test/CodeGen/attr-weakref2.c
The file was modifiedclang/test/CodeGen/pragma-pack-1.c
The file was modifiedclang/test/CodeGen/dllexport.c
The file was modifiedclang/test/CodeGen/dllexport-1.c
The file was modifiedclang/test/CodeGen/volatile-1.c
The file was modifiedclang/test/CodeGen/address-space.c
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedclang/test/Headers/xmmintrin.c
The file was modifiedclang/test/Driver/xcore-opts.c
The file was modifiedclang/test/CodeGen/2008-07-21-mixed-var-fn-decl.c
The file was modifiedclang/test/CodeGen/pr25786.c
The file was modifiedclang/docs/ClangCommandLineReference.rst
The file was modifiedclang/test/CodeGen/aarch64-sve.c
The file was modifiedclang/test/PCH/tentative-defs.c
The file was modifiedclang/test/CodeGen/2009-10-20-GlobalDebug.c
The file was modifiedclang/test/CodeGenOpenCL/amdgpu-nullptr.cl
The file was modifiedclang/test/CodeGen/align-systemz.c
The file was modifiedclang/test/PCH/external-defs.c
The file was modifiedclang/test/CodeGen/cfstring-elf-cfbuild-x86_64.c
The file was modifiedclang/test/CodeGenObjC/constant-string-class.m
The file was modifiedclang/test/CodeGen/microsoft-no-common-align.c
The file was modifiedclang/test/Parser/pragma-visibility2.c
The file was modifiedclang/test/CodeGen/alias.c
The file was modifiedclang/test/CodeGen/private-extern-redef.c
The file was modifiedclang/test/PCH/chain-external-defs.c
The file was modifiedclang/test/CodeGenCXX/clang-sections-tentative.c
The file was modifiedclang/test/CodeGen/no-common.c
The file was modifiedclang/test/CodeGen/tls-model.c
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedclang/test/CodeGenOpenCL/address-spaces.cl
The file was modifiedclang/test/CodeGenObjC/tentative-cfconstantstring.m
Commit 57b8b2cc50d0cd8d65728afb5fa7605ee2188843 by herhut
Revert "[mlir][ods] Add query for derived attribute"

This reverts commit 5aa57c28120127ee526ba702646f5e7239ef08f3.

The source code generated due to this ods change does not compile,
as it passes to few arguments to llvm::is_contained.
The file was modifiedmlir/test/mlir-tblgen/op-attribute.td
The file was modifiedmlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
Commit 4e3b037665fd596b1a7ea0774d6e2b30266dc65c by tclin914
[AVR] Fix incorrect register state for LDRdPtr

Summary:
LDRdPtr expanded from LDWRdPtr shouldn't define its second operand(SrcReg).
The second operand is its source register.
Add -verify-machineinstrs into command line of testcases can trigger this error.

Reviewers: dylanmckay

Reviewed By: dylanmckay

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75437
The file was modifiedllvm/test/CodeGen/AVR/PR37143.ll
The file was modifiedllvm/test/CodeGen/AVR/brind.ll
The file was modifiedllvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
The file was modifiedllvm/test/CodeGen/AVR/load.ll
The file was modifiedllvm/test/CodeGen/AVR/pseudo/LDWRdPtr.mir