FailedChanges

Summary

  1. [SelectionDAG] Reduce assumptions made about levels. NFC (details)
  2. [InstCombine] fix undef propagation for vector urem transform (PR44186) (details)
  3. [ELF][AArch64] Support R_AARCH64_{CALL26,JUMP26} range extension thunks (details)
  4. [DAGCombine] Factor oplist operations. NFC (details)
  5. [lit] Be more explicit about the state of tests (details)
  6. [update_cc_test_checks.py] Use CHECK_RE from common (details)
  7. [VPlan] Move graph traits (NFC). (details)
  8. Reland "b19ec1eb3d0c [BPI] Improve unreachable/ColdCall heurstics to (details)
  9. [clang][modules] Add support for merging lifetime-extended temporaries (details)
  10. [OPENMP]Fix PR44133: Emit definitions of used constructors/functions. (details)
  11. [OPENMP]Use cast instead dyn_cast, NFC. (details)
  12. [AArch64] Attempt to fixup test line. NFC (details)
  13. [WebAssembly] Find wasm-opt with GetProgramPath (details)
  14. [MIBundles] Move analyzeVirtReg out of MIBundleOperands iterator (NFC). (details)
  15. [ARM] More reversed vcmp tests. NFC (details)
  16. [ARM] Add some VCMP folding and canonicalisation (details)
  17. [ARM] Add ARMCC constants to tablegen. NFC (details)
  18. [ARM] Add ARMVCCThen to tablegen and make use of it. NFC (details)
  19. [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy (details)
  20. [lldb] Fix TestFormattersSBAPI test (details)
  21. [LLDB] Set the right address size on output DataExtractors from (details)
  22. [MIBundles] Move analyzePhysReg out of MIBundleOperands iterator (NFC). (details)
  23. [clangd] repair mac tests for 88bccded8fa1 (details)
  24. [lldb/CMake] Simplify logic for adding example Python packages (NFC) (details)
  25. [lldb/CMake] Add in_call_stack to the utilities package (details)
  26. [Remarks][ThinLTO] Use the correct file extension based on the format (details)
  27. Revert "[clangd] repair mac tests for 88bccded8fa1" (details)
  28. [libcxx{,abi}] Emit deplibs only when detected by CMake (details)
Commit d8d51062256ae59e8c34a94c541119b813b53a79 by deadalnix
[SelectionDAG] Reduce assumptions made about levels. NFC
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Commit af4e59949cc4cc895be76a441a2a867189ee0f55 by spatel
[InstCombine] fix undef propagation for vector urem transform (PR44186)
As described here: https://bugs.llvm.org/show_bug.cgi?id=44186
The match() code safely allows undef values, but we can't safely
propagate a vector constant that contains an undef to the new compare
instruction.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
The file was modifiedllvm/test/Transforms/InstCombine/vector-urem.ll
Commit bf535ac4a28268e6a481acee5a794ef5deed5018 by maskray
[ELF][AArch64] Support R_AARCH64_{CALL26,JUMP26} range extension thunks
with addends
Fixes AArch64 part of PR40438
The current range extension thunk framework does not handle a relocation
relative to a STT_SECTION symbol with a non-zero addend, which may be
used by jumps/calls to local functions on some RELA targets (AArch64,
powerpc ELFv1, powerpc64 ELFv2, etc).  See PR40438 and the following
code for examples:
  // clang -target $target a.cc
// .text.cold may be placed in a separate output section.
// The distance between bar in .text.cold and foo in .text may be
larger than 128MiB.
static void foo() {}
__attribute__((section(".text.cold"))) static int bar() { foo(); return
0; }
__attribute__((used)) static int dummy = bar();
This patch makes such thunks with addends work for AArch64. The target
independent part can be reused by PPC in the future.
On REL targets (ARM, MIPS), jumps/calls are not represented as
STT_SECTION + non-zero addend (see
MCELFObjectTargetWriter::needsRelocateWithSymbol), so they don't need
this feature, but we need to make sure this patch does not affect them.
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D70637
The file was modifiedlld/ELF/Relocations.cpp
The file was modifiedlld/ELF/Target.cpp
The file was modifiedlld/ELF/Arch/PPC.cpp
The file was modifiedlld/ELF/Target.h
The file was modifiedlld/ELF/Thunks.cpp
The file was modifiedlld/ELF/Arch/ARM.cpp
The file was modifiedlld/ELF/Relocations.h
The file was modifiedlld/test/ELF/aarch64-thunk-script.s
The file was modifiedlld/ELF/Thunks.h
The file was modifiedlld/ELF/Arch/PPC64.cpp
The file was modifiedlld/test/ELF/aarch64-thunk-pi.s
The file was modifiedlld/ELF/Arch/AArch64.cpp
The file was modifiedlld/ELF/Arch/Mips.cpp
Commit c594d14d40f5c55a839ed51602cea198ff76e8a1 by deadalnix
[DAGCombine] Factor oplist operations. NFC
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Commit 62ab949248d88be0215921f047dd82b02b99138c by julian.lettner
[lit] Be more explicit about the state of tests
Tests go through the following stages:
*) discovered
*) filtered
*) executed
Only executed tests have a result (e.g., PASS, FAIL, XFAIL, etc.).  See
"result codes" in Test.py.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D70612
The file was modifiedllvm/utils/lit/lit/main.py
Commit 3b55eebd239ee7d518a95ca9ecccf879b17d7e8c by Alexander.Richardson
[update_cc_test_checks.py] Use CHECK_RE from common
Summary: This change modifies the common.CHECK_RE regex to also handle
'//' comment prefixes which allows us to share it between clang and IR
tests. Using the regex from common means that *-SAME lines are also
stripped now. Before this change using the --function-signature flag
would result in -SAME: lines from previous runs not being removed.
Reviewers: MaskRay, jdoerfert
Reviewed By: jdoerfert
Subscribers: jdoerfert, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70890
The file was modifiedllvm/utils/UpdateTestChecks/common.py
The file was modifiedllvm/utils/update_cc_test_checks.py
Commit fe459ce65a993dee5e20648a8e01330a44e879b8 by flo
[VPlan] Move graph traits (NFC).
By defining the graph traits right after the VPBlockBase definitions, we
can make use of them earlier in the file.
Reviewers: hsaito, Ayal, gilr
Reviewed By: gilr
Differential Revision: https://reviews.llvm.org/D70733
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
Commit 2da205d43eeb402d2c42bdbd2f564e2686b5573d by taewook.oh
Reland "b19ec1eb3d0c [BPI] Improve unreachable/ColdCall heurstics to
handle loops."
Summary: b19ec1eb3d0c has been reverted because of the test failures
with PowerPC targets. This patch addresses the issues from the previous
commit.
Test Plan: ninja check-all. Confirmed that CodeGen/PowerPC/pr36292.ll
and CodeGen/PowerPC/sms-cpy-1.ll pass
Subscribers: llvm-commits
The file was modifiedllvm/lib/Analysis/BranchProbabilityInfo.cpp
The file was modifiedllvm/test/CodeGen/PowerPC/pr36292.ll
The file was modifiedllvm/test/Analysis/BranchProbabilityInfo/noreturn.ll
The file was modifiedllvm/test/CodeGen/X86/ragreedy-hoist-spill.ll
The file was modifiedllvm/test/CodeGen/X86/block-placement.ll
The file was modifiedllvm/test/Analysis/BranchProbabilityInfo/basic.ll
The file was addedDIFF
The file was modifiedllvm/test/CodeGen/X86/pr37916.ll
The file was modifiedllvm/include/llvm/Analysis/BranchProbabilityInfo.h
The file was modifiedllvm/test/CodeGen/PowerPC/sms-cpy-1.ll
Commit 9ec6d7121132d30db68818e4f684910f76307fdf by tyker
[clang][modules] Add support for merging lifetime-extended temporaries
Summary: Add support for merging lifetime-extended temporaries
Reviewers: rsmith
Reviewed By: rsmith
Subscribers: xbolva00, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70190
The file was addedclang/test/Modules/merge-lifetime-extended-temporary.cpp
The file was addedclang/test/Modules/Inputs/merge-lifetime-extended-temporary/c.h
The file was addedclang/test/Modules/Inputs/merge-lifetime-extended-temporary/module.modulemap
The file was modifiedclang/include/clang/AST/TextNodeDumper.h
The file was modifiedclang/lib/AST/TextNodeDumper.cpp
The file was addedclang/test/Modules/Inputs/merge-lifetime-extended-temporary/b.h
The file was modifiedclang/include/clang/Serialization/ASTReader.h
The file was addedclang/test/Modules/Inputs/merge-lifetime-extended-temporary/a.h
The file was modifiedclang/lib/Serialization/ASTReaderDecl.cpp
The file was modifiedclang/include/clang/AST/DeclCXX.h
Commit 478541a6da59fa3eadab98cabdcb0126fad3fdb5 by a.bataev
[OPENMP]Fix PR44133: Emit definitions of used constructors/functions.
Need to fully rebuild the initializer/combiner when instatiating the
declare reduction constrcut to properly emit used functions.
The file was modifiedclang/lib/Sema/SemaTemplateInstantiateDecl.cpp
The file was modifiedclang/test/OpenMP/declare_reduction_codegen.cpp
Commit f17a1d8b283d227dcbc88caf94acf55abc91c1f9 by a.bataev
[OPENMP]Use cast instead dyn_cast, NFC.
Here the expression is always a DeclRefExpr, no need to use dyn_cast.
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
Commit 1d4587346f51ca5cc5741337cadfaeb208ca59ad by david.green
[AArch64] Attempt to fixup test line. NFC
The test is complaining on some of the builders. This attempts to adjust
the run line to be more line the others in the same folder, using
clang_cc1 as opposed to the driver.
The file was modifiedclang/test/CodeGen/aarch64-neon-vcadd.c
Commit 8f1e2151b8e923345a18aa3025a7d074e134768b by sunfish
[WebAssembly] Find wasm-opt with GetProgramPath
Instead of just searching for wasm-opt in PATH, use GetProgramPath,
which checks the `COMPILER_PATH` environment variable, -B paths, and
`PATH`.
Differential Revision: https://reviews.llvm.org/D70780
The file was modifiedclang/lib/Driver/ToolChains/WebAssembly.cpp
Commit 5d0625664bf013ad2be52d3204dcd738bb2bf44c by flo
[MIBundles] Move analyzeVirtReg out of MIBundleOperands iterator (NFC).
analyzeVirtReg does not really fit into the iterator and moving it makes
it easier to change the base iterator.
Reviewers: evandro, t.p.northover, paquette, MatzeB, arsenm, qcolombet
Reviewed By: qcolombet
Differential Revision: https://reviews.llvm.org/D70558
The file was modifiedllvm/lib/CodeGen/MachineInstrBundle.cpp
The file was modifiedllvm/lib/CodeGen/InlineSpiller.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineInstrBundle.h
Commit 63aff5cd3c83cc1000cf9c85388e62071086dda2 by david.green
[ARM] More reversed vcmp tests. NFC
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpz.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpfz.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpr.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpfr.ll
Commit 57d96ab593dfff39dc6eb8fa5f25eaf64af26ee1 by david.green
[ARM] Add some VCMP folding and canonicalisation
The VCMP instructions in MVE can accept a register or ZR, but only as
the right hand operator. Most of the time this will already be correct
because the icmp will have been canonicalised that way already. There
are some cases in the lowering of float conditions that this will not
apply to though. This code should fix up those cases.
Differential Revision: https://reviews.llvm.org/D70822
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.cpp
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpfz.ll
The file was modifiedllvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
The file was modifiedllvm/lib/Target/ARM/Utils/ARMBaseInfo.h
Commit a223a4d66f4c7e28e7c6015b9e4c4a652a9677a1 by david.green
[ARM] Add ARMCC constants to tablegen. NFC
I got tired of looking at magic constants in tablegen files. This adds
condition codes like ARMCCeq and makes use of them.
I also removed the extra patterns for reverse condition codes from
D70296, they should now be covered by the parent commit.
Differential Revision: https://reviews.llvm.org/D70824
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
The file was modifiedllvm/lib/Target/ARM/ARMInstrNEON.td
The file was modifiedllvm/lib/Target/ARM/ARMInstrInfo.td
Commit 469ee617a011354b37d4c8d1c41ba8be0d719af0 by david.green
[ARM] Add ARMVCCThen to tablegen and make use of it. NFC
Similar to the parent, this adds some constants to tablegen to replace
the existing magic values.
Differential Revision: https://reviews.llvm.org/D70825
The file was modifiedllvm/lib/Target/ARM/ARMInstrInfo.td
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
Commit 3d02fa6da7d250e086b01b4ec66b513debb7950d by vkeles
[GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy
Summary: When combining COPY instructions, we were replacing the
destination registers with the source register without checking register
constraints. This patch adds a simple logic to check if the constraints
match before replacing registers.
Reviewers: qcolombet, aditya_nandakumar, aemerson, paquette, dsanders,
Petar.Avramovic
Reviewed By: aditya_nandakumar
Subscribers: rovka, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70616
The file was modifiedllvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/combine-copy.mir
Commit afd5d912812e6f2ea99c8890676d47a01bbcfbb1 by aadsm
[lldb] Fix TestFormattersSBAPI test
Summary: This test was broken in two ways:
* Using the wrong API (e.g.: format = instead of SetFormat)
* The hex checker was only checking "01" which will pass with 0x0000001
Reviewers: clayborg, lanza, wallace
Reviewed By: clayborg
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70884
The file was modifiedlldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py
Commit 7d019d1a3be252a885e8db1ee7af11c90b450d38 by martin
[LLDB] Set the right address size on output DataExtractors from
ObjectFile
If filling in a DataExtractor from an ObjectFile, e.g. via the
ReadSectionData method, the output DataExtractor gets the address size
from the m_data member.
ObjectFile's m_data member is initialized without knowledge about the
address size (so the address size is set based on the host's
sizeof(void*), and at that point within ObjectFile's constructor,
virtual methods implemented in subclasses (like GetAddressByteSize())
can't be called, therefore fix it up when filling in external
DataExtractors.
This makes sure that line tables from executables with a different
address size are parsed properly; previously this tripped up
DWARFDebugLine::LineTable::parse for 32 bit executables on a 64 bit
host, as the address size in the line table (4) didn't match the one set
in the DWARFDataExtractor.
Differential Revision: https://reviews.llvm.org/D70848
The file was modifiedlldb/source/Symbol/ObjectFile.cpp
The file was addedlldb/test/Shell/SymbolFile/DWARF/win-i386-line-table.s
Commit 5154b0253d262be12d8f21edefd8c6d231dcf7a1 by flo
[MIBundles] Move analyzePhysReg out of MIBundleOperands iterator (NFC).
analyzePhysReg does not really fit into the iterator and moving it makes
it easier to change the base iterator.
Reviewers: evandro, t.p.northover, paquette, MatzeB, arsenm, qcolombet
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D70559
The file was modifiedllvm/lib/CodeGen/MachineBasicBlock.cpp
The file was modifiedllvm/lib/CodeGen/InlineSpiller.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp
The file was modifiedllvm/lib/CodeGen/MachineInstrBundle.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineInstrBundle.h
Commit 82039cbc8d2a0f6fb5995f54e0e42919999bcfd0 by sam.mccall
[clangd] repair mac tests for 88bccded8fa1
The file was modifiedclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp
Commit e5290a06d6c23bd222543cb9b689a199343021a7 by Jonas Devlieghere
[lldb/CMake] Simplify logic for adding example Python packages (NFC)
This simplifies the CMake logic for adding the Python examples to the
Python package. It unifies the use of create_python_package by adding
the NOINIT option and removes the `target` argument, which is always
`finish_swig`.
The file was modifiedlldb/CMakeLists.txt
Commit 8f2c100f6fa5250b987d11e53d24119bc1f8850e by Jonas Devlieghere
[lldb/CMake] Add in_call_stack to the utilities package
A subset of the examples are shipped as python packages. Include the
in_call_stack utility.
The file was modifiedlldb/CMakeLists.txt
Commit 7902d6cc803065eae4d434642a8b4afd940a216b by francisvm
[Remarks][ThinLTO] Use the correct file extension based on the format
Since we now have multiple formats, the ThinLTO remark files should also
respect that.
The file was modifiedllvm/lib/LTO/LTO.cpp
The file was modifiedllvm/test/ThinLTO/X86/diagnostic-handler-remarks.ll
Commit 93f77617abba512d2861e2fc50ce385883f587b6 by sam.mccall
Revert "[clangd] repair mac tests for 88bccded8fa1"
Revert "[clangd] Try harder to find a plausible `clang` as argv0,
particularly on Mac."
The file was modifiedclang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
The file was modifiedclang-tools-extra/clangd/GlobalCompilationDatabase.cpp
Commit a9b5fff591d462f1f22e44ab1a269b82b8f2a664 by mgorny
[libcxx{,abi}] Emit deplibs only when detected by CMake
This is a followup to 35bc5276ca3.  It fixes the dependent libs usage in
libcxx and libcxxabi to link pthread and rt libraries only if CMake
detects them, rather than based on explicit platform blacklist.
Differential Revision: https://reviews.llvm.org/D70888
The file was modifiedlibcxxabi/src/cxa_exception_storage.cpp
The file was modifiedlibcxx/src/shared_mutex.cpp
The file was modifiedlibcxx/src/chrono.cpp
The file was modifiedlibcxxabi/src/cxa_guard_impl.h
The file was modifiedlibcxxabi/src/fallback_malloc.cpp
The file was modifiedlibcxx/src/algorithm.cpp
The file was modifiedlibcxx/src/condition_variable.cpp
The file was modifiedlibcxx/src/debug.cpp
The file was modifiedlibcxx/src/experimental/memory_resource.cpp
The file was modifiedlibcxx/src/mutex.cpp
The file was modifiedlibcxx/src/filesystem/operations.cpp
The file was modifiedlibcxx/src/memory.cpp
The file was modifiedlibcxx/CMakeLists.txt
The file was modifiedlibcxx/src/thread.cpp
The file was modifiedlibcxxabi/CMakeLists.txt
The file was modifiedlibcxxabi/src/cxa_thread_atexit.cpp