FailedChanges

Summary

  1. [AST] Use a reference in a range-based for (details)
  2. [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map (details)
Commit 29e78ec67988a5aa712da805f8197bfa3d738700 by koraq
[AST] Use a reference in a range-based for
This avoids unneeded copies when using a range-based for loops.
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to
-Wall.
Differential Revision: https://reviews.llvm.org/D71526
The file was modifiedclang/lib/AST/ASTContext.cpp
Commit 8280896bd1b055a192d9e7d482b0ffa14ee88e3a by Raphael Isemann
[lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map
of known instances
Summary: Currently we do our RTTI check for ClangExternalASTSourceCommon
by using this global map of ClangExternalASTSourceCommon where every
instance is registering and deregistering itself on
creation/destruction. Then we can do the RTTI check by looking up in
this map from ClangASTContext.
This patch removes this whole thing and just adds LLVM-style RTTI
support to ClangExternalASTSourceCommon which is possible with D71397.
Reviewers: labath, aprantl
Reviewed By: labath
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71398
The file was modifiedlldb/include/lldb/Symbol/ClangExternalASTSourceCommon.h
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
The file was modifiedlldb/source/Symbol/ClangExternalASTSourceCommon.cpp