FailedChanges

Summary

  1. [WebAssembly] Replace SIMD int min/max builtins with patterns (details)
  2. [InstCombine] Teach removeBitcastsFromLoadStoreOnMinMax not to change (details)
  3. [LoopFusion] Restrict loop fusion to rotated loops. (details)
  4. [NFC-I] Remove hack for fp-classification builtins (details)
  5. Fix a bug in the property-based serialization of dependent template (details)
  6. [TSan][Darwin] Avoid calling pthread_self() before libpthread is (details)
  7. [AArch64][SVE] Add patterns for logical immediate operations. (details)
  8. git-llvm: Add option to push to Github with SSH (details)
  9. Revert "[NFC-I] Remove hack for fp-classification builtins" (details)
  10. Add default initialization to compressed_pair. (details)
  11. [X86] Add x86 triple to command line in mxcsr-reg-usage.ll (details)
  12. [lldb] Respect previously set values of LLDB_TABLEGEN_EXE (details)
  13. [coroutines][PR41909] Generalize fix from D62550 (details)
Commit 3a93756dfbb0dcb7c62fcbe5b0ab8f8591fc9721 by tlively
[WebAssembly] Replace SIMD int min/max builtins with patterns
Summary: The instructions were originally implemented via builtins and
intrinsics so users would have to explicitly opt-in to using them. This
was useful while were validating whether these instructions should have
been merged into the spec proposal. Now that they have been, we can use
normal codegen patterns, so the intrinsics and builtins are no longer
useful.
Reviewers: aheejin
Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish,
cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D71500
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-intrinsics.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
The file was modifiedllvm/include/llvm/IR/IntrinsicsWebAssembly.td
The file was modifiedclang/include/clang/Basic/BuiltinsWebAssembly.def
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/test/CodeGen/builtins-wasm.c
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-arith.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
Commit 02f644c59ad0d480285b569a0c5ecbd038866ce8 by craig.topper
[InstCombine] Teach removeBitcastsFromLoadStoreOnMinMax not to change
the size of a store.
We can change the type as long as we don't change the size.
Fixes PR44306
Differential Revision: https://reviews.llvm.org/D71532
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
The file was modifiedllvm/test/Transforms/InstCombine/PR37526.ll
Commit ff07fc66d9eef577f3b44716f72e581a18cd9ac9 by kbarton
[LoopFusion] Restrict loop fusion to rotated loops.
Summary: This patch restricts loop fusion to only consider rotated loops
as valid candidates. This simplifies the analysis and transformation and
aligns with other loop optimizations.
Reviewers: jdoerfert, Meinersbur, dmgreen, etiotto, Whitney, fhahn,
hfinkel
Reviewed By: Meinersbur
Subscribers: ormris, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71025
The file was modifiedllvm/lib/Transforms/Scalar/LoopFuse.cpp
The file was modifiedllvm/test/Transforms/LoopFusion/loop_nest.ll
The file was modifiedllvm/test/Transforms/LoopFusion/diagnostics_missed.ll
The file was modifiedllvm/test/Transforms/LoopFusion/four_loops.ll
The file was modifiedllvm/test/Transforms/LoopFusion/simple.ll
The file was modifiedllvm/test/Transforms/LoopFusion/cannot_fuse.ll
Commit b1e542f302c1ed796ad9f703d4d36e010afcb914 by erich.keane
[NFC-I] Remove hack for fp-classification builtins
The FP-classification builtins (__builtin_isfinite, etc) use variadic
packs in the definition file to mean an overload set.  Because of that,
floats were converted to doubles, which is incorrect. There WAS a patch
to remove the cast after the fact.
THis patch switches these builtins to just be custom type checking,
calls the implicit conversions for the integer members, and makes sure
the correct L->R casts are put into place, then does type checking like
normal.
A future direction (that wouldn't be NFC) would consider making
conversions for the floating point parameter legal.
The file was modifiedclang/test/Sema/crash-invalid-builtin.c
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/include/clang/Basic/Builtins.def
The file was addedclang/test/Sema/builtin-fpclassification.c
Commit 803403afc83f659be1c620eb1896dcf704b18b0a by rjmccall
Fix a bug in the property-based serialization of dependent template
names.
Apparently we didn't test this in the test suite because we have a lot
of redundant ways of representing this situation that kick in in the
more common situations.  For example, DependentTST stores a qualifier +
identifier pair rather than a TemplateName.
The file was modifiedclang/include/clang/AST/PropertiesBase.td
The file was modifiedclang/test/PCH/cxx-templates.h
The file was modifiedclang/test/PCH/cxx-templates.cpp
Commit f9a706a36ae5dcb87b0b6649d0c80e989400f48e by julian.lettner
[TSan][Darwin] Avoid calling pthread_self() before libpthread is
initialized
This skips calling `pthread_self` when `main_thread_identity` hasn't
been initialized yet.  `main_thread_identity` is only ever assigned in
`__tsan::InitializePlatform`.  This change should be relatively safe; we
are not changing behavior other than skipping the call to `pthread_self`
when `main_thread_identity == 0`.
rdar://57822138
Reviewed By: kubamracek
Differential Revision: https://reviews.llvm.org/D71559
The file was modifiedcompiler-rt/lib/tsan/rtl/tsan_platform_mac.cpp
Commit f933878991a9b00f3fcf96066678a8816da0a764 by danilo.carvalho.grael
[AArch64][SVE] Add patterns for logical immediate operations.
Summary: Add pattern matching for the following SVE logical vector and
immediate instructions:
- and/bic, orr/orn, eor/eon.
Reviewers: sdesmalen, huntergr, rengolin, efriedma, c-rhodes, mgudim,
kmclaughlin
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl,
llvm-commits, amehsan
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71483
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td
The file was addedllvm/test/CodeGen/AArch64/sve-int-log-imm.ll
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td
Commit 38dd2d50924a3795d1ad61c7c0873632255f324a by v.churavy
git-llvm: Add option to push to Github with SSH
Summary: For users with 2FA Github password challenge can be rather
cumbersome and I personally use key based authentication through SSH.
This fixes the SSH feature that was present and exposes it as a command
line option.
Reviewers: tstellar
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71534
The file was modifiedllvm/utils/git-svn/git-llvm
Commit 3f22b4721e6c9859c392d9891411cbc8d9e10c70 by erich.keane
Revert "[NFC-I] Remove hack for fp-classification builtins"
This reverts commit b1e542f302c1ed796ad9f703d4d36e010afcb914.
The original 'hack' didn't chop out fp-16 to double conversions, so
systems that use FP16ConversionIntrinsics end up in IR-CodeGen with an
i16 type isntead of a float type (like PPC64-BE).  The bots noticed
this.
Reverting until I figure out how to fix this
The file was removedclang/test/Sema/builtin-fpclassification.c
The file was modifiedclang/include/clang/Basic/Builtins.def
The file was modifiedclang/test/Sema/crash-invalid-builtin.c
The file was modifiedclang/lib/Sema/SemaChecking.cpp
Commit 0fa118a9da6786a0aaf81e309d8c3b38bc5f61dd by eric
Add default initialization to compressed_pair.
This change introduces the __default_init_tag to memory, and a
corresponding element constructor to allow for default initialization of
either of the pair values. This is useful for classes such as
std::string where most (all) constructors explicitly initialize the
values in the constructor.
Patch by Martijn Vels (mvels@google.com) Reviewed as
https://reviews.llvm.org/D70617
The file was modifiedlibcxx/include/memory
The file was addedlibcxx/test/libcxx/memory/compressed_pair/compressed_pair.pass.cpp
Commit 2ff251c6a39c55377fbcb0a4786a1bc4f7a60dda by craig.topper
[X86] Add x86 triple to command line in mxcsr-reg-usage.ll
I'm not sure how this hasn't been causing any issues.
The file was modifiedllvm/test/CodeGen/X86/mxcsr-reg-usage.ll
Commit 3fbe518a102a344abbd837e364a404c0c695d183 by apl
[lldb] Respect previously set values of LLDB_TABLEGEN_EXE
If you set LLDB_TABLEGEN_EXE in a CMake cache file or in the CMake
invocation line, your setting isn't respected. Setting up the tablegen
for the host will overwrite the value that we set LLDB_TABLEGEN_EXE to,
which defeats the whole point of setting it in the first place.
The file was modifiedlldb/utils/TableGen/CMakeLists.txt
Commit 376cf43729c8025eecbd2969522c5687f2a3919f by modocache
[coroutines][PR41909] Generalize fix from D62550
Summary: In https://reviews.llvm.org/D62550 @rsmith pointed out that
there are many situations in which a coroutine body statement may be
transformed/rebuilt as part of a template instantiation, and my naive
check whether the coroutine was a generic lambda was insufficient.
This is indeed true, as I've learned by reading more of the
TreeTransform code. Most transformations are written in a way that
doesn't assume the resulting types are not dependent types. So the
assertion in 'TransformCoroutineBodyStmt', that the promise type must no
longer be dependent, is out of place.
This patch removes the assertion, spruces up some code comments, and
adds a test that would have failed with my naive check from
https://reviews.llvm.org/D62550.
Reviewers: GorNishanov, rsmith, lewissbaker
Reviewed By: rsmith
Subscribers: junparser, EricWF, rsmith, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70579
The file was modifiedclang/test/SemaCXX/coroutines.cpp
The file was modifiedclang/lib/Sema/TreeTransform.h