SuccessChanges

Summary

  1. Refactor CompareReferenceRelationship and its callers in preparation for (details)
  2. [Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is (details)
  3. Add prototype for a function we call. (details)
  4. [analyzer] Teach MismatchedDealloc about initWithBytesNoCopy with (details)
  5. [Remarks][Driver][NFC] Make shouldEmitRemarks more available in the (details)
  6. [Remarks][Driver] Run dsymutil when remarks are enabled (details)
  7. Output names in the AST in tests (details)
  8. Trim trailing whitespace (details)
  9. Add method to ignore invisible AST nodes (details)
  10. [X86] Add test case to show incorrect formation of masked add from (details)
  11. [X86] Add a simple hack to IsProfitableToFold to prevent vselect+strict (details)
  12. Revert concepts changes from D41910 (details)
  13. Revert "[Orc][LLJIT] Use JITLink even if a custom (details)
  14. [Docs] Fix a typo (details)
  15. [WebAssembly] Add avgr_u intrinsics and require nuw in patterns (details)
Commit 3ced23976aa8a86a17017c87821c873b4ca80bc2 by richard
Refactor CompareReferenceRelationship and its callers in preparation for
implementing the resolution of CWG2352.
No functionality change, except that we now convert the referent of a
reference binding to the underlying type of the reference in more cases;
we used to happen to preserve the type sugar from the referent if the
only type change was in the cv-qualifiers.
This exposed a bug in how we generate code for trivial assignment
operators: if the type sugar (particularly the may_alias attribute) got
lost during reference binding, we'd use the "wrong" TBAA information for
the load during the assignment.
The file was modifiedclang/include/clang/Sema/Sema.h
The file was modifiedclang/test/AST/ast-dump-expr-json.cpp
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/lib/Sema/SemaInit.cpp
The file was modifiedclang/lib/Sema/SemaExprCXX.cpp
The file was modifiedclang/lib/CodeGen/CGExprCXX.cpp
The file was modifiedclang/lib/Sema/SemaCast.cpp
The file was modifiedclang/test/Index/print-type.cpp
Commit 298e183e813c884dd22816383405bae3ef9ef278 by Lang Hames
[Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is
supplied.
LLJITBuilder will now use JITLink on supported platforms even if a
custom JITTargetMachineBuilder is supplied, provided that neither the
code model, nor the relocation model, nor the ObjectLinkingLayerCreator
is set.
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/JITTargetMachineBuilder.h
The file was modifiedllvm/lib/ExecutionEngine/Orc/LLJIT.cpp
Commit 997bc8b2e6b973dd8c9b17414310cac822543f79 by Jason Molenda
Add prototype for a function we call.
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/a.c
Commit bce1cce6bf1286541c57690ab1129fbc02c60f93 by Artem Dergachev
[analyzer] Teach MismatchedDealloc about initWithBytesNoCopy with
deallocator.
MallocChecker warns when memory is passed into -[NSData
initWithBytesNoCopy] but isn't allocated by malloc(), because it will be
deallocated by free(). However, initWithBytesNoCopy has an overload that
takes an arbitrary block for deallocating the object. If such overload
is used, it is no longer necessary to make sure that the memory is
allocated by malloc().
The file was modifiedclang/test/Analysis/Inputs/system-header-simulator-objc.h
The file was modifiedclang/test/Analysis/malloc.mm
The file was modifiedclang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
Commit a8c678cb9a90c4f82505f573e9b9fa23fec93a64 by francisvm
[Remarks][Driver][NFC] Make shouldEmitRemarks more available in the
Driver
Move the function to Driver.h so that it can be re-used in other places.
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/include/clang/Driver/Driver.h
The file was modifiedclang/lib/Driver/Driver.cpp
Commit d79b11fefb8e92660893b8ccf9e21d23668a6c73 by francisvm
[Remarks][Driver] Run dsymutil when remarks are enabled
When clang is invoked with a source file without -c or -S, it creates a
cc1 job, a linker job and if debug info is requested, a dsymutil job. In
case of remarks, we should also create a dsymutil job to avoid losing
the remarks that will be generated in a tempdir that gets removed.
Differential Revision: https://reviews.llvm.org/D71675
The file was modifiedclang/lib/Driver/Driver.cpp
The file was modifiedclang/test/Driver/darwin-opt-record.c
Commit a9f597b62ebdb670392fec2d5a5154e43b6398aa by steveire
Output names in the AST in tests
The file was modifiedclang/unittests/AST/ASTTraverserTest.cpp
Commit 84fd2bedf4096e78b892165138051b8563169fe3 by steveire
Trim trailing whitespace
The file was modifiedclang/unittests/AST/ASTTraverserTest.cpp
Commit 98e8f774eb6ca8946b3104b4e82beefd41ca2c35 by steveire
Add method to ignore invisible AST nodes
Reviewers: aaron.ballman
Subscribers: mgorny, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70613
The file was modifiedclang/include/clang/AST/Expr.h
The file was modifiedclang/unittests/AST/ASTTraverserTest.cpp
The file was modifiedclang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
The file was modifiedclang/lib/AST/ASTContext.cpp
The file was modifiedclang/include/clang/AST/ASTNodeTraverser.h
The file was modifiedclang/unittests/AST/CMakeLists.txt
The file was modifiedclang/include/clang/AST/ASTTypeTraits.h
The file was modifiedclang/lib/AST/Expr.cpp
Commit 6bf7c345f82a06107a541db80f1ae128844c307c by craig.topper
[X86] Add test case to show incorrect formation of masked add from
vselect+strict_fadd.
The masked operation will suppress exceptions on masked out lanes. But
that's not what vselect+strict_fadd means.
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
Commit f0df4218b67d0abe96867804b8932b9b88998f51 by craig.topper
[X86] Add a simple hack to IsProfitableToFold to prevent vselect+strict
fp operations from being folded into masked instructions.
We really need to update the isel patterns to prevent this, but that
requires some tablegen de-tangling. So this hack will work for
correctness in the short term.
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
The file was modifiedllvm/lib/Target/X86/X86ISelDAGToDAG.cpp
Commit 5094e6dad64c755be1bb797b0307c54dbae8871d by Vedant Kumar
Revert concepts changes from D41910
These changes caused LibcxxVariantDataFormatterTestCase in lldb to fail
with an assert:
Assertion failed: (Idx < size() && "Out-of-bounds Bit access."),
function operator[], file
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h,
line 452.
In:
7  clang-10                 0x00000001094b79d9
isAtLeastAsSpecializedAs(clang::Sema&, clang::SourceLocation,
clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*,
clang::TemplatePartialOrderingContext, unsigned int) + 1865 8  clang-10
               0x00000001094b7111
clang::Sema::getMoreSpecializedTemplate(clang::FunctionTemplateDecl*,
clang::FunctionTemplateDecl*, clang::SourceLocation,
clang::TemplatePartialOrderingContext, unsigned int, unsigned int) + 97
9  clang-10                 0x000000010939bf88
clang::isBetterOverloadCandidate(clang::Sema&, clang::OverloadCandidate
const&, clang::OverloadCandidate const&, clang::SourceLocation,
clang::OverloadCandidateSet::CandidateSetKind) + 1128
Revert "[Concepts] Fix incorrect move out of temporary in D41910"
This reverts commit 11d5fa6e87e3584f72056ecc2b17f88c58323dde.
Revert "[Concepts] Fix crash in D41910"
This reverts commit 12038be20ee6a903cdbd3fddce65535ef683e31d.
Revert "[Concepts] Constrained partial specializations and function
overloads."
This reverts commit fc0731b98a67c793862288f8ae334322666214dc.
The file was modifiedclang/lib/Sema/SemaTemplateInstantiateDecl.cpp
The file was modifiedclang/lib/AST/DeclTemplate.cpp
The file was modifiedclang/lib/Frontend/FrontendActions.cpp
The file was modifiedclang/lib/Sema/SemaTemplate.cpp
The file was modifiedclang/include/clang/Sema/Sema.h
The file was removedclang/test/CXX/temp/temp.constr/temp.constr.order/var-template-partial-specializations.cpp
The file was modifiedclang/include/clang/AST/DeclTemplate.h
The file was modifiedclang/lib/Sema/SemaTemplateInstantiate.cpp
The file was modifiedclang/lib/Serialization/ASTReaderDecl.cpp
The file was removedclang/test/CXX/temp/temp.constr/temp.constr.normal/p1.cpp
The file was modifiedclang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp
The file was removedclang/test/CXX/temp/temp.constr/temp.constr.order/class-template-partial-specializations.cpp
The file was modifiedclang/lib/Sema/SemaTemplateDeduction.cpp
The file was removedclang/test/CXX/temp/temp.constr/temp.constr.order/function-templates.cpp
The file was modifiedclang/lib/Serialization/ASTWriterDecl.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaConcept.cpp
The file was modifiedclang/lib/AST/ASTImporter.cpp
Commit 5ea91bea15dd0cda55b83d108686c3087b479284 by Lang Hames
Revert "[Orc][LLJIT] Use JITLink even if a custom
JITTargetMachineBuilder is supplied."
This reverts commit 298e183e813c884dd22816383405bae3ef9ef278.
This commit caused some build failures -- reverting while I investigate.
The file was modifiedllvm/lib/ExecutionEngine/Orc/LLJIT.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/JITTargetMachineBuilder.h
Commit 6218696bc938ce108da9ddb7b13cb187d0413e86 by noreply
[Docs] Fix a typo
The file was modifiedllvm/docs/TestSuiteGuide.md
Commit 71eb8023d85e5201d32ea24194ec5bc07db23527 by tlively
[WebAssembly] Add avgr_u intrinsics and require nuw in patterns
Summary: The vector pattern `(a + b + 1) / 2` was previously selected to
an avgr_u instruction regardless of nuw flags, but this is incorrect in
the case where either addition may have an unsigned wrap. This CL
changes the existing pattern to require both adds to have nuw flags and
adds builtin functions and intrinsics for the avgr_u instructions
because the corrected pattern is not representable in C.
Reviewers: aheejin
Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish,
cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D71648
The file was modifiedclang/include/clang/Basic/BuiltinsWebAssembly.def
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-arith.ll
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/test/CodeGen/builtins-wasm.c
The file was modifiedllvm/include/llvm/IR/IntrinsicsWebAssembly.td
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-intrinsics.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td