SuccessChanges

Summary

  1. [yaml2obj] - Add testing for OSABI field. (details)
  2. [lldb] Don't process symlinks deep inside DWARFUnit (details)
  3. [yaml2obj] - Add support for ELFOSABI_LINUX. (details)
  4. [yaml2obj] - Allow using an arbitrary value for OSABI. (details)
  5. [lldb] Add sanity check to CreateDeclContext and fixed illformed (details)
  6. [lldb][NFC] Delete all 'else return ...' in CompilerDeclContext.cpp (details)
  7. [lldb][NFC] Remove wrong and unused ClangASTContext::CopyDecl method (details)
  8. [lldb][NFC] Remove unused 'type' parameter in (details)
Commit 2cebc1a7170fc6c0ff3d15e677a59582450eb81d by grimar
[yaml2obj] - Add testing for OSABI field.
We have no such testing. This makes impossible to add support for new
ELFOSABI_* tags.
Differential revision: https://reviews.llvm.org/D71763
The file was addedllvm/test/tools/yaml2obj/ELF/header-osabi.yaml
Commit 3cfb6677b2aa20f782d9bb0f7958e61f5a976c16 by pavel
[lldb] Don't process symlinks deep inside DWARFUnit
Summary: This code is handling debug info paths starting with
/proc/self/cwd, which is one of the mechanisms people use to obtain
"relocatable" debug info (the idea being that one starts the debugger
with an appropriate cwd and things "just work").
Instead of resolving the symlinks inside DWARFUnit, we can do the same
thing more elegantly by hooking into the existing Module path remapping
code. Since llvm::DWARFUnit does not support any similar functionality,
doing things this way is also a step towards unifying llvm and lldb
dwarf parsers.
Reviewers: JDevlieghere, aprantl, clayborg, jdoerfert
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71770
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
Commit 1f985775566dbb7f7b05b923445c50a0e65daece by grimar
[yaml2obj] - Add support for ELFOSABI_LINUX.
ELFOSABI_LINUX is an alias for ELFOSABI_GNU. It is not that obvious
probably.
Differential revision: https://reviews.llvm.org/D71764
The file was modifiedllvm/lib/ObjectYAML/ELFYAML.cpp
The file was modifiedllvm/test/tools/yaml2obj/ELF/header-osabi.yaml
Commit f027e1a68dacfb692b4f3e30abfda529d020d472 by grimar
[yaml2obj] - Allow using an arbitrary value for OSABI.
There was no way to set an unsupported or unknown OS ABI. With this
patch it is possible to use any numeric value.
Differential revision: https://reviews.llvm.org/D71765
The file was modifiedllvm/lib/ObjectYAML/ELFYAML.cpp
The file was modifiedllvm/test/tools/yaml2obj/ELF/header-osabi.yaml
Commit 73951a11c64b4e748bbd1291d5021aef6aa400a5 by Raphael Isemann
[lldb] Add sanity check to CreateDeclContext and fixed illformed
CompilerContext in ClangExpressionDeclMap.
This adds a check that the ClangASTContext actually fits to the
DeclContext that we want to create a CompilerDeclContext for. If the
ClangASTContext (and its associated ASTContext) does not fit to the
DeclContext (that is, the DeclContext wasn't created by the ASTContext),
all computations using this malformed CompilerDeclContext will yield
unpredictable results.
Also fixes the only place that actually hits this assert which is the
construction of a CompilerDeclContext in ClangExpressionDeclMap where we
pass an unrelated ASTContext instead of the ASTContext of the current
expression.
I had to revert my previous change to DWARFASTParserClangTests.cpp back
to using the unsafe direct construction of CompilerDeclContext as this
assert won't work if the DeclContext we pass isn't a valid DeclContext
in the first place.
The file was modifiedlldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
Commit 76d294cb8744b8b15a72d5adb2d435d2265ea9d7 by Raphael Isemann
[lldb][NFC] Delete all 'else return ...' in CompilerDeclContext.cpp
The file was modifiedlldb/source/Symbol/CompilerDeclContext.cpp
Commit a175c6a6f6bd98a5afc3bb90b41362e812134309 by Raphael Isemann
[lldb][NFC] Remove wrong and unused ClangASTContext::CopyDecl method
The file was modifiedlldb/include/lldb/Symbol/ClangASTContext.h
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
Commit b6c29d9de027692cfe93a4f701cf49f1d5f99574 by Raphael Isemann
[lldb][NFC] Remove unused 'type' parameter in
ClangExpressionDeclMap::FindGlobalVariable
We never pass something else than a nullptr as the 'type' so the related
code in this function is never reached.
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp