SuccessChanges

Summary

  1. Revert "[msan] Check qsort input." (details)
  2. Allow newlines in AST Matchers in clang-query files (details)
  3. [X86] Add custom widening for v2f64->v2i32 strict_fp_to_uint with (details)
  4. [ELF] Improve the condition to create .interp (details)
  5. [X86] Add custom widening for v2i32->v2f64 strict_uint_to_fp with (details)
  6. Add a clang-tidy configuration file for MLIR, it is using camelBack for (details)
  7. [ELF][test] Fix dynamic-linker.s (details)
  8. Revert "Make lazyload_metadata.ll resilient to the addition of new (details)
  9. [X86] Custom widen 128/256-bit vXi32 uint_to_fp on avx512f targets (details)
  10. Make lazyload_metadata.ll resilient to the addition of new metadata (details)
  11. Fix -Wunused-lambda-capture warnings. (details)
  12. Remove SrcVT only used in an assert and propagate query. (details)
  13. [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (details)
  14. add custom operation for strict fpextend/fpround (details)
  15. Revert "Allow newlines in AST Matchers in clang-query files" + 1 (details)
  16. Remove unused static function. (details)
  17. Fix a -Wcovered-switch-default warning by moving the unreachable out of (details)
  18. Remove an unused static function. (details)
  19. Fix a -Wcovered-switch-default warning by moving the unreachable out of (details)
  20. Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned (details)
  21. Add an __attribute__((unused)) to populateWithGenerated since it might (details)
Commit 04926e67fda210c9709da4f8672ac0b5147ebb90 by eugenis
Revert "[msan] Check qsort input."
This change breaks LLVM bootstrap with ASan and MSan.
FAILED: lib/ToolDrivers/llvm-lib/Options.inc OptParser.td:137:1: error:
Option is equivalent to def INPUT : Option<[], "<input>", KIND_INPUT>;
^ OptParser.td:137:1: error: Other defined here def INPUT : Option<[],
"<input>", KIND_INPUT>;
This reverts commit caa48a6b88aeed8ae80e6ddb1eae8c6a7cbe260b.
The file was modifiedcompiler-rt/test/msan/qsort.cpp
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
Commit 522ee29a4fb3814db604b585c8637247477ec057 by steveire
Allow newlines in AST Matchers in clang-query files
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71842
The file was modifiedclang-tools-extra/clang-query/Query.h
The file was modifiedclang-tools-extra/clang-query/QueryParser.cpp
The file was modifiedclang/unittests/ASTMatchers/Dynamic/ParserTest.cpp
The file was modifiedclang-tools-extra/clang-query/tool/ClangQuery.cpp
The file was modifiedclang-tools-extra/clang-query/Query.cpp
The file was modifiedclang/lib/ASTMatchers/Dynamic/Parser.cpp
The file was modifiedclang-tools-extra/unittests/clang-query/QueryParserTest.cpp
The file was modifiedclang/include/clang/ASTMatchers/Dynamic/Parser.h
Commit bb0138729b8d4af3d8bd888c821ff79f1350f045 by craig.topper
[X86] Add custom widening for v2f64->v2i32 strict_fp_to_uint with
avx512f, but not avx512vl.
AVX512F added instruction for vector fp_to_uint conversions. With
AVX512VL we can use a specific instruction that does v2f64->v4i32 with
zeroes in the 2 extra elements. For non-strict nodes without AVX512VL we
relied on type legalization to turn it to v4f64->v4i32 which would later
be widened by op legalization to v8f64->v8i32. But type legalization
doesn't currently widen strict nodes since it doesn't know how to safely
and efficiently pad the extra elements. But for X86 we know padding with
zeroes is safe and efficient so do that ourselves.
The file was modifiedllvm/test/CodeGen/X86/vec-strict-fptoint-128.ll
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 1417558e4a61794347c6bfbafaff7cd96985b2c3 by maskray
[ELF] Improve the condition to create .interp
Similar to rL362355, but with the `!config->shared` guard.
(1) {gcc,clang} -fuse-ld=bfd -pie -fPIE -nostdlib a.c => .interp created
(2) {gcc,clang} -fuse-ld=lld -pie -fPIE -nostdlib a.c => .interp not
created
(3) {gcc,clang} -fuse-ld=lld -pie -fPIE -nostdlib a.c a.so => .interp
created
The inconsistency of (2) is due to the condition
`!Config->SharedFiles.empty()`. To make lld behave more like ld.bfd, we
could change the condition to:
    config->hasDynSymTab && !config->dynamicLinker.empty() &&
script->needsInterpSection();
However, that would bring another inconsistency as can be observed with:
(4) {gcc,clang} -fuse-ld=bfd -no-pie -nostdlib a.c => .interp not
created
The file was modifiedlld/ELF/Writer.cpp
The file was modifiedlld/test/ELF/dynamic-linker.s
The file was modifiedlld/test/ELF/ppc64-func-entry-points.s
Commit 90ff34e6ab38a333b16890c0d4b7ca891d213652 by craig.topper
[X86] Add custom widening for v2i32->v2f64 strict_uint_to_fp with
AVX512F, but not AVX512VL.
Previously we were widening with isel patterns, but that wasn't
exception safe for strict FP. So now we widen to v4i32->v4f64 during
type legalization. And then let op legalization further widen to
v8i32->v8f64.
The vec_int_to_fp.ll changes are caused by us no longer narrowing
extracts of strict_uint_to_fp to the v4i32->v2f64 instruction without
AVX512VL only to have isel rewiden it. Now we just keep it wide
throughout. So we don't have an opportunity to narrow the load.
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vec_int_to_fp.ll
The file was modifiedllvm/test/CodeGen/X86/vec-strict-inttofp-128.ll
The file was modifiedllvm/lib/Target/X86/X86InstrAVX512.td
Commit b52cb5688b618a751c80e6d7ca2d1cae486c713d by aminim
Add a clang-tidy configuration file for MLIR, it is using camelBack for
naming at the moment
The file was addedmlir/.clang-tidy
Commit 019a92bb2832447092bb5c1faf9d03bb03b8c9c8 by maskray
[ELF][test] Fix dynamic-linker.s
The file was modifiedlld/test/ELF/dynamic-linker.s
Commit ad1f7a895ba452ae8d9d0743bdbf8337cf36c5d9 by rnk
Revert "Make lazyload_metadata.ll resilient to the addition of new
metadata kinds"
This reverts commit be4704bd41a4dd8bb5c4dd5a614744c69fb3cf8e.
This test fails on Windows without awk.
The file was modifiedllvm/test/ThinLTO/X86/lazyload_metadata.ll
Commit f953882113d089206821ad3113a48d873b7c7f23 by craig.topper
[X86] Custom widen 128/256-bit vXi32 uint_to_fp on avx512f targets
without avx512vl. Similar for vXi64 sint_to_fp/uint_to_fp on avx512dq
without avx512vl.
Previously we widened these through isel patterns, but that didn't work
for STRICT_ nodes. Those need to be padded with zeroes in the upper bits
which is harder to do in isel patterns.
The file was modifiedllvm/test/CodeGen/X86/vec-strict-inttofp-128.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
The file was modifiedllvm/lib/Target/X86/X86InstrAVX512.td
The file was modifiedllvm/test/CodeGen/X86/vec-strict-inttofp-256.ll
Commit 4e5d134da1cf948f02fc283adc65c723c6672eaa by david
Make lazyload_metadata.ll resilient to the addition of new metadata
kinds
Summary: The specific number of records loaded depends on the number of
kinds, but the difference between the lazy and not lazy cases does not.
Reviewers: modocache
Subscribers: llvm-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71882
The file was modifiedllvm/test/ThinLTO/X86/lazyload_metadata.ll
Commit 2369560f4a7720b19edfbf9de14ef061307ff773 by echristo
Fix -Wunused-lambda-capture warnings.
The file was modifiedclang-tools-extra/clang-query/QueryParser.cpp
The file was modifiedclang/lib/ASTMatchers/Dynamic/Parser.cpp
Commit 1584e2f9870fb95169cd4ea7aedc05bfabe28cf6 by echristo
Remove SrcVT only used in an assert and propagate query.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 78f714f824fac8aa3fdd85908c41538bccefb959 by n54
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Summary: Add support for NetBSD 9.0 and newer versions of interceptors
operating on struct statvfs: fstatvfs, fstatvfs1, getmntinfo,
getvfsstat, statvfs, statvfs1.
The default promoted interceptors are for NetBSD 9.99.26. Older ones
(currently 9.0) are kept in a new NetBSD specific file:
/sanitizer_common_interceptors_netbsd_compat.inc. This file defines
compat interceptors and mangles `INIT_*` macros, concatenating the
current interceptors and the compat ones. This redefinition is not
elegant, but it avoids preprocessor madness.
Define struct_statvfs90_sz for the compat purposes.
Reviewers: mgorny, kcc, vitalybuka, joerg
Reviewed By: mgorny
Subscribers: dberris, llvm-commits, #sanitizers
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D71700
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h
The file was addedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_netbsd_compat.inc
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cpp
Commit 1a7b69f5dd32980a7e0b0841a99dc65b2b887203 by chen3.liu
add custom operation for strict fpextend/fpround
Differential Revision: https://reviews.llvm.org/D71892
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
The file was modifiedllvm/test/CodeGen/X86/vec-strict-128.ll
The file was modifiedllvm/lib/Target/X86/X86InstrAVX512.td
The file was modifiedllvm/lib/Target/X86/X86InstrSSE.td
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.h
The file was modifiedllvm/lib/Target/X86/X86InstrFragmentsSIMD.td
Commit 5ca97d0defeed38feec2352692f6bb80297d6712 by eugenis
Revert "Allow newlines in AST Matchers in clang-query files" + 1
Revert "Fix -Wunused-lambda-capture warnings." This reverts commit
2369560f4a7720b19edfbf9de14ef061307ff773. This reverts commit
522ee29a4fb3814db604b585c8637247477ec057.
clang/lib/ASTMatchers/Dynamic/Parser.cpp:610:13: warning: implicit
conversion turns string literal into bool: 'const char [35]' to 'bool'
[-Wstring-conversion]
   assert(!"Newline should never be found here");
The file was modifiedclang-tools-extra/clang-query/tool/ClangQuery.cpp
The file was modifiedclang-tools-extra/clang-query/QueryParser.cpp
The file was modifiedclang/unittests/ASTMatchers/Dynamic/ParserTest.cpp
The file was modifiedclang-tools-extra/clang-query/Query.cpp
The file was modifiedclang/include/clang/ASTMatchers/Dynamic/Parser.h
The file was modifiedclang-tools-extra/clang-query/Query.h
The file was modifiedclang/lib/ASTMatchers/Dynamic/Parser.cpp
The file was modifiedclang-tools-extra/unittests/clang-query/QueryParserTest.cpp
Commit 30617e4b9c871882c6fc765d12eb85c1aba87139 by echristo
Remove unused static function.
The file was modifiedmlir/lib/Dialect/VectorOps/VectorTransforms.cpp
Commit 3009cee75f04fb2bb28fbe7fc33cff3782c0f882 by echristo
Fix a -Wcovered-switch-default warning by moving the unreachable out of
the covered switch.
The file was modifiedmlir/lib/Dialect/StandardOps/Ops.cpp
Commit 3d18ce71548a84f5ed69585d084964fafda14a82 by echristo
Remove an unused static function.
The file was modifiedmlir/lib/Dialect/StandardOps/Ops.cpp
Commit e1838a17898aba53282f14a39aa01af5992b8f21 by echristo
Fix a -Wcovered-switch-default warning by moving the unreachable out of
the covered switch.
The file was modifiedmlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
Commit 8f9304f559adf90a21e667f2af0f191cb4a057ac by echristo
Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned
statvfs interceptors" as it's failing the netbsd specific linter parts
of the sanitizer linter:
llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_netbsd_compat.inc:23:
Lines should be <= 80 characters long  [whitespace/line_length]
llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cpp:2450:
Do not use variable-length arrays.  Use an appropriately named ('k'
followed by CamelCase) compile-time constant for the size.
This reverts commit 78f714f824fac8aa3fdd85908c41538bccefb959.
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cpp
The file was removedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_netbsd_compat.inc
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
Commit 371038e3ff724238a99fe6d8a16dca2d79e5c036 by echristo
Add an __attribute__((unused)) to populateWithGenerated since it might
not be used where defined and is autogenerated.
The file was modifiedmlir/tools/mlir-tblgen/RewriterGen.cpp