Changes

disable ZLib on the LLDB builder
Although there is a zlib library installed on the host, the headers are 
not.  ZLIB was previously disabled, but the library detection now is 
kicking in, and incorrectly enabling ZLIB.  Explicitly disable ZLIB 
support.

[PowerPC][NFC] Fix clang-tidy warning
Reported by 
https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-726/clang-tidy.txt
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11672:10: 
warning: invalid case style for variable 'isEQ'
[readability-identifier-naming]
   bool isEQ = (MI.getOpcode() == PPC::ANDI_rec_1_EQ_BIT ||
        ^~~~
        IsEq
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11679:14: 
warning: invalid case style for variable 'dl'
[readability-identifier-naming]
   DebugLoc dl = MI.getDebugLoc();
            ^~
            Dl

Revert "[InstCombine] Fix infinite loop due to bitcast <-> phi
transforms"
This reverts commit 27a0795943fee0f30b995fe5165428afc2dfd402.
Seems to break test-suite.

[Attributor][Fix] Avoid leaking memory after D68765

Match code following lambdas when ignoring invisible nodes
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71976

Unnest struct in Matcher implementation
This allows implementation of the traverse() matcher to surround 
matchers like unless().

Implement additional traverse() overloads
Summary: These overloads make it possible to wrap unless(), anyOf(),
has() etc with the traverse matcher.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71977

[InstCombine] add/adjust tests for masked bit; NFC

[InstCombine] fold zext of masked bit set/clear
This does not solve PR17101, but it is one of the underlying diffs noted
here: https://bugs.llvm.org/show_bug.cgi?id=17101#c8
We could ease the one-use checks for the 'clear'
(no 'not' op) half of the transform, but I do not know if that asymmetry
would make things better or worse.
Proofs: https://rise4fun.com/Alive/uVB
  Name: masked bit set
 %sh1 = shl i32 1, %y
 %and = and i32 %sh1, %x
 %cmp = icmp ne i32 %and, 0
 %r = zext i1 %cmp to i32
 =>
 %s = lshr i32 %x, %y
 %r = and i32 %s, 1
  Name: masked bit clear
 %sh1 = shl i32 1, %y
 %and = and i32 %sh1, %x
 %cmp = icmp eq i32 %and, 0
 %r = zext i1 %cmp to i32
 =>
 %xn = xor i32 %x, -1
 %s = lshr i32 %xn, %y
 %r = and i32 %s, 1

[mlir] Make code blocks more consistent
Use the same form specification for the same type of code.

[CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if
possible.
We already recognize the __builtin versions of these, might as well 
recognize the libcall version.
Differential Revision: https://reviews.llvm.org/D72028

[X86] Add test case for opposite branch condition for PR44412. NFC

[mlir][docs] Remove redundant path prefix
./ is not needed.

[OPENMP]Emit artificial threprivate vars as threadlocal, if possible.
It may improve performance for declare reduction constructs.

[amdgpu] Fix scoreboard updating on `s_waitcnt_vscnt`.
Summary: - Other counters are accidentally cleared.
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl,
dstuttard, tpr, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71866

Revert "[Diagnostic] Add ftabstop to -Wmisleading-indentation"
This reverts commit b47b35ff51b355a446483777155290541ab64fae.
This caused failed asserts (Assertion `FIDAndOffset.second > ColNo &&
"Column number smaller than file offset?"' failed.) on a source file
with a single line containing
"int main (void) { for( int i = 0; i < 9; i++ ); return 0; }".

AMDGPU: Precommit test showing extra instructions are introduced

[LegalizeVectorOps][AArch64] Stop asking for v4f16 fp_round and
fp_extend to be promoted.
These operations are needed as building blocks for promoting so they 
can't be promoted themselves.
This appeared to work because the fp_extend query type for operation 
actions is the result type, not the input type so it never triggered in
the legalizer.
For fp_round, the vector op legalizer just ended up creating a nop
fp_extend that was elided by getNode, followed by a nop fp_round that
was also elided by getNode. This was followed by a final fp_round from
v4f32 back to vf416 which was CSEd to the original node. Then legalize
vector ops just believed that node legalized to itself. LegalizeDAG took
another crack at promoting it, but didn't have a handler so just skipped
it with a debug message saying it wasn't promoted.
This patch just removes the operation actions to avoid this non-sense.
Found while trying to refactor LegalizeVectorOps to handle multiple
result nodes better.

[X86] Use carry flag from add for (seteq (add X, -1), -1).
If we just subtracted 1 and are checking if the result is -1. We can use
the carry flag from the ADD instead of an explicit CMP. I'm using the
same checks for the add users as EmitTest.
Fixes one case from PR44412
Differential Revision: https://reviews.llvm.org/D72019

[X86][InstCombine] Add constant folding and simplification support for
pdep and pext
The instructions use a mask to either pack disjoint bits together(pext)
or spread bits to disjoint locations(pdep). If the mask is all 0s then
no bits are extracted or deposited. If the mask is all ones, then the
source value is written to the result since no compression or expansion
happens. Otherwise if both the source and mask are constant we can walk
the bits in the source/mask and calculate the result.
There other crazier things we could do like computeKnownBits or turning
pext into shift/and if only a single contiguous range of bits is
extracted.
Fixes PR44389
Differential Revision: https://reviews.llvm.org/D71952

[X86] Constant fold KSHIFT of an all zeros vector to just an all zeros
vector.

[ELF][RISCV] Improve error message for unknown relocations
Like rLLD354040.

DAG: Stop trying to fold FP -(x-y) -> y-x in getNode with nsz
This was increasing the number of instructions when fsub was legalized 
on AMDGPU with no signed zeros enabled. This fold should be guarded by 
hasOneUse, and I don't think getNode should be doing that. The same fold
is already done as a regular combine through isNegatibleForFree.
This does require duplicating, even though isNegatibleForFree does this
combine already (and properly checks hasOneUse) to avoid one PPC 
regression. In the regression, the outer fneg has nsz but the fsub 
operand does not. isNegatibleForFree only sees the operand, and doesn't
see it's used from a nsz context. A nsz parameter needs to be added and
threaded through isNegatibleForFree to avoid this.

[X86] Add X87 FCMOV support to X86FlagsCopyLowering.
Fixes PR44396

[X86] Fix typo in getCMovOpcode.
The 64-bit HasMemoryOperand line was using CMOV32rm instead of CMOV64rm.
Not sure how to test this. We have no test coverage that passes true for
HasMemoryOperand.

[Attributor] AAValueConstantRange: Value range analysis using constant
range
This patch introduces `AAValueConstantRange`, which answers a possible
range for integer value in a specific program point. One of the
motivations is propagating existing `range` metadata. (I think we need
to change the situation that `range` metadata cannot be put to
Argument).
The state is a tuple of `ConstantRange` and it is initialized to (known,
assumed) = ([-∞, +∞], empty).
Currently, AAValueConstantRange is created when AAValueSimplify cannot 
simplify the value.
Supported
- BinaryOperator(add, sub, ...)
- CmpInst(icmp eq, ...)
- !range metadata
`AAValueConstantRange` is not intended to extend to polyhedral range
value analysis.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D71620

[ELF][RISCV][test] Test absolute/PC-relative/branch relocations to
undefined weak symbols

[MC][TargetMachine] Delete MCTargetOptions::MCPIECopyRelocations
clang/lib/CodeGen/CodeGenModule performs the -mpie-copy-relocations 
check and sets dso_local on applicable global variables. We don't need 
to duplicate the work in TargetMachine shouldAssumeDSOLocal.
Verified that -mpie-copy-relocations can still emit PC relative 
relocations for external variable accesses.
clang -target x86_64 -fpie -mpie-copy-relocations -c => R_X86_64_PC32 
clang -target aarch64 -fpie -mpie-copy-relocations -c =>
R_AARCH64_ADR_PREL_PG_HI21+R_AARCH64_LDST64_ABS_LO12_NC

add strict float for round operation
Differential Revision: https://reviews.llvm.org/D72026

clang-tidy doc: Remove severities as they don't make consensus
Reviewers: jdoerfert, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: whisperity, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72049

[ARM] Add +mve feature to mve tests. NFC

[lldb][NFC] Make some checks more readable in
Variable::PrivateAutoComplete

[NFC] Fixes -Wrange-loop-analysis warnings
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to
-Wall.
Differential Revision: https://reviews.llvm.org/D71857

Adds fixit hints to the -Wrange-loop-analysis
Differential Revision: https://reviews.llvm.org/D68913

Improve Wrange-loop-analyses for rvalue reference
The Wrange-loop-analyses warns if a copy is made. Suppress this warning
when a temporary is bound to a rvalue reference.
While fixing this issue also found a copy-paste error in test6, which is
also fixed.
Differential Revision: https://reviews.llvm.org/D71806

Adds -Wrange-loop-analysis to -Wall
This makes the range loop warnings part of -Wall.
Fixes PR32823: Warn about accidental coping of data in range based for
Differential Revision: https://reviews.llvm.org/D68912

[X86] Call SimplifyMultipleUseDemandedBits from combineVSelectToBLENDV
if the condition is used by something other than select conditions.
We might be able to bypass some nodes on the condition path.
Differential Revision: https://reviews.llvm.org/D71984

[InstCombine] Add tests for sub nuw of geps; NFC
Tests for PR44419.

[InstCombine] Regenerate test checks; NFC

[InstCombine] Add tests for PR44423 and PR44425; NFC

[MachineScheduler] improve reuse of 'releaseNode'method
The 'SchedBoundary::releaseNode' is merely invoked for releasing the
Top/Bottom root nodes. However,  'SchedBoundary::releasePending' uses
its same logic to check if the Pending queue has any releasable SUnit. 
It is possible to slightly modify the body of the two, allowing re-use
of the former ('releaseNode') in the latter.
Patch by Lorenzo Casalino <lorenzo.casalino93@gmail.com>
Reviewers: MatzeB, fhahn, atrick
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D65506

[InstCombine] Fix incorrect inbounds on GEP of GEP (PR44425)
This fixes https://bugs.llvm.org/show_bug.cgi?id=44425. We need to drop
inbounds if one of the GEPs is not inbounds. This was already done when
creating a new GEP, but not when modifying in place.
Differential Revision: https://reviews.llvm.org/D72059

Revert "Adds -Wrange-loop-analysis to -Wall"
The sanitizer-x86_64-linux buildbot failed to build lld with -Werror.
This reverts commit d8117542ac57f6051674ca70ea14c0e0d7d9b046.

[lldb][NFC] Simplify CompilerType constructors/destructors and fix
unused variable warning
CompilerType has no virtual functions and no statements in its
constructors, so we can simplify this code. This also allows Clang to
emit unused variable warnings for CompilerType, so I also removed one
unused variable that otherwise causes -Werror builds to fail.

[InstCombine] Preserve inbounds when merging with zero-index GEP
(PR44423)
This addresses https://bugs.llvm.org/show_bug.cgi?id=44423. If one of
the GEPs is inbounds and the other is zero-index, we can also preserve
inbounds.
Differential Revision: https://reviews.llvm.org/D72060

tests: XFAIL/UNSUPPORTED tests on Windows
Now that we are building the python bindings on Windows once more, the 
extended testsuite is running.  Mark a few failing tests and skip a few 
tests which hang.  This should at least bring the bot back to green 
without reverting the Python changes which are an improvement for the 
build system and enable another ~35% of the test suite which was 
previously disabled.

[mlir] Fix warnings when compiling with Clang 9.0
Fixes: warning: comparison of integers of different signs: 'const
unsigned int' and '(anonymous namespace)::OperationPrinter::(anonymous
enum at F:\llvm-project\mlir\lib\IR\AsmPrinter.cpp:1444:3)'
[-Wsign-compare]

[mlir] Fix linking with LLD
The issue is that /WHOLEARCHIVE is interpreted differently in LLD, which
needs the same exact path as the .lib; whereas link.exe can take the
library name, withoutout a path or extension, if that was already
supplied on the cmd-line. I'll write a follow-up patch to fix the issue
in LLD.

[mlir] Fix compilation warnings
Fixes:
- (MSVC)
F:\llvm-project\mlir\lib\Dialect\Linalg\Analysis\DependenceAnalysis.cpp(103):
warning C4551: function call missing argument list
- (Clang) tools\mlir\lib\Dialect\SPIRV\SPIRVCanonicalization.inc(232,1):
warning: unused function 'populateWithGenerated' [-Wunused-function]

[polly][Support] Un-break polly tests Previously, the polly unit tests
were stuck in a infinite loop. There was an edge case in
StringRef::count() introduced by
9f6b13e5cce96066d7262d224c971d93c2724795, where an empty 'Str' would
cause the function to never exit. Also fixed usage in polly.

[lld] Fix -Wrange-loop-analysis warnings
One instance looks like a false positive:
lld/ELF/Relocations.cpp:1622:14: note: use reference type 'const
std::pair<ThunkSection *, uint32_t> &' (aka 'cons t
pair<lld::elf::ThunkSection *, unsigned int> &') to prevent copying
       for (const std::pair<ThunkSection *, uint32_t> ts :
isd->thunkSections)
It is not changed in this commit.

[mlir] Fix -Wrange-loo-analysis warnings
for (const auto &x : llvm::zip(..., ...))
->
for (auto x : llvm::zip(..., ...))
The return type of zip() is a wrapper that wraps a tuple of references.
> warning: loop variable 'p' is always a copy because the range of type
'detail::zippy<detail::zip_shortest, ArrayRef<long> &, ArrayRef<long>
&>' does not return a reference [-Wrange-loop-analysis]

build: reduce CMake handling for zlib
Rather than handling zlib handling manually, use `find_package` from
CMake to find zlib properly. Use this to normalize the
`LLVM_ENABLE_ZLIB`,
`HAVE_ZLIB`, `HAVE_ZLIB_H`. Furthermore, require zlib if
`LLVM_ENABLE_ZLIB` is set to `YES`, which requires the distributor to
explicitly select whether zlib is enabled or not. This simplifies the
CMake handling and usage in the rest of the tooling.

build: make `LLVM_ENABLE_ZLIB` a tri-bool for users
Treat the flag `LLVM_ENABLE_ZLIB` as a tri-bool, `FORCE_ON` being `ON`, 
and `ON` being an auto-detect.  This is needed as many of the builders 
enable the flag without having zlib available.

[Coroutines] Rename "legacy" passes (NFC)
A series of patches beginning with https://reviews.llvm.org/D71898 
propose to add an implementation of the coroutine passes to the new pass 
manager. As part of these changes, the coroutine passes that implement 
the legacy pass manager interface are renamed, to `<PassName>Legacy`. 
This mirrors similar changes that have been made to many other passes in 
LLVM as they've been transitioned to support both old and new pass 
managers.
This commit splits out the renaming portion of that patch and commits it 
in advance as an NFC (no functional change intended) commit. It renames:
* `CoroEarly` => `CoroEarlyLegacy`
* `CoroSplit` => `CoroSplitLegacy`
* `CoroElide` => `CoroElideLegacy`
* `CoroCleanup` => `CoroCleanupLegacy`

[RegisterClassInfo] Use SmallVector::assign instead of resize to make
sure we erase previous contents from all entries of the vector.
resize only writes to elements that get added. Any elements that already
existed maintain their previous value. In this case we're trying to
erase cached information so we should use assign which will write to
every element.
Found while trying to add new tests to an existing X86 test and
noticed register allocation changing in other functions.

[X86] Add test cases for regcall function that takes a long double as a
parameter, but does not return a long double.
I believe we are incorrectly doing some FP stack manipulations after the
call.

[Coroutines] const-ify internal helpers (NFC)
Several helpers internal to llvm/Transforms/Coroutines do not use
'const' for parameters that are not modified. Add const where possible.

[gn build] (manually) merge 68a235d07f9e70

[X86] Add x86_regcallcc calling convention to function declaration
recently added in a test.
The callsite had the calling convention, but not the function itself.

[mlir][spirv] Fix links in docs and update dialect docs
Summary: This commit fixes links to code directories and uses doc links
on mlir.llvm.org where possible. The docs in TableGen dialect definition 
is also updated to reflect recent developments.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72051

[mlir][spirv] NFC: Move shader ABI attributes to a new file
This allows us to include the definitions of these attributes in other
files without pulling in all dependencies for lowering.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72054