1. [flang][NFC] Change how error symbols are recorded (details)
Commit 627e9007eaba39624fe92a4d97dceb18bc51f190 by tkeith
[flang][NFC] Change how error symbols are recorded

When an error is associated with a symbol, it was marked with a flag
from Symbol::Flag. The problem with that is that you need a mutable
symbol to do that. Instead, store the set of error symbols in the
SemanticsContext. This allows for some const_casts to be eliminated.

Also, improve the internal error that occurs if SetError is called
but no fatal error has been reported.

Differential Revision:
The file was modifiedflang/lib/Semantics/expression.cpp (diff)
The file was modifiedflang/lib/Semantics/tools.cpp (diff)
The file was modifiedflang/lib/Semantics/semantics.cpp (diff)
The file was modifiedflang/lib/Semantics/type.cpp (diff)
The file was modifiedflang/lib/Semantics/resolve-names.cpp (diff)
The file was modifiedflang/include/flang/Semantics/type.h (diff)
The file was modifiedflang/include/flang/Semantics/semantics.h (diff)
The file was modifiedflang/include/flang/Semantics/symbol.h (diff)