SuccessChanges

Summary

  1. CallingConvLower.h - remove unnecessary MachineFunction.h include. NFC. (details)
  2. [modules] Correctly parse LateParsedTemplates in case of dependent modules. (details)
  3. [lldb][NFC] Rewrite CPP11EnumTypes test to make it faster (details)
Commit 7582c5c023a8d6bff224e80dc5ded916122d8c99 by llvm-dev
CallingConvLower.h - remove unnecessary MachineFunction.h include. NFC.

Reduce to forward declaration, add the Register.h include that we still needed, move CCState::ensureMaxAlignment into CallingConvLower.cpp as it was the only function that needed the full definition of MachineFunction.

Fix a few implicit dependencies further down.
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/CallLowering.h (diff)
The file was modifiedllvm/lib/CodeGen/CallingConvLower.cpp (diff)
The file was modifiedllvm/lib/Target/Mips/MipsCallLowering.h (diff)
The file was modifiedllvm/include/llvm/CodeGen/CallingConvLower.h (diff)
Commit 2c9dbcda4f71497d4a58020bb093af438fb6e967 by v.g.vassilev
[modules] Correctly parse LateParsedTemplates in case of dependent modules.

While parsing LateParsedTemplates, Clang assumes that the Global DeclID matches
with the Local DeclID of a Decl. This is not the case when we have multiple
dependent modules , each having their own LateParsedTemplate section. In such a
case, a Local/Global DeclID confusion occurs which leads to improper casting of
FunctionDecl's.

This commit creates a Vector to map the LateParsedTemplate section of each
Module with their module file and therefore resolving the Global/Local DeclID
confusion.

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D86514
The file was modifiedclang/lib/Serialization/ASTReader.cpp (diff)
The file was modifiedclang/include/clang/Serialization/ASTReader.h (diff)
Commit 101f37a1b330e3f0ae57762db47bba28f72cf50d by Raphael Isemann
[lldb][NFC] Rewrite CPP11EnumTypes test to make it faster

TestCPP11EnumTypes is one of the most expensive tests on my system and takes
around 35 seconds to run. A relatively large amount of that time is actually
doing CPU intensive work it seems (and not waiting on timeouts like other
slow tests).

The main issue is that this test repeatedly compiles the same source files
with different compiler defines. The test is also including standard library
headers, so it will also build all system modules with the gmodules debug
info variant. This leads to the problem that this test ends up compiling all
system Clang modules 8 times (one for each subtest with a unique define). As
the system modules are quite large, this causes that this test spends most
of its runtime just recompiling all system modules on macOS.

There is also the small issue that this test is starting and start-stopping
the test process a few hundred times.

This rewrites the test to instead just use a macro to instantiate all the
enum types in a single source and uses global variables to test the values
(which means there is no more need to continue/stop or even start a process).

I kept running all the debug info variants (event though it doesn't seem really
relevant) to keep this as NFC as possible.

This reduced the test runtime by around 1.5 seconds on my system (or in relative
numbers, the runtime of this test decreases by 95%).
The file was modifiedlldb/test/API/lang/cpp/enum_types/TestCPP11EnumTypes.py (diff)
The file was modifiedlldb/test/API/lang/cpp/enum_types/main.cpp (diff)