SuccessChanges

Summary

  1. [llvm-readobj/elf] - Introduce Relocation<ELFT> helper. (details)
  2. LegalizeTypes.h - remove orphan SplitVSETCC declaration. NFCI. (details)
  3. [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings. (details)
  4. [MLIR] Fix Win test due to partial order of CHECK directives (details)
  5. [InstCombine] give a name to an intermediate value for easier tracking; NFC (details)
  6. [InstCombine] add test with more unreachable insts; NFC (details)
  7. [SelectionDAG] memcpy expansion of const volatile struct ignores const zero (details)
  8. [X86] Replace EmitX86AddSubSatExpr with EmitX86BinaryIntrinsic generic helper. NFCI. (details)
  9. MachineStableHash.h - remove MachineInstr.h include. NFC. (details)
  10. [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI. (details)
  11. Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings." (details)
Commit 3a86eb03d54ef80cf498d9473a1c735c93cdfa66 by grimar
[llvm-readobj/elf] - Introduce Relocation<ELFT> helper.

It removes templating for Elf_Rel[a] handling that we
introduced earlier and introduces a helper class instead.

It was briefly discussed in D87087, which showed,
why having templates is probably not ideal for the generalization
of dumpers code.

Differential revision: https://reviews.llvm.org/D87141
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp (diff)
Commit e57cbcbdc18adcadc6c97ff4f3f81b0f4b81c698 by llvm-dev
LegalizeTypes.h - remove orphan SplitVSETCC declaration. NFCI.

The implementation no longer exists
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h (diff)
Commit 15acdd75439b402e993ebe0dbf8eb02e9b88bbdc by frgossen
[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings.

Merge the two lowering passes because they are not useful by themselves. The new
pass lowers to `std` and `scf` is considered an auxiliary dialect.

See also
https://llvm.discourse.group/t/conversions-with-multiple-target-dialects/1541/12

Differential Revision: https://reviews.llvm.org/D86779
The file was modifiedmlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp (diff)
The file was removedmlir/test/Conversion/ShapeToSCF/shape-to-scf.mlir
The file was removedmlir/lib/Conversion/ShapeToSCF/CMakeLists.txt
The file was modifiedmlir/include/mlir/Conversion/Passes.h (diff)
The file was removedmlir/lib/Conversion/ShapeToSCF/ShapeToSCF.cpp
The file was modifiedmlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir (diff)
The file was modifiedmlir/include/mlir/Conversion/Passes.td (diff)
The file was removedmlir/include/mlir/Conversion/ShapeToSCF/ShapeToSCF.h
Commit 1c849ec40a53ca017a668b957fef333e560b0886 by ntv
[MLIR] Fix Win test due to partial order of CHECK directives

Differential Revision: https://reviews.llvm.org/D87230
The file was modifiedmlir/test/Conversion/VectorToSCF/vector-to-loops.mlir (diff)
Commit 3ca8b9a560a249a18b9f6092b96aa7e8e52db5cf by spatel
[InstCombine] give a name to an intermediate value for easier tracking; NFC

As noted in PR47430, we probably want to conditionally include 'nsw'
here anyway, so we are going to need to fill out the optional args.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp (diff)
The file was modifiedllvm/test/Transforms/InstCombine/sub.ll (diff)
Commit 28aa60aae25b7e46804deae909b29b66c1b41d95 by spatel
[InstCombine] add test with more unreachable insts; NFC

Goes with D87149
The file was modifiedllvm/test/Transforms/InstCombine/assume.ll (diff)
Commit 79ea83e104e368ef0f520f1bfa74c15d91baef93 by simon.wallis2
[SelectionDAG] memcpy expansion of const volatile struct ignores const zero

In getMemcpyLoadsAndStores(), a memcpy where the source is a zero constant is expanded to a MemOp::Set instead of a MemOp::Copy, even when the memcpy is volatile.
This is incorrect.

The fix is to add a check for volatile, and expand to MemOp::Copy in the volatile case.

Reviewed By: chill

Differential Revision: https://reviews.llvm.org/D87134
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (diff)
The file was addedllvm/test/CodeGen/ARM/memcpy-const-vol-struct.ll
Commit a8a91533dd65041ced68ed5b9348b5d023837488 by llvm-dev
[X86] Replace EmitX86AddSubSatExpr with EmitX86BinaryIntrinsic generic helper. NFCI.

Feed the Intrinsic::ID value directly instead of via the IsSigned/IsAddition bool flags.
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp (diff)
Commit 6670f5d1e66563ad482576d9db4b8393539ab53b by llvm-dev
MachineStableHash.h - remove MachineInstr.h include. NFC.

Use forward declarations and move the include to MachineStableHash.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineStableHash.h (diff)
The file was modifiedllvm/lib/CodeGen/MachineStableHash.cpp (diff)
Commit dbb81881955d641bc873442e75874a5cb160f4ee by grimar
[llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI.

Currently we have 2 large `printDynamicRelocations` methods that
have a very similar code for GNU/LLVM styles.

This patch removes the duplication and renames them to `printDynamicReloc`
for consistency.

Differential revision: https://reviews.llvm.org/D87087
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp (diff)
Commit 973800dc7cbe28a98030293e77afa8ea0343c37d by david.truby
Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings."

This reverts commit 15acdd75439b402e993ebe0dbf8eb02e9b88bbdc.
The file was addedmlir/lib/Conversion/ShapeToSCF/CMakeLists.txt
The file was modifiedmlir/include/mlir/Conversion/Passes.h (diff)
The file was addedmlir/lib/Conversion/ShapeToSCF/ShapeToSCF.cpp
The file was modifiedmlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp (diff)
The file was addedmlir/include/mlir/Conversion/ShapeToSCF/ShapeToSCF.h
The file was modifiedmlir/include/mlir/Conversion/Passes.td (diff)
The file was addedmlir/test/Conversion/ShapeToSCF/shape-to-scf.mlir
The file was modifiedmlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir (diff)