FailedChanges

Summary

  1. [UpdateTestChecks] Allow $ in function names (details)
  2. [aarch64][tests] Add tests which show current lack of implicit null support (details)
  3. [flang][msvc] Work around if constexpr (false) evaluation. NFC. (details)
  4. [X86] Add test case for a masked load mask becoming all ones after type legalization. (details)
  5. [DAGCombiner] Teach visitMLOAD to replace an all ones mask with an unmasked load (details)
  6. [lsan] Share platform allocator settings between ASan and LSan (details)
Commit ce0eb81c72749d1e96cfc6fb68af3c24b63753cc by David A Greene
[UpdateTestChecks] Allow $ in function names

Some compilers generation functions with '$' in their names, so recognize those
functions.

This also requires recognizing function names inside quotes in some contexts in
order to escape certain characters.

Differential Revision: https://reviews.llvm.org/D82995
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/aarch64_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/riscv_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/mips_function_name.ll.expected
The file was modifiedllvm/utils/UpdateTestChecks/asm.py (diff)
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/wasm-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/x86-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/hexagon_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/lanai-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/ppc-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/msp430_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/hexagon_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/mips_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/ppc_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/sparc_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/hexagon-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/wasm_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/msp430_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/msp430-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/riscv_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/mips-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/aarch64-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/wasm_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/ppc_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/aarch64_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/sparc_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/amdgpu-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/lanai_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/systemz_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/sparc-function-name.test
The file was modifiedllvm/utils/UpdateTestChecks/common.py (diff)
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_function_name.ll
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/arm-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/systemz-function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/systemz_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/function-name.test
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/lanai_function_name.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_llc_test_checks/riscv-function-name.test
Commit 7af4f44c3e3dfb4483fb4dcc200f9376e96d6208 by listmail
[aarch64][tests] Add tests which show current lack of implicit null support

I will be posting a patch which adds appropriate target support shortly; landing the tests so that the diffs are clear.
The file was addedllvm/test/CodeGen/AArch64/implicit-null-check.ll
Commit dee4686227842aa0e8380c7925049a5df9c4f781 by llvm-project
 [flang][msvc] Work around if constexpr (false) evaluation. NFC.

MSVC tries to expand templates that are in the false-branch of a `if constexpr` construct. In this case, the condition checks whether a tuple has at least one element and then is trying to access it using `std::get<0>`, which fails when the tuple has 0 elements.

The workaround is to extract that case into a separate method.

This patch is part of the series to make flang compilable with MS Visual Studio <http://lists.llvm.org/pipermail/flang-dev/2020-July/000448.html>.

Reviewed By: klausler

Differential Revision: https://reviews.llvm.org/D87728
The file was modifiedflang/lib/Parser/basic-parsers.h (diff)
Commit 65ef2e50a29630f9f0fba4899045c0058dacfcb0 by craig.topper
[X86] Add test case for a masked load mask becoming all ones after type legalization.

We should be able to turn this into a unmasked load. X86 has an
optimization to detect that the first and last element aren't masked
and then turn the whole thing into an unmasked load and a blend.
That transform is disabled on avx512 though.

But if we know the blend isn't needed, then the unmasked load by
itself should always be profitable.
The file was modifiedllvm/test/CodeGen/X86/masked_load.ll (diff)
Commit 89ee4c0314bd08143d954d80bf7678d3a3ecc15a by craig.topper
[DAGCombiner] Teach visitMLOAD to replace an all ones mask with an unmasked load

If we have an all ones mask, we can just a regular masked load. InstCombine already gets this in IR. But the all ones mask can appear after type legalization.

Only avx512 test cases are affected because X86 backend already looks for element 0 and the last element being 1. It replaces this with an unmasked load and blend. The all ones mask is a special case of that where the blend will be removed. That transform is only enabled on avx2 targets. I believe that's because a non-zero passthru on avx2 already requires a separate blend so its more profitable to handle mixed constant masks.

This patch adds a dedicated all ones handling to the target independent DAG combiner. I've skipped extending, expanding, and index loads for now. X86 doesn't use index so I don't know much about it. Extending made me nervous because I wasn't sure I could trust the memory VT had the right element count due to some weirdness in vector splitting. For expanding I wasn't sure if we needed different undef handling.

Differential Revision: https://reviews.llvm.org/D87788
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (diff)
The file was modifiedllvm/test/CodeGen/X86/masked_load.ll (diff)
Commit c57df3dc09e8b59c55c83ba5c354569a82a5c3b8 by phosek
[lsan] Share platform allocator settings between ASan and LSan

This moves the platform-specific parameter logic from asan into
sanitizer_common so lsan can reuse it.

Patch By: mcgrathr

Differential Revision: https://reviews.llvm.org/D85930
The file was modifiedcompiler-rt/lib/lsan/lsan_allocator.h (diff)
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_allocator.h (diff)
The file was modifiedcompiler-rt/lib/asan/asan_allocator.h (diff)