Changes

MemTag: stack initializer merging.
Summary: MTE provides instructions to update memory tags and data at the
same time. This change makes use of those to generate more compact code
for stack variable tagging + initialization.
We collect memory store and memset instructions following an alloca or a 
lifetime.start call, and replace them with the corresponding MTE 
intrinsics. Since the intrinsics work on 16-byte aligned chunks, the 
stored values are combined as necessary.
Reviewers: pcc, vitalybuka, ostannard
Subscribers: srhines, javed.absar, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66167
llvm-svn: 369297

Recommit "[llvm-objcopy][MachO] Support load commands used in
executables/shared libraries"
Summary: This patch implements copying some load commands that appear in
executables/shared libraries such as the indirect symbol table.
I don't add tests intentionally because this patch is incomplete: we
need a layout algorithm for executables/shared libraries. I'll submit it
as a separate patch with tests.
Reviewers: alexshap, rupprecht, jhenderson, compnerd
Reviewed By: alexshap
Subscribers: abrachet, mgorny, mgrang, MaskRay, mtrent, jakehehrlich,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D63395
llvm-svn: 369298

Fixed placement of llvm.global_dtors on Windows.
Differential revision: https://reviews.llvm.org/D66373
llvm-svn: 369299

Refactor isPointerOffset (NFC).
Summary: Simplify the API using Optional<> and address comments in
        https://reviews.llvm.org/D66165
Reviewers: vitalybuka
Subscribers: hiraditya, llvm-commits, ostannard, pcc
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66317
llvm-svn: 369300

Recommit "[llvm-objcopy][MachO] Implement a layout algorithm for
executables"
Summary: The layout algorithm for relocatable objects and for executable
are somewhat different. This patch implements the latter one based on
the algorithm in LLD (MachOFileLayout).
Reviewers: alexshap, rupprecht, jhenderson
Reviewed By: alexshap
Subscribers: jakehehrlich, abrachet, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65539
llvm-svn: 369301

Recommit "[Attributor] Fix: Do not partially resolve returned calls."
This reverts commit b1752f670f3d6393306dd5d37546b6e23384d8a2.
Fixed the issue with a different commit, reapply this one as it was, 
afaik, not broken.
llvm-svn: 369303

Fix use-after-free
Summary: The warning
``` lldb/source/Core/FormatEntity.cpp:2350:25: warning: object backing
the pointer will be destroyed at the end of the full-expression
[-Wdangling]
``` is emitted after annotating `llvm::StringRef` with
`[[gsl::Pointer]]`.
The reason is that in
```
size_t FormatEntity::AutoComplete(CompletionRequest &request) {
 llvm::StringRef str = request.GetCursorArgumentPrefix().str();
``` the function `GetCursorArgumentPrefix()` returns a `StringRef`, and
`StringRef::str()` returns a temporary `std::string`.
Reviewers: jingham, JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D66442
llvm-svn: 369304

[CaptureTracker] Let subclasses provide dereferenceability information
Summary: CaptureTracker subclasses might have better dereferenceability 
information which allows null pointer checks to be no-capturing. The
first user will be D59922.
Reviewers: sanjoy, hfinkel, aykevl, sstefan1, uenoku, xbolva00
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66371
llvm-svn: 369305

[ORC] fix use-after-free detected by -Wreturn-stack-address
Summary: llvm/lib/ExecutionEngine/Orc/Layer.cpp:53:12: warning:
returning address of local temporary object [-Wreturn-stack-address]
In
``` StringRef IRMaterializationUnit::getName() const {
[...]
    return TSM.withModuleDo(
       [](const Module &M) { return M.getModuleIdentifier(); });
```
`getModuleIdentifier()` returns a `const std::string &`, but the
implicit return type of the lambda is `std::string` by value, and thus
the returned `StringRef` refers to a temporary `std::string`.
Detect by annotating `llvm::StringRef` with `[[gsl::Pointer]]`.
Reviewers: lhames, sgraenitz
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66440
llvm-svn: 369306

Windows: Include "windows" Instead of "Windows"
The actual include directory is lldb/Host/windows not lldb/Host/Windows
which breaks on case sensitive file systems
Patch by Gwen Mittertreiner!
llvm-svn: 369307

[Support][Time profiler] Make FE codegen blocks to be inside frontend
blocks
Summary: Add `Frontend` time trace entry to `HandleTranslationUnit()`
function. Add test to check all codegen blocks are inside frontend
blocks. Also, change `--time-trace-granularity` option a bit to make
sure very small time blocks are outputed to json-file when using
`--time-trace-granularity=0`.
This fixes http://llvm.org/pr41969
Reviewers: russell.gallop, lebedev.ri, thakis
Reviewed By: russell.gallop
Subscribers: vsapsai, aras-p, lebedev.ri, hiraditya, cfe-commits,
llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D63325
llvm-svn: 369308

[lit] Check for accidental external command calls
This patch extends lit's test suite to check that lit's internal shell 
doesn't accidentally execute internal commands as external commands. It
does so by putting fake failing versions of those commands in
`PATH` while the entire lit test suite is running.  Without the fixes in
D65697 but with its tests, this approach catches accidental external
`env` calls.
Reviewed By: probinson
Differential Revision: https://reviews.llvm.org/D66293
llvm-svn: 369309

[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Summary: rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on
LLVMPasses. In particular, symbols defined in LLVMPasses that are
referenced by the destructor of `PassBuilder` are now referenced by
LLVMOrcJIT through
`Speculation.cpp.o`.
We believe that referencing symbols defined in LLVMPasses in the 
destructor of `PassBuilder` is valid, and that adding to the set of such 
symbols is legitimate. To support such cases, this patch adds LLVMPasses 
to the set of libraries being linked when linking in LLVMOrcJIT causes 
such symbols from LLVMPasses to be referenced.
Reviewers: Whitney, anhtuyen, pree-jackie
Reviewed By: pree-jackie
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66441
llvm-svn: 369310

[sanitizer_common] Extend test after switch to posix_spawn
llvm-svn: 369311

Provide a meaningful diagnostic when LLVM_PATH doesn't point to a
directory
llvm-svn: 369312

[lldb] Fix typo on the BreakpointLocation header and the lldbtest.py
(NFC)
Summary: This commit fixes some typo I found while exploring LLDB's
codebase.
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D66452
llvm-svn: 369313

[TSan] Rename file with libdispatch interceptors
llvm-svn: 369314

[SLP][NFC] Avoid repetitive calls to getSameOpcode()
We can avoid repetitive calls getSameOpcode() for already known tree
elements by keeping MainOp and AltOp in TreeEntry.
Differential Revision: https://reviews.llvm.org/D64700
llvm-svn: 369315

Fix typo.  "piont" => "point"
Found by Chris Morris (cwmorris).
llvm-svn: 369316

[WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC.
WebAssembly doesn't support PC relative relocation or relocation 
expressions that can't be reduced to single symbol.
The only support for we have for fixups involving two symbols are when 
both symbols are defined and withing the same section.  In this case 
evaluateFixup will already have evaluated to the expression before 
calling recordRelocation.
llvm-svn: 369317

[WebAssembly][MC] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off
builds after r369317
llvm-svn: 369318

[analyzer] NFC: Drop support for extra text attached to bug reports.
It was introduced in 2011 but never used since then.
llvm-svn: 369319

[analyzer] NFC: Rename GRBugReporter to PathSensitiveBugReporter.
The GR prefix is super ancient.
llvm-svn: 369320

[CallGraph] Take into accound calls that aren't within any function
bodies.
This patch improves Clang call graph analysis by adding in expressions 
that are not found in regular function bodies, such as default arguments 
or member initializers.
Patch by Joshua Cranmer!
Differential Revision: https://reviews.llvm.org/D65453
llvm-svn: 369321

MCAsmMacro: add `#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)` to
some dump() declarations
llvm-svn: 369324

[AsmPrinter] Remove const qualifier from EmitBasicBlockStart.
Overriders may want to modify state in it. AMDGPU wants to, but has to
make its members mutable in order to do so.
Besides, EmitBasicBlockEnd is not const, so why should Start be?
Patch by Bevin Hansson.
Reviewed By: nickdesaulniers
Differential Revision: https://reviews.llvm.org/D66341
llvm-svn: 369325

[NFC] Test commit, fix some comment spelling.
llvm-svn: 369326

[Attributor] Fix the "clamp" operator
The clamp operator should not take the known of the given state as the 
known is potentially based on assumed information. This also adds TODOs 
to guide improvements.
llvm-svn: 369327

[Attributor] Use structured deduction for AANonNull
Summary: What D66126 did for AAAlign, this patch does for AANonNull.
Agian, the logic becomes more concise and localized. Again, returned
poiners are not annotated properly but that will not be an issue if this
lands with the "on-demand" generation of attributes. First improvements
due to the genericValueTraversal are already visible.
Reviewers: sstefan1, uenoku
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66128
llvm-svn: 369328

[Attributor] Use structured deduction for AADereferenceable
Summary: This is analogous to D66128 but for AADereferenceable. We have
the logic concentrated in the floating value updateImpl and we use the
combiner helper classes for arguments and return values.
The regressions will go away with "on-demand" attribute creation. 
Improvements are already visible in the existing tests.
Reviewers: uenoku, sstefan1
Subscribers: hiraditya, bollu, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66272
llvm-svn: 369329

[Attributor][NFC] Cleanup statistics code
llvm-svn: 369330

[Attributor] Create abstract attributes on-demand
Before, we create the set of abstract attributes initially and then 
dealt with the fact hat a lookup could fail, e.g., return a nullptr. 
This patch will ensure we always return a valid object from a lookup, 
allowing us not only to remove the nullptr checks but also to grow the 
set of abstract attributes "in-flight" on-demand.
One can now start from those that have the best chance of improving 
performance without the need to specify all they might depend on.
While this introduces some boilerplate, the usage of attributes is much 
easier and cleaner now.
Reviewers: uenoku, sstefan1
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66276
llvm-svn: 369331

[X86] Add back the -x86-experimental-vector-widening-legalization comand
line flag and all associated code, but leave it enabled by default
Google is reporting performance issues with the new default behavior and
have asked for a way to switch back to the old behavior while we 
investigate and make fixes.
I've restored all of the code that had since been removed and added 
additional checks of the command flag onto code paths that are not
otherwise guarded by a check of getTypeAction.
I've also modified the cost model tables to hopefully get us back to the
previous costs.
Hopefully we won't need to support this for very long since we have no
test coverage of the old behavior so we can very easily break it.
llvm-svn: 369332

[Attributor] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off
builds after r369331
llvm-svn: 369334

[compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists
Otherwise it doesn't work when building with -DLLVM_ENABLE_LTO=thin
(We hit this in Chromium in 
https://bugs.chromium.org/p/chromium/issues/detail?id=966403)
llvm-svn: 369336

[MC] Delete an overload of MCExpr::evaluateKnownAbsolute and its
associated hack
The hack dated back to 2010 (r121076) and was documented by r122144:
  // FIXME: The use if InSet = Addrs is a hack. Setting InSet causes us
 // absolutize differences across sections and that is what the MachO
writer
 // uses Addrs for.
llvm-svn: 369337

[test/Object] - Move/rewrite 2 more test cases.
This patch makes a change for test/Object tests responsible for
relocations.
* 2 tests were moved to llvm-readobj/llvm-objdump folders: 
Object/elf-reloc-no-sym.test -> tools/llvm-readobj/elf-reloc-no-sym.test 
Object/objdump-reloc-shared.test ->
tools/llvm-objdump/relocations-in-nonreloc.test
* A prerecompiled binary was removed and these tests were refactored.
Differential revision: https://reviews.llvm.org/D66291
llvm-svn: 369342

[ELF][PPC] Allow PT_LOAD to have overlapping p_offset ranges
This change affects the non-linker script case (precisely, when the
`SECTIONS` command is not used). It deletes 3 alignments at PT_LOAD 
boundaries for the default case: the size of a powerpc64 binary can be 
decreased by at most 192kb. The technique can be ported to other 
targets.
Let me demonstrate the idea with a maxPageSize=65536 example:
When assigning the address to the first output section of a new PT_LOAD, 
if the end p_vaddr of the previous PT_LOAD is 0x10020, we advance to the
next multiple of maxPageSize: 0x20000. The new PT_LOAD will thus have
p_vaddr=0x20000. Because p_offset and p_vaddr are congruent modulo 
maxPageSize, p_offset will be 0x20000, leaving a p_offset gap [0x10020, 
0x20000) in the output.
Alternatively, if we advance to 0x20020, the new PT_LOAD will have 
p_vaddr=0x20020. We can pick either 0x10020 or 0x20020 for p_offset! 
Obviously 0x10020 is the choice because it leaves no gap. At runtime, 
p_vaddr will be rounded down by pagesize (65536 if 
pagesize=maxPageSize). This PT_LOAD will load additional initial 
contents from p_offset ranges [0x10000,0x10020), which will also be 
loaded by the previous PT_LOAD. This is fine if -z noseparate-code is in 
effect or if we are not transiting between executable and non-executable 
segments.
ld.bfd -z noseparate-code leverages this technique to keep output small. 
This patch implements the technique in lld, which is mostly effective on 
targets with large defaultMaxPageSize (AArch64/MIPS/PPC: 65536). The 3 
removed alignments can save almost 3*65536 bytes.
Two places that rely on p_vaddr%pagesize = 0 have to be updated.
1) We used to round p_memsz(PT_GNU_RELRO) up to commonPageSize (defaults
 to 4096 on all targets). Now p_vaddr%commonPageSize may be non-zero.
 The updated formula takes account of that factor. 2) Our TP offsets
formulae are only correct if p_vaddr%p_align = 0.
 Fix them. See the updated comments in InputSection.cpp for details.
  On targets that we enable the technique (only PPC64 now),
 we can potentially make `p_vaddr(PT_TLS)%p_align(PT_TLS) != 0`
 if `sh_addralign(.tdata) < sh_addralign(.tbss)`
  This exposes many problems in ld.so implementations, especially the
 offsets of dynamic TLS blocks. Known issues:
  FreeBSD 13.0-CURRENT rtld-elf (i386/amd64/powerpc/arm64)
 glibc (HEAD) i386 and x86_64
https://sourceware.org/bugzilla/show_bug.cgi?id=24606
 musl<=1.1.22 on TLS Variant I architectures (aarch64/powerpc64/...)
  So, force p_vaddr%p_align = 0 by rounding dot up to p_align(PT_TLS).
The technique will be enabled (with updated tests) for other targets in 
subsequent patches.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D64906
llvm-svn: 369343

[ELF][AArch64] Allow PT_LOAD to have overlapping p_offset ranges
Ported the D64906 technique to AArch64. It deletes 3 alignments at 
PT_LOAD boundaries for the default case: the size of an aarch64 binary 
decreases by at most 192kb.
If `sh_addralign(.tdata) < sh_addralign(.tbss)`, we can potentially make
`p_vaddr(PT_TLS)%p_align(PT_TLS) != 0`.
ld.so that are known to have problems if p_vaddr%p_align!=0:
* musl<=1.1.22
* FreeBSD 13.0-CURRENT (and before) rtld-elf arm64
New test aarch64-tls-vaddr-align.s checks that our workaround makes
p_vaddr%p_align = 0.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D64930
llvm-svn: 369344

Rudimentary support for Doxygen \retval command
...so that at least a preceding \param etc. that lacks a description
gets a
-Wdocumentation warning (instead of erroneously treating the \retval ...
text as its paragraph).
Differential Revision: https://reviews.llvm.org/D66350
llvm-svn: 369345

[llvm-objcopy][MachO] Fix method names. NFC.
Reviewers: alexshap, rupprecht, jhenderson
Reviewed By: alexshap, rupprecht
Subscribers: jakehehrlich, abrachet, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65540
llvm-svn: 369346

[ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_386
Ported the D64906 technique to EM_386.
If `sh_addralign(.tdata) < sh_addralign(.tbss)`, we can potentially make
`p_vaddr(PT_TLS)%p_align(PT_TLS) != 0`.
ld.so that are known to have problems if p_vaddr%p_align!=0:
* FreeBSD 13.0-CURRENT rtld-elf
* glibc https://sourceware.org/bugzilla/show_bug.cgi?id=24606
New test i386-tls-vaddr-align.s checks our workaround makes
p_vaddr%p_align = 0.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D65865
llvm-svn: 369347

[yaml2obj/obj2yaml][MachO] Allow setting custom section data
Reviewers: alexshap, jhenderson, rupprecht
Reviewed By: alexshap, jhenderson
Subscribers: abrachet, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65799
llvm-svn: 369348

[clangd] Skip function bodies inside processed files while indexing
Summary: This significantly improves performance of background indexing.
We do not collect references and declarations inside the processed 
files, so this does not affect the final indexing results.
The idea is borrowed from libclang, which has a similar optimization in 
its indexing functionality.
Measurements show a nice decrease in indexing time, up to ~40% for 
building the whole index. These are not proper benchmarks, so one should 
not rely on these results too much.
1. Rebuilding the whole index for LLVM:
 - Before. Total time: 14m58s.
   ./bin/clangd -pch-storage=memory < ./clangd.input  23917.67s user
515.86s system 2718% cpu 14:58.68 total
 - After. Total time: 8m41s.
   ./bin/clangd -pch-storage=memory < ./clangd.input  13627.29s user
288.10s system 2672% cpu 8:40.67 total
2. Rebuilding index after removing shards matching '*clangd*'
(case-insensitively):
 - Before. Total time: 30s.
   ./bin/clangd -pch-storage=memory < ./clangd.input  130.94s user 6.82s
system 452% cpu 30.423 total
 - After. Total time: 26s.
   ./bin/clangd -pch-storage=memory < ./clangd.input  80.51s user 5.40s
system 333% cpu 25.777 total
Reviewers: kadircet, sammccall
Reviewed By: kadircet
Subscribers: MaskRay, jkorous, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66226
llvm-svn: 369349

[ELF][PPC] Allow PT_LOAD to have overlapping p_offset ranges on EM_PPC
Ported the D64906 technique to EM_PPC.
Delete ppc-rela.s that is covered by ppc32-abs-pic.s
llvm-svn: 369351

[lldb] D66174 `RegularExpression` cleanup
I find as a good cleanup to drop the Compile method. As I do not find
TIMTOWTDI as an advantage and there is already constructor parameter to
compile the regex.
Differential Revision: https://reviews.llvm.org/D66392
llvm-svn: 369352

[lldb][NFC] Test quotes when completing
llvm-svn: 369353

[DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF.
The calculation there was correct only for DWARF32.
Differential Revision: https://reviews.llvm.org/D66421
llvm-svn: 369356

[COFF] Allow using custom .edata from input object files
This is used by Wine for manually crafting export tables.
If the input object contains .edata sections, GNU ld references them in
the export directory instead of synthesizing an export table using 
either export directives or the normal auto export mechanism. (AFAIK, 
historically, way way back, GNU ld didn't support synthesizing the 
export table - one was supposed to generate it using dlltool and link it
in instead.)
If faced with --out-implib and --output-def, GNU ld still populates 
those output files with the same export info as it would have generated 
otherwise, disregarding the input .edata. As this isn't an intended 
usage combination, I'm not adding checks for that in tests.
Differential Revision: https://reviews.llvm.org/D65903
llvm-svn: 369358

[yaml2obj/obj2yaml][MachO] Fix a test failure in big endian hosts
These section contents are dummy data (0xdeadbeef) and it's endianess 
does not matter.
- http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/37265
llvm-svn: 369360

[COFF] Require an explicit -implib option for creating implibs in mingw
mode
GNU ld doesn't produce implibs unless explicitly requested.
Differential Revision: https://reviews.llvm.org/D66367
llvm-svn: 369363

[libcxx] Fix build breakage on mips
Fixes https://bugs.llvm.org/show_bug.cgi?id=43011 caused by 
https://reviews.llvm.org/D63284.
Committing as obvious.
llvm-svn: 369364

[X86][Btver2] Fix latency and throughput of CMPXCHG instructions.
On Jaguar, CMPXCHG has a latency of 11cy, and a maximum throughput of
0.33 IPC. Throughput is superiorly limited to 0.33 because of the
implicit in/out dependency on register EAX. In the case of repeated
non-atomic CMPXCHG with the same memory location, store-to-load
forwarding occurs and values for sequent loads are quickly forwarded
from the store buffer.
Interestingly, the functionality in LLVM that computes the reciprocal
throughput doesn't seem to know about RMW instructions. That
functionality only looks at the "consumed resource cycles" for the
throughput computation. It should be fixed/improved by a future patch.
In particular, for RMW instructions, that logic should also take into
account for the write latency of in/out register operands.
An atomic CMPXCHG has a latency of ~17cy. Throughput is also limited to
~17cy/inst due to cache locking, which prevents other memory uOPs to
start executing before the "lock releasing" store uOP.
CMPXCHG8rr and CMPXCHG8rm are treated specially because they decode to
one less macro opcode. Their latency tend to be the same as the other
RR/RM variants. RR variants are relatively fast 3cy (but still
microcoded - 5 macro opcodes).
CMPXCHG8B is 11cy and unfortunately doesn't seem to benefit from
store-to-load forwarding. That means, throughput is clearly limited by
the in/out dependency on GPR registers. The uOP composition is sadly
unknown (due to the lack of PMCs for the Integer pipes). I have reused
the same mix of consumed resource from the other CMPXCHG instructions
for CMPXCHG8B too. LOCK CMPXCHG8B is instead 18cycles.
CMPXCHG16B is 32cycles. Up to 38cycles when the LOCK prefix is
specified. Due to the in/out dependencies, throughput is limited to 1
instruction every 32 (or 38) cycles dependeing on whether the LOCK
prefix is specified or not. I wouldn't be surprised if the microcode for
CMPXCHG16B is similar to 2x microcode from CMPXCHG8B. So, I have
speculatively set the JALU01 consumption to 2x the resource cycles used
for CMPXCHG8B.
The two new hasLockPrefix() functions are used by the btver2 scheduling
model check if a MCInst/MachineInst has a LOCK prefix. Calls to
hasLockPrefix() have been encoded in predicates of variant scheduling
classes that describe lat/thr of CMPXCHG.
Differential Revision: https://reviews.llvm.org/D66424
llvm-svn: 369365

Fix MSVC "result of 32-bit shift implicitly converted to 64 bits"
warning. NFCI.
llvm-svn: 369366

[MCA][X86] Add tests for LOCK variants of standard X86 arithmetic ops
D66424 adds the base support for LOCK so we should be able to add
special case support for all these cases in future patches
llvm-svn: 369367

[CMake] Update C4324 MSVC warning comment to explain its still broken at
VS2019
As promised, I've updated the comment for the C4324 MSVC warning that
was re-disabled at rL367409 / rG8f823e63e3edf87ab029ba32b68f3eb5d2f392b5
to put it in terms of currently supported VS versions
llvm-svn: 369368

Recommit "MemoryBuffer: Add a missing error-check to getOpenFileImpl"
This recommits r368977, which was reverted in r369027 due to test 
failures in lldb. The cause of this was different behavior of 
readNativeFileSlice on windows and unix. These have been addressed in 
r369269.
The original commit message was: In case the function was called with a
desired read size *and* the file was not an "mmap()" candidate, the
function was falling back to a
"pread()", but it was failing to check the result of that system call. 
This meant that the function would return "success" even though the read 
operation failed, and it returned a buffer full of uninitialized memory.
Reviewers: rnk, dblaikie
Subscribers: kristina, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66224
llvm-svn: 369370

[cmake] Remove the test for libstdc++<4.9
It is no longer relevant now that llvm requires >=5.1.
llvm-svn: 369371

[OpenCL] Add const, volatile and pointer builtin handling
Const, volatile, and pointer types were previously available, but not 
working.  This patch adds handling for OpenCL builtin functions.
Add TableGen definitions for some atomic and asynchronous builtins to 
make use of the new functionality.
Patch by Pierre Gondois and Sven van Haastregt.
Differential Revision: https://reviews.llvm.org/D63442
llvm-svn: 369373

unittests: Use yaml2obj as a library instead of an external process
Summary: Recently, yaml2obj has been turned into a library. This means
we can use it from our unit tests directly, instead of shelling out to
an external process. This patch does just that.
Reviewers: JDevlieghere, aadsm, espindola, jdoerfert
Subscribers: emaste, mgorny, arichardson, MaskRay, jhenderson, abrachet,
lldb-commits
Differential Revision: https://reviews.llvm.org/D65949
llvm-svn: 369374

[RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used
for the FDE location
Follow binutils in using RISCV_32_PCREL for the FDE initial location. As 
explained in the relevant binutils commit
<https://github.com/riscv/riscv-binutils-gdb/commit/a6cbf936e3dce68114d28cdf60d510a3f78a6d40>, 
the ADD/SUB pair of relocations is problematic in the presence of linker 
relaxation.
This patch has the same end goal as D64715 but includes test changes and 
avoids adding a new global VariantKind to MCExpr.h (preferring 
RISCVMCExpr VKs like the rest of the RISC-V backend).
Differential Revision: https://reviews.llvm.org/D66419
llvm-svn: 369375

[InstCombine] add tests for min/max with min/max of same operands; NFC
llvm-svn: 369376

[llvm-readobj] Prepend argv[0] to error/warning messages
Summary: Currently, we report:
    error: ...
Prepend argv[0] (tool name):
    llvm-readobj: error: ...
This is consistent with most GNU binutils/clang/lld, and gives a bit 
more context in a long build log.
Reviewed By: grimar, jhenderson, rupprecht
Differential Revision: https://reviews.llvm.org/D66425
llvm-svn: 369377

[DWARF] Fix reading 64-bit DWARF type units.
The type_offset field is 8 bytes long in DWARF64. The patch extends 
TypeOffset to uint64_t and fixes its reading. The patch also fixes 
checking of TypeOffset bounds as it was inaccurate in DWARF64 case.
Differential Revision: https://reviews.llvm.org/D66465
llvm-svn: 369378

Convert minidump unittests to use llvm::yaml::convertYAML
previously they used a minidump-specific function for this purpose, but 
this is no longer needed now that whole of yaml2obj is available as a 
library.
llvm-svn: 369379

Removed the 'id' AST matcher, which is superseded by '.bind()'
Summary: The 'id' matcher is not even included in the AST Matchers
Reference document, so I don't expect there to be a significant number
of users.
There's no reason to provide two ways to do the exact same thing that 
only have a minor syntactic difference.
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66462
llvm-svn: 369380

Fix build for r369374
This patch added some gtest code to the TestingSupport library. As this 
is not a unit test, but a unit test library, gtest does not get added to 
the include path automatically, but we have to do that ourselves. (It 
was working for me without this because the compiler picked up the 
system gtest instead.)
llvm-svn: 369381

[llvm-objdump] - Remove one of `report_error` functions and improve the
error reporting.
One of the report_error functions was taking object::Archive::Child as
an argument. It feels excessive, this patch removes it and introduce a
helper function instead. Also I fixed a "TODO" in this patch what
improved the message printed.
Differential revision: https://reviews.llvm.org/D66468
llvm-svn: 369382

Regex: +regex string lifetime comment
Differential Revision: https://reviews.llvm.org/D66464
llvm-svn: 369383

[X86][FMA] Add FMA 'negated expression' combine tests for D63141
llvm-svn: 369384

[Syntax] Added function to get macro expansion tokens to TokenBuffer.
Summary: Returns the first token in every mapping where the token is an
identifier. This API is required to be able to highlight macro
expansions in clangd.
Reviewers: hokein, ilya-biryukov
Subscribers: kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66470
llvm-svn: 369385

[InstCombine] simplify min/max of min/max with same operands (PR35607)
This is the original integer variant requested in: 
https://bugs.llvm.org/show_bug.cgi?id=35607
As noted in the TODO and several similar TODOs around this block, we
could do this in instsimplify, but then it would cost more because we
would be trying to match min/max via ValueTracking in 2 different
places.
There are 4 commuted variants for each of smin/smax/umin/umax that are
not matched here. There are also icmp predicate variants that are not
included in the affected test file because they are already handled by
instsimplify by folding the final icmp to true/false.
https://rise4fun.com/Alive/3KVc
  Name: smax(smax, smin)
 %c1 = icmp slt i32 %x, %y
 %c2 = icmp slt i32 %y, %x
 %min = select i1 %c1, i32 %x, i32 %y
 %max = select i1 %c2, i32 %x, i32 %y
 %c3 = icmp sgt i32 %max, %min
 %r = select i1 %c3, i32 %max, i32 %min
 =>
 %r = %max
  Name: smin(smax, smin)
 %c1 = icmp slt i32 %x, %y
 %c2 = icmp slt i32 %y, %x
 %min = select i1 %c1, i32 %x, i32 %y
 %max = select i1 %c2, i32 %x, i32 %y
 %c3 = icmp sgt i32 %max, %min
 %r = select i1 %c3, i32 %min, i32 %max
 =>
 %r = %min
  Name: umax(umax, umin)
 %c1 = icmp ult i32 %x, %y
 %c2 = icmp ult i32 %y, %x
 %min = select i1 %c1, i32 %x, i32 %y
 %max = select i1 %c2, i32 %x, i32 %y
 %c3 = icmp ult i32 %min, %max
 %r = select i1 %c3, i32 %max, i32 %min
 =>
 %r = %max
  Name: umin(umax, umin)
 %c1 = icmp ult i32 %x, %y
 %c2 = icmp ult i32 %y, %x
 %min = select i1 %c1, i32 %x, i32 %y
 %max = select i1 %c2, i32 %x, i32 %y
 %c3 = icmp ult i32 %min, %max
 %r = select i1 %c3, i32 %min, i32 %max
 =>
 %r = %min
llvm-svn: 369386

[clangd] Fix one testcase in XRefsTests.
Summary: The test didn't test anything actually -- it used "[]" as
annotation which should be
"[[]]".
This patch also fixes a bug in XRef where we may return duplicated refs.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66349
llvm-svn: 369387

[X86][BtVer2] Fix latency and throughput of atomic INC/DEC/NEG/NOT.
Latency and throughput of LOCK INC/DEC/NEG/NOT is always 19cy. Number of
uOPs is still 1.
Differential Revision: https://reviews.llvm.org/D66469
llvm-svn: 369388

[BlockExtractor] Avoid assert with wrong line format
Summary: When the line format is wrong, we may end up accessing out of
bound memory. eg: the test with invalide line will cause assert. 
Assertion `idx < size()' failed
The fix is to report fatal when we found mismatched line format.
Reviewers: qcolombet, volkan
Reviewed By: qcolombet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66444
llvm-svn: 369389

[InstCombine] improve readability for icmp with cast folds; NFC
1. Update function name and stale code comments. 2. Use variable names
that are less ambiguous. 3. Move operand checks into the function as
early exits.
llvm-svn: 369390

[llvm-objcopy] Append '\n' to warning messages
Currently the warning message of `llvm-strip %t.o %t.o` does not include 
the trailing newline. Fix this by appending a '\n'.
This is the only warning llvm-objcopy and llvm-strip can issue.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D66475
llvm-svn: 369391

[llvm-objcopy][test] Add a test to show that argv[0] is included in
error/warning messages
test/llvm-objcopy/ELF/error-format.test is similar to
test/llvm-readobj/error-format.test added in D66425.
Reviewed By: grimar, jhenderson
Differential Revision: https://reviews.llvm.org/D66476
llvm-svn: 369392

[libc++] Explicitly cast in generate_canonical
A new clang warning introduced in r367497 was complaining about the
change in value.
Thanks to Brian Cain for the patch. Differential Revision:
https://reviews.llvm.org/D66422
llvm-svn: 369393

[libc++] std::abs should not return double
Implement LWG Issue 2735 by adding std::abs tests for several types and
checking their return value. NFC.
llvm-svn: 369394

    [CodeGen] Add a pass to do block predication on SSA machine IR.
    For targets requiring aggressive scheduling and/or software pipeline
we need to
   apply predication before preRA scheduling. This adds a pass re-using
the early
   if-cvt infrastructure but generating predicated instructions instead
of
   speculatively executing instructions. It allows doing if conversion
on blocks
   containing instructions with side-effects. The pass re-use the target
hook from
   postRA if-conversion to let the target decide on the heuristic to
apply.
    Differential Revision: https://reviews.llvm.org/D66190
llvm-svn: 369395

Regex: Add isValid() with no parameter
There will be some performance (only a little) improvement for LLDB's 
RegularExpression::Execute.
Differential Revision: https://reviews.llvm.org/D66463
llvm-svn: 369396

[clang] Use the new Regex::isValid() with no parameter
Differential Revision: https://reviews.llvm.org/D66463
llvm-svn: 369397

[lldb] Use the new Regex::isValid() with no parameter
Differential Revision: https://reviews.llvm.org/D66463
llvm-svn: 369398

Fix availability of __thread_id on builds with external threading.
Reviewed as https://reviews.llvm.org/D66480
llvm-svn: 369399

[scudo][standalone] Fix malloc_iterate
Summary: cferris's Bionic tests found an issue in Scudo's
`malloc_iterate`.
We were inclusive of both boundaries, which resulted in a `Block` that 
was located on said boundary to be possibly accounted for twice, or just
being accounted for while iterating on regions that are not ours
(usually the unmapped ones in between Primary regions).
The fix is to exclude the upper boundary in `iterateOverChunks`, and add
a regression test.
This additionally corrects a typo in a comment, and change the 64-bit 
Primary iteration function to not assume that `BatchClassId` is 0.
Reviewers: cferris, morehouse, hctim, vitalybuka, eugenis
Reviewed By: hctim
Subscribers: delcypher, #sanitizers, llvm-commits
Tags: #llvm, #sanitizers
Differential Revision: https://reviews.llvm.org/D66231
llvm-svn: 369400

gn build: Merge r369298
llvm-svn: 369401

win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or
newer
MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and 
so should clang-cl: 
https://docs.microsoft.com/en-us/cpp/build/reference/zc-twophase
clang-cl takes the MSVC version it emulates from the -fmsc-version flag, 
or if that's not passed it tries to check what the installed version of 
MSVC is and uses that, and failing that it uses a default version that's 
currently 1911. So this changes the default if no -fmsc-version flag is 
passed and no installed MSVC is detected. (It also changes the default 
if -fmsc-version is passed or MSVC is detected, and either indicates
_MSC_VER >= 1911.)
As mentioned in the MSDN article, the Windows SDK header files in 
version 10.0.15063.0 (Creators Update or Redstone 2) and earlier 
versions do not work correctly with /Zc:twoPhase. If you need to use 
these old SDKs with a new clang-cl, explicitly pass /Zc:twoPhase- to get 
the old behavior.
Fixes PR43032.
Differential Revision: https://reviews.llvm.org/D66394
llvm-svn: 369402

[GlobalISel] Handle multiple registers in dbg.value intrinsic
https://reviews.llvm.org/D66077
The value passed into dbg.value may relate to multiple registers, each
of which need a DBG_VALUE.
This fix calls MIRBuilder.buildDirectDbgValue for each register.
Without this, IR passed in from flang-compiler/flang may fail an 
assertion in getOrCreateVReg.
Patch by : peterwaller-arm.
llvm-svn: 369403

[ARM] Select vaddva
This patch adds vaddva selection.
Differential revision: https://reviews.llvm.org/D66410
llvm-svn: 369404

[CodeGen] Add EarlyIfConvert test missed in previous commit
llvm-svn: 369405

[libc++] Populate a lit feature including the compiler patch level
If the compiler is (for example) AppleClang 10.0.1, we would previously 
populate the following lit features:
    apple-clang
   apple-clang-10
   apple-clang-10.0
This patch additionally populates a feature called 'apple-clang-10.0.1', 
which allows more precise enabling/disabling of tests.
llvm-svn: 369406

Make the FindTypes(std::vector<CompilerContext>, ...) API testable in
lldb-test
This adds a -compiler-context=<...> option to lldb-test that trakes a 
comma-separated string that is a list of kind/name pairs and translates
it into a std::vector<CompilerContext>, a CompilerContext being a pair
of context-kind and name.
Differential Revision: https://reviews.llvm.org/D66453
<rdar://problem/54471165>
llvm-svn: 369407

[LifetimeAnalysis] Add support for free functions
Differential Revision: https://reviews.llvm.org/D66303
llvm-svn: 369408

[libc++] Disable <chrono> ""d and ""y literal tests on AppleClang 10.0.0
In r368882, I enabled those tests for all AppleClang's above version 9. 
However, it turns out that the feature is only supported starting with 
AppleClang 10.0.1, not AppleClang 10.0.0. This commit fixes that hole.
llvm-svn: 369409

[X86] Use isNullConstant instead of getConstantOperandVal == 0. NFC
llvm-svn: 369410

[InstCombine] make fold for icmp with sext more efficient; NFC
We were creating 2 instructions and relying on a subsequent fold to
invert a not(icmp). Create the final icmp directly instead.
llvm-svn: 369411

[X86][BtVer2] Use ReadAfterLd entries for the register operands of
CMPXCHG.
This is a follow-up of r369365.
llvm-svn: 369412

[libc++] fix test for unsigned char
On some systems char is unsigned. If that is the case, we will now test
signed char twice in std::abs. NFC. Fixes the build bots.
llvm-svn: 369413

[Attr] Support _attribute__ ((fallthrough))
Summary: Fixed extraneous matches of non-NullStmt
Reviewers: aaron.ballman, rsmith, efriedma, xbolva00
Reviewed By: aaron.ballman, rsmith, xbolva00
Subscribers: riccibruno, arphaman, ziangwan, ojeda, xbolva00,
nickdesaulniers, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64838
llvm-svn: 369414

bump lld version used by buildbots
llvm-svn: 369416

Revert "AMDGPU: Fix iterator error when lowering SI_END_CF"
This reverts r367500 and r369203. This is causing various test failures.
llvm-svn: 369417

Fix name of the error message, NFC.
llvm-svn: 369418

Fix typo in comment. NFCI.
llvm-svn: 369419

[libc++] Precise XFAIL for AppleClang 11
This test doesn't fail on all patch levels of AppleClang 11
llvm-svn: 369420

[InstCombine] add helper function for icmp+zext/sext; NFC
llvm-svn: 369421

[libc++] Implement LWG 3199
Summary: The resolution of LWG 3199 makes sure that input-streaming into
an empty bitset does not set the failbit on the input stream.
Reviewers: mclow.lists, EricWF
Subscribers: christof, jkorous, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D65105
llvm-svn: 369422

[WebAssembly][lld] Fix crash when applying relocations to debug sections
Debug sections are special in that they can contain relocations against 
symbols that are not present in the final output (i.e. not live). 
However it is also possible to have R_WASM_TABLE_INDEX relocations 
against symbols that don't have a table index assigned (since they are 
not address taken by actual code.
Fixes: https://github.com/emscripten-core/emscripten/issues/9023
Differential Revision: https://reviews.llvm.org/D66435
llvm-svn: 369423

[ClangExpressionParser] Add ClangDeclVendor
Summary: This introduces a layer between DeclVendor and the currently
implemented DeclVendors (ClangModulesDeclVendor and
AppleObjCDeclVendor). This allows the removal of
DeclVendor::GetImporterSource which is extremely clang-specific, freeing
up the interface to be more general.
A good follow up to this would be to remove the remaining instances of 
clang in DeclVendor, either by moving things to ClangDeclVendor or by 
using wrappers (e.g. CompilerDecl instead of clang::NamedDecl).
Differential Revision: https://reviews.llvm.org/D66451
llvm-svn: 369424

[COFF] Print the file name on errors writing the pdb file
This avoids confusing contextless error messages such as "No such file 
or directory" if e.g. the pdb output file should be written to a 
nonexistent directory. (This can happen with linkrepro scripts, at least 
old ones.)
Differential Revision: https://reviews.llvm.org/D66466
llvm-svn: 369425

[TargetMachine] Don't try to create COFFSTUB references on windows on
non-COFF
This avoids spurious relocation types for windows/elf targets.
Differential Revision: https://reviews.llvm.org/D66401
llvm-svn: 369426

[Sema][Typo] Fix assertion failure for expressions with multiple typos
Summary: As Typo Resolution can create new TypoExprs while resolving
typos, it is necessary to recurse through the expression to search for
more typos.
This should fix the assertion failure in `clang::Sema::~Sema()`:
 `DelayedTypos.empty() && "Uncorrected typos!"`
Notes:
- In case some TypoExprs are created but thrown away, Sema
 now has a Vector that is used to keep track of newly created
 typos.
- For expressions with multiple typos, we only give suggestions
 if we are able to resolve all typos in the expression
- This patch is similar to D37521 except that it does not eagerly
 commit to a correction for the first typo in the expression.
 Instead, it will search for corrections which fix all of the
 typos in the expression.
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D62648
llvm-svn: 369427

fix buildbot start script to no longer hang
llvm-svn: 369428

[libc++] Avoid implicit conversion warning in a <random> test
By stashing the computation of `E::max() - E::min()` in a variable, we 
avoid the warning introduced in r367497. Note that we use `auto` to 
avoid having to deduce the type of the computation, which is not a 
problem since Clang provides `auto` as an extension even in C++03 (and 
we disable warnings related to using C++11 extensions in the test
suite).
llvm-svn: 369429

Force honoring nthreads-var and thread-limit-var inside teams construct
on host
This patch fixes https://bugs.llvm.org/show_bug.cgi?id=42906, via adding 
adjustment of number of threads on enter to the teams construct on host 
according to user settings. This allows to pass checks and avoid
assertions at time of team of threads creation.
Patch by Andrey Churbanov
Differential Revision: https://reviews.llvm.org/D66351
llvm-svn: 369430

[X86] Add isel patterns for (i64 (zext (i8 (bitcast (v16i1 X))))) to use
a KMOVW and a SUBREG_TO_REG. Similar for i8 and anyextend.
We already had patterns for extending to i32 to take advantage of the
impliciting zeroing of the upper bits of a 32-bit GPR that is done by
KMOVW/KMOVB. But the extend might be all the way to i64, in which case
the existing patterns would fail and we'd get a KMOVW/B followed by a
MOVZX. By adding patterns for i64 we can use the fact that KMOVW/B zero
the upper bits of the 32-bit GPR and the normal property that 32-bit GPR
writes implicitly zero the upper 32-bits of the full 64-bit GPR.
The anyextend patterns are slightly different since we don't care about
the upper zeros. For the i8->i64 I think this avoids selecting the
anyextend as a MOVZX to prevent a partial register issue that doesn't
exist. For i16->i64 I think we would have just emitted an insert_subreg
on top of the extract_subreg that the vXi16->i16 bitcast pattern emits.
The register coalescer or peephole pass should combine those, but this
saves that work and makes i8/16 consistent.
llvm-svn: 369431

[OPENMP]Fix delayed diagnostics for standalone declare target directive.
If the function is marked as declare target in a standalone directive, 
the delayed diagnostics is not emitted. Patch fixes this problem.
llvm-svn: 369432

[GWP-ASan] Fix typos.
Summary: Fix two spelling typos and de-indent a guarded #define so that
it's consistent with clang-format.
Reviewers: vitalybuka
Reviewed By: vitalybuka
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D66311
llvm-svn: 369433

[X86] Add a DAG combine to transform (i8 (bitcast (v8i1
(extract_subvector (v16i1 X), 0)))) -> (i8 (trunc (i16 (bitcast (v16i1
X))))) on KNL target
Without AVX512DQ we don't have KMOVB so we can't really copy 8-bits of a
k-register to a GPR. We have to copy 16 bits instead. We do this even if
the DAG copy is from v8i1->v16i1. If we detect the (i8 (bitcast (v8i1
(extract_subvector (v16i1 X), 0)))) we should rewrite the types to match
the copy we do support. By doing this, we can help known bits to
propagate without losing the upper 8 bits of the input to the
extract_subvector. This allows some zero extends to be removed since we
have an isel pattern to use kmovw for (zero_extend (i16 (bitcast (v16i1
X))).
Differential Revision: https://reviews.llvm.org/D66489
llvm-svn: 369434

[CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
Given that LLDB_TEST_USE_CUSTOM_C_COMPILER and LLDB_TEST_C_COMPILER are 
both set at configuration time, I don't really see the point of having 
both. This patch simplifies things and uses the custom C/C++ compiler 
when the variable is set, and uses the default one when it's not set. 
The variable can be unset by passing -ULLDB_TEST_C_COMPILER to CMake.
Differential revision: https://reviews.llvm.org/D66429
llvm-svn: 369435

[Symbol][NFC] Remove references to clang in TypeMap
llvm-svn: 369436

[libc++] Fix std::abs tests
On systems where sizeof(long) == sizeof(int) the current tests failed.
This commit updates those tests to work on all systems. std::abs has
specific long specializations which can be used instead.
llvm-svn: 369437

[llvm-extract] Update the help message for group extraction feature
Summary: https://reviews.llvm.org/D60973 exposed the group extraction
feature of the BlockExtractor to llvm-extract. However, the help message
was not updated, so users might not be able to know how to use this
feature without looking into history/commits.
This patch just update the help message to show how to use this group 
extraction feature.
Reviewers: qcolombet, volkan
Reviewed By: qcolombet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66438
llvm-svn: 369438

[InstCombine] add tests for mismatched cast ops for icmp; NFC
Motivating case is shown in PR42700: 
https://bugs.llvm.org/show_bug.cgi?id=42700
llvm-svn: 369439

[AutoFDO] Make call targets order deterministic for sample profile
Summary: StringMap is used for storing call target to frequency map for
AutoFDO. However the iterating order of StringMap is non-deterministic,
which leads to non-determinism in AutoFDO profile output. Now new API
getSortedCallTargets and SortCallTargets are added for deterministic
ordering and output.
Roundtrip test for text profile and binary profile is added.
Reviewers: wmi, davidxl, danielcdh
Subscribers: hiraditya, mgrang, llvm-commits, twoh
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66191
llvm-svn: 369440

[AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA
This patch fixes https://github.com/google/sanitizers/issues/703 On a
Graviton-A1 aarch64 machine with 48-bit VMA, the time spent in LSan and
ASan reduced from 2.5s to 0.01s when running
clang -fsanitize=leak
compiler-rt/test/lsan/TestCases/sanity_check_pure_c.c && time ./a.out 
clang -fsanitize=address
compiler-rt/test/lsan/TestCases/sanity_check_pure_c.c && time ./a.out
With this patch, LSan and ASan create both the 32 and 64 allocators and
select at run time between the two allocators following a global
variable that is initialized at init time to whether the allocator64 can
be used in the virtual address space.
Differential Revision: https://reviews.llvm.org/D60243
llvm-svn: 369441

[NewPM] Run ubsan-coroutines test under the legacy pass manager only
The passes that lower the llvm.coro.* instrinsics have not yet been
ported, so only run under the legacy PM for now.
See https://bugs.llvm.org/show_bug.cgi?id=42867
Differential Revision: https://reviews.llvm.org/D66493
llvm-svn: 369442

[test] Fix tests when run on windows after SVN r369426. NFC.
When running tests on windows, invoking "llc -march=<arch>" will 
implicitly use windows as the target os, making these tests misbehave 
after this change.
Fix the issue by using more specific -mtriple values instead of plain
-march in these tests.
This should hopefully fix buildbot failures like 
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/9816.
llvm-svn: 369443

[Attributor] Remove unused variable. NFC.
llvm-svn: 369444

[COFF] Check errorCount before committing the output file
This avoids producing an output file if errors appeared late in the 
linking process (e.g. while fixing relocations, or as in the test, while
checking for multiple resources). If an output file is produced, build
tools might not retry building it on rebuilds, even if a previous build
failed due to the error return code.
Differential Revision: https://reviews.llvm.org/D66491
llvm-svn: 369445

[InstCombine] add more extra use tests for icmp with extends; NFC
llvm-svn: 369447

Fix a couple of unguarded operator, calls in algorithm. Fixes PR#43063.
Updated all the heap tests to check this.
llvm-svn: 369448

[analyzer] Improve VirtualCallChecker and enable parts of it by default.
Calling a pure virtual method during construction or destruction is
undefined behavior. It's worth it to warn about it by default. That part
is now known as the cplusplus.PureVirtualCall checker.
Calling a normal virtual method during construction or destruction may
be fine, but does behave unexpectedly, as it skips virtual dispatch. Do
not warn about this by default, but let projects opt in into it by
enabling the optin.cplusplus.VirtualCall checker manually.
Give the two parts differentiated warning text:
  Before:
    Call to virtual function during construction or destruction:
   Call to pure virtual function during construction
    Call to virtual function during construction or destruction:
   Call to virtual function during destruction
  After:
    Pure virtual method call:
   Call to pure virtual method 'X::foo' during construction
       has undefined behavior
    Unexpected loss of virtual dispatch:
   Call to virtual method 'Y::bar' during construction
       bypasses virtual dispatch
Also fix checker names in consumers that support them (eg., clang-tidy) 
because we now have different checker names for pure virtual calls and 
regular virtual calls.
Also fix capitalization in the bug category.
Differential Revision: https://reviews.llvm.org/D64274
llvm-svn: 369449

[analyzer] Fix a crash when destroying a non-region.
Add defensive check that prevents a crash when we try to evaluate a
destructor whose this-value is a concrete integer that isn't a null.
Differential Revision: https://reviews.llvm.org/D65349
llvm-svn: 369450

[analyzer] NFC: Remove the BugTypes set from BugReporter.
Its only purpose was to avoid a bug that's caused by making a virtual
call in BugReporter's destructor.
llvm-svn: 369451

[NFC] Update RegularExpression documentation
llvm-svn: 369452

[LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test
(NFC)
Summary: The test for conditional breakpoints on Windows was skipped
because there was no expression evaluation support at the time it was
written.
After removing the annotation and testing it again, the test is passing. 
http://lists.llvm.org/pipermail/lldb-dev/2019-August/015405.html
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Reviewers: stella.stamenova, jingham
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D66499
llvm-svn: 369453

Adds support for writing the .bss section for XCOFF object files.
Adds Wrapper classes for MCSymbol and MCSection into the XCOFF target 
object writer. Also adds a class to represent the top-level sections,
which we materialize in the ObjectWriter.
executePostLayoutBinding will map all csects into the appropriate 
container depending on its storage mapping class, and map all symbols 
into their containing csect. Once all symbols have been processed we
- Assign addresses and symbol table indices.
- Calaculte section sizes.
- Build the section header table.
- Assign the sections raw-pointer value for non-virtual sections.
Since the .bss section is virtual, writing the header table is enough to 
add support. Writing of a sections raw data, or of any relocations is 
not included in this patch.
Testing is done by dumping the section header table, but it needs to be 
extended to include dumping the symbol table once readobj support for 
dumping auxiallary entries lands.
Differential Revision: https://reviews.llvm.org/D65159
llvm-svn: 369454

Teach GlobalISelEmitter to treat used iPTRAny operands as pointer
operands
Overloaded intrinsics can use iPTRAny in used/input operands.
The GlobalISelEmitter doesn't know that these are pointers, so it treats
them as scalars. As a result, these intrinsics can't be imported.
This teaches the GlobalISelEmitter to recognize these as pointers rather
than scalars.
Differential Revision: https://reviews.llvm.org/D65756
llvm-svn: 369455

[Symbol] Move VerifyDecl to ClangASTContext
VerifyDecl is specific to clang and is only used in ClangASTContext.
llvm-svn: 369456

Revert [WinEH] Allocate space in funclets stack to save XMM CSRs
This reverts r367088 (git commit
9ad565f70ec5fd3531056d7c939302d4ea970c83)
And the follow up fix r368631 / e9865b9b31bb2e6bc742dc6fca8f9f9517c3c43e
llvm-svn: 369457

[DebugInfo] Add debug location to dynamic atexit destructor
Fixes PR43012
Differential Revision: https://reviews.llvm.org/D66328
llvm-svn: 369458

[DAGCombiner][X86] Teach visitCONCAT_VECTORS to combine (concat_vectors
(concat_vectors X, Y), undef)) -> (concat_vectors X, Y, undef, undef)
I also had to add a new combine to X86's combineExtractSubvector to
prevent a regression.
This helps our vXi1 code see the full concat operation and allow it
optimize undef to a zero if there is already a zero in the concat. This
helped us use a movzx instead of an AND in some of the tests. In those
tests, one concat comes from SelectionDAGBuilder and the second comes
from type legalization of v4i1->i4 bitcasts which uses an additional
concat. Though these changes weren't my original motivation.
I'm looking at making X86ISelLowering's narrowShuffle emit a
concat_vectors instead of an insert_subvector since concat_vectors is
more canonical during early DAG combine. This patch helps prevent a
regression from my experiments with that.
Differential Revision: https://reviews.llvm.org/D66456
llvm-svn: 369459

[AArch64][GlobalISel] Select patterns which use shifted register
operands
This adds GlobalISel equivalents for the following from
AArch64InstrFormats:
- arith_shifted_reg32
- arith_shifted_reg64
And partial support for
- logical_shifted_reg32
- logical_shifted_reg32
The only thing missing for the logical cases is support for rotates.
Other than the missing support, the transformation is identical for the
arithmetic shifted register and the logical shifted register.
Lots of tests here:
- Add select-arith-shifted-reg.mir to show that we correctly select add
and sub instructions which use this pattern.
- Add select-logical-shifted-reg.mir to cover patterns which are not
shared between the arithmetic and logical cases.
- Update addsub-shifted.ll to show that we correctly fold shifts into 
adds/subs.
- Update eon.ll to show that we can select the eon instruction by
folding xors.
Differential Revision: https://reviews.llvm.org/D66163
llvm-svn: 369460

[NFC] Fix -Wdocumentation warnings in Utility.
This patch fixes a bunch of -Wdocumentation warnings in Utility. I'm 
sure there are still a bunch outdated comments left, but this fixes the 
most flagrant inconsistencies that the compiler understands.
llvm-svn: 369461

Remove assert with tautological compare from XCOFFObjectWriter.
Remove assert of 'Sec->getCSectType() <= 0x07u' added in r369454, since
its always true.
llvm-svn: 369462

Add a missing _VSTD:: before a call to merge. Fixes PR43034. Checked the
rest of 'algorithm' looking for unqualified calls. Didn't find any.
llvm-svn: 369463

[MemorySSA] Fix existing phis when inserting defs.
Summary: When inserting a new Def, and inserting Phis in the IDF when
needed, also mark the already existing Phis in the IDF as non-optimized,
since these may need fixing as well. In the test attached, there is a
Phi in the IDF that happens to be trivial, and is wrongfully removed by
the call to getLastDef that follows. This is a valid situation and the
existing IDF Phis need to marked as "may need fixing" as well. Resolves
PR43044.
Reviewers: george.burgess.iv
Subscribers: Prazek, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66495
llvm-svn: 369464

[AArch64][GlobalISel] Select logical_imm32 and logical_imm64 patterns
Add a GlobalISel equivalent for the logical_imm32_XFORM and
logical_imm64_XFORM SDNodeXForms in AArch64InstrFormats.td.
- Add select-logical-imm.mir, which contains tests for each imported
pattern.
- Update select-pr32733.mir and select-scalar-shift-imm.mir, since they
now select instructions of this form.
Differential Revision: https://reviews.llvm.org/D66162
llvm-svn: 369465

[MemorySSA] Make Phi cleanups consistent.
Summary: Make Phi cleanups consistent: remove self as a trivial Phi and 
recurse to potentially remove other trivial phis.
Reviewers: george.burgess.iv
Subscribers: Prazek, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66454
llvm-svn: 369466

[RISCV GlobalISel] Adding initial GlobalISel infrastructure
Summary: Add an initial GlobalISel skeleton for RISCV. It can only run
ir translator for `ret void`.
Patch by Andrew Wei
Reviewers: asb, sabuasal, apazos, lenary, simoncook, lewis-revill,
edward-jones, rogfer01, xiangzhai, rovka, Petar.Avramovic, mgorny,
dsanders
Reviewed By: dsanders
Subscribers: pzheng, s.egerton, dsanders, hiraditya, rbar, johnrusso,
niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, MartinMosbeck,
brucehoult, the_o, PkmX, jocewei, psnobl, benna, Jim, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65219
llvm-svn: 369467

[Sanitizer] Remove unused functions
Differential Revision: https://reviews.llvm.org/D66503
llvm-svn: 369468

[X86] Autogenerate vec_* tests. NFC
llvm-svn: 369469

[Attributor] Liveness for internal functions.
For an internal function, if all its call sites are dead, the body of
the function is considered dead.
Reviewers: jdoerfert, uenoku
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D66155
llvm-svn: 369470

Fix assert in XCOFFObjectWriter related to program code csects.
Removed code that added program code csects to a collection as part of
addressing review comments, but I failed to update an assert affected by
the change before commiting.
llvm-svn: 369471

[AArch64][asan] fix typo in AsanStats::Print
This created an infinite loop that timed out several build bots while 
executing the test in compiler-rt/test/asan/TestCases/atexit_stats.cpp
Differential Revision: https://reviews.llvm.org/D60243
llvm-svn: 369472

Add TinyPtrVector support for general pointer-like things.
In particular, make TinyPtrVector<PtrIntPair<T *, 1>> work. Remove all 
unnecessary assumptions that the element type has a formal "null" 
representation. The important property to maintain is that 
default-constructed element type has the same internal representation as
the default-constructed PointerUnion (all zero bits).
Remove the incorrect recursive behavior from PointerUnion::isNull. This
was never generally correct because it only recursed over the first type
parameter. With variadic templates it's completely unnecessary.
llvm-svn: 369473

Add triple to new test to try to pacify bots
llvm-svn: 369474

[X86] Automatically generate shift tests. NFC
llvm-svn: 369475

gn build: Merge r369467
llvm-svn: 369476

[dotest] Don't set the DWARF version override in CFLAGS_EXTRA.
We cannot override the DWARF version in the CFLAGS_EXTRA because they 
are used by tests that explicitly build without debug info. Instead, we 
pass them through the regular CFLAGS.
llvm-svn: 369477

Remove llvm/utils/git/find-rev
It assumes git-svn, hasn't been touched in ages, and it's replaced by
llvm-git in llvm/utils/git-svn.
Differential Revision: https://reviews.llvm.org/D66193
llvm-svn: 369478

[Doxygen] Document private class members.
Given that the C++ documentation is meant for LLDB developers it makes 
sense to include private class members in the output.
llvm-svn: 369479

[AArch64][GlobalISel] Add support for narrowScalar of G_ZEXT
We do this by merging the source with the high bits set to 0.
Differential Revision: https://reviews.llvm.org/D66181
llvm-svn: 369480

libcxx: Rename .hpp files in libcxx/test/support to .h
LLVM uses .h as its extension for header files.
Files renamed using:
    for f in libcxx/test/support/*.hpp; do git mv $f ${f%.hpp}.h; done
References to the files updated using:
    for f in $(git diff master | grep 'rename from' | cut -f 3 -d ' ');
do
       a=$(basename $f);
       echo $a;
       rg -l $a libcxx | xargs sed -i '' "s/$a/${a%.hpp}.h/";
   done
HPP include guards updated manually using:
    for f in $(git diff master | grep 'rename from' | cut -f 3 -d ' ');
do
     echo ${f%.hpp}.h ;
   done | xargs mvim
Differential Revision: https://reviews.llvm.org/D66104
llvm-svn: 369481