FailedChanges

Summary

  1. [X86] Remove an isel pattern than can never match. Remove bitcasts of loads from a few others. (details)
  2. Fix missing build dependency on omp_gen. (details)
  3. [Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align (details)
  4. [MSP430] Declare comparison LibCalls as returning i16 instead of i32 (details)
  5. [builtins] Change si_int to int in some helper declarations (details)
  6. [Alignment][NFC] Migrate PPC, X86 and XCore backends to Align (details)
  7. [Alignment][NFC] TargetLowering::allowsMemoryAccess (details)
  8. [clang-tidy][docs] Fix malformed link in ReleaseNotes (details)
  9. [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'. (details)
  10. [MLIR][Shape] Fix lowering of `shape.get_extent` (details)
  11. Revert "Fix missing build dependency on omp_gen." (details)
  12. [mlir] Fix case in MLIRGPUtoVulkanTransforms (details)
  13. [GlobalISel][InlineAsm] Add support for matching input constraints (details)
  14. AMDGPU/GlobalISel: Select icmp intrinsic (details)
  15. [yaml2obj] - Add a way to set default values for macros used in a YAML. (details)
  16. [yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key. (details)
Commit 767c9c5bf5ba4dbaa8edadb1d2e26254321c30c0 by craig.topper
[X86] Remove an isel pattern than can never match. Remove bitcasts of loads from a few others.
The file was modifiedllvm/lib/Target/X86/X86InstrXOP.td
Commit ed4328c607306a2aa6df4833a0dce4482edbc94c by simon.tatham
Fix missing build dependency on omp_gen.

Summary:
`include/llvm/Frontend/OpenMP/CMakeLists.txt` creates a new target
called `omp_gen`, which is automatically added to
`LLVM_COMMON_DEPENDS` by the `add_public_tablegen_target` macro. But
it only gets added to the version of `LLVM_COMMON_DEPENDS` in the
scope of that subsidiary CMakeLists file, and it doesn't propagate all
the way back up to the permanent version of that variable which is
actually used to set dependencies.

The visible effect is that the output build scripts contain a missing
dependency. For example, if I run cmake in Ninja output mode, and then
run

  ninja -t commands tools/clang/examples/PrintFunctionNames/CMakeFiles/PrintFunctionNames.dir/PrintFunctionNames.cpp.o

to list all the commands that are prerequisites of building that
object file, then the list does not include the llvm-tblgen command
that builds `include/llvm/Frontend/OpenMP/OMP.h.inc`, even though that
generated include file is needed (by a chain of includes starting from
`clang/AST/AST.h`), and that object file can't be compiled without it.
This missing dependency can cause intermittent build failures,
depending on the order that Ninja (or whatever) happens to schedule
its commands.

I've fixed it by adding a `set` command in two levels of
`CMakeLists.txt` to propagate the modified version of
`LLVM_COMMON_DEPENDS` back up through the parent scopes so that
`omp_gen` does end up on the version seen by the main
`llvm/CMakeLists.txt`.

Reviewers: clementval, thakis, chandlerc, jdoerfert

Reviewed By: clementval

Subscribers: jdenny, mgorny, sstefan1, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82659
The file was modifiedllvm/include/llvm/CMakeLists.txt
The file was modifiedllvm/include/llvm/Frontend/OpenMP/CMakeLists.txt
Commit 4f5133a4dcd0b023160879740d32bbcca198664f by gchatelet
[Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align

This patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Differential Revision: https://reviews.llvm.org/D82749
The file was modifiedllvm/lib/Target/Hexagon/HexagonVExtract.cpp
The file was modifiedllvm/lib/Target/ARM/ARMISelDAGToDAG.cpp
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.cpp
The file was modifiedllvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
The file was modifiedllvm/lib/Target/MSP430/MSP430ISelDAGToDAG.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp
Commit 19e75717eff2c22e6643addcc44caa8dc2f0125f by anton
[MSP430] Declare comparison LibCalls as returning i16 instead of i32

For TI's distribution of msp430-gcc
```
msp430-elf-gcc -S -o- -Os -x c - <<< "int f(float a, float b) { return a != b; }"
```
does not mention `R13` at all. `__libgcc_cmp_return__` machine mode is 2 byte on MSP430, as well.

Differential Revision: https://reviews.llvm.org/D82635
The file was addedllvm/test/CodeGen/MSP430/cmp-return-type.ll
The file was modifiedllvm/lib/Target/MSP430/MSP430ISelLowering.h
Commit 0ee439b705e82a4fe20e266bc8fea96d0e60e1ec by anton
[builtins] Change si_int to int in some helper declarations

This patch changes types of some integer function arguments or return values from `si_int` to the default `int` type to make it more compatible with `libgcc`.

The compiler-rt/lib/builtins/README.txt has a link to the [libgcc specification](http://gcc.gnu.org/onlinedocs/gccint/Libgcc.html#Libgcc). This specification has an explicit note on `int`, `float` and other such types being just illustrations in some cases while the actual types are expressed with machine modes.

Such usage of always-32-bit-wide integer type may lead to issues on 16-bit platforms such as MSP430. Provided [libgcc2.h](https://gcc.gnu.org/git/?p=gcc.git;a=blob_plain;f=libgcc/libgcc2.h;hb=HEAD) can be used as a reference for all targets supported by the libgcc, this patch fixes some existing differences in helper declarations.

This patch is expected to not change behavior at all for targets with 32-bit `int` type.

Differential Revision: https://reviews.llvm.org/D81285
The file was modifiedcompiler-rt/lib/builtins/ctzdi2.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzsi2_test.c
The file was modifiedcompiler-rt/lib/builtins/clzdi2.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzti2_test.c
The file was modifiedcompiler-rt/lib/builtins/powidf2.c
The file was modifiedcompiler-rt/lib/builtins/powitf2.c
The file was modifiedcompiler-rt/test/builtins/Unit/clzdi2_test.c
The file was modifiedcompiler-rt/lib/builtins/paritydi2.c
The file was modifiedcompiler-rt/test/builtins/Unit/ffsti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/ctzti2_test.c
The file was modifiedcompiler-rt/lib/builtins/int_lib.h
The file was modifiedcompiler-rt/test/builtins/Unit/powidf2_test.c
The file was modifiedcompiler-rt/lib/builtins/popcountti2.c
The file was modifiedcompiler-rt/test/builtins/Unit/powitf2_test.c
The file was modifiedcompiler-rt/lib/builtins/powixf2.c
The file was modifiedcompiler-rt/test/builtins/Unit/paritysi2_test.c
The file was modifiedcompiler-rt/lib/builtins/ctzsi2.c
The file was modifiedcompiler-rt/lib/builtins/clzti2.c
The file was modifiedcompiler-rt/lib/builtins/paritysi2.c
The file was modifiedcompiler-rt/test/builtins/Unit/ctzsi2_test.c
The file was modifiedcompiler-rt/lib/builtins/powisf2.c
The file was modifiedcompiler-rt/test/builtins/Unit/popcountti2_test.c
The file was modifiedcompiler-rt/lib/builtins/README.txt
The file was modifiedcompiler-rt/lib/builtins/parityti2.c
The file was modifiedcompiler-rt/test/builtins/Unit/powixf2_test.c
The file was modifiedcompiler-rt/lib/builtins/ffsti2.c
The file was modifiedcompiler-rt/lib/builtins/clzsi2.c
The file was modifiedcompiler-rt/lib/builtins/popcountsi2.c
The file was modifiedcompiler-rt/test/builtins/Unit/parityti2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/paritydi2_test.c
The file was modifiedcompiler-rt/test/builtins/Unit/popcountsi2_test.c
The file was modifiedcompiler-rt/lib/builtins/ctzti2.c
The file was modifiedcompiler-rt/test/builtins/Unit/powisf2_test.c
Commit a976ea3209b5ad2310882c0895e0095ba4b04eef by gchatelet
[Alignment][NFC] Migrate PPC, X86 and XCore backends to Align

This patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Differential Revision: https://reviews.llvm.org/D82779
The file was modifiedllvm/lib/Target/PowerPC/PPCFrameLowering.cpp
The file was modifiedllvm/lib/Target/XCore/XCoreMachineFunctionInfo.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelDAGToDAG.cpp
The file was modifiedllvm/lib/Target/XCore/XCoreFrameLowering.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
Commit 5f8bdb3e6a997a3031a447db38bd3c358fee86e4 by gchatelet
[Alignment][NFC] TargetLowering::allowsMemoryAccess

Second patch of a series to adapt TargetLowering::allowsXXX functions

This patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Differential Revision: https://reviews.llvm.org/D82785
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelLoweringHVX.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelLowering.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelLowering.h
The file was modifiedllvm/lib/CodeGen/TargetLoweringBase.cpp
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Commit 60cde47893476581218c380921e5489c98be40ce by n.james93
[clang-tidy][docs] Fix malformed link in ReleaseNotes
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
Commit fe08ab542bd6328a7906e38ae473cf655eb6a228 by Xing
[DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

'InitialLength' is replaced with 'Format' (DWARF32 by default) and 'Length' in this patch.
Besides, test cases for DWARFv4 and DWARFv5, DWARF32 and DWARF64 is
added.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D82622
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml
The file was modifiedllvm/unittests/DebugInfo/GSYM/GSYMTest.cpp
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml
The file was modifiedllvm/lib/ObjectYAML/DWARFVisitor.cpp
The file was modifiedlldb/unittests/Expression/DWARFExpressionTest.cpp
The file was modifiedlldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_cu_ranges.yaml
The file was modifiedllvm/test/tools/llvm-gsymutil/ARM_AArch64/fat-macho-dwarf.yaml
The file was modifiedllvm/tools/obj2yaml/dwarf2yaml.cpp
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml
The file was modifiedllvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml
The file was modifiedllvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
The file was modifiedllvm/lib/ObjectYAML/DWARFYAML.cpp
The file was modifiedllvm/include/llvm/ObjectYAML/DWARFYAML.h
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF2-AddrSize8-FormValues.yaml
The file was modifiedllvm/lib/ObjectYAML/DWARFEmitter.cpp
The file was modifiedllvm/test/tools/llvm-gsymutil/X86/mach-dwarf.yaml
The file was modifiedlldb/unittests/Symbol/Inputs/inlined-functions.yaml
The file was modifiedllvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml
The file was modifiedllvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp
The file was modifiedlldb/test/API/functionalities/source-map/a.yaml
Commit 8577a090f5f04e18d72bb2dd387e60082e4da0ca by frgossen
[MLIR][Shape] Fix lowering of `shape.get_extent`

The declarative conversion patterns caused crashes in the asan configuration.
The non-declarative implementation circumvents this.

Differential Revision: https://reviews.llvm.org/D82797
The file was modifiedmlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
The file was modifiedmlir/lib/Conversion/ShapeToStandard/ShapeToStandardPatterns.td
Commit 39ea5d74b283d5a42f34b856d22bfaf806a1c907 by simon.tatham
Revert "Fix missing build dependency on omp_gen."

This reverts commit ed4328c607306a2aa6df4833a0dce4482edbc94c.

My change apparently caused a buildbot to fail with the error

  CMake Error at /b/sanitizer-x86_64-linux-autoconf/build/tsan_release_build/lib/cmake/llvm/AddLLVM.cmake:869 (add_dependencies):
  The dependency target "omp_gen" of target "ScudoBenchmarks.x86_64" does not
  exist.

I don't at all understand why, because as far as I can see, the target
`omp_gen` is only added to `LLVM_COMMON_DEPENDS` after having been
created, so there //should// be no way it can end up on anything's
dependency list if it doesn't exist! But apparently it happened anyway.

Differential Revision: https://reviews.llvm.org/D82659
The file was modifiedllvm/include/llvm/CMakeLists.txt
The file was modifiedllvm/include/llvm/Frontend/OpenMP/CMakeLists.txt
Commit 446b90135f0f88be4b8dddaf6a92842f94e7a43f by thomasraoux
[mlir] Fix case in MLIRGPUtoVulkanTransforms

This changes the casing of MLIRGPUtoVulkanTransforms to be consistent
with other transform libraries.

Differential Revision: https://reviews.llvm.org/D82840
The file was modifiedmlir/lib/Conversion/GPUToVulkan/CMakeLists.txt
Commit 4b980cc9ca08a0b95b4ac6994770155a48881729 by petar.avramovic
[GlobalISel][InlineAsm] Add support for matching input constraints

Find def operand that corresponds to matching constraint and
tie input to that operand.

Differential Revision: https://reviews.llvm.org/D82651
The file was addedllvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll
The file was modifiedllvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
Commit d7173826331eb2c263ecee607e86cebcf1c08ad7 by petar.avramovic
AMDGPU/GlobalISel: Select icmp intrinsic

Select into corresponding V_CMP instruction based on CmpInst predicate,
stored as immediate, in last operand.

Differential Revision: https://reviews.llvm.org/D82652
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
The file was addedllvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.icmp.ll
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
Commit 657c4ab39dc80f569f422d40347b97586c27b2ba by grimar
[yaml2obj] - Add a way to set default values for macros used in a YAML.

Currently we have to override all macros that are declared. But in many
cases it is convenient to use default values and to override only
a particular one or two.

This provides a way to set a default value for any macro:

```
Symbols:
  - Name: [[FOO=foo]]
```

Differential revision: https://reviews.llvm.org/D82455
The file was modifiedllvm/test/tools/yaml2obj/macro.yaml
The file was modifiedllvm/tools/yaml2obj/yaml2obj.cpp
Commit 64bae035ef8c1ca438c412310ef4f3906dd56b77 by grimar
[yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key.

It implements the way to describe a section content using a multi line description. E.g:

```
- Name:         .foo
  Type:         SHT_PROGBITS
  ContentArray: [ 0x11, 0x22, 0x33, 0x44,                                ## .long 11223344
                  0x55, 0x66,                                            ## .short 5566.
                  0x77,                                                  ## .byte 0x77
                  0x88, 0x99, 0xAA, 0xBB, 0xCC, 0xDD, 0xEE, 0xFF, 0x00 ] ## .quad 0x8899aabbccddeeff
```

It was briefly discussed in D75123 thread previously.

Differential revision: https://reviews.llvm.org/D82366
The file was modifiedllvm/include/llvm/ObjectYAML/ELFYAML.h
The file was modifiedllvm/lib/ObjectYAML/ELFYAML.cpp
The file was addedllvm/test/tools/yaml2obj/ELF/content-array.yaml

Summary

  1. [test-suite] Exclude another UB tests from the gcc-torture suite (details)
Commit 0bfeb655e49fc6feeeb63d534019019bf4bb4d7c by selliott
[test-suite] Exclude another UB tests from the gcc-torture suite

Reviewed By: lenary

Patch by Johannes Doerfert <johannes@jdoerfert.de>

Differential Revision: https://reviews.llvm.org/D77988
The file was modifiedSingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt (diff)