FailedChanges

Summary

  1. [lldb] Don't crash when LLDB can't extract the tsan report (details)
  2. [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library (details)
Commit 1c5a0cb1c3bffdae0d73acf8a23e31646b35c596 by Raphael Isemann
[lldb] Don't crash when LLDB can't extract the tsan report

Right now all tsan tests are crashing on Linux. The tests were already marked as
expected failures, but since commit 20ce8affce85d added an assert that every
StopInfo needs a non-empty stop description the tests actually started crash
(which is even with an expectedFailure a failed test).

The reason for that is that we never had any stop description when hitting tsan
errors on Linux. Before the assert that just made the test fail, but now the
empty description is hitting the assert. This patch just adds a generic stop
description mentioning tsan to prevent that we hit that assert on platforms
where we don't support extracting the tsan report.

Reviewed By: friss

Differential Revision: https://reviews.llvm.org/D86593
The file was modifiedlldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp
Commit e9a3d1a401b07cbf7b11695637f1b549782a26cd by Raphael Isemann
[FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

The actual FileCheck logic seems to be implemented in LLVMSupport. I don't see a
good reason for having FileCheck implemented there as it has a very specific use
while LLVMSupport is a dependency of pretty much every LLVM tool there is. In
fact, the only use of FileCheck I could find (outside the FileCheck tool and the
FileCheck unit test) is a single call in GISelMITest.h.

This moves the FileCheck logic to its own LLVMFileCheck library. This way only
FileCheck and the GlobalISelTests now have a dependency on this code.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86344
The file was addedllvm/utils/gn/secondary/llvm/lib/FileCheck/BUILD.gn
The file was removedllvm/include/llvm/Support/FileCheck.h
The file was modifiedllvm/utils/FileCheck/FileCheck.cpp
The file was modifiedllvm/utils/FileCheck/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn
The file was removedllvm/lib/Support/FileCheckImpl.h
The file was modifiedllvm/include/llvm/module.modulemap
The file was modifiedllvm/unittests/CMakeLists.txt
The file was addedllvm/unittests/FileCheck/CMakeLists.txt
The file was addedllvm/lib/FileCheck/FileCheck.cpp
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/BUILD.gn
The file was removedllvm/lib/Support/FileCheck.cpp
The file was modifiedllvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
The file was modifiedllvm/unittests/CodeGen/GlobalISel/GISelMITest.h
The file was modifiedllvm/lib/Support/CMakeLists.txt
The file was addedllvm/include/llvm/FileCheck/FileCheck.h
The file was addedllvm/unittests/FileCheck/FileCheckTest.cpp
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
The file was modifiedllvm/unittests/Support/CMakeLists.txt
The file was modifiedllvm/lib/CMakeLists.txt
The file was removedllvm/unittests/Support/FileCheckTest.cpp
The file was addedllvm/utils/gn/secondary/llvm/unittests/FileCheck/BUILD.gn
The file was addedllvm/lib/FileCheck/FileCheckImpl.h
The file was addedllvm/lib/FileCheck/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/GlobalISel/BUILD.gn