SuccessChanges

Summary

  1. [lldb] Improve test failure reporting for expect() (details)
  2. [PassManager] Move load/store motion pass after DSE in LTO pipeline. (details)
  3. [EarlyCSE] add tests for fma/fmuladd; NFC (details)
  4. [X86] Fix llvm-qualified-auto warning by using const auto*. NFC. (details)
  5. [X86] Fix llvm-qualified-auto warning by using auto*. NFC. (details)
  6. [X86] Avoid llvm-qualified-auto warning by not using auto. NFC. (details)
  7. [mlir] Add Acos, Asin, Atan, Sinh, Cosh, Pow to SPIRVGLSLOps (details)
  8. LowerEmuTLS.cpp - remove unused TargetLowering.h include. NFC. (details)
  9. [spirv] Add SPIR-V GLSL extended Round op (details)
  10. [mlir] Support default valued attribute in StructsGen (details)
  11. [mlir][VectorOps] Fall back to a loop when accessing a vector from a strided memref (details)
  12. [LLD][PowerPC][test] Fix out-of-memory issue running ppc64-pcrel-long-branch-error.s (details)
  13. [GVN] add tests for >2 arg commutable intrinsics; NFC (details)
  14. [IR][GVN] add/allow commutative intrinsics with >2 args (details)
  15. Fix spelling mistake. NFC. (details)
  16. X86/X86TargetObjectFile.cpp - remove unused headers. NFCI. (details)
Commit 9f18f3c858d5ff8154701a50c2be6f7b19667a1d by david.spickett
[lldb] Improve test failure reporting for expect()

This updates the errors reported by expect()
to something like:

```
Ran command:
"help"

Got output:
Debugger commands:
<...>

Expecting start string: "Debugger commands:" (was found)
Expecting end string: "foo" (was not found)
```
(see added tests for more examples)

This shows the user exactly what was run,
what checks passed and which failed. Along with
whether that check was supposed to pass.
(including what regex patterns matched)

These lines are also output to the test
trace file, whether the test passes or not.

Note that expect() will still fail at the first failed
check, in line with previous behaviour.

Also I have flipped the wording of the assert
message functions (.*_MSG) to describe failures
not successes. This makes more sense as they are
only shown on assert failures.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D86792
The file was modifiedlldb/packages/Python/lldbsuite/test/lldbtest.py
The file was addedlldb/test/API/assert_messages_test/TestAssertMessages.py
Commit 6de51189b07bbae853cc7c053dfb5f383c308c76 by flo
[PassManager] Move load/store motion pass after DSE in LTO pipeline.

As far as I am aware, the placement of MergedLoadStoreMotion in the
pipeline is not heavily tuned currently. It seems to not matter much if
we do it after DSE in the LTO pipeline (no binary changes for -O3 -flto
on MultiSource/SPEC2000/SPEC2006). Moving it after DSE however has a
major benefit: MemorySSA is constructed by LICM and is consumed by DSE,
so if MergedLoadStoreMotion happens after DSE, we do not need to
preserve MemorySSA in it.

If there are any concerns with this move, I can also update
MergedLoadStoreMotion to preserve MemorySSA.

This patch together with D86651 (preserve MemSSA in MemCpyOpt) and
D86534 (preserve MemSSA in GVN) are the remaining patches to bring down
compile-time for DSE + MemorySSA to the levels outlined in
http://lists.llvm.org/pipermail/llvm-dev/2020-August/144417.html

Once they land, we should be able to start with flipping the switch on
enabling DSE + MmeorySSA.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D86967
The file was modifiedllvm/lib/Transforms/IPO/PassManagerBuilder.cpp
Commit e1a3038689947f7b36dccdc7b8308881cd763a89 by spatel
[EarlyCSE] add tests for fma/fmuladd; NFC
The file was modifiedllvm/test/Transforms/EarlyCSE/commute.ll
Commit 5b2926974460c2486df7160e7273782e003812f6 by llvm-dev
[X86] Fix llvm-qualified-auto warning by using const auto*. NFC.
The file was modifiedllvm/lib/Target/X86/X86EvexToVex.cpp
Commit 23d9f4b958b8bc1f8862cad027b1f7c747bb5375 by llvm-dev
[X86] Fix llvm-qualified-auto warning by using auto*. NFC.
The file was modifiedllvm/lib/Target/X86/X86ISelDAGToDAG.cpp
Commit 890707aa0169a259ab8572091120756aec2d0c06 by llvm-dev
[X86] Avoid llvm-qualified-auto warning by not using auto. NFC.

Try to consistently use the actual type name in the file.
The file was modifiedllvm/lib/Target/X86/X86FixupBWInsts.cpp
Commit 2860b2c14b42af1d6204af9a546edc7993680452 by antiagainst
[mlir] Add Acos, Asin, Atan, Sinh, Cosh, Pow to SPIRVGLSLOps

Reviewed By: mravishankar, antiagainst

Differential Revision: https://reviews.llvm.org/D86929
The file was modifiedmlir/include/mlir/Dialect/SPIRV/SPIRVGLSLOps.td
The file was modifiedmlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir
The file was modifiedmlir/test/Dialect/SPIRV/glslops.mlir
Commit 91848b11b4cce3e0583ab0f1ab12333661f9c7ba by llvm-dev
LowerEmuTLS.cpp - remove unused TargetLowering.h include. NFC.

We only needed llvm/IR/Constants.h.
The file was modifiedllvm/lib/CodeGen/LowerEmuTLS.cpp
Commit 1e21ca4d25f9743a0efdb1775812da84f8f98fa2 by antiagainst
[spirv] Add SPIR-V GLSL extended Round op

Reviewed By: mravishankar, antiagainst

Differential Revision: https://reviews.llvm.org/D86914
The file was modifiedmlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir
The file was modifiedmlir/test/Dialect/SPIRV/glslops.mlir
The file was modifiedmlir/include/mlir/Dialect/SPIRV/SPIRVGLSLOps.td
Commit 7939b76e2a7b1fbc288f6d700bdbe53c581b58a6 by antiagainst
[mlir] Support default valued attribute in StructsGen

Its handling is similar to optional attributes, except for the
getter method.

Reviewed By: rsuderman

Differential Revision: https://reviews.llvm.org/D87055
The file was modifiedmlir/unittests/TableGen/structs.td
The file was modifiedmlir/unittests/TableGen/StructsGenTest.cpp
The file was modifiedmlir/tools/mlir-tblgen/StructsGen.cpp
Commit dfb7b3fe02c0e84968960f4aef88361e6de10874 by benny.kra
[mlir][VectorOps] Fall back to a loop when accessing a vector from a strided memref

The scalar loop is slow but correct.

Differential Revision: https://reviews.llvm.org/D87082
The file was modifiedmlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
The file was modifiedmlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
Commit db367ff2d8d038f61d09521d5e6a293528df3d54 by wei.huang
[LLD][PowerPC][test] Fix out-of-memory issue running ppc64-pcrel-long-branch-error.s

Following 97febb1, fix the out-of-memory error associated with buffering the output
in-memory by writing to an allocated file with the minimum offset and running it
on ppc system-linux only.

Peer reviewed by: nemanjai
The file was modifiedlld/test/ELF/ppc64-pcrel-long-branch-error.s
Commit 4013cfd34df363dfd8d963375d72349c5da2623c by spatel
[GVN] add tests for >2 arg commutable intrinsics; NFC
The file was modifiedllvm/test/Transforms/NewGVN/commute.ll
The file was modifiedllvm/test/Transforms/GVN/commute.ll
Commit bdd5bfd0e434637c44916fe2072b1d80fa022092 by spatel
[IR][GVN] add/allow commutative intrinsics with >2 args

Follow-up to D86798 and rGe25449f.
The file was modifiedllvm/lib/Transforms/Scalar/GVN.cpp
The file was modifiedllvm/test/Transforms/GVN/commute.ll
The file was modifiedllvm/include/llvm/IR/IntrinsicInst.h
Commit 0563cd6739c9516f0fefd02b1cbf5e82ef11da4f by llvm-dev
Fix spelling mistake. NFC.
The file was modifiedllvm/lib/Target/X86/X86TargetObjectFile.h
Commit 58afaecdc23148219d18d566dbaf79f37950f716 by llvm-dev
X86/X86TargetObjectFile.cpp - remove unused headers. NFCI.
The file was modifiedllvm/lib/Target/X86/X86TargetObjectFile.cpp