SuccessChanges

Summary

  1. [analyzer] [NFC] Introduce refactoring of PthreadLockChecker (details)
  2. [InstCombine] add bitwise logic fold tests for D86395; NFC (details)
  3. Add a new altera check for structure packing and alignment. (details)
  4. [clang] Limit the maximum level of fold-expr expansion. (details)
  5. [mlir][VectorOps] Fix more GCC5 weirdness (details)
  6. [NFC][ARM] Precommit test (details)
  7. [DSE,MemorySSA] Increase walker limit a bit. (details)
  8. [gn build] (manually) port 156b127945a8 (details)
  9. StructPackAlignCheck: Fix a -Winconsistent-missing-override warning (details)
  10. Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given" (details)
  11. [clang-tidy] Fix dynamic build failures after 156b127945a8c923d141e608b7380427da024376 (details)
  12. [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted type in WidenVecRes_Convert. (details)
Commit e67405141836fcd88183863758eeb42f32e847a6 by dpetrov
[analyzer] [NFC] Introduce refactoring of PthreadLockChecker

Change capitalization of some names due to LLVM naming rules.
Change names of some variables to make them more speaking.
Rework similar bug reports into one common function.

Prepare code for the next patches to reduce unrelated changes.

Differential Revision: https://reviews.llvm.org/D87138
The file was modifiedclang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
Commit 4964d75d7078b932ac6b17c1990adaa6eada75c1 by spatel
[InstCombine] add bitwise logic fold tests for D86395; NFC
The file was modifiedllvm/test/Transforms/InstCombine/xor.ll
Commit 156b127945a8c923d141e608b7380427da024376 by aaron
Add a new altera check for structure packing and alignment.

The altera struct pack align lint check finds structs that are inefficiently
packed or aligned and recommends packing/aligning of the structs using the
packed and aligned attributes as needed in a warning.
The file was modifiedclang-tools-extra/clang-tidy/CMakeLists.txt
The file was addedclang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/index.rst
The file was addedclang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was addedclang-tools-extra/test/clang-tidy/checkers/altera-struct-pack-align.cpp
The file was modifiedclang-tools-extra/clang-tidy/ClangTidyForceLinker.h
The file was addedclang-tools-extra/clang-tidy/altera/CMakeLists.txt
The file was addedclang-tools-extra/clang-tidy/altera/StructPackAlignCheck.h
The file was addedclang-tools-extra/docs/clang-tidy/checks/altera-struct-pack-align.rst
Commit 9c9974c3ccb6468cc83f759240293538cf123fcd by hokein.wu
[clang] Limit the maximum level of fold-expr expansion.

Introduce a new diagnostic, and respect the bracket-depth (256) by default.

Differential Revision: https://reviews.llvm.org/D86936
The file was modifiedclang/lib/Sema/TreeTransform.h
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was addedclang/test/SemaCXX/fold_expr_expansion_limit.cpp
Commit 51d30c3429fa0f46bf8c0e4a38840952c11be4f9 by benny.kra
[mlir][VectorOps] Fix more GCC5 weirdness

VectorToSCF.cpp:515:47: error: specialization of 'template<class TransferOpTy> mlir::LogicalResult mlir::VectorTransferRewriter<TransferOpTy>::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const' in different namespace [-fpermissive]
The file was modifiedmlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
Commit 94cfbef0a74ec3e5490878dc417fea5ecfcf2a6a by sam.parker
[NFC][ARM] Precommit test
The file was addedllvm/test/CodeGen/Thumb2/LowOverheadLoops/remat-vctp.ll
Commit c7b7c32f4a25d15e992215c8524871bef47d959b by flo
[DSE,MemorySSA] Increase walker limit a bit.

This slightly bumps the walker limit so that it covers more cases while
not increasing compile-time too much:
http://llvm-compile-time-tracker.com/compare.php?from=0fc1c2b51ba0cfb9145139af35be638333865251&to=91144a50ea4fa82c0c877e77784f60371640b263&stat=instructions
The file was modifiedllvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
Commit e09e1d97c112ef9488b2f88db560d3d459c0652e by thakis
[gn build] (manually) port 156b127945a8
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
The file was addedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/altera/BUILD.gn
Commit 9933188c90615c9c264ebb69117f09726e909a25 by thakis
StructPackAlignCheck: Fix a -Winconsistent-missing-override warning
The file was modifiedclang-tools-extra/clang-tidy/altera/StructPackAlignCheck.h
Commit 2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79 by hans
Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given"

This caused more warnings than expected, see https://crbug.com/1126019

Also reverts the follow-up 7907e5516.

> Differential Revision: https://reviews.llvm.org/D86369
The file was modifiedclang/test/SemaCXX/no-rtti.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticGroups.td
The file was modifiedclang/lib/Sema/SemaExprCXX.cpp
The file was removedclang/test/SemaCXX/ms_no_dynamic_cast.cpp
The file was removedclang/test/SemaCXX/no_dynamic_cast.cpp
The file was modifiedclang/lib/Sema/SemaCast.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
Commit 32ae37b038b16a1ff9c81428ae4f003377439a22 by hokein.wu
[clang-tidy] Fix dynamic build failures after 156b127945a8c923d141e608b7380427da024376
The file was modifiedclang-tools-extra/clang-tidy/altera/CMakeLists.txt
Commit 6dc3e22b575267d2ede36f741bb9eb2455f36cff by paulsson
[DAGTypeLegalizer] Handle ZERO_EXTEND of promoted type in WidenVecRes_Convert.

On SystemZ, a ZERO_EXTEND of an i1 vector handled by WidenVecRes_Convert()
always ended up being scalarized, because the type action of the input is
promotion which was previously an unhandled case in this method.

This fixes https://bugs.llvm.org/show_bug.cgi?id=47132.

Differential Revision: https://reviews.llvm.org/D86268

Patch by Eli Friedman.
Review: Ulrich Weigand
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
The file was modifiedllvm/test/CodeGen/SystemZ/vec-zext.ll