FailedChanges

Summary

  1. Temporairly revert "Thread safety analysis: Consider global variables in scope" & followup (details)
  2. Rename MemRefDescriptor::getElementType() to MemRefDescriptor::getElementPtrType(). (details)
  3. [AMDGPU] Workaround for LDS Misalignment bug on GFX10 (details)
  4. [ARM] Fixup of a few test cases. NFC. (details)
  5. [DomTree] Use SmallVector<DomTreeNodeBase *, 4> instead of std::vector. (details)
  6. [NFC][Asan] Fit ChunkHeader into redzone (details)
  7. [APFloat] Fix uninitialized variable in IEEEFloat constructors (details)
  8. ARMTargetParser.cpp - use auto const references in for range loops. NFCI. (details)
  9. TrigramIndex.cpp - remove unnecessary includes. NFCI. (details)
  10. [ValueTracking] Add UndefOrPoison/Poison-only version of relevant functions (details)
  11. [flang]Add Semantic Checks for OpenMP Allocate Clause (details)
Commit 8427885e27813c457dccb011f65e8ded74444e31 by lebedev.ri
Temporairly revert "Thread safety analysis: Consider global variables in scope" & followup

This appears to cause false-positives because it started to warn on local non-global variables.

Repro posted to https://reviews.llvm.org/D84604#2262745

This reverts commit 9dcc82f34ea9b623d82d2577b93aaf67d36dabd2.
This reverts commit b2ce79ef66157dd752e3864ece57915e23a73f5d.
The file was modifiedclang/lib/Analysis/ThreadSafety.cpp
The file was modifiedclang/lib/Analysis/ThreadSafetyCommon.cpp
The file was modifiedclang/test/SemaCXX/warn-thread-safety-negative.cpp
The file was modifiedclang/test/SemaCXX/warn-thread-safety-analysis.cpp
Commit 3a577f544618d9713aca5052e55143142d23f427 by csigg
Rename MemRefDescriptor::getElementType() to MemRefDescriptor::getElementPtrType().

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D87284
The file was modifiedmlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
The file was modifiedmlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
The file was modifiedmlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
Commit 43af2a6faa272565cde4e3eec7dfeac593d29701 by Mirko.Brkusanin
[AMDGPU] Workaround for LDS Misalignment bug on GFX10

Add subtarget feature check to avoid using ds_read/write_b96/128 with too
low alignment if a bug is present on that specific hardware.
Add this "feature" to GFX 10.1.1 as it is also affected.
Add global-isel test.
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
The file was addedllvm/test/CodeGen/AMDGPU/GlobalISel/lds-misaligned-bug.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/lds-misaligned-bug.ll
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPU.td
Commit 8cb8cea1bd7f03330fc310b8993a3be89da90c1d by sjoerd.meijer
[ARM] Fixup of a few test cases. NFC.

After changing the semantics of get.active.lane.mask, I missed a few tests
that should use now the tripcount instead of the backedge taken count.
The file was modifiedllvm/test/CodeGen/Thumb2/active_lane_mask.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/tail-pred-intrinsic-sub-sat.ll
The file was modifiedllvm/test/Verifier/get-active-lane-mask.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/reductions.ll
Commit 3a61bfb027a623807a30adb496ab62203c9b4ba5 by flo
[DomTree] Use SmallVector<DomTreeNodeBase *, 4> instead of std::vector.

Currentl DomTreeNodeBase is using std::vectot to store it's children.
Using SmallVector should be more efficient in terms of compile-time.

A size of 4 seems to be the sweet-spot in terms of compile-time,
according to

http://llvm-compile-time-tracker.com/compare.php?from=9933188c90615c9c264ebb69117f09726e909a25&to=d7a801d027648877b20f0e00e822a7a64c58d976&stat=instructions

This results in the following geomean improvements

```
                       geomean insts     max rss
O3                          -0.31 %       +0.02 %
ReleaseThinLTO              -0.35 %       -0.12 %
ReleaseLTO                  -0.28 %       -0.12 %
O0                          -0.06 %       -0.02 %
NewPM O3                    -0.36 %       +0.05 %
ReleaseThinLTO (link only)  -0.44 %       -0.10 %
ReleaseLTO-g (link only):   -0.32 %       -0.03 %
```

I am not sure if there's any other benefits of using std::vector over
SmallVector.

Reviewed By: kuhar, asbirlea

Differential Revision: https://reviews.llvm.org/D87319
The file was modifiedllvm/include/llvm/Support/GenericDomTree.h
Commit b5bc56da8aa23dc57db9d286b0591dbcf9b1bdd3 by Vitaly Buka
[NFC][Asan] Fit ChunkHeader into redzone

In code as-is min redzone and ChunkHeader are 16 byte.
This patch just makes sure that redzone is calculated correctly if we
extend ChunkHeader.
The file was modifiedcompiler-rt/lib/asan/asan_allocator.cpp
Commit 24ecfdac7b7d195795b6cb0e373cba8bfa7911f4 by llvm-dev
[APFloat] Fix uninitialized variable in IEEEFloat constructors

Some constructors of IEEEFloat do not initialize member variable exponent.
Fix it by initializing exponent with the following values:

For NaNs, the `exponent` is `maxExponent+1`.
For Infinities, the `exponent` is `maxExponent+1`.
For Zeroes, the `exponent` is `maxExponent-1`.

Patch by: @nullptr.cpp (Yang Fan)

Differential Revision: https://reviews.llvm.org/D86997
The file was modifiedllvm/lib/Support/APFloat.cpp
The file was modifiedllvm/include/llvm/ADT/APFloat.h
Commit f16b2d83154aed71aaf9a0717fbb0199d027f312 by llvm-dev
ARMTargetParser.cpp - use auto const references in for range loops. NFCI.

Fix static analysis warnings about unnecessary copies.
The file was modifiedllvm/lib/Support/ARMTargetParser.cpp
Commit 455cce3e216ba3cac0844b4ee9cf85791c1ac046 by llvm-dev
TrigramIndex.cpp - remove unnecessary includes. NFCI.

TrigramIndex.h already includes most of these.
The file was modifiedllvm/include/llvm/Support/TrigramIndex.h
The file was modifiedllvm/lib/Support/TrigramIndex.cpp
Commit 25ce1e0497259711836f949005297125e92a6e93 by aqjune
[ValueTracking] Add UndefOrPoison/Poison-only version of relevant functions

This patch adds isGuaranteedNotToBePoison and programUndefinedIfUndefOrPoison.

isGuaranteedNotToBePoison will be used at D75808. The latter function is used at isGuaranteedNotToBePoison.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D84242
The file was modifiedllvm/include/llvm/Analysis/ValueTracking.h
The file was modifiedllvm/lib/Transforms/Scalar/IndVarSimplify.cpp
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
The file was modifiedllvm/lib/Analysis/ValueTracking.cpp
The file was modifiedllvm/unittests/Analysis/ValueTrackingTest.cpp
The file was modifiedllvm/lib/Transforms/Instrumentation/PoisonChecking.cpp
Commit 0fd425af071a9bc5c0891a4db09f4d9a466b7be9 by caroline.concatto
[flang]Add Semantic Checks for OpenMP Allocate Clause

Reviewed By: kiranchandramohan, clementval, kiranktp, raghavendhra

Differential Revision: https://reviews.llvm.org/D86051
The file was modifiedflang/include/flang/Semantics/symbol.h
The file was modifiedflang/test/Semantics/omp-clause-validity01.f90
The file was addedflang/test/Semantics/omp-resolve06.f90
The file was modifiedflang/lib/Semantics/resolve-directives.cpp
The file was modifiedflang/lib/Semantics/check-omp-structure.cpp
The file was modifiedflang/lib/Semantics/check-omp-structure.h