FailedChanges

Summary

  1. [WebAssembly] Define the signature for __stack_chk_fail The WebAssembly backend needs to know the signatures of all runtime libcall functions. This adds the signature for __stack_chk_fail which was previously missing. Also, make the error message for a missing libcall include the name of the function. Differential Revision: https://reviews.llvm.org/D59521 Reviewed By: sbc100
  2. [PowerPC] Try harder to avoid load/move-to VSR for partial vector loads Change the PPCISelLowering.cpp function that decides to avoid update form in favor of partial vector loads to know about newer load types and to not be confused by the chain operand. Differential Revision: https://reviews.llvm.org/D60102
  3. [GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h This was falling back and gives us a reason to create a selectIntrinsic function which we would need eventually anyway. Update arm64-crypto.ll to show that we correctly select it. Also factor out the code for finding an intrinsic ID.
  4. [UpdateTestChecks] Allow Lbegin_func without a leading period On mingw/i686, local labels don't start with a leading period. Also escape the leading period, as it previously could match any char. Differential Revision: https://reviews.llvm.org/D61254
  5. [X86] Run CFIInstrInserter on Windows if Dwarf is used This is necessary since SVN r330706, as tail merging can include CFI instructions since then. This fixes PR40322 and PR40012. Differential Revision: https://reviews.llvm.org/D61252
  6. Fix one more case of passing options with too many dashes.
Revision 359505 by djg:
[WebAssembly] Define the signature for __stack_chk_fail

The WebAssembly backend needs to know the signatures of all runtime
libcall functions. This adds the signature for __stack_chk_fail which was
previously missing.

Also, make the error message for a missing libcall include the name of
the function.

Differential Revision: https://reviews.llvm.org/D59521

Reviewed By: sbc100
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpptrunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
The file was added/llvm/trunk/test/CodeGen/WebAssembly/stack-protector.lltrunk/test/CodeGen/WebAssembly/stack-protector.ll
Revision 359504 by froese:
[PowerPC] Try harder to avoid load/move-to VSR for partial vector loads

Change the PPCISelLowering.cpp function that decides to avoid update form in
favor of partial vector loads to know about newer load types and to not be
confused by the chain operand.

Differential Revision: https://reviews.llvm.org/D60102
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpptrunk/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/PowerPC/pre-inc-disable.lltrunk/test/CodeGen/PowerPC/pre-inc-disable.ll
Revision 359501 by paquette:
[GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h

This was falling back and gives us a reason to create a selectIntrinsic function
which we would need eventually anyway. Update arm64-crypto.ll to show that we
correctly select it.

Also factor out the code for finding an intrinsic ID.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.cpptrunk/lib/Target/AArch64/AArch64InstructionSelector.cpp
The file was modified/llvm/trunk/test/CodeGen/AArch64/arm64-crypto.lltrunk/test/CodeGen/AArch64/arm64-crypto.ll
Revision 359497 by mstorsjo:
[UpdateTestChecks] Allow Lbegin_func without a leading period

On mingw/i686, local labels don't start with a leading period.

Also escape the leading period, as it previously could match
any char.

Differential Revision: https://reviews.llvm.org/D61254
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/UpdateTestChecks/asm.pytrunk/utils/UpdateTestChecks/asm.py
Revision 359496 by mstorsjo:
[X86] Run CFIInstrInserter on Windows if Dwarf is used

This is necessary since SVN r330706, as tail merging can include
CFI instructions since then.

This fixes PR40322 and PR40012.

Differential Revision: https://reviews.llvm.org/D61252
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86TargetMachine.cpptrunk/lib/Target/X86/X86TargetMachine.cpp
The file was added/llvm/trunk/test/CodeGen/X86/PR40322.lltrunk/test/CodeGen/X86/PR40322.ll
Revision 359495 by dhinton:
Fix one more case of passing options with too many dashes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/gold/X86/strip_names.lltrunk/test/tools/gold/X86/strip_names.ll

Summary

  1. [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. Summary: We are currently implementing support in LLDB that reconstructs the STL templates from the target program in the expression evaluator. This reconstruction happens during the import process from our debug info AST into the expression evaluation AST, which means we need a way to intercept the ASTImporter import process. This patch adds an protected ImportImpl method that we can overwrite in LLDB to implement our special importing logic (which is essentially just looking into a C++ module that is attached to the target context). Because ImportImpl has to call MapImported/AddToLookup for the decls it creates, this patch also exposes those via a new unified method and checks that we call it when importing decls. Reviewers: martong, balazske, a.sidorin, shafik, a_sidorin Reviewed By: martong, a_sidorin Subscribers: rnkovacs, cfe-commits, lldb-commits, aprantl Tags: #clang Differential Revision: https://reviews.llvm.org/D59485
Revision 359502 by Raphael Isemann:
[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

Summary:
We are currently implementing support in LLDB that reconstructs the STL templates from
the target program in the expression evaluator. This reconstruction happens during the
import process from our debug info AST into the expression evaluation AST, which means
we need a way to intercept the ASTImporter import process.

This patch adds an protected ImportImpl method that we can overwrite in LLDB to implement
our special importing logic (which is essentially just looking into a C++ module that is attached to
the target context). Because ImportImpl has to call MapImported/AddToLookup for the decls it
creates, this patch also exposes those via a new unified method and checks that we call it when
importing decls.

Reviewers: martong, balazske, a.sidorin, shafik, a_sidorin

Reviewed By: martong, a_sidorin

Subscribers: rnkovacs, cfe-commits, lldb-commits, aprantl

Tags: #clang

Differential Revision: https://reviews.llvm.org/D59485
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/ASTImporter.htrunk/include/clang/AST/ASTImporter.h
The file was modified/cfe/trunk/lib/AST/ASTImporter.cpptrunk/lib/AST/ASTImporter.cpp
The file was modified/cfe/trunk/unittests/AST/ASTImporterTest.cpptrunk/unittests/AST/ASTImporterTest.cpp

Summary

  1. Fix FIXME added in r359339 We have windows.h in asan_win.cc, so we can just use the correct prototypes for these EH-related interceptors without worrying. Also fix an unused variable warning while I'm here.
  2. Pacify sanitizer lint script after r359498
  3. [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc HeapReAlloc should allow for 0 sized reallocations without freeing the memory block provided by the user. _recalloc previously did not zero new memory after reallocation. https://reviews.llvm.org/D61268
Revision 359500 by rnk:
Fix FIXME added in r359339

We have windows.h in asan_win.cc, so we can just use the correct
prototypes for these EH-related interceptors without worrying.

Also fix an unused variable warning while I'm here.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_malloc_win.cctrunk/lib/asan/asan_malloc_win.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_win.cctrunk/lib/asan/asan_win.cc
Revision 359499 by rnk:
Pacify sanitizer lint script after r359498
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_malloc_win.cctrunk/lib/asan/asan_malloc_win.cc
Revision 359498 by mcgov:
[AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc

HeapReAlloc should allow for 0 sized reallocations without freeing the memory block provided by the user.

_recalloc previously did not zero new memory after reallocation.
https://reviews.llvm.org/D61268
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_malloc_win.cctrunk/lib/asan/asan_malloc_win.cc
The file was added/compiler-rt/trunk/test/asan/TestCases/Windows/heaprealloc_zero_size.cctrunk/test/asan/TestCases/Windows/heaprealloc_zero_size.cc
The file was added/compiler-rt/trunk/test/asan/TestCases/Windows/recalloc_sanity.cctrunk/test/asan/TestCases/Windows/recalloc_sanity.cc