FailedChanges

Summary

  1. Add __builtin_dcbf support for PPC Summary: This patch adds support for __builtin_dcbf for PPC. __builtin_dcbf copies the contents of a modified block from the data cache to main memory and flushes the copy from the data cache. Differential revision: https://reviews.llvm.org/D59843
  2. [PDB] Fix hash function used to write /src/headerblock lld-link used to write PDB files that DIA couldn't recover natvis files from if: - The global strings table was > 64kiB - There were at least 3 natvis files The cause was that the hash function for the /src/headerblock stream was incorrect: It needs to be truncated to 16 bit. If the global strings table was <= 64kiB, truncating to 16 bit is a no-op, so this wasn't needed for small programs. If there are only 1 or 2 natvis files, then the growth strategy in HashTable::grow() would mean the hash table would have 2 buckets (for 1 natvis file) or 4 buckets (for 4 natvis files), and since the hash function is used modulo number of buckets, and since 2 and 4 divide 0x10000, the missing `% 0x10000` is a no-op there too. For 3 natvis files, the hash table grows to 6 buckets, which has a factor that's not common with 0x10000 and the difference starts to matter. Fixes PR41626. Differential Revision: https://reviews.llvm.org/D61277
  3. gn build: Merge r359252
  4. [ORC] Replace the LLJIT/LLLazyJIT Create methods with Builder utilities. LLJITBuilder and LLLazyJITBuilder construct LLJIT and LLLazyJIT instances respectively. Over time these will allow more configurable options to be added while remaining easy to use in the default case, which for default in-process JITing is now: auto J = ExitOnErr(LLJITBuilder.create());
  5. [JITLink] Move a typedef. The FinalizeContinuation typedef belongs on the Allocation class, not the allocator.
  6. [WebAssembly] Make an assertion message prettier. NFC. This is a follow-up to https://reviews.llvm.org/D59521.
Revision 359517 by saghir:
Add __builtin_dcbf support for PPC

Summary:
This patch adds support for __builtin_dcbf for PPC.

__builtin_dcbf copies the contents of a modified block from the data cache
to main memory and flushes the copy from the data cache.

Differential revision: https://reviews.llvm.org/D59843
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LanguageExtensions.rstN/A
The file was modified/cfe/trunk/include/clang/Basic/BuiltinsPPC.defN/A
The file was added/cfe/trunk/test/CodeGen/builtins-ppc-cache.cN/A
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicsPowerPC.tdtrunk/include/llvm/IR/IntrinsicsPowerPC.td
The file was added/llvm/trunk/test/CodeGen/PowerPC/dcbf.lltrunk/test/CodeGen/PowerPC/dcbf.ll
Revision 359515 by nico:
[PDB] Fix hash function used to write /src/headerblock

lld-link used to write PDB files that DIA couldn't recover natvis
files from if:

- The global strings table was > 64kiB
- There were at least 3 natvis files

The cause was that the hash function for the /src/headerblock stream
was incorrect: It needs to be truncated to 16 bit.

If the global strings table was <= 64kiB, truncating to 16 bit is a
no-op, so this wasn't needed for small programs.

If there are only 1 or 2 natvis files, then the growth strategy in
HashTable::grow() would mean the hash table would have 2 buckets (for 1
natvis file) or 4 buckets (for 4 natvis files), and since the hash
function is used modulo number of buckets, and since 2 and 4 divide
0x10000, the missing `% 0x10000` is a no-op there too. For 3 natvis
files, the hash table grows to 6 buckets, which has a factor that's not
common with 0x10000 and the difference starts to matter.

Fixes PR41626.

Differential Revision: https://reviews.llvm.org/D61277
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.htrunk/include/llvm/DebugInfo/PDB/Native/HashTable.h
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/NamedStreamMap.cpptrunk/lib/DebugInfo/PDB/Native/NamedStreamMap.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpptrunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp
The file was modified/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpptrunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp
Revision 359514 by nico:
gn build: Merge r359252
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/llvm/unittests/ExecutionEngine/Orc/BUILD.gntrunk/utils/gn/secondary/llvm/unittests/ExecutionEngine/Orc/BUILD.gn
Revision 359511 by Lang Hames:
[ORC] Replace the LLJIT/LLLazyJIT Create methods with Builder utilities.

LLJITBuilder and LLLazyJITBuilder construct LLJIT and LLLazyJIT instances
respectively. Over time these will allow more configurable options to be
added while remaining easy to use in the default case, which for default
in-process JITing is now:

auto J = ExitOnErr(LLJITBuilder.create());
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ExecutionEngine/Orc/LLJIT.htrunk/include/llvm/ExecutionEngine/Orc/LLJIT.h
The file was modified/llvm/trunk/lib/ExecutionEngine/Orc/LLJIT.cpptrunk/lib/ExecutionEngine/Orc/LLJIT.cpp
The file was modified/llvm/trunk/tools/lli/lli.cpptrunk/tools/lli/lli.cpp
Revision 359510 by Lang Hames:
[JITLink] Move a typedef.

The FinalizeContinuation typedef belongs on the Allocation class, not the
allocator.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ExecutionEngine/JITLink/JITLink.htrunk/include/llvm/ExecutionEngine/JITLink/JITLink.h
Revision 359509 by djg:
[WebAssembly] Make an assertion message prettier. NFC.

This is a follow-up to https://reviews.llvm.org/D59521.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpptrunk/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp

Summary

  1. Add __builtin_dcbf support for PPC Summary: This patch adds support for __builtin_dcbf for PPC. __builtin_dcbf copies the contents of a modified block from the data cache to main memory and flushes the copy from the data cache. Differential revision: https://reviews.llvm.org/D59843
  2. [Diagnostics] Support -Wtype-limits for GCC compatibility Summary: GCC's -Wtype-limits (part of -Wextra): Warn if a comparison is always true or always false due to the limited range of the data type Reviewers: rsmith, aaron.ballman, lebedev.ri, thakis Reviewed By: rsmith Subscribers: lebedev.ri, jdoerfert, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58841
  3. Re-land r359250, [COFF] Statically link certain runtime library functions Reverts the revert of r359251, this time with fixed tests. Differential Revision: https://reviews.llvm.org/D55229
  4. Make test more robust by writing stdout/stderr to different files. Our internal build bots were failing this test randomly as the stderr output was emitted to the file in the middle of the stdout output line that the test was checking.
Revision 359517 by saghir:
Add __builtin_dcbf support for PPC

Summary:
This patch adds support for __builtin_dcbf for PPC.

__builtin_dcbf copies the contents of a modified block from the data cache
to main memory and flushes the copy from the data cache.

Differential revision: https://reviews.llvm.org/D59843
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LanguageExtensions.rsttrunk/docs/LanguageExtensions.rst
The file was modified/cfe/trunk/include/clang/Basic/BuiltinsPPC.deftrunk/include/clang/Basic/BuiltinsPPC.def
The file was added/cfe/trunk/test/CodeGen/builtins-ppc-cache.ctrunk/test/CodeGen/builtins-ppc-cache.c
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicsPowerPC.tdN/A
The file was added/llvm/trunk/test/CodeGen/PowerPC/dcbf.llN/A
Revision 359516 by xbolva00:
[Diagnostics] Support -Wtype-limits for GCC compatibility

Summary:
GCC's  -Wtype-limits (part of -Wextra):
Warn if a comparison is always true or always false due to the limited range of the data type

Reviewers: rsmith, aaron.ballman, lebedev.ri, thakis

Reviewed By: rsmith

Subscribers: lebedev.ri, jdoerfert, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D58841
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticGroups.tdtrunk/include/clang/Basic/DiagnosticGroups.td
The file was modified/cfe/trunk/test/Sema/compare.ctrunk/test/Sema/compare.c
The file was modified/cfe/trunk/test/Sema/tautological-constant-compare.ctrunk/test/Sema/tautological-constant-compare.c
The file was modified/cfe/trunk/test/Sema/tautological-constant-enum-compare.ctrunk/test/Sema/tautological-constant-enum-compare.c
The file was modified/cfe/trunk/test/SemaCXX/compare.cpptrunk/test/SemaCXX/compare.cpp
Revision 359513 by rnk:
Re-land r359250, [COFF] Statically link certain runtime library functions

Reverts the revert of r359251, this time with fixed tests.

Differential Revision: https://reviews.llvm.org/D55229
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cpptrunk/lib/CodeGen/CodeGenModule.cpp
The file was added/cfe/trunk/test/CodeGenCXX/dllimport-runtime-fns.cpptrunk/test/CodeGenCXX/dllimport-runtime-fns.cpp
The file was modified/cfe/trunk/test/CodeGenCXX/runtime-dllstorage.cpptrunk/test/CodeGenCXX/runtime-dllstorage.cpp
The file was modified/cfe/trunk/test/CodeGenObjC/gnu-init.mtrunk/test/CodeGenObjC/gnu-init.m
The file was modified/cfe/trunk/test/CodeGenObjCXX/msabi-stret.mmtrunk/test/CodeGenObjCXX/msabi-stret.mm
Revision 359512 by dyung:
Make test more robust by writing stdout/stderr to different files.

Our internal build bots were failing this test randomly as the stderr
output was emitted to the file in the middle of the stdout output
line that the test was checking.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Index/missing_vfs.ctrunk/test/Index/missing_vfs.c