FailedChanges

Summary

  1. vs integration: vs2019 support
  2. [cmake] Fix error message on simulated VS version check For clang-cl self hosts in VS2015 environment this was reporting: "Host Clang must have at least -fms-compatibility-version=19.00.24213.1, your version is 9.0.0". This check fires as CMake detects the simulated environment as _MSC_VER 1900, which is truncated. This makes it less than the required 19.00.24213.1. Differential revision: https://reviews.llvm.org/D61188
  3. Revert rL359519 : [MemorySSA] Invalidate MemorySSA if AA or DT are invalidated. Summary: MemorySSA keeps internal pointers of AA and DT. If these get invalidated, so should MemorySSA. Reviewers: george.burgess.iv, chandlerc Subscribers: jlebar, Prazek, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61043 ........ This was causing windows build bot failures
  4. [SLP] Lit test that cannot get vectorized due to lack of look-ahead operand reordering heuristic. The code in this test is not vectorized by SLP because its operand reordering cannot look beyond the immediate predecessors. This will get fixed in a follow-up patch that introduces the look-ahead operand reordering heuristic. Committed on behalf of @vporpo (Vasileios Porpodas) Differential Revision: https://reviews.llvm.org/D61283
  5. [llvm-objcopy] - Check dynamic relocation sections for broken references. This is a fix for https://bugs.llvm.org/show_bug.cgi?id=41371. Currently, it is possible to break the sh_link field of the dynamic relocation section by removing the section it refers to. The patch fixes an issue and adds 2 test cases. One of them shows that it does not seem possible to break the sh_info field. I added an assert to verify this. Differential revision: https://reviews.llvm.org/D60825
  6. Update checks in an instcombine test, NFC This reduces the delta in some incoming work that changes this test.
  7. [ARM] Implement TTI::getMemcpyCost This implements TargetTransformInfo method getMemcpyCost, which estimates the number of instructions to which a memcpy instruction expands to. Differential Revision: https://reviews.llvm.org/D59787
  8. Fix for bug 41512: lower INSERT_VECTOR_ELT(ZeroVec, 0, Elt) to SCALAR_TO_VECTOR(Elt) for all SSE flavors Current LLVM uses pxor+pinsrb on SSE4+ for INSERT_VECTOR_ELT(ZeroVec, 0, Elt) insead of much simpler movd. INSERT_VECTOR_ELT(ZeroVec, 0, Elt) is idiomatic construct which is used e.g. for _mm_cvtsi32_si128(Elt) and for lowest element initialization in _mm_set_epi32. So such inefficient lowering leads to significant performance digradations in ceratin cases switching from SSSE3 to SSE4. https://bugs.llvm.org/show_bug.cgi?id=41512 Here INSERT_VECTOR_ELT(ZeroVec, 0, Elt) is simply converted to SCALAR_TO_VECTOR(Elt) when applicable since latter is closer match to desired behavior and always efficiently lowered to movd and alike. Committed on behalf of @Serge_Preis (Serge Preis) Differential Revision: https://reviews.llvm.org/D60852
Revision 359557 by hans:
vs integration: vs2019 support
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/msbuild/source.extension.vsixmanifesttrunk/tools/msbuild/source.extension.vsixmanifest
Revision 359556 by russell_gallop:
[cmake] Fix error message on simulated VS version check

For clang-cl self hosts in VS2015 environment this was reporting: "Host
Clang must have at least -fms-compatibility-version=19.00.24213.1, your
version is 9.0.0".

This check fires as CMake detects the simulated environment as _MSC_VER
1900, which is truncated. This makes it less than the required
19.00.24213.1.

Differential revision: https://reviews.llvm.org/D61188
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/modules/CheckCompilerVersion.cmaketrunk/cmake/modules/CheckCompilerVersion.cmake
Revision 359555 by rksimon:
Revert rL359519 : [MemorySSA] Invalidate MemorySSA if AA or DT are invalidated.

Summary:
MemorySSA keeps internal pointers of AA and DT.
If these get invalidated, so should MemorySSA.

Reviewers: george.burgess.iv, chandlerc

Subscribers: jlebar, Prazek, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D61043
........
This was causing windows build bot failures
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/MemorySSA.htrunk/include/llvm/Analysis/MemorySSA.h
The file was modified/llvm/trunk/lib/Analysis/MemorySSA.cpptrunk/lib/Analysis/MemorySSA.cpp
The file was removed/llvm/trunk/test/Analysis/MemorySSA/invalidate.lltrunk/test/Analysis/MemorySSA/invalidate.ll
Revision 359553 by rksimon:
[SLP] Lit test that cannot get vectorized due to lack of look-ahead operand reordering heuristic.

The code in this test is not vectorized by SLP because its operand reordering cannot look beyond the immediate predecessors.
This will get fixed in a follow-up patch that introduces the look-ahead operand reordering heuristic.

Committed on behalf of @vporpo (Vasileios Porpodas)

Differential Revision: https://reviews.llvm.org/D61283
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/SLPVectorizer/X86/lookahead.lltrunk/test/Transforms/SLPVectorizer/X86/lookahead.ll
Revision 359552 by grimar:
[llvm-objcopy] - Check dynamic relocation sections for broken references.

This is a fix for https://bugs.llvm.org/show_bug.cgi?id=41371.

Currently, it is possible to break the sh_link field of the dynamic relocation section
by removing the section it refers to. The patch fixes an issue and adds 2 test cases.

One of them shows that it does not seem possible to break the sh_info field.
I added an assert to verify this.

Differential revision: https://reviews.llvm.org/D60825
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shinfo-reference.testtrunk/test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shinfo-reference.test
The file was added/llvm/trunk/test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shlink-reference.testtrunk/test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shlink-reference.test
The file was modified/llvm/trunk/tools/llvm-objcopy/ELF/Object.cpptrunk/tools/llvm-objcopy/ELF/Object.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/ELF/Object.htrunk/tools/llvm-objcopy/ELF/Object.h
Revision 359549 by jmorse:
Update checks in an instcombine test, NFC

This reduces the delta in some incoming work that changes this test.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/sub.lltrunk/test/Transforms/InstCombine/sub.ll
Revision 359547 by sjoerdmeijer:
[ARM] Implement TTI::getMemcpyCost

This implements TargetTransformInfo method getMemcpyCost, which estimates the
number of instructions to which a memcpy instruction expands to.

Differential Revision: https://reviews.llvm.org/D59787
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/TargetTransformInfo.cpptrunk/lib/Analysis/TargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMTargetTransformInfo.cpptrunk/lib/Target/ARM/ARMTargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMTargetTransformInfo.htrunk/lib/Target/ARM/ARMTargetTransformInfo.h
The file was modified/llvm/trunk/test/Analysis/CostModel/ARM/memcpy.lltrunk/test/Analysis/CostModel/ARM/memcpy.ll
Revision 359545 by rksimon:
Fix for bug 41512: lower INSERT_VECTOR_ELT(ZeroVec, 0, Elt) to SCALAR_TO_VECTOR(Elt) for all SSE flavors

Current LLVM uses pxor+pinsrb on SSE4+ for INSERT_VECTOR_ELT(ZeroVec, 0, Elt) insead of much simpler movd.
INSERT_VECTOR_ELT(ZeroVec, 0, Elt) is idiomatic construct which is used e.g. for _mm_cvtsi32_si128(Elt) and for lowest element initialization in _mm_set_epi32.
So such inefficient lowering leads to significant performance digradations in ceratin cases switching from SSSE3 to SSE4.
https://bugs.llvm.org/show_bug.cgi?id=41512

Here INSERT_VECTOR_ELT(ZeroVec, 0, Elt) is simply converted to SCALAR_TO_VECTOR(Elt) when applicable since latter is closer match to desired behavior and always efficiently lowered to movd and alike.

Committed on behalf of @Serge_Preis (Serge Preis)

Differential Revision: https://reviews.llvm.org/D60852
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/insertelement-zero.lltrunk/test/CodeGen/X86/insertelement-zero.ll

Summary

  1. Fix gcc "-Wdangling-else" warning. NFCI.
  2. Fix gcc "-Wdangling-else" warnings. NFCI.
Revision 359551 by rksimon:
Fix gcc "-Wdangling-else" warning. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Tooling/LookupTest.cpptrunk/unittests/Tooling/LookupTest.cpp
Revision 359550 by rksimon:
Fix gcc "-Wdangling-else" warnings. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/AST/ASTImporterTest.cpptrunk/unittests/AST/ASTImporterTest.cpp

Summary

  1. Fix Wpedantic "default argument specified for lambda parameter" warning. NFCI.
Revision 359548 by rksimon:
Fix Wpedantic "default argument specified for lambda parameter" warning. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CodeComplete.cpptrunk/clangd/CodeComplete.cpp