FailedChanges

Summary

  1. [ThinLTO] Fix unreachable code when parsing summary entries. Summary: Early returns were causing some code to be skipped. This was missed since the summary entries are typically at the end of the llvm assembly file. Fixes PR41663. Reviewers: RKSimon, wristow Subscribers: mehdi_amini, inglorion, eraman, steven_wu, dexonsmith, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61355
  2. [AMDGPU] gfx1010 DS implementation Differential Revision: https://reviews.llvm.org/D61332
  3. Revert "[DAGCombiner] try repeated fdiv divisor transform before building estimate" This reverts commit fb9a5307a94e6f1f850e4d89f79103b123f16279 (rL359398) because it can cause an infinite loop due to opposing combines.
  4. Fix 80 column violation. NFCI.
  5. [SCEV] Use isKnownViaNonRecursiveReasoning for smax simplification Summary: Commit rL331949: SCEV] Do not use induction in isKnownPredicate for simplification umax changed the codepath for umax from isKnownPredicate to isKnownViaNonRecursiveReasoning to avoid compile time blow up (and as I found out also stack overflows). However, there is an exact copy of the code for umax that was lacking this change. In D50167 I want to unify these codepaths, but to avoid that being a behavior change for the smax case, pull this independent bit out of it. Reviewed By: sanjoy Differential Revision: https://reviews.llvm.org/D61166
Revision 359697 by tejohnson:
[ThinLTO] Fix unreachable code when parsing summary entries.

Summary:
Early returns were causing some code to be skipped. This was missed
since the summary entries are typically at the end of the llvm assembly
file.

Fixes PR41663.

Reviewers: RKSimon, wristow

Subscribers: mehdi_amini, inglorion, eraman, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D61355
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/AsmParser/LLParser.cpptrunk/lib/AsmParser/LLParser.cpp
The file was modified/llvm/trunk/test/Assembler/thinlto-summary.lltrunk/test/Assembler/thinlto-summary.ll
Revision 359696 by rampitec:
[AMDGPU] gfx1010 DS implementation

Differential Revision: https://reviews.llvm.org/D61332
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpptrunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/DSInstructions.tdtrunk/lib/Target/AMDGPU/DSInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpptrunk/lib/Target/AMDGPU/SIISelLowering.cpp
The file was added/llvm/trunk/test/CodeGen/AMDGPU/lds-misaligned-bug.lltrunk/test/CodeGen/AMDGPU/lds-misaligned-bug.ll
The file was added/llvm/trunk/test/MC/AMDGPU/mubuf-gfx10.strunk/test/MC/AMDGPU/mubuf-gfx10.s
Revision 359695 by spatel:
Revert "[DAGCombiner] try repeated fdiv divisor transform before building estimate"

This reverts commit fb9a5307a94e6f1f850e4d89f79103b123f16279 (rL359398)
because it can cause an infinite loop due to opposing combines.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpptrunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/fdiv-combine-vec.lltrunk/test/CodeGen/X86/fdiv-combine-vec.ll
Revision 359694 by rksimon:
Fix 80 column violation. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 359693 by kfischer:
[SCEV] Use isKnownViaNonRecursiveReasoning for smax simplification

Summary:
Commit
rL331949: SCEV] Do not use induction in isKnownPredicate for simplification umax

changed the codepath for umax from isKnownPredicate to
isKnownViaNonRecursiveReasoning to avoid compile time blow up (and as
I found out also stack overflows). However, there is an exact copy of
the code for umax that was lacking this change. In D50167 I want to unify
these codepaths, but to avoid that being a behavior change for the smax
case, pull this independent bit out of it.

Reviewed By: sanjoy
Differential Revision: https://reviews.llvm.org/D61166
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ScalarEvolution.cpptrunk/lib/Analysis/ScalarEvolution.cpp

Summary

  1. [analyzer][tests][NFC] Add EOF newlines, normalize reference expected files Reference expected files not ending with a newline are normalized to have said newlines. Additionally `plist-macros-with-expansion.cpp.plist` is modified to add a line that is ignored by `%diff_plist`, but not by the more sensitive pattern proposed by http://lists.llvm.org/pipermail/cfe-dev/2019-April/061904.html for `%normalize_plist`.
  2. [analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC For various files under `clang/test/Analysis`, D52036 applied `%diff_plist` to replace `diff` invocations with certain options and D56340 swapped the order of the arguments so that the reference file comes first. The tests that used `tail` to filter the test output were not modified accordingly. This patch applies the corresponding update to those tests.
Revision 359692 by hubert.reinterpretcast:
[analyzer][tests][NFC] Add EOF newlines, normalize reference expected files

Reference expected files not ending with a newline are normalized to
have said newlines. Additionally `plist-macros-with-expansion.cpp.plist`
is modified to add a line that is ignored by `%diff_plist`, but not by
the more sensitive pattern proposed by
http://lists.llvm.org/pipermail/cfe-dev/2019-April/061904.html for
`%normalize_plist`.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plisttrunk/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
The file was modified/cfe/trunk/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plisttrunk/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plist
The file was modified/cfe/trunk/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plisttrunk/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plist
Revision 359691 by hubert.reinterpretcast:
[analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC

For various files under `clang/test/Analysis`, D52036 applied
`%diff_plist` to replace `diff` invocations with certain options and
D56340 swapped the order of the arguments so that the reference file
comes first. The tests that used `tail` to filter the test output were
not modified accordingly. This patch applies the corresponding update
to those tests.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Analysis/MismatchedDeallocator-path-notes.cpptrunk/test/Analysis/MismatchedDeallocator-path-notes.cpp
The file was modified/cfe/trunk/test/Analysis/diagnostics/plist-diagnostics-include-check.cpptrunk/test/Analysis/diagnostics/plist-diagnostics-include-check.cpp
The file was modified/cfe/trunk/test/Analysis/diagnostics/plist-multi-file.ctrunk/test/Analysis/diagnostics/plist-multi-file.c
The file was modified/cfe/trunk/test/Analysis/lambda-notes.cpptrunk/test/Analysis/lambda-notes.cpp
The file was modified/cfe/trunk/test/Analysis/malloc-plist.ctrunk/test/Analysis/malloc-plist.c