FailedChanges

Summary

  1. Make check-clang depend on the clang-check binary always check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-tidy, clang-refactor, etc) if the static analyzer is enabled. However, several lit tests call clang-check unconditionally, so always depend on it. Fixes a "could not find clang-check" lit warning in clean builds with the static analyzer disabled. Also sort the deps in the CMake file and put just one dep on each line. Differential Revision: https://reviews.llvm.org/D61324
  2. Minor tweaks to PDB docs - Fix a broken link - Some spelling fixes - Remove an unnecessary "amortized" - Don't say "log(n) random access"; "random access" means O(1) - Make MSF overview a bit more concise Differential Revision: https://reviews.llvm.org/D61196
Revision 359717 by nico:
Make check-clang depend on the clang-check binary always

check-clang (the target that runs all clang tests) used to
only depend on clang-check (a binary like clang-tidy,
clang-refactor, etc) if the static analyzer is enabled.
However, several lit tests call clang-check unconditionally,
so always depend on it.

Fixes a "could not find clang-check" lit warning in clean builds with
the static analyzer disabled.

Also sort the deps in the CMake file and put just one dep on each line.

Differential Revision: https://reviews.llvm.org/D61324
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/CMakeLists.txtN/A
The file was modified/llvm/trunk/utils/gn/secondary/clang/test/BUILD.gntrunk/utils/gn/secondary/clang/test/BUILD.gn
Revision 359714 by nico:
Minor tweaks to PDB docs

- Fix a broken link
- Some spelling fixes
- Remove an unnecessary "amortized"
- Don't say "log(n) random access"; "random access" means O(1)
- Make MSF overview a bit more concise

Differential Revision: https://reviews.llvm.org/D61196
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/PDB/DbiStream.rsttrunk/docs/PDB/DbiStream.rst
The file was modified/llvm/trunk/docs/PDB/TpiStream.rsttrunk/docs/PDB/TpiStream.rst
The file was modified/llvm/trunk/docs/PDB/index.rsttrunk/docs/PDB/index.rst
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/RawTypes.htrunk/include/llvm/DebugInfo/PDB/Native/RawTypes.h

Summary

  1. Make check-clang depend on the clang-check binary always check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-tidy, clang-refactor, etc) if the static analyzer is enabled. However, several lit tests call clang-check unconditionally, so always depend on it. Fixes a "could not find clang-check" lit warning in clean builds with the static analyzer disabled. Also sort the deps in the CMake file and put just one dep on each line. Differential Revision: https://reviews.llvm.org/D61324
  2. [Parser] Avoid correcting delayed typos in array subscript multiple times. We correct some typos in `ActOnArraySubscriptExpr` and `ActOnOMPArraySectionExpr`, so when their result is `ExprError`, we can end up correcting delayed typos in the same expressions again. In general it is OK but when `NumTypos` is incorrect, we can hit the assertion > Assertion failed: (Entry != DelayedTypos.end() && "Failed to get the state for a TypoExpr!"), function getTypoExprState, file clang/lib/Sema/SemaLookup.cpp, line 5219. Fix by replacing some subscript `ExprResult` with typo-corrected expressions instead of keeping the original expressions. Thus if original expressions contained `TypoExpr`, we'll use corrected expressions instead of trying to correct them again. rdar://problem/47403222 Reviewers: rsmith, erik.pilkington, majnemer Reviewed By: erik.pilkington Subscribers: jkorous, dexonsmith, cfe-commits Differential Revision: https://reviews.llvm.org/D60848
Revision 359717 by nico:
Make check-clang depend on the clang-check binary always

check-clang (the target that runs all clang tests) used to
only depend on clang-check (a binary like clang-tidy,
clang-refactor, etc) if the static analyzer is enabled.
However, several lit tests call clang-check unconditionally,
so always depend on it.

Fixes a "could not find clang-check" lit warning in clean builds with
the static analyzer disabled.

Also sort the deps in the CMake file and put just one dep on each line.

Differential Revision: https://reviews.llvm.org/D61324
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/CMakeLists.txttrunk/test/CMakeLists.txt
The file was modified/llvm/trunk/utils/gn/secondary/clang/test/BUILD.gnN/A
Revision 359713 by vsapsai:
[Parser] Avoid correcting delayed typos in array subscript multiple times.

We correct some typos in `ActOnArraySubscriptExpr` and
`ActOnOMPArraySectionExpr`, so when their result is `ExprError`, we can
end up correcting delayed typos in the same expressions again. In
general it is OK but when `NumTypos` is incorrect, we can hit the
assertion

> Assertion failed: (Entry != DelayedTypos.end() && "Failed to get the state for a TypoExpr!"), function getTypoExprState, file clang/lib/Sema/SemaLookup.cpp, line 5219.

Fix by replacing some subscript `ExprResult` with typo-corrected expressions
instead of keeping the original expressions. Thus if original expressions
contained `TypoExpr`, we'll use corrected expressions instead of trying to
correct them again.

rdar://problem/47403222

Reviewers: rsmith, erik.pilkington, majnemer

Reviewed By: erik.pilkington

Subscribers: jkorous, dexonsmith, cfe-commits

Differential Revision: https://reviews.llvm.org/D60848
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Parse/ParseExpr.cpptrunk/lib/Parse/ParseExpr.cpp
The file was modified/cfe/trunk/test/SemaCXX/typo-correction.cpptrunk/test/SemaCXX/typo-correction.cpp
The file was added/cfe/trunk/test/SemaObjC/typo-correction-subscript.mtrunk/test/SemaObjC/typo-correction-subscript.m

Summary

  1. [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator Reviewers: eugenis, cryptoad, kcc Reviewed By: kcc Subscribers: kcc, kubamracek, #sanitizers, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D61155
Revision 359715 by Vitaly Buka:
[sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator

Reviewers: eugenis, cryptoad, kcc

Reviewed By: kcc

Subscribers: kcc, kubamracek, #sanitizers, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D61155
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_allocator.htrunk/lib/asan/asan_allocator.h
The file was modified/compiler-rt/trunk/lib/hwasan/hwasan_allocator.htrunk/lib/hwasan/hwasan_allocator.h
The file was modified/compiler-rt/trunk/lib/lsan/lsan_allocator.htrunk/lib/lsan/lsan_allocator.h
The file was modified/compiler-rt/trunk/lib/msan/msan_allocator.cctrunk/lib/msan/msan_allocator.cc
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_combined.htrunk/lib/sanitizer_common/sanitizer_allocator_combined.h
The file was modified/compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_internal.htrunk/lib/sanitizer_common/sanitizer_allocator_internal.h
The file was modified/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cctrunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc
The file was modified/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_testlib.cctrunk/lib/sanitizer_common/tests/sanitizer_allocator_testlib.cc
The file was modified/compiler-rt/trunk/lib/scudo/scudo_allocator.htrunk/lib/scudo/scudo_allocator.h
The file was modified/compiler-rt/trunk/lib/scudo/scudo_allocator_combined.htrunk/lib/scudo/scudo_allocator_combined.h
The file was modified/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.htrunk/lib/tsan/rtl/tsan_rtl.h