FailedChanges

Summary

  1. [yaml2obj] - Make interface of `NameToIdxMap` class be human friendly and fix users. This patch inverses the values returned by `addName` and `lookup` methods of the class mentioned so that they now return true on success and false on failure. Also, it does minor code cleanup. Differential revision: https://reviews.llvm.org/D61190
  2. [gn] Include libcxx configuration file This was omitted in r359806 but is already referenced in the GN build.
Revision 359818 by grimar:
[yaml2obj] - Make interface of `NameToIdxMap` class be human friendly and fix users.

This patch inverses the values returned by `addName` and
`lookup` methods of the class mentioned so that they
now return true on success and false on failure.
Also, it does minor code cleanup.

Differential revision: https://reviews.llvm.org/D61190
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/yaml2obj/yaml2elf.cpptrunk/tools/yaml2obj/yaml2elf.cpp
Revision 359815 by phosek:
[gn] Include libcxx configuration file

This was omitted in r359806 but is already referenced in the GN build.
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/utils/gn/secondary/libcxx/config.gnitrunk/utils/gn/secondary/libcxx/config.gni

Summary

  1. [Sema] Emit warning for visibility attribute on internal-linkage declaration GCC warns on these cases, but we currently just silently ignore the attribute. Differential Revision: https://reviews.llvm.org/D61097
  2. Use primary template parameter names for variable template debug info Summary: Fixes PR41677 Consider: template <typename LHS, typename RHS> constexpr bool is_same_v = false; template <typename T> constexpr bool is_same_v<T, T> = true; template constexpr bool is_same_v<int, int>; Before this change, when emitting debug info for the `is_same_v<int, int>` global variable, clang would crash because it would try to use the template parameter list from the partial specialization to give parameter names to template arguments. This doesn't work in general, since a partial specialization can have fewer arguments than the primary template. Therefore, always use the primary template. Hypothetically we could try to use the parameter names from the partial specialization when possible, but it's not clear this really helps debugging in practice. Reviewers: JDevlieghere, aprantl, ormris, dblaikie Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61408
Revision 359814 by scott.linder:
[Sema] Emit warning for visibility attribute on internal-linkage declaration

GCC warns on these cases, but we currently just silently ignore the attribute.

Differential Revision: https://reviews.llvm.org/D61097
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.tdtrunk/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/lib/Sema/SemaDeclAttr.cpptrunk/lib/Sema/SemaDeclAttr.cpp
The file was modified/cfe/trunk/test/Sema/attr-visibility.ctrunk/test/Sema/attr-visibility.c
The file was modified/cfe/trunk/test/SemaCXX/ast-print.cpptrunk/test/SemaCXX/ast-print.cpp
The file was modified/cfe/trunk/test/SemaCXX/attr-visibility.cpptrunk/test/SemaCXX/attr-visibility.cpp
Revision 359809 by rnk:
Use primary template parameter names for variable template debug info

Summary:
Fixes PR41677

Consider:
  template <typename LHS, typename RHS> constexpr bool is_same_v = false;
  template <typename T> constexpr bool is_same_v<T, T> = true;
  template constexpr bool is_same_v<int, int>;

Before this change, when emitting debug info for the
`is_same_v<int, int>` global variable, clang would crash because it
would try to use the template parameter list from the partial
specialization to give parameter names to template arguments. This
doesn't work in general, since a partial specialization can have fewer
arguments than the primary template. Therefore, always use the primary
template. Hypothetically we could try to use the parameter names from
the partial specialization when possible, but it's not clear this really
helps debugging in practice.

Reviewers: JDevlieghere, aprantl, ormris, dblaikie

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D61408
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGDebugInfo.cpptrunk/lib/CodeGen/CGDebugInfo.cpp
The file was modified/cfe/trunk/test/CodeGenCXX/debug-info-template-member.cpptrunk/test/CodeGenCXX/debug-info-template-member.cpp
The file was added/cfe/trunk/test/CodeGenCXX/debug-info-var-template-partial.cpptrunk/test/CodeGenCXX/debug-info-var-template-partial.cpp

Summary

  1. [libc++][CMake] Link against libSystem on Apple platforms Instead of manually linking against libm/librt/libpthread, we should be linking against libSystem on Apple platforms, and only that. libm and libpthread are symlinks to libSystem anyway.
Revision 359808 by Louis Dionne:
[libc++][CMake] Link against libSystem on Apple platforms

Instead of manually linking against libm/librt/libpthread, we should be
linking against libSystem on Apple platforms, and only that. libm and
libpthread are symlinks to libSystem anyway.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/cmake/config-ix.cmaketrunk/cmake/config-ix.cmake
The file was modified/libcxx/trunk/src/CMakeLists.txttrunk/src/CMakeLists.txt