FailedChanges

Summary

  1. [X86] LowerMULH - remove unused Lo/Hi vector indices. NFCI. Leftover from before we had the extract128BitVector helpers.
  2. [MIR] Add simple PRE pass to MachineCSE This is the second part of the commit fixing PR38917 (hoisting partitially redundant machine instruction). Most of PRE (partitial redundancy elimination) and CSE work is done on LLVM IR, but some of redundancy arises during DAG legalization. Machine CSE is not enough to deal with it. This simple PRE implementation works a little bit intricately: it passes before CSE, looking for partitial redundancy and transforming it to fully redundancy, anticipating that the next CSE step will eliminate this created redundancy. If CSE doesn't eliminate this, than created instruction will remain dead and eliminated later by Remove Dead Machine Instructions pass. The third part of the commit is supposed to refactor MachineCSE, to make it more clear and to merge MachinePRE with MachineCSE, so one need no rely on further Remove Dead pass to clear instrs not eliminated by CSE. First step: https://reviews.llvm.org/D54839 Fixes llvm.org/PR38917 Reviewers: RKSimon Subscribers: hfinkel, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D56772
  3. Reduce variable scope to just the if() block its actually used in. NFCI.
Revision 359871 by rksimon:
[X86] LowerMULH - remove unused Lo/Hi vector indices. NFCI.

Leftover from before we had the extract128BitVector helpers.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 359870 by anton-afanasyev:
[MIR] Add simple PRE pass to MachineCSE

This is the second part of the commit fixing PR38917 (hoisting
partitially redundant machine instruction). Most of PRE (partitial
redundancy elimination) and CSE work is done on LLVM IR, but some of
redundancy arises during DAG legalization. Machine CSE is not enough
to deal with it. This simple PRE implementation works a little bit
intricately: it passes before CSE, looking for partitial redundancy
and transforming it to fully redundancy, anticipating that the next
CSE step will eliminate this created redundancy. If CSE doesn't
eliminate this, than created instruction will remain dead and eliminated
later by Remove Dead Machine Instructions pass.

The third part of the commit is supposed to refactor MachineCSE,
to make it more clear and to merge MachinePRE with MachineCSE,
so one need no rely on further Remove Dead pass to clear instrs
not eliminated by CSE.

First step: https://reviews.llvm.org/D54839

Fixes llvm.org/PR38917

Reviewers: RKSimon

Subscribers: hfinkel, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D56772
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/MachineCSE.cpptrunk/lib/CodeGen/MachineCSE.cpp
The file was modified/llvm/trunk/test/CodeGen/Mips/internalfunc.lltrunk/test/CodeGen/Mips/internalfunc.ll
The file was modified/llvm/trunk/test/CodeGen/X86/avx2-masked-gather.lltrunk/test/CodeGen/X86/avx2-masked-gather.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_compressstore.lltrunk/test/CodeGen/X86/masked_compressstore.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_gather.lltrunk/test/CodeGen/X86/masked_gather.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_store.lltrunk/test/CodeGen/X86/masked_store.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_store_trunc.lltrunk/test/CodeGen/X86/masked_store_trunc.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_store_trunc_ssat.lltrunk/test/CodeGen/X86/masked_store_trunc_ssat.ll
The file was modified/llvm/trunk/test/CodeGen/X86/masked_store_trunc_usat.lltrunk/test/CodeGen/X86/masked_store_trunc_usat.ll
Revision 359869 by rksimon:
Reduce variable scope to just the if() block its actually used in. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp

Summary

  1. [Sema][ObjC] Disable -Wunused-parameter for ObjC methods The warning isn't very useful when the function is an ObjC method. rdar://problem/41561853 Differential Revision: https://reviews.llvm.org/D61147
Revision 359864 by ahatanak:
[Sema][ObjC] Disable -Wunused-parameter for ObjC methods

The warning isn't very useful when the function is an ObjC method.

rdar://problem/41561853

Differential Revision: https://reviews.llvm.org/D61147
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaDecl.cpptrunk/lib/Sema/SemaDecl.cpp
The file was modified/cfe/trunk/test/SemaObjC/method-unused-attribute.mtrunk/test/SemaObjC/method-unused-attribute.m
The file was modified/cfe/trunk/test/SemaObjC/unused.mtrunk/test/SemaObjC/unused.m

Summary

  1. [clangd] Minor code style cleanups in Protocol.h. NFC - Remove a parameter name that was misspelled (OS used for non-stream parameter) - Declare operator == (TextEdit, TextEdit) outside the struct, for consistency with other user-declared ops in our code. - Fix naming style of a parameter.
Revision 359866 by ibiryukov:
[clangd] Minor code style cleanups in Protocol.h. NFC

- Remove a parameter name that was misspelled (OS used for non-stream
  parameter)
- Declare operator == (TextEdit, TextEdit) outside the struct, for
  consistency with other user-declared ops in our code.
- Fix naming style of a parameter.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/Protocol.htrunk/clangd/Protocol.h

Summary

  1. Avoid duplicate function aliases on MinGW after SVN r359835 On MinGW, the same alias mechanism as for ELF, using __attribute__((__alias__())), is used.
Revision 359865 by mstorsjo:
Avoid duplicate function aliases on MinGW after SVN r359835

On MinGW, the same alias mechanism as for ELF, using
__attribute__((__alias__())), is used.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/builtins/comparedf2.ctrunk/lib/builtins/comparedf2.c
The file was modified/compiler-rt/trunk/lib/builtins/comparesf2.ctrunk/lib/builtins/comparesf2.c