FailedChanges

Summary

  1. [LICM] auto-generate complete test checks; NFC
  2. [CodeGenPrepare] limit overflow intrinsic matching to a single basic block Using/updating a dominator tree to match math overflow patterns may be very expensive in compile-time (because of the way CGP uses a DT), so just handle the single-block case. Also, we were restarting the iterator loops when doing the overflow intrinsic transforms by marking the dominator tree for update. That was done to prevent iterating over a removed instruction. But we can postpone the deletion using the existing "RemovedInsts" structure, and that means we don't need to update the DT. See post-commit thread for rL354298 for more details: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190422/646276.html Differential Revision: https://reviews.llvm.org/D61075
  3. [Object][XCOFF] Add an XCOFF dumper for llvm-readobj. Patch adds support for dumping of file headers with llvm-readobj. XCOFF object files are added to test dumping a well formed file, and dumping both negative timestamps and negative symbol counts, both of which are allowed in the XCOFF definition. Differential Revision: https://reviews.llvm.org/D60878
  4. [TargetLowering] expandUnalignedStore - cleanup EVT variables. NFCI. Avoid duplicated EVTs and rename Store/Load VTs to avoid -Wshadow warnings.
Revision 359881 by spatel:
[LICM] auto-generate complete test checks; NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/LICM/hoist-mustexec.lltrunk/test/Transforms/LICM/hoist-mustexec.ll
Revision 359879 by spatel:
[CodeGenPrepare] limit overflow intrinsic matching to a single basic block

Using/updating a dominator tree to match math overflow patterns may be very
expensive in compile-time (because of the way CGP uses a DT), so just handle
the single-block case.

Also, we were restarting the iterator loops when doing the overflow intrinsic
transforms by marking the dominator tree for update. That was done to prevent
iterating over a removed instruction. But we can postpone the deletion using
the existing "RemovedInsts" structure, and that means we don't need to update
the DT.

See post-commit thread for rL354298 for more details:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190422/646276.html

Differential Revision: https://reviews.llvm.org/D61075
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/CodeGenPrepare.cpptrunk/lib/CodeGen/CodeGenPrepare.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/cgp-usubo.lltrunk/test/CodeGen/X86/cgp-usubo.ll
The file was modified/llvm/trunk/test/Transforms/CodeGenPrepare/X86/optimizeSelect-DT.lltrunk/test/Transforms/CodeGenPrepare/X86/optimizeSelect-DT.ll
The file was modified/llvm/trunk/test/Transforms/CodeGenPrepare/X86/overflow-intrinsics.lltrunk/test/Transforms/CodeGenPrepare/X86/overflow-intrinsics.ll
Revision 359878 by sfertile:
[Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Patch adds support for dumping of file headers with llvm-readobj. XCOFF
object files are added to test dumping a well formed file, and dumping
both negative timestamps and negative symbol counts, both of which are
allowed in the XCOFF definition.

Differential Revision: https://reviews.llvm.org/D60878
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Object/XCOFFObjectFile.htrunk/include/llvm/Object/XCOFFObjectFile.h
The file was modified/llvm/trunk/lib/Object/XCOFFObjectFile.cpptrunk/lib/Object/XCOFFObjectFile.cpp
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/xcoff-basic-neg-sym-count.otrunk/test/tools/llvm-readobj/Inputs/xcoff-basic-neg-sym-count.o
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/xcoff-basic-neg-time.otrunk/test/tools/llvm-readobj/Inputs/xcoff-basic-neg-time.o
The file was added/llvm/trunk/test/tools/llvm-readobj/Inputs/xcoff-basic.otrunk/test/tools/llvm-readobj/Inputs/xcoff-basic.o
The file was added/llvm/trunk/test/tools/llvm-readobj/xcoff-basic.testtrunk/test/tools/llvm-readobj/xcoff-basic.test
The file was modified/llvm/trunk/tools/llvm-readobj/CMakeLists.txttrunk/tools/llvm-readobj/CMakeLists.txt
The file was modified/llvm/trunk/tools/llvm-readobj/ObjDumper.htrunk/tools/llvm-readobj/ObjDumper.h
The file was added/llvm/trunk/tools/llvm-readobj/XCOFFDumper.cpptrunk/tools/llvm-readobj/XCOFFDumper.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/llvm-readobj.cpptrunk/tools/llvm-readobj/llvm-readobj.cpp
Revision 359877 by rksimon:
[TargetLowering] expandUnalignedStore - cleanup EVT variables. NFCI.

Avoid duplicated EVTs and rename Store/Load VTs to avoid -Wshadow warnings.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpptrunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Summary

  1. Added an AST matcher for declarations that are in the `std` namespace Reviewers: alexfh Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61480
Revision 359876 by gribozavr:
Added an AST matcher for declarations that are in the `std` namespace

Reviewers: alexfh

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D61480
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LibASTMatchersReference.htmltrunk/docs/LibASTMatchersReference.html
The file was modified/cfe/trunk/include/clang/ASTMatchers/ASTMatchers.htrunk/include/clang/ASTMatchers/ASTMatchers.h
The file was modified/cfe/trunk/lib/AST/DeclBase.cpptrunk/lib/AST/DeclBase.cpp
The file was modified/cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpptrunk/lib/ASTMatchers/Dynamic/Registry.cpp
The file was modified/cfe/trunk/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpptrunk/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
The file was modified/clang-tools-extra/trunk/clang-tidy/bugprone/InaccurateEraseCheck.cppN/A

Summary

  1. [clangd] Fix header-guard check for include insertion, and don't index header guards. Summary: Both of these attempt to check whether a header guard exists while parsing the file. However the file is only marked as guarded once clang finishes processing it. We defer the checks and work until SymbolCollector::finish(). This is ugly and ad-hoc, deferring *all* work might be cleaner. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, mgrang, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61442
  2. Added an AST matcher for declarations that are in the `std` namespace Reviewers: alexfh Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D61480
Revision 359880 by sammccall:
[clangd] Fix header-guard check for include insertion, and don't index header guards.

Summary:
Both of these attempt to check whether a header guard exists while parsing the
file. However the file is only marked as guarded once clang finishes processing
it. We defer the checks and work until SymbolCollector::finish().

This is ugly and ad-hoc, deferring *all* work might be cleaner.

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, mgrang, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D61442
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/index/Symbol.cpptrunk/clangd/index/Symbol.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/Symbol.htrunk/clangd/index/Symbol.h
The file was modified/clang-tools-extra/trunk/clangd/index/SymbolCollector.cpptrunk/clangd/index/SymbolCollector.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/SymbolCollector.htrunk/clangd/index/SymbolCollector.h
The file was modified/clang-tools-extra/trunk/clangd/unittests/SymbolCollectorTests.cpptrunk/clangd/unittests/SymbolCollectorTests.cpp
Revision 359876 by gribozavr:
Added an AST matcher for declarations that are in the `std` namespace

Reviewers: alexfh

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D61480
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LibASTMatchersReference.htmlN/A
The file was modified/cfe/trunk/include/clang/ASTMatchers/ASTMatchers.hN/A
The file was modified/cfe/trunk/lib/AST/DeclBase.cppN/A
The file was modified/cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cppN/A
The file was modified/cfe/trunk/unittests/ASTMatchers/ASTMatchersNarrowingTest.cppN/A
The file was modified/clang-tools-extra/trunk/clang-tidy/bugprone/InaccurateEraseCheck.cpptrunk/clang-tidy/bugprone/InaccurateEraseCheck.cpp