FailedChanges

Summary

  1. [hexagon] change AsmParser assertion to error For immediates that can't be evaluated in assembler-mapped instructions, we should return 'invalid operand' instead of assert.
  2. [Docs][CodeGenerator][eBPF] Correct the values for BPF_X and BPF_K Fix the values of BPF_X and BPF_K according to BPFInstrFormats.td: " def BPF_K : BPFSrcType<0x0>; def BPF_X : BPFSrcType<0x1>; " The right value for BPF_X is 0x1, and the right value for BPF_K is 0x0. Signed-off-by: Wang YanQing <udknight@gmail.com> Differential Revision: https://reviews.llvm.org/D61512
  3. [X86] Allow assembly parser to accept x/y/z suffixes on non-memory vfpclassps/pd and on memory forms in intel syntax The x/y/z suffix is needed to disambiguate the memory form in at&t syntax since no xmm/ymm/zmm register is mentioned. But we should also allow it for the register and broadcast forms where its not needed for consistency. This matches gas. The printing code will still only use the suffix for the memory form where it is needed.
  4. [llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final" Summary: This patch was previously applied in r231221, and reverted in r231254 because it broke self-hosting. It was subsequently fixed and reapplied in r231274. Unfortunately, making the `parser<T>` classes final prevents inheritance which makes it impossible to implement custom parsers. Reverting r231221 restores the ability to customize parsers. Reviewers: dblaikie Reviewed By: dblaikie Subscribers: craig.topper, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D60955
  5. [X86] LowerToHorizontalOp - Tidyup calls to getHopForBuildVector. NFCI. Merge the if() tests for the various HADD/SUB + Subtarget tests
  6. [SelectionDAG] CreateTopologicalOrder - don't use iterator We shouldn't use an iterator to loop across a std::vector when the same loop is adding elements to that std::vector Found by cppcheck
  7. AMDGPU: Select VOP3 form of sub The VOP3 form should always be the preferred selection form to be shrunk later. The r600 sub test needs to be split out because it asserts on the arguments in the new test during the calling convention lowering.
  8. AMDGPU: Support shrinking add with FI in SIFoldOperands Avoids test regression in a future patch
  9. Revert r359549 - incorrect update of test checks. NFC
  10. [x86] add tests for fneg with undefs; NFC This was originally part of D61419.
  11. AMDGPU: Remove redundant patterns for shifts
  12. AMDGPU: Remove redundant patterns for sub There were 2 patterns for sub, one selecting to sub and one to subrev. Only one of these will succeed, so remove the reversed one.
Revision 359905 by bcain:
[hexagon] change AsmParser assertion to error

For immediates that can't be evaluated in assembler-mapped instructions, we
should return 'invalid operand' instead of assert.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpptrunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
The file was added/llvm/trunk/test/MC/Hexagon/hex-immediates.strunk/test/MC/Hexagon/hex-immediates.s
The file was added/llvm/trunk/test/MC/Hexagon/inval_immed.strunk/test/MC/Hexagon/inval_immed.s
Revision 359904 by yhs:
[Docs][CodeGenerator][eBPF] Correct the values for BPF_X and BPF_K

Fix the values of BPF_X and BPF_K according to BPFInstrFormats.td:
"
def BPF_K : BPFSrcType<0x0>;
def BPF_X : BPFSrcType<0x1>;
"

The right value for BPF_X is 0x1, and the right value for BPF_K is 0x0.

Signed-off-by: Wang YanQing <udknight@gmail.com>

Differential Revision: https://reviews.llvm.org/D61512
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CodeGenerator.rsttrunk/docs/CodeGenerator.rst
Revision 359903 by ctopper:
[X86] Allow assembly parser to accept x/y/z suffixes on non-memory vfpclassps/pd and on memory forms in intel syntax

The x/y/z suffix is needed to disambiguate the memory form in at&t syntax since no xmm/ymm/zmm register is mentioned.

But we should also allow it for the register and broadcast forms where its not needed for consistency. This matches gas.

The printing code will still only use the suffix for the memory form where it is needed.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86InstrAVX512.tdtrunk/lib/Target/X86/X86InstrAVX512.td
The file was modified/llvm/trunk/test/MC/X86/intel-syntax-x86-avx512dq_vl.strunk/test/MC/X86/intel-syntax-x86-avx512dq_vl.s
The file was modified/llvm/trunk/test/MC/X86/x86-64-avx512dq.strunk/test/MC/X86/x86-64-avx512dq.s
The file was modified/llvm/trunk/test/MC/X86/x86-64-avx512dq_vl.strunk/test/MC/X86/x86-64-avx512dq_vl.s
Revision 359902 by dhinton:
[llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final"

Summary: This patch was previously applied in r231221, and reverted in
r231254 because it broke self-hosting.  It was subsequently fixed and
reapplied in r231274.  Unfortunately, making the `parser<T>` classes
final prevents inheritance which makes it impossible to implement
custom parsers.

Reverting r231221 restores the ability to customize parsers.

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: craig.topper, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60955
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/CommandLine.htrunk/include/llvm/Support/CommandLine.h
Revision 359901 by rksimon:
[X86] LowerToHorizontalOp - Tidyup calls to getHopForBuildVector. NFCI.

Merge the if() tests for the various HADD/SUB + Subtarget tests
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 359900 by rksimon:
[SelectionDAG] CreateTopologicalOrder - don't use iterator

We shouldn't use an iterator to loop across a std::vector when the same loop is adding elements to that std::vector

Found by cppcheck
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpptrunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Revision 359899 by arsenm:
AMDGPU: Select VOP3 form of sub

The VOP3 form should always be the preferred selection form to be
shrunk later.

The r600 sub test needs to be split out because it asserts on the
arguments in the new test during the calling convention lowering.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.tdtrunk/lib/Target/AMDGPU/VOP2Instructions.td
The file was added/llvm/trunk/test/CodeGen/AMDGPU/r600.sub.lltrunk/test/CodeGen/AMDGPU/r600.sub.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/sub.lltrunk/test/CodeGen/AMDGPU/sub.ll
Revision 359898 by arsenm:
AMDGPU: Support shrinking add with FI in SIFoldOperands

Avoids test regression in a future patch
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpptrunk/lib/Target/AMDGPU/SIFoldOperands.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/fold-fi-operand-shrink.mirtrunk/test/CodeGen/AMDGPU/fold-fi-operand-shrink.mir
Revision 359897 by rlougher:
Revert r359549 - incorrect update of test checks. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/sub.lltrunk/test/Transforms/InstCombine/sub.ll
Revision 359896 by spatel:
[x86] add tests for fneg with undefs; NFC

This was originally part of D61419.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/vec_fneg.lltrunk/test/CodeGen/X86/vec_fneg.ll
Revision 359895 by arsenm:
AMDGPU: Remove redundant patterns for shifts
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.tdtrunk/lib/Target/AMDGPU/VOP2Instructions.td
Revision 359894 by arsenm:
AMDGPU: Remove redundant patterns for sub

There were 2 patterns for sub, one selecting to sub and one to
subrev. Only one of these will succeed, so remove the reversed one.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.tdtrunk/lib/Target/AMDGPU/VOP2Instructions.td