FailedChanges

Summary

  1. [LegalizeDAG] Return true from ExpandNode for some nodes that don't have (details)
  2. AvoidBindCheck.cpp: Fix GCC 5.3 build errors (details)
  3. AvoidBindCheck.cpp: Fix unused variables warning (details)
  4. [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their (details)
  5. [UpdateTestChecks] Fix parsing of RUN: lines with line continuations (details)
  6. [llvm][bindings][go] Fix typo (details)
  7. [NFC] Slightly improve wording in the comments (details)
Commit 039664db87d255570854ade5241bf53b8ce3b5a9 by craig.topper
[LegalizeDAG] Return true from ExpandNode for some nodes that don't have
expand support.
These nodes have a FIXME that they only get here because a Custom
handler returned SDValue() instead of the original Op.
Even though we aren't expanding them, we should return true here to
prevent ConvertNodeToLibcall from also trying to process them until the
FIXME has been addressed.
I'm hoping to add checking to ConvertNodeToLibcall to make sure we don't
give it nodes it doesn't have support for.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
Commit 8e7f60e942ff009de742e20e10ebc09dcdecd5a2 by hans
AvoidBindCheck.cpp: Fix GCC 5.3 build errors
It was failing with:
clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:61:29: error:
declaration of ‘clang::tidy::modernize::{anonymous}::CaptureMode
clang::tidy::modernize::{anonymous}::BindArgument::CaptureMode’
[-fpermissive]
  CaptureMode CaptureMode = CM_None;
                            ^
clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:38:6: error:
changes meaning of ‘CaptureMode’ from ‘enum
clang::tidy::modernize::{anonymous}::CaptureMode’ [-fpermissive]
enum CaptureMode { CM_None, CM_ByRef, CM_ByValue, CM_InitExpression };
     ^
The file was modifiedclang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
Commit b5f295ffcec2fa7402e39eb1262acbd55a7d39f5 by hans
AvoidBindCheck.cpp: Fix unused variables warning
The file was modifiedclang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
Commit 315600f480055f5143aaa245f25bd25221edfa91 by Raphael Isemann
[lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their
use in ValueObjectSynthetic
Summary: ThreadSafeSTLVector and ThreadSafeSTLMap are not useful for
achieving any degree of thread safety in LLDB and should be removed
before they are used in more places. They are only used (unsurprisingly
incorrectly) in
`ValueObjectSynthetic::GetChildAtIndex`, so this patch replaces their
use there with a simple mutex with which we guard the related data
structures. This doesn't make ValueObjectSynthetic::GetChildAtIndex any
more thread-safe, but on the other hand it at least allows us to get rid
of the ThreadSafeSTL* data structures without changing the observable
behaviour of ValueObjectSynthetic (beside that it is now a few bytes
smaller).
Reviewers: labath, JDevlieghere, jingham
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70845
The file was modifiedlldb/include/lldb/Core/ValueObjectSyntheticFilter.h
The file was removedlldb/include/lldb/Core/ThreadSafeSTLVector.h
The file was removedlldb/include/lldb/Core/ThreadSafeSTLMap.h
The file was modifiedlldb/source/Core/ValueObjectSyntheticFilter.cpp
Commit c246d6e536c7112019cba6cfc764daeb9088ef29 by Alexander.Richardson
[UpdateTestChecks] Fix parsing of RUN: lines with line continuations
I accidentally broke this in d9542db49e90457de62af3bfe395aaf4c47b68a5
due to incorrectly placed parentheses.
The file was modifiedllvm/utils/UpdateTestChecks/common.py
Commit 33f93ea23a09c89e701a12ee315decb469362ea8 by kadircet
[llvm][bindings][go] Fix typo
The file was modifiedllvm/bindings/go/llvm/dibuilder.go
Commit 9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0 by kbobyrev
[NFC] Slightly improve wording in the comments
Reviewed by: hokein
Differential Revision: https://reviews.llvm.org/D70943
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp