FailedChanges

Summary

  1. Differentiate between the presumed and actual file when dumping the AST (details)
  2. Correcting the offsets within the test to fix the bots. (details)
  3. [APInt][PatternMatch] Add 'is non-positive' predicate (details)
  4. [GlobalISel]: Allow targets to override how to widen constants during (details)
  5. [FileCheck] Given multiple -dump-input, prefer most verbose (details)
  6. [NFC] Pass a reference to CodeGenFunction to methods of LValue and (details)
  7. Revert "Fix llvm-namespace-comment for macro expansions" (details)
  8. Fix signed mismatch warnings in MetadataTests.cpp (details)
Commit fa6c157ebeef55fd1e00266d1d1ad6aaa6161ef2 by aaron
Differentiate between the presumed and actual file when dumping the AST
to JSON
Currently, when dumping the AST to JSON, the presumed file is what is
included when dumping a source location. This patch changes the behavior
to instead dump the actual file, and only dump a presumed file name when
it differs from the actual file.
This also corrects an issue with the test script generator that would
prevent it from working on Windows due to file permissions issues.
The file was modifiedclang/include/clang/AST/JSONNodeDumper.h
The file was addedclang/test/AST/ast-dump-file-line-json.c
The file was modifiedclang/lib/AST/JSONNodeDumper.cpp
The file was modifiedclang/test/AST/gen_ast_dump_json_test.py
Commit 898df29c5b2ebbc4a24143e476d8e9a54569d2e5 by aaron
Correcting the offsets within the test to fix the bots.
The file was modifiedclang/test/AST/ast-dump-file-line-json.c
Commit 444ac34182d562db2cb3b7d93d0d63acca1a6c9a by lebedev.ri
[APInt][PatternMatch] Add 'is non-positive' predicate
It will be useful for implementing the fold mentioned in
https://bugs.llvm.org/show_bug.cgi?id=44100#c4
The file was modifiedllvm/include/llvm/ADT/APInt.h
The file was modifiedllvm/unittests/ADT/APIntTest.cpp
The file was modifiedllvm/include/llvm/IR/PatternMatch.h
The file was modifiedllvm/unittests/IR/PatternMatch.cpp
Commit 6da7dbb806dce9fbc05416482a5b895efdea96b0 by aditya_nandakumar
[GlobalISel]: Allow targets to override how to widen constants during
legalization
https://reviews.llvm.org/D70922
This adds a hook to allow targets to define exactly what extension
operation should be performed for widening constants. This handles cases
like widening i1 true which would end up becoming -1 which affects code
quality during combines. Additionally, in order to stay consistent with
how DAG is promoting constants, we now signextend for byte sized types
and zero extend otherwise (by default). Targets can of course override
this if necessary.
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/legalizer/select.mir
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/llvm-ir/constants.ll
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/llvm-ir/select.ll
The file was modifiedllvm/test/CodeGen/X86/GlobalISel/shl-scalar.ll
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/llvm-ir/fcmp.ll
The file was modifiedllvm/test/CodeGen/X86/GlobalISel/ashr-scalar.ll
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
The file was modifiedllvm/test/CodeGen/X86/GlobalISel/legalize-constant.mir
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/legalizer/constants.mir
The file was modifiedllvm/include/llvm/Support/LowLevelTypeImpl.h
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
The file was modifiedllvm/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir
The file was modifiedllvm/test/CodeGen/ARM/GlobalISel/arm-legalize-consts.mir
The file was modifiedllvm/test/CodeGen/X86/GlobalISel/lshr-scalar.ll
Commit fdde18a7c3e5ae62f458fb83230ec340bf658668 by jdenny.ornl
[FileCheck] Given multiple -dump-input, prefer most verbose
Problem: `FILECHECK_OPTS` was implemented so that a test runner, such as
a bot, can specify FileCheck debugging options, such as
`-dump-input=fail`.  However, some existing test suites have FileCheck
calls that already specify `-dump-input=fail` or `-dump-input=always`.
Without this patch, such tests fail under such a test runner because
FileCheck doesn't accept multiple occurrences of `-dump-input`.
Solution: This patch permits multiple occurrences of `-dump-input` by
assigning precedence to its values in the following descending order:
`help`, `always`, `fail`, and `never`.  That is, any occurrence of
`help` always obtains help, and otherwise the behavior is similar to
`-v` vs. `-vv` in that the option specifying the greatest verbosity has
precedence.
Rationale: My justification for the new behavior is as follows.  I have
not experienced use cases where, either as a test runner or as a test
author, I want to **limit** the permitted debugging verbosity
(except as a test author in FileCheck's or lit's test suites where the
FileCheck debugging output itself is under test, but the solution there
is `env FILECHECK_OPTS=`, and I imagine we should use the same solution
anywhere else this need might occur).  Of course, as either a test
runner or test author, it is useful to **increase** debugging verbosity.
Reviewed By: probinson
Differential Revision: https://reviews.llvm.org/D70784
The file was modifiedllvm/test/FileCheck/dump-input-enable.txt
The file was modifiedllvm/utils/FileCheck/FileCheck.cpp
Commit 8a5b7c35709d9ce1f44a99f0c5b084bf2696ea17 by Akira
[NFC] Pass a reference to CodeGenFunction to methods of LValue and
AggValueSlot
This is needed for the pointer authentication work we plan to do in the
near future.
https://github.com/apple/llvm-project/blob/a63a81bd9911f87a0b5dcd5bdd7ccdda7124af87/clang/docs/PointerAuthentication.rst
The file was modifiedclang/lib/CodeGen/TargetInfo.cpp
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/lib/CodeGen/CGStmt.cpp
The file was modifiedclang/lib/CodeGen/CGBlocks.cpp
The file was modifiedclang/lib/CodeGen/CGDeclCXX.cpp
The file was modifiedclang/lib/CodeGen/CGExprScalar.cpp
The file was modifiedclang/lib/CodeGen/CGStmtOpenMP.cpp
The file was modifiedclang/lib/CodeGen/CGClass.cpp
The file was modifiedclang/lib/CodeGen/CGObjC.cpp
The file was modifiedclang/lib/CodeGen/CGAtomic.cpp
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
The file was modifiedclang/lib/CodeGen/CodeGenFunction.cpp
The file was modifiedclang/lib/CodeGen/CGExpr.cpp
The file was modifiedclang/lib/CodeGen/CGNonTrivialStruct.cpp
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.cpp
The file was modifiedclang/lib/CodeGen/CGCall.cpp
The file was modifiedclang/lib/CodeGen/CGExprCXX.cpp
The file was modifiedclang/lib/CodeGen/CGExprComplex.cpp
The file was modifiedclang/lib/CodeGen/CGValue.h
The file was modifiedclang/lib/CodeGen/CGDecl.cpp
The file was modifiedclang/lib/CodeGen/CGExprAgg.cpp
Commit c375dc230d16f451cf1c7e2868237da6ef7bc4cf by alexfh
Revert "Fix llvm-namespace-comment for macro expansions"
This reverts commit 4736d63f752f8d13f4c6a9afd558565c32119718. This
commit introduces a ton of false positives and incorrect fixes. See
https://reviews.llvm.org/D69855#1767089 for details.
The file was modifiedclang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
The file was removedclang-tools-extra/test/clang-tidy/checkers/llvm-namespace-comment.cpp
The file was modifiedclang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.h
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments.cpp
Commit 3e0d21d84bef95edbf00e0b3e6d5a584300f1349 by dblaikie
Fix signed mismatch warnings in MetadataTests.cpp
The file was modifiedllvm/unittests/IR/MetadataTest.cpp