SuccessChanges

Summary

  1. [NFC,StackSafety] Fix template arg name (details)
  2. [llvm] Fix unused variable warnings (details)
  3. [mlir][Linalg] NFC - Make markers use Identifier instead of StringRef (details)
  4. TargetFrameLowering.h - remove unnecessary includes. NFC. (details)
  5. Fix MSVC "not all control paths return a value" warning. NFC. (details)
  6. [clang-tidy] add new check readability-use-anyofallof (details)
  7. [LangRef] Fix description of shape args for matrix.multiply. (details)
Commit 264d435ee10c699b12562eea695793199ff757f5 by Vitaly Buka
[NFC,StackSafety] Fix template arg name
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp (diff)
Commit c5468253aa555c2df98bd1f49d1e9d44b0150a2e by kadircet
[llvm] Fix unused variable warnings
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (diff)
Commit e349fb70a23f3a39e058605e4e2db66da5e5ea4a by ntv
[mlir][Linalg] NFC - Make markers use Identifier instead of StringRef

Summary: This removes string ownership worries by putting everything into the context and allows more constructing identifiers programmatically.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D81027
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp (diff)
The file was modifiedmlir/test/lib/Transforms/TestLinalgTransforms.cpp (diff)
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Transforms.cpp (diff)
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h (diff)
The file was modifiedmlir/test/Dialect/Linalg/transform-patterns.mlir (diff)
Commit 7a96c181d0f09aae3ebe50c1eea71aa1b11d5789 by llvm-dev
TargetFrameLowering.h - remove unnecessary includes. NFC.

Move TargetFrameLowering.h include to the top of the TargetFrameLoweringImpl.cpp includes (clang-format doesn't do this by default as the filenames don't match).
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h (diff)
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp (diff)
Commit e6ba0a55fd39b600f3f431308f4a7e36e48f91ae by llvm-dev
Fix MSVC "not all control paths return a value" warning. NFC.

Add llvm_unreachable after switch statement for CheckerRegistry::StateFromCmdLine enum
The file was modifiedclang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp (diff)
Commit add51e152aa6dc3aa7a51901a099b2ebe8cfe377 by gehre.matthias
[clang-tidy] add new check readability-use-anyofallof

Summary:
Finds range-based for loops that can be replaced by a call to ``std::any_of`` or
``std::all_of``. In C++ 20 mode, suggests ``std::ranges::any_of`` or
``std::ranges::all_of``.
For now, no fixits are produced.

Reviewers: aaron.ballman, alexfh, hokein

Subscribers: mgorny, xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77572
The file was addedclang-tools-extra/docs/clang-tidy/checks/readability-use-anyofallof.rst
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst (diff)
The file was modifiedclang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp (diff)
The file was modifiedclang-tools-extra/clang-tidy/readability/CMakeLists.txt (diff)
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof.cpp
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof-cpp20.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst (diff)
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.h
Commit 90e291912ac7e3caf9251969a5c47310c6aa01ff by flo
[LangRef] Fix description of shape args for matrix.multiply.

Currently all code instances within the matrix lowering pass consider
matrix A to be MxN and B to be NxK, producing C which is MxK. Anyone
interacting with this API after reading the docs but without reading the pass
would expect A: MxK, B: KxN, and C: MxN. These changes bring the documentation
in line with the implementation.

One point of concern with this, the original signature as described in the docs
may be better or at least more expected. The interface as it was written
reflected other common matrix multiplication interfaces such as BLAS'[1], where
the matrices are MxK, KxN, MxN respectively. Choosing to honor this requires
changing code and tests instead, but should be mostly just renaming of variables.

Patch by Braedy Kuzma <braedy@ualberta.ca>

[1] http://www.netlib.org/lapack/explore-html/db/dc9/group__single__blas__level3_gafe51bacb54592ff5de056acabd83c260.html#gafe51bacb54592ff5de056acabd83c260

Reviewers: anemet, LuoYuanke, nicolasvasilache, fhahn

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D80663
The file was modifiedllvm/docs/LangRef.rst (diff)