SuccessChanges

Summary

  1. [LLDB] Fix SVE offset calculation in NativeRegisterContextLinux_arm64 (details)
  2. [not][test] Fix disable-symbolization.test when 'printenv' is not available (details)
  3. [MLInliner] Support training that doesn't require partial rewards (details)
  4. Properly pass modules flags to frontend when using -std=c++20 instead of -std=c++2a. (details)
  5. Add NDEBUG checks around debug only loop to avoid unused variable (details)
  6. [flang] Don't attempt to compute element size if no DynamicType (details)
  7. Disable 'not' test on Windows because 'env' from GnuWin32 cannot be used without arguments. (details)
  8. [DebugInfo] Move constructor homing case in shouldOmitDefinition. (details)
  9. Temporarily Revert "[DebugInfo] Move constructor homing case in shouldOmitDefinition." (details)
  10. [CMake] Fix ncurses/zlib in LLVM_SYSTEM_LIBS for Windows GNU (details)
  11. [SyntaxTree] Split `MemberPointer` tests with annotations (details)
  12. [SyntaxTree] Split ConstVolatileQualifiers tests (details)
  13. [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test (details)
Commit 4283320b7286dc94367b22df09499dc934e1fbf9 by omair.javaid
[LLDB] Fix SVE offset calculation in NativeRegisterContextLinux_arm64

There was typo left from changes in CalculateSVEOffset where we moved
FPSR/FPCR offset calculation into WriteRegister and ReadRegister.

Differential Revision: https://reviews.llvm.org/D79699
The file was modifiedlldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
Commit a5e65ad3a30cd77a768e093276e3426c6d81a32d by maskray
[not][test] Fix disable-symbolization.test when 'printenv' is not available

On Windows, 'env' or 'printenv' may not exist.

Also switch back to 'env' which is specified by POSIX.1-2017. 'printenv' is not
standard (I picked it because 'printenv' exists on GnuWin32 but 'env' does not).

Reviewed By: zequanwu

Differential Revision: https://reviews.llvm.org/D86496
The file was modifiedllvm/test/tools/not/disable-symbolization.test
Commit 8c63df2416dc7a492f6464519b516a202147dc91 by mtrofin
[MLInliner] Support training that doesn't require partial rewards

If we use training algorithms that don't need partial rewards, we don't
need to worry about an ir2native model. In that case, training logs
won't contain a 'delta_size' feature either (since that's the partial
reward).

Differential Revision: https://reviews.llvm.org/D86481
The file was modifiedllvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
The file was modifiedllvm/test/Transforms/Inline/ML/development-training-log.ll
Commit 91604949ef2fc8401d17a31362c46c310d5550b6 by richard
Properly pass modules flags to frontend when using -std=c++20 instead of -std=c++2a.

In passing, also teach the driver to map /std:c++latest to -std=c++20
not -std=c++2a.
The file was modifiedclang/test/Driver/modules.cpp
The file was modifiedclang/test/Driver/cl-options.c
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
Commit 1a2a34a38a7d6310b38958fbe49c274431ac223d by echristo
Add NDEBUG checks around debug only loop to avoid unused variable
warnings.
The file was modifiedmlir/tools/mlir-reduce/ReductionTreeUtils.cpp
Commit 044a71d828cab57b9aefd402105960959a4e2c0e by tkeith
[flang] Don't attempt to compute element size if no DynamicType

If an error has occurred a symbol may have a DeclTypeSpec but no
valid DynamicType. There is no need to compute the size of erroneous
symbols.

Also, we only need to process object entities and procedure entities.
All other kinds of symbols can be skipped.

This fixes another problem revealed by https://bugs.llvm.org/show_bug.cgi?id=47265

Differential Revision: https://reviews.llvm.org/D86484
The file was modifiedflang/lib/Semantics/compute-offsets.cpp
Commit 1f04678f875e2b8b8a396b8e77ca21d57dbbb0d5 by alexandre.ganea
Disable 'not' test on Windows because 'env' from GnuWin32 cannot be used without arguments.
The file was modifiedllvm/test/tools/not/disable-symbolization.test
Commit 589ce5f7050dd83fd3f7dbc182ea0fb051ece994 by akhuang
[DebugInfo] Move constructor homing case in shouldOmitDefinition.

For some reason the ctor homing case was before the template
specialization case, and could have returned false too early.
I moved the code out into a separate function to avoid this.

Also added a run line to the template specialization test. I guess
all the -debug-info-kind=limited tests should still pass with =constructor,
but it's probably unnecessary to test for all of those.

Differential Revision: https://reviews.llvm.org/D86491
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp
Commit 05777ab941063192b9ccb1775358a83a2700ccc1 by echristo
Temporarily Revert "[DebugInfo] Move constructor homing case in shouldOmitDefinition."
as it's causing test failures.

This reverts commit 589ce5f7050dd83fd3f7dbc182ea0fb051ece994.
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp
Commit 2b3807d822c50d361ae67184b6de5a41bd7b1bba by phosek
[CMake] Fix ncurses/zlib in LLVM_SYSTEM_LIBS for Windows GNU

For the Windows GNU platform, CMAKE_FIND_LIBRARY_PREFIXES is a list
containing an empty string, which ended up in a regex capturing group,
which is invalid in CMake's regex engine. With this change, we get the
following:

  set(CMAKE_FIND_LIBRARY_PREFIXES "lib" "")
  set(CMAKE_FIND_LIBRARY_SUFFIXES ".dll.a" ".a" ".lib")
  get_system_libname(path/to/libz.dll.a zlib)
  message("${zlib}")

outputs z, as expected.

Patch By: haampie

Differential Revision: https://reviews.llvm.org/D86434
The file was modifiedllvm/lib/Support/CMakeLists.txt
Commit 61273f298f2ccca5a474013ff59a94eef0371efb by ecaldas
[SyntaxTree] Split `MemberPointer` tests with annotations

Differential Revision: https://reviews.llvm.org/D86467
The file was modifiedclang/unittests/Tooling/Syntax/BuildTreeTest.cpp
Commit b493e4cb3e37401d4fe5c0b2ba1adf7e66758bb0 by ecaldas
[SyntaxTree] Split ConstVolatileQualifiers tests

Differential Revision: https://reviews.llvm.org/D86469
The file was modifiedclang/unittests/Tooling/Syntax/BuildTreeTest.cpp
Commit 7f426c65b06f2d19546b2d50fccc15de9dde3d85 by ecaldas
[SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

Differential Revision: https://reviews.llvm.org/D86470
The file was modifiedclang/unittests/Tooling/Syntax/BuildTreeTest.cpp