SuccessChanges

Summary

  1. Fix typos in builders descriptions (details)
Commit 98990a0a6b3d5b8f62ba6cfac00ddb3b4a933bba by diana.picus
Fix typos in builders descriptions

Differential Revision: https://reviews.llvm.org/D86868
The file was modifiedbuildbot/osuosl/master/config/builders.py (diff)

Summary

  1. Revert "[ARM] Register pressure with -mthumb forces register reload before each call" (details)
  2. [SVE][CodeGen] Fix TypeSize/ElementCount related warnings in sve-split-load.ll (details)
  3. [analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API (details)
  4. Revert "[lldb] Add reproducer verifier" (details)
  5. [NFCI] Removed an un-used declaration got accidentally introduced in f91d18eaa946b2d2ea5a9 (details)
  6. [llvm-readobj/elf] - Report warnings instead of errors when dumping broken stack sizes sections. (details)
  7. [llvm-readobj][test] - Update the comment in archive.test (details)
  8. [llvm-readobj][test] - Remove amdgpu-elf-definitions.test (details)
  9. [libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY (details)
  10. [llvm-dwarfdump][test] Add tests for dumping the .debug_line_str section. (details)
  11. [NFC][Asan] Format includes (details)
  12. [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (details)
  13. Reland [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library (details)
  14. [InstCombine] adjust recip sqrt tests for better coverage; NFC (details)
  15. [llvm-readobj] - Remove Error.cpp,.h and drop dependencies in the code. (details)
  16. [NFC] Test commit, whitespace changes (details)
  17. [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass (details)
Commit ffd0b31c7cbaa8322d2963afe6ace4e3a0889ddb by david.green
Revert "[ARM] Register pressure with -mthumb forces register reload before each call"

Expensive checks are failing, complaining about additional MMO operands
added to the branch.
The file was modifiedllvm/lib/Target/ARM/Thumb1InstrInfo.cpp
The file was removedllvm/test/CodeGen/ARM/minsize-call-cse-3.ll
The file was removedllvm/test/CodeGen/ARM/minsize-call-cse-2.ll
The file was modifiedllvm/lib/Target/ARM/Thumb1InstrInfo.h
Commit 9fbb113247a5c09d319760d3f0e1768dfdbadfa4 by david.sherwood
[SVE][CodeGen] Fix TypeSize/ElementCount related warnings in sve-split-load.ll

I have fixed up a number of warnings resulting from TypeSize -> uint64_t
casts and calling getVectorNumElements() on scalable vector types. I
think most of the changes are fairly trivial except for those in
DAGTypeLegalizer::SplitVecRes_MLOAD I've tried to ensure we create
the MachineMemoryOperands in a sensible way for scalable vectors.

I have added a CHECK line to the following test:

  CodeGen/AArch64/sve-split-load.ll

that ensures no new warnings are added.

Differential Revision: https://reviews.llvm.org/D86697
The file was modifiedllvm/include/llvm/Support/TypeSize.h
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
The file was modifiedllvm/test/CodeGen/AArch64/sve-split-load.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Commit a787a4ed16d6867f56d81159a8fcf2b711d18a8a by gabor.marton
[analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API

By using optionals, we no longer have to check the validity of types that we
get from a lookup. This way, the definition of the summaries have a declarative
form, there are no superflous conditions in the source code.

Differential Revision: https://reviews.llvm.org/D86531
The file was modifiedclang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
The file was addedclang/test/Analysis/std-c-library-functions-POSIX-lookup.c
Commit 7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a by Raphael Isemann
Revert "[lldb] Add reproducer verifier"

This reverts commit 297f69afac58fc9dc13897857a5e70131c5adc85. It broke
the Fedora 33 x86-64 bot. See the review for more info.
The file was modifiedlldb/source/Commands/CommandObjectReproducer.cpp
The file was modifiedlldb/source/Utility/Reproducer.cpp
The file was modifiedlldb/source/Commands/Options.td
The file was modifiedlldb/include/lldb/Utility/Reproducer.h
The file was modifiedlldb/source/Utility/ReproducerProvider.cpp
The file was modifiedlldb/test/Shell/Reproducer/TestDebugSymbols.test
The file was removedlldb/test/Shell/Reproducer/TestVerify.test
The file was modifiedllvm/include/llvm/Support/VirtualFileSystem.h
The file was modifiedlldb/tools/driver/Driver.cpp
The file was modifiedlldb/source/API/SBReproducer.cpp
The file was modifiedlldb/include/lldb/API/SBReproducer.h
The file was modifiedlldb/tools/driver/Options.td
The file was modifiedllvm/lib/Support/VirtualFileSystem.cpp
Commit 03812041d8d9075e730d71100d59384b404dfb79 by SourabhSingh.Tomar
[NFCI] Removed an un-used declaration got accidentally introduced in f91d18eaa946b2d2ea5a9
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h
Commit 7de090a3248355ebf326d2a6e369e0f293c1259e by grimar
[llvm-readobj/elf] - Report warnings instead of errors when dumping broken stack sizes sections.

This replaces `reportError` calls with `reportUniqueWarning` and improves testing
for the code that is related to stack sizes dumping.

Differential revision: https://reviews.llvm.org/D86783
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
The file was modifiedllvm/test/tools/llvm-readobj/ELF/stack-sizes.test
Commit 6c6984ecd5438f3f7016bf6b79ebf6d9962f5b4b by grimar
[llvm-readobj][test] - Update the comment in archive.test

Addresses post commit review comment for D86771.
The file was modifiedllvm/test/tools/llvm-readobj/archive.test
Commit ca233be2f0a6623d835d33f1453d3248448ba606 by grimar
[llvm-readobj][test] - Remove amdgpu-elf-definitions.test

`amdgpu-elf-definitions.test` is a file that tests
`Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:
1) We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`.
2) We test 'OS/ABI' in `file-header-os-abi.test` for all possible values.
3) We test machine types in `file-header-machine-types.test`

In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.

Differential revision: https://reviews.llvm.org/D86774
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
The file was removedllvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
Commit 722db5c0b4e8dffabbd97265e5ea9edac05548ae by mikhail.maltsev
[libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY

Fix compilation of libcxx when using -DLIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY. Target `cxx_external_threads` gets linked to `cxx-headers` to include all needed headers and flags.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D86773
The file was modifiedlibcxx/src/CMakeLists.txt
Commit ea1f5133cc572720bbb9a90d271a59d99a55845d by Xing
[llvm-dwarfdump][test] Add tests for dumping the .debug_line_str section.

This patch adds tests for dumping the .debug_line_str section. The
dumper of the debug_line_str section is able to write nonprintable
strings as escaped chars while the dumper of the debug_str and
debug_str.dwo sections cannot. I will fix them and add tests for them
in a follow-up patch.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86916
The file was addedllvm/test/tools/llvm-dwarfdump/debug-line-str.yaml
Commit bd6ee511502f89319f8e50ad883cfe0406202ce1 by Vitaly Buka
[NFC][Asan] Format includes
The file was modifiedcompiler-rt/lib/asan/asan_allocator.cpp
Commit 2114f71aaa8dc2e75fe9cd79aa4d72d164e9b95d by a.bataev
[OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

Function Sema::isOpenMPGlobalCapturedDecl() has a parameter `unsigned Level`,
but use `Level >= 0` as the condition of `while`, thus cause an infinite loop.
Fix by changing the loop condition to `Level > 0`.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D86858
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
Commit 5ffd940ac02a8e000691c45a6dc4f69d0198e675 by Raphael Isemann
Reland [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

This relands e9a3d1a401b07cbf7b11695637f1b549782a26cd which was originally
missing linking LLVMSupport into LLMVFileCheck which broke the SHARED_LIBS build.

Original summary:

The actual FileCheck logic seems to be implemented in LLVMSupport. I don't see a
good reason for having FileCheck implemented there as it has a very specific use
while LLVMSupport is a dependency of pretty much every LLVM tool there is. In
fact, the only use of FileCheck I could find (outside the FileCheck tool and the
FileCheck unit test) is a single call in GISelMITest.h.

This moves the FileCheck logic to its own LLVMFileCheck library. This way only
FileCheck and the GlobalISelTests now have a dependency on this code.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D86344
The file was modifiedllvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
The file was modifiedllvm/include/llvm/module.modulemap
The file was modifiedllvm/utils/FileCheck/FileCheck.cpp
The file was modifiedllvm/unittests/Support/CMakeLists.txt
The file was modifiedllvm/utils/FileCheck/CMakeLists.txt
The file was addedllvm/unittests/FileCheck/FileCheckTest.cpp
The file was addedllvm/lib/FileCheck/FileCheck.cpp
The file was removedllvm/include/llvm/Support/FileCheck.h
The file was modifiedllvm/lib/Support/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn
The file was addedllvm/lib/FileCheck/CMakeLists.txt
The file was modifiedllvm/unittests/CMakeLists.txt
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/BUILD.gn
The file was removedllvm/unittests/Support/FileCheckTest.cpp
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
The file was modifiedllvm/lib/CMakeLists.txt
The file was removedllvm/lib/Support/FileCheckImpl.h
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/GlobalISel/BUILD.gn
The file was addedllvm/include/llvm/FileCheck/FileCheck.h
The file was removedllvm/lib/Support/FileCheck.cpp
The file was addedllvm/utils/gn/secondary/llvm/lib/FileCheck/BUILD.gn
The file was addedllvm/lib/FileCheck/FileCheckImpl.h
The file was addedllvm/utils/gn/secondary/llvm/unittests/FileCheck/BUILD.gn
The file was addedllvm/unittests/FileCheck/CMakeLists.txt
The file was modifiedllvm/unittests/CodeGen/GlobalISel/GISelMITest.h
Commit d48699e3e89f342ecb9dfc288f6840cd41ecb5e5 by spatel
[InstCombine] adjust recip sqrt tests for better coverage; NFC

Goes with D86726
The file was modifiedllvm/test/Transforms/InstCombine/fmul-sqrt.ll
Commit 3d90a61cf2edc22f1f006de351a1812592a7648b by grimar
[llvm-readobj] - Remove Error.cpp,.h and drop dependencies in the code.

We have Error.cpp/.h which contains some code for working with error codes.
In fact we use Error/Expected<> almost everywhere already and we can get rid
of these files.

Note: a few places in the code used readobj specific error codes,
e.g. `return readobj_error::unknown_symbol`. But these codes are never really used,
i.e. the code checks the fact of a success/error call only.
So I've changes them to `return inconvertibleErrorCode()` for now.
It seems that these places probably should be converted to use `Error`/`Expected<>`.

Differential revision: https://reviews.llvm.org/D86772
The file was modifiedllvm/tools/llvm-readobj/ObjDumper.cpp
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
The file was modifiedllvm/tools/llvm-readobj/WasmDumper.cpp
The file was removedllvm/tools/llvm-readobj/Error.h
The file was modifiedllvm/tools/llvm-readobj/WindowsResourceDumper.cpp
The file was modifiedllvm/test/tools/llvm-readobj/archive.test
The file was modifiedllvm/tools/llvm-readobj/llvm-readobj.cpp
The file was modifiedllvm/tools/llvm-readobj/Win64EHDumper.cpp
The file was modifiedllvm/tools/llvm-readobj/CMakeLists.txt
The file was modifiedllvm/tools/llvm-readobj/COFFDumper.cpp
The file was modifiedllvm/tools/llvm-readobj/DwarfCFIEHPrinter.h
The file was modifiedllvm/tools/llvm-readobj/MachODumper.cpp
The file was modifiedllvm/tools/llvm-readobj/ARMWinEHPrinter.cpp
The file was modifiedllvm/tools/llvm-readobj/ARMEHABIPrinter.h
The file was removedllvm/tools/llvm-readobj/Error.cpp
The file was modifiedllvm/tools/llvm-readobj/XCOFFDumper.cpp
Commit 5a3ede58e2c1df53cf1f74d2b8c4916c4a974b0b by Abhina.Sreeskantharajan
[NFC] Test commit, whitespace changes

Differential Revision: https://reviews.llvm.org/D85324
The file was modifiedclang/test/Preprocessor/init-zos.c
Commit 68717acb24e505169509b590e8c83557da54451e by anhtuyen
[LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass

Loop Idiom Recognize Pass (LIRP) attempts to transform loops with subscripted arrays
into memcpy/memset function calls. In some particular situation, this transformation
introduces negative impacts. For example: https://bugs.llvm.org/show_bug.cgi?id=47300

This patch will enable users to disable a particular part of the transformation, while
he/she can still enjoy the benefit brought about by the rest of LIRP. The default
behavior stays unchanged: no part of LIRP is disabled by default.

Reviewed By: etiotto (Ettore Tiotto)

Differential Revision: https://reviews.llvm.org/D86262
The file was modifiedllvm/include/llvm/Transforms/Scalar/LoopIdiomRecognize.h
The file was addedllvm/test/Transforms/LoopIdiom/disable-options.ll
The file was modifiedllvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

Summary

  1. Fix typos in builders descriptions (details)
Commit 98990a0a6b3d5b8f62ba6cfac00ddb3b4a933bba by diana.picus
Fix typos in builders descriptions

Differential Revision: https://reviews.llvm.org/D86868
The file was modifiedbuildbot/osuosl/master/config/builders.py