SuccessChanges

Summary

  1. [X86] Add more add/sub carry tests (details)
  2. DWARFDebugLoclists: add location list "interpretation" logic (details)
  3. [lldb][NFC] Simplify a return in (details)
Commit a9018fddf9ba17e53a35674bf0a93e78382c4c23 by dave
[X86] Add more add/sub carry tests
Preparation for: https://reviews.llvm.org/D70079
https://reviews.llvm.org/D70077
The file was modifiedllvm/test/CodeGen/X86/subcarry.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/addcarry.ll (diff)
The file was modifiedllvm/test/CodeGen/SystemZ/int-uadd-03.ll (diff)
The file was modifiedllvm/test/CodeGen/SystemZ/int-usub-03.ll (diff)
Commit ebe2f56030458e7a4c2375c6d92a48f0ed01eb5b by pavel
DWARFDebugLoclists: add location list "interpretation" logic
Summary: This patch extracts the logic for computing the "absolute"
locations, which was partially present in the debug_loclists dumper,
completes it, and moves it into a separate function. This makes it
possible to later reuse the same logic for uses other than dumping.
The dumper is changed to reuse the location list interpreter, and its
format is changed somewhat. In "verbose" mode it prints the "raw" value
of a location list, the interpreted location (if available) and the
expression itself. In non-verbose mode it prints only one of the
location forms: it prefers the interpreted form, but falls back to the
"raw" format if interpretation is not possible (for instance, because we
were not given a base address, or the resolution of indirect addresses
failed).
This patch also undos some of the changes made in D69672, namely the
part about making all functions static. The main reason for this is that
I learned that the original approach (dumping only fully resolved
locations) meant that it was impossible to rewrite one of the existing
tests. To make that possible (and make the "inline location" dump work
in more cases), I now reuse the same dumping mechanism as is used for
section-based dumping. As this required having more objects know about
the various location lists classes, it seemed like a good idea to create
an interface abstracting the difference between them.
Therefore, I now create a DWARFLocationTable class, which will serve as
a base class for the location list classes. DWARFDebugLoclists is made
to inherit from that. DWARFDebugLoc will follow.
Another positive effect of this change is that section-based dumping
code will not need to use templates (as originally) envisioned, and that
the argument lists of the dumping functions become shorter.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70081
The file was modifiedllvm/test/DebugInfo/X86/fission-ranges.ll (diff)
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists_startx_length.s (diff)
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h (diff)
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFContext.cpp (diff)
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDie.cpp (diff)
The file was modifiedllvm/test/DebugInfo/X86/loclists-dwp.ll (diff)
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp (diff)
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s (diff)
The file was modifiedllvm/test/CodeGen/X86/debug-loclists.ll (diff)
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loc_dwo.s (diff)
The file was addedllvm/include/llvm/DebugInfo/DWARF/DWARFLocationExpression.h
Commit ec4c96d68566debcc4588c4189b4ef8a5f78729a by Raphael Isemann
[lldb][NFC] Simplify a return in
ThreadPlanStepInRange::DefaultShouldStopHereCallback
We know should_stop_here is false here, so we might as well return false
directly.
The file was modifiedlldb/source/Target/ThreadPlanStepInRange.cpp (diff)