FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [llvm-readob] - Refactor printing of sections flags. NFCI. (details)
  2. [llvm-readobj][test] - Move a comment. NFC. (details)
  3. [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS (details)
  4. [NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter] (details)
  5. [llvm-exegesis][mips] Add lit test (details)
  6. [AArch64] Enable clustering memory accesses to fixed stack objects (details)
  7. [AArch64] Improve codegen of volatile load/store of i128 (details)
  8. [OpenCL] Add builtin function extension handling (details)
  9. recommit: [ASTImporter] Friend class decl should not be visible in its (details)
  10. [DebugInfo] Correctly handle salvaged casts and split fragments at ISel (details)
  11. [Syntax] Allow to mutate syntax trees (details)
  12. [Syntax] Uppercase the first letter of the test name. NFC (details)
  13. [Syntax] Use a hash table to search for tokens by their location (details)
  14. gn build: Merge 1ad15046dcf (details)
  15. Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and (details)
  16. gn build: Merge 7ea2e5195a8 (details)
  17. Revert "[DebugInfo] Correctly handle salvaged casts and split fragments (details)
  18. [gicombiner] Add support for arbitrary match data being passed from (details)
  19. [lldb][NFC] Add unit test for persistent variable lookup with (details)
  20. [InstCombine] add tests for copysign; NFC (details)
Commit 8810284af2ab2e950b86a33c47ac7cf52beb5d74 by grimar
[llvm-readob] - Refactor printing of sections flags. NFCI.
This is a natural clean-up after D71462/D71464. It allows to define
known section letters used for GNU style in one place.
Differential revision: https://reviews.llvm.org/D71591
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
Commit 36c3b3a61c9371c8f1fe10dda4c2bc00a77261c3 by grimar
[llvm-readobj][test] - Move a comment. NFC.
I've forgot to address this review comment.
The file was modifiedllvm/test/tools/llvm-readobj/ELF/section-flags-os-proc.test
Commit a6be12dbb14382cbc7817acbac2a86dfb2201949 by david.stenberg
[cmake] Add llvm-locstats to LLVM_TEST_DEPENDS
Summary: Make sure that llvm-locstats is updated before running lit
tests even when it's not an explicit target.
Reviewers: djtodoro, krisb, spatel
Reviewed By: djtodoro
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71611
The file was modifiedllvm/test/CMakeLists.txt
Commit 7cd1cfdd6b6c89f74af69f3513b5856a5c837317 by anna.welker
[NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter]
Add an extra parameter so alignment can be taken under consideration in
gather/scatter legalization.
Differential Revision: https://reviews.llvm.org/D71610
The file was modifiedllvm/lib/CodeGen/ScalarizeMaskedMemIntrin.cpp
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfo.h
The file was modifiedllvm/lib/Target/ARM/ARMTargetTransformInfo.h
The file was modifiedllvm/lib/Target/X86/X86TargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/X86/X86TargetTransformInfo.h
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/lib/Analysis/TargetTransformInfo.cpp
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfoImpl.h
Commit 862a60241687a2f718d2c4f554afd9d520da8952 by Milos.Stojanovic
[llvm-exegesis][mips] Add lit test
Adding a basic lit test for MIPS.
Differential Revision: https://reviews.llvm.org/D71605
The file was addedllvm/test/tools/llvm-exegesis/Mips/latency-by-opcode-name.s
The file was addedllvm/test/tools/llvm-exegesis/Mips/lit.local.cfg
Commit 97ca7c2cc9083ebde681b0e11f7a8ccae1966d64 by jay.foad
[AArch64] Enable clustering memory accesses to fixed stack objects
Summary: r347747 added support for clustering mem ops with FI base
operands including support for fixed stack objects in shouldClusterFI,
but apparently this was never tested.
This patch fixes shouldClusterFI to work with scaled as well as unscaled
load/store instructions, and fixes the ordering of memory ops in
MemOpInfo::operator< to ensure that memory addresses always increase,
regardless of which direction the stack grows.
Subscribers: MatzeB, kristof.beyls, hiraditya, javed.absar, arphaman,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71334
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.h
The file was modifiedllvm/test/CodeGen/AArch64/cluster-frame-index.mir
The file was modifiedllvm/test/CodeGen/AArch64/tailcall_misched_graph.ll
The file was modifiedllvm/lib/CodeGen/MachineScheduler.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was modifiedllvm/test/CodeGen/AArch64/arm64-memset-inline.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
The file was modifiedllvm/test/CodeGen/AArch64/expand-select.ll
Commit 364b8f5fbe0ac496931dcbd6f0493781f0677e82 by victor.campos
[AArch64] Improve codegen of volatile load/store of i128
Summary: Instead of generating two i64 instructions for each load or
store of a volatile i128 value (two LDRs or STRs), now emit a single LDP
or STP.
Reviewers: labrinea, t.p.northover, efriedma
Reviewed By: efriedma
Subscribers: kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69559
The file was modifiedllvm/test/CodeGen/AArch64/cmpxchg-O0.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.td
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.h
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was addedllvm/test/CodeGen/AArch64/i128_volatile_load_store.ll
Commit 308b8b76ceee805c964faf9f2176e3e05532a45b by sven.vanhaastregt
[OpenCL] Add builtin function extension handling
Provide a mechanism to attach OpenCL extension information to builtin
functions, so that their use can be restricted according to the
extension(s) the builtin is part of.
Patch by Pierre Gondois and Sven van Haastregt.
Differential Revision: https://reviews.llvm.org/D71476
The file was modifiedclang/lib/Sema/SemaLookup.cpp
The file was modifiedclang/lib/Sema/OpenCLBuiltins.td
The file was modifiedclang/test/SemaOpenCL/fdeclare-opencl-builtins.cl
The file was modifiedclang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
Commit bc5b7e21e32b23603f4d6148adeb88cd34dd287e by gabor.marton
recommit: [ASTImporter] Friend class decl should not be visible in its
context
Summary: In the past we had to use DeclContext::makeDeclVisibleInContext
to make friend declarations available for subsequent lookup calls and
this way we could chain (redecl) the structurally equivalent decls. By
doing this we created an AST that improperly made declarations visible
in some contexts, so the AST was malformed. Since we use the importer
specific lookup this is no longer necessary, because with that we can
find every previous nodes.
Reviewers: balazske, a_sidorin, a.sidorin, shafik
Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, teemperor,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71020
The file was modifiedclang/lib/AST/ASTImporter.cpp
The file was modifiedclang/unittests/AST/ASTImporterTest.cpp
Commit bb1b0bc4e57428ce364d3d6c075ff03cb8973462 by stozer
[DebugInfo] Correctly handle salvaged casts and split fragments at ISel
Previously, LLVM had no functional way of performing casts inside of a
DIExpression(), which made salvaging cast instructions other than Noop
casts impossible. This patch enables the salvaging of casts by using the
DW_OP_LLVM_convert operator for SExt and Trunc instructions.
There is another issue which is exposed by this fix, in which fragment
DIExpressions (which are preserved more readily by this patch) for
values that must be split across registers in ISel trigger an assertion,
as the 'split' fragments extend beyond the bounds of the fragment
DIExpression causing an error. This patch also fixes this issue by
checking the fragment status of DIExpressions which are to be split, and
dropping fragments that are invalid.
The file was modifiedllvm/lib/IR/DebugInfoMetadata.cpp
The file was modifiedllvm/test/Transforms/EarlyCSE/debug-info-undef.ll
The file was addedllvm/test/CodeGen/ARM/fragmented-args-multiple-regs.ll
The file was modifiedllvm/test/DebugInfo/X86/dbg-value-dropped-instcombine.ll
The file was modifiedllvm/test/Transforms/InstCombine/cast-mul-select.ll
The file was modifiedllvm/test/Transforms/InstCombine/pr43893.ll
The file was modifiedllvm/test/Transforms/InstCombine/unavailable-debug.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was addedllvm/test/DebugInfo/salvage-cast-debug-info.ll
The file was modifiedllvm/include/llvm/IR/DebugInfoMetadata.h
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
Commit 1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6 by ibiryukov
[Syntax] Allow to mutate syntax trees
Summary: This patch adds facilities to mutate the syntax trees and
produce corresponding text replacements.
The public interface of the syntax library now includes facilities to:
   1. perform type-safe modifications of syntax trees,
   2. compute textual replacements to apply the modifications,
   3. create syntax trees not backed by the source code.
For each of the three, we only add a few example transformations in this
patch to illustrate the idea, support for more kinds of nodes and
transformations will be done in follow-up patches.
The high-level mutation operations are implemented on top of operations
that allow to arbitrarily change the trees. They are considered to be
implementation details and are not available to the users of the
library.
Reviewers: sammccall, gribozavr2
Reviewed By: gribozavr2
Subscribers: merge_guards_bot, mgorny, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64573
The file was modifiedclang/unittests/Tooling/Syntax/CMakeLists.txt
The file was modifiedclang/include/clang/Tooling/Syntax/BuildTree.h
The file was modifiedclang/include/clang/Tooling/Syntax/Tree.h
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
The file was modifiedclang/lib/Tooling/Syntax/Tokens.cpp
The file was modifiedclang/lib/Tooling/Syntax/CMakeLists.txt
The file was addedclang/include/clang/Tooling/Syntax/Mutations.h
The file was modifiedclang/include/clang/Tooling/Syntax/Tokens.h
The file was addedclang/lib/Tooling/Syntax/Mutations.cpp
The file was addedclang/lib/Tooling/Syntax/Synthesis.cpp
The file was modifiedclang/lib/Tooling/Syntax/Tree.cpp
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
The file was addedclang/lib/Tooling/Syntax/ComputeReplacements.cpp
Commit 038f53882e7cc25da0a71018d1c7f9b4706675c2 by ibiryukov
[Syntax] Uppercase the first letter of the test name. NFC
To match naming style of other tests.
The file was modifiedclang/unittests/Tooling/Syntax/TokensTest.cpp
Commit c1bbefef9d36e84e469513374ef404b9e354b262 by ibiryukov
[Syntax] Use a hash table to search for tokens by their location
This is both more efficient and avoids corner cases in
`SourceManager::isBeforeInTranslationUnit`.
The change is trivial and clearly a performance improvement on the hot
path of building the syntax tree, so sending without review.
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
Commit 2f4569303093359c0be2a8df0f24301492b68598 by llvmgnsyncbot
gn build: Merge 1ad15046dcf
The file was modifiedllvm/utils/gn/secondary/clang/lib/Tooling/Syntax/BUILD.gn
Commit 7ea2e5195a82bd9370d0b4362512b67c8b2cde80 by daniel_l_sanders
Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and
parse instruction DAG's from the input""
This reverts commit e62e760f29567fe0841af870c65a4f8ef685d217.
The issue @uweigand raised should have been fixed by iterating over the
vector that owns the operand list data instead of the FoldingSet.
The MSVC issue raised by @thakis should have been fixed by relaxing the
regexes a little. I don't have a Windows machine available to test that
so I tested it by using `perl -p -e 's/0x([0-9a-f]+)/\U\1\E/g' to
convert the output of %p to the windows style.
I've guessed at the issue @phosek raised as there wasn't enough
information to investigate it. What I think is happening on that bot is
the -debug option isn't available because the second stage build is a
release build. I'm not sure why other release-mode bots didn't report it
though.
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagEdge.cpp
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.cpp
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagOperands.cpp
The file was addedllvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagEdge.h
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagInstr.cpp
The file was modifiedllvm/test/TableGen/GICombinerEmitter/match-invalid.td
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.h
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagOperands.h
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagInstr.h
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.cpp
The file was modifiedllvm/include/llvm/ADT/iterator.h
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.h
The file was modifiedllvm/utils/TableGen/GlobalISel/CMakeLists.txt
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
The file was addedllvm/utils/TableGen/GlobalISel/GIMatchDag.h
The file was modifiedllvm/utils/TableGen/GICombinerEmitter.cpp
Commit bad6a76041ee4c360f96bdaa1f4cc5606eda203e by llvmgnsyncbot
gn build: Merge 7ea2e5195a8
The file was modifiedllvm/utils/gn/secondary/llvm/utils/TableGen/GlobalISel/BUILD.gn
Commit 1f3dd83cc1f2b8f72b9d59e2b4221b12fb7f9a95 by stozer
Revert "[DebugInfo] Correctly handle salvaged casts and split fragments
at ISel"
Reverted due to build failure on windows bots.
This reverts commit bb1b0bc4e57428ce364d3d6c075ff03cb8973462.
The file was removedllvm/test/CodeGen/ARM/fragmented-args-multiple-regs.ll
The file was modifiedllvm/test/DebugInfo/X86/dbg-value-dropped-instcombine.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was removedllvm/test/DebugInfo/salvage-cast-debug-info.ll
The file was modifiedllvm/test/Transforms/InstCombine/unavailable-debug.ll
The file was modifiedllvm/include/llvm/IR/DebugInfoMetadata.h
The file was modifiedllvm/lib/IR/DebugInfoMetadata.cpp
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
The file was modifiedllvm/test/Transforms/EarlyCSE/debug-info-undef.ll
The file was modifiedllvm/test/Transforms/InstCombine/pr43893.ll
The file was modifiedllvm/test/Transforms/InstCombine/cast-mul-select.ll
Commit 55c57408b0e70b188b0505e011172f13ec3b15fc by daniel_l_sanders
[gicombiner] Add support for arbitrary match data being passed from
match to apply
Summary: This is used by the extending_loads combine to tell the apply
step which use is the preferred one to fold and the other uses should be
re-written to consume.
Depends on D69117
Reviewers: volkan, bogner
Reviewed By: volkan
Subscribers: hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69147
The file was modifiedllvm/utils/TableGen/GICombinerEmitter.cpp
The file was modifiedllvm/include/llvm/Target/GlobalISel/Combine.td
The file was modifiedllvm/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpp
Commit d8a3194987301672fbd50f4e5703952381f0157c by Raphael Isemann
[lldb][NFC] Add unit test for persistent variable lookup with
ClangExpressionDeclMap
This adds a unit test for looking up persistent declarations in the
scratch AST context. Also adds the `GetPersistentDecl` hook to the
ClangExpressionDeclMap that this unit test can emulate looking up
persistent variables without having a lldb_private::Target.
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
The file was modifiedlldb/unittests/Expression/ClangExpressionDeclMapTest.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
Commit c7492fbd4e85632a05428bd0281fcfd06f1fff6c by spatel
[InstCombine] add tests for copysign; NFC
The file was modifiedllvm/test/Transforms/InstCombine/copysign.ll