FailedChanges

Summary

  1. MCP: Fixed bug with dest overlapping copy source (details)
  2. [NFC][InstCombine] Add tests that show a number of canonicalization (details)
  3. [lldb] Check if we actually have a Clang type in (details)
  4. [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType (details)
  5. [lldb][NFC] Move LLVM RTTI implementation from enum to static ID (details)
  6. [lldb] Add missing include to ObjCLanguage.cpp to fix build (details)
  7. [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly (details)
Commit 07ebd741546e399f3db0a7c08a7fb1932e14080c by tim.renouf
MCP: Fixed bug with dest overlapping copy source
In MachineCopyPropagation, when propagating the source of a copy into
the operand of a later instruction, bail if a destination overlaps
(partly defines) the copy source. If the instruction where the
substitution is happening is also a copy, allowing the propagation
confuses the tracking mechanism.
Differential Revision: https://reviews.llvm.org/D69953
Change-Id: Ic570754f878f2d91a4a50a9bdcf96fbaa240726d
The file was addedllvm/test/CodeGen/AMDGPU/mcp-overlap-after-propagation.mir
The file was modifiedllvm/lib/CodeGen/MachineCopyPropagation.cpp
Commit a85e676916b6babe9a5479ad3425ccce32f1ecaa by suc-daniil
[NFC][InstCombine] Add tests that show a number of canonicalization
opportunities
Reviewers: spatel, RKSimon, lebedev.ri, apilipenko
Reviewed-By: apilipenko
Tags: #llvm
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D68263
The file was addedllvm/test/Transforms/InstCombine/phi-equal-incoming-pointers.ll
Commit bd7d9a85b8b09c945b98d374cc37cb374db012e6 by Raphael Isemann
[lldb] Check if we actually have a Clang type in
ObjCLanguage::GetPossibleFormattersMatches
We call IsPossibleDynamicType but we also need to check if this is a
Clang type, otherwise other languages with dynamic types (like Swift)
might end up being interpreted as potential Obj-C dynamic types.
The file was modifiedlldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Commit 6cc853b416a2b0d0b435d145988c5d3b6faaa712 by Raphael Isemann
[lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType
Reviewers: davide, xiaobai
Reviewed By: davide, xiaobai
Subscribers: davide, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70074
The file was modifiedlldb/include/lldb/Symbol/CompilerType.h
Commit 52f3a2faf92c4d8efd0e626d52d5f64b7c5d468f by Raphael Isemann
[lldb][NFC] Move LLVM RTTI implementation from enum to static ID
variable
Summary: swift-lldb currently has to patch the ExpressionKind enum to
add support for Swift expressions. If we implement LLVM's RTTI with a
static ID variable instead of a centralised enum we can drop that patch.
Reviewers: labath, davide
Reviewed By: labath
Subscribers: JDevlieghere, lldb-commits
Tags: #upstreaming_lldb_s_downstream_patches, #lldb
Differential Revision: https://reviews.llvm.org/D70070
The file was modifiedlldb/source/Expression/LLVMUserExpression.cpp
The file was modifiedlldb/include/lldb/Expression/FunctionCaller.h
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.h
The file was modifiedlldb/include/lldb/Expression/UserExpression.h
The file was modifiedlldb/include/lldb/Expression/UtilityFunction.h
The file was modifiedlldb/source/Expression/FunctionCaller.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.h
The file was modifiedlldb/source/Expression/UtilityFunction.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
The file was modifiedlldb/source/Expression/Expression.cpp
The file was modifiedlldb/include/lldb/Expression/Expression.h
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
The file was modifiedlldb/include/lldb/Expression/LLVMUserExpression.h
The file was modifiedlldb/source/Expression/UserExpression.cpp
Commit 874b6495b5fd6d7e2dc91d6a756eea67486ea7bb by Raphael Isemann
[lldb] Add missing include to ObjCLanguage.cpp to fix build
The file was modifiedlldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Commit a75f8d98d7ac9e557b238a229a9a2647c71feed1 by paulhoad
[clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly
for some operator functions
Summary: https://bugs.llvm.org/show_bug.cgi?id=36294
Addressing bug related to returning after return type not being honoured
for some operator types.
```
$ bin/clang-format --style="{BasedOnStyle: llvm,
AlwaysBreakAfterReturnType: TopLevelDefinitions}" /tmp/foo.cpp class Foo
{ public:
bool operator!() const;
bool operator<(Foo const &) const;
bool operator*() const;
bool operator->() const;
bool operator+() const;
bool operator-() const;
bool f() const;
};
bool Foo::operator!() const { return true; } bool Foo::operator<(Foo
const &) const {
return true;
} bool Foo::operator*() const { return true; } bool Foo::operator->()
const { return true; } bool Foo::operator+() const {
return true;
} bool Foo::operator-() const {
return true;
} bool Foo::f() const {
return true;
}
```
Reviewers: mitchell-stellar, klimek, owenpan, sammccall, rianquinn
Reviewed By: sammccall
Subscribers: merge_guards_bot, cfe-commits
Tags: #clang-format, #clang-tools-extra, #clang
Differential Revision: https://reviews.llvm.org/D69573
The file was modifiedclang/unittests/Format/FormatTest.cpp
The file was modifiedclang/lib/Format/TokenAnnotator.cpp